2018-10-30 11:03:57 -04:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
|
|
|
require 'spec_helper'
|
2019-07-24 10:45:31 -04:00
|
|
|
require Rails.root.join('ee', 'spec', 'db', 'schema_support') if Gitlab.ee?
|
2018-10-30 11:03:57 -04:00
|
|
|
|
|
|
|
describe 'Database schema' do
|
|
|
|
let(:connection) { ActiveRecord::Base.connection }
|
|
|
|
let(:tables) { connection.tables }
|
|
|
|
|
|
|
|
# Use if you are certain that this column should not have a foreign key
|
2019-07-24 10:45:31 -04:00
|
|
|
# EE: edit the ee/spec/db/schema_support.rb
|
2018-10-30 11:03:57 -04:00
|
|
|
IGNORED_FK_COLUMNS = {
|
|
|
|
abuse_reports: %w[reporter_id user_id],
|
Backport the EE schema and migrations to CE
This backports all EE schema changes to CE, including EE migrations,
ensuring both use the same schema.
== Updated tests
A spec related to ghost and support bot users had to be modified to make
it pass. The spec in question assumes that the "support_bot" column
exists when defining the spec. In the single codebase setup this is not
the case, as the column is backported in a later migration. Any attempt
to use a different schema version or use of "around" blocks to
conditionally disable specs won't help, as reverting the backport
migration would also drop the "support_bot" column. Removing the
"support_bot" tests entirely appears to be the only solution.
We also need to update some foreign key tests now that we have
backported the EE columns. Fortunately, these changes are very minor.
== Backporting migrations
This commit moves EE specific migrations (except those for the Geo
tracking database) and related files to CE, and also removes any traces
of the ee/db directory.
Some migrations had to be modified or removed, as they no longer work
with the schema being backported. These migrations were all quite old,
so we opted for removing them where modifying them would take too much
time and effort.
Some old migrations were modified in EE, while also existing in CE. In
these cases we took the EE code, and in one case removed them entirely.
It's not worth spending time trying to merge these changes somehow as we
plan to remove old migrations around the release of 12.0, see
https://gitlab.com/gitlab-org/gitlab-ce/issues/59177 for more details.
2019-04-29 08:16:03 -04:00
|
|
|
application_settings: %w[performance_bar_allowed_group_id slack_app_id snowplow_site_id],
|
|
|
|
approvers: %w[target_id user_id],
|
|
|
|
approvals: %w[user_id],
|
|
|
|
approver_groups: %w[target_id],
|
2018-10-30 11:03:57 -04:00
|
|
|
audit_events: %w[author_id entity_id],
|
|
|
|
award_emoji: %w[awardable_id user_id],
|
Backport the EE schema and migrations to CE
This backports all EE schema changes to CE, including EE migrations,
ensuring both use the same schema.
== Updated tests
A spec related to ghost and support bot users had to be modified to make
it pass. The spec in question assumes that the "support_bot" column
exists when defining the spec. In the single codebase setup this is not
the case, as the column is backported in a later migration. Any attempt
to use a different schema version or use of "around" blocks to
conditionally disable specs won't help, as reverting the backport
migration would also drop the "support_bot" column. Removing the
"support_bot" tests entirely appears to be the only solution.
We also need to update some foreign key tests now that we have
backported the EE columns. Fortunately, these changes are very minor.
== Backporting migrations
This commit moves EE specific migrations (except those for the Geo
tracking database) and related files to CE, and also removes any traces
of the ee/db directory.
Some migrations had to be modified or removed, as they no longer work
with the schema being backported. These migrations were all quite old,
so we opted for removing them where modifying them would take too much
time and effort.
Some old migrations were modified in EE, while also existing in CE. In
these cases we took the EE code, and in one case removed them entirely.
It's not worth spending time trying to merge these changes somehow as we
plan to remove old migrations around the release of 12.0, see
https://gitlab.com/gitlab-org/gitlab-ce/issues/59177 for more details.
2019-04-29 08:16:03 -04:00
|
|
|
boards: %w[milestone_id],
|
2018-10-30 11:03:57 -04:00
|
|
|
chat_names: %w[chat_id service_id team_id user_id],
|
|
|
|
chat_teams: %w[team_id],
|
|
|
|
ci_builds: %w[erased_by_id runner_id trigger_request_id user_id],
|
|
|
|
ci_pipelines: %w[user_id],
|
|
|
|
ci_runner_projects: %w[runner_id],
|
|
|
|
ci_trigger_requests: %w[commit_id],
|
|
|
|
cluster_providers_gcp: %w[gcp_project_id operation_id],
|
|
|
|
deploy_keys_projects: %w[deploy_key_id],
|
|
|
|
deployments: %w[deployable_id environment_id user_id],
|
2019-07-03 01:01:05 -04:00
|
|
|
draft_notes: %w[discussion_id commit_id],
|
2018-10-30 11:03:57 -04:00
|
|
|
emails: %w[user_id],
|
|
|
|
events: %w[target_id],
|
Backport the EE schema and migrations to CE
This backports all EE schema changes to CE, including EE migrations,
ensuring both use the same schema.
== Updated tests
A spec related to ghost and support bot users had to be modified to make
it pass. The spec in question assumes that the "support_bot" column
exists when defining the spec. In the single codebase setup this is not
the case, as the column is backported in a later migration. Any attempt
to use a different schema version or use of "around" blocks to
conditionally disable specs won't help, as reverting the backport
migration would also drop the "support_bot" column. Removing the
"support_bot" tests entirely appears to be the only solution.
We also need to update some foreign key tests now that we have
backported the EE columns. Fortunately, these changes are very minor.
== Backporting migrations
This commit moves EE specific migrations (except those for the Geo
tracking database) and related files to CE, and also removes any traces
of the ee/db directory.
Some migrations had to be modified or removed, as they no longer work
with the schema being backported. These migrations were all quite old,
so we opted for removing them where modifying them would take too much
time and effort.
Some old migrations were modified in EE, while also existing in CE. In
these cases we took the EE code, and in one case removed them entirely.
It's not worth spending time trying to merge these changes somehow as we
plan to remove old migrations around the release of 12.0, see
https://gitlab.com/gitlab-org/gitlab-ce/issues/59177 for more details.
2019-04-29 08:16:03 -04:00
|
|
|
epics: %w[updated_by_id last_edited_by_id start_date_sourcing_milestone_id due_date_sourcing_milestone_id],
|
2018-10-30 11:03:57 -04:00
|
|
|
forked_project_links: %w[forked_from_project_id],
|
Backport the EE schema and migrations to CE
This backports all EE schema changes to CE, including EE migrations,
ensuring both use the same schema.
== Updated tests
A spec related to ghost and support bot users had to be modified to make
it pass. The spec in question assumes that the "support_bot" column
exists when defining the spec. In the single codebase setup this is not
the case, as the column is backported in a later migration. Any attempt
to use a different schema version or use of "around" blocks to
conditionally disable specs won't help, as reverting the backport
migration would also drop the "support_bot" column. Removing the
"support_bot" tests entirely appears to be the only solution.
We also need to update some foreign key tests now that we have
backported the EE columns. Fortunately, these changes are very minor.
== Backporting migrations
This commit moves EE specific migrations (except those for the Geo
tracking database) and related files to CE, and also removes any traces
of the ee/db directory.
Some migrations had to be modified or removed, as they no longer work
with the schema being backported. These migrations were all quite old,
so we opted for removing them where modifying them would take too much
time and effort.
Some old migrations were modified in EE, while also existing in CE. In
these cases we took the EE code, and in one case removed them entirely.
It's not worth spending time trying to merge these changes somehow as we
plan to remove old migrations around the release of 12.0, see
https://gitlab.com/gitlab-org/gitlab-ce/issues/59177 for more details.
2019-04-29 08:16:03 -04:00
|
|
|
geo_event_log: %w[hashed_storage_attachments_event_id],
|
|
|
|
geo_job_artifact_deleted_events: %w[job_artifact_id],
|
|
|
|
geo_lfs_object_deleted_events: %w[lfs_object_id],
|
|
|
|
geo_node_statuses: %w[last_event_id cursor_last_event_id],
|
|
|
|
geo_nodes: %w[oauth_application_id],
|
|
|
|
geo_repository_deleted_events: %w[project_id],
|
|
|
|
geo_upload_deleted_events: %w[upload_id model_id],
|
2018-10-30 11:03:57 -04:00
|
|
|
identities: %w[user_id],
|
2019-02-15 11:37:55 -05:00
|
|
|
issues: %w[last_edited_by_id state_id],
|
2019-05-22 11:47:42 -04:00
|
|
|
jira_tracker_data: %w[jira_issue_transition_id],
|
2018-10-30 11:03:57 -04:00
|
|
|
keys: %w[user_id],
|
|
|
|
label_links: %w[target_id],
|
|
|
|
lfs_objects_projects: %w[lfs_object_id project_id],
|
Backport the EE schema and migrations to CE
This backports all EE schema changes to CE, including EE migrations,
ensuring both use the same schema.
== Updated tests
A spec related to ghost and support bot users had to be modified to make
it pass. The spec in question assumes that the "support_bot" column
exists when defining the spec. In the single codebase setup this is not
the case, as the column is backported in a later migration. Any attempt
to use a different schema version or use of "around" blocks to
conditionally disable specs won't help, as reverting the backport
migration would also drop the "support_bot" column. Removing the
"support_bot" tests entirely appears to be the only solution.
We also need to update some foreign key tests now that we have
backported the EE columns. Fortunately, these changes are very minor.
== Backporting migrations
This commit moves EE specific migrations (except those for the Geo
tracking database) and related files to CE, and also removes any traces
of the ee/db directory.
Some migrations had to be modified or removed, as they no longer work
with the schema being backported. These migrations were all quite old,
so we opted for removing them where modifying them would take too much
time and effort.
Some old migrations were modified in EE, while also existing in CE. In
these cases we took the EE code, and in one case removed them entirely.
It's not worth spending time trying to merge these changes somehow as we
plan to remove old migrations around the release of 12.0, see
https://gitlab.com/gitlab-org/gitlab-ce/issues/59177 for more details.
2019-04-29 08:16:03 -04:00
|
|
|
ldap_group_links: %w[group_id],
|
2018-10-30 11:03:57 -04:00
|
|
|
members: %w[source_id created_by_id],
|
2019-02-15 11:37:55 -05:00
|
|
|
merge_requests: %w[last_edited_by_id state_id],
|
2018-10-30 11:03:57 -04:00
|
|
|
namespaces: %w[owner_id parent_id],
|
|
|
|
notes: %w[author_id commit_id noteable_id updated_by_id resolved_by_id discussion_id],
|
|
|
|
notification_settings: %w[source_id],
|
|
|
|
oauth_access_grants: %w[resource_owner_id application_id],
|
|
|
|
oauth_access_tokens: %w[resource_owner_id application_id],
|
|
|
|
oauth_applications: %w[owner_id],
|
|
|
|
project_group_links: %w[group_id],
|
|
|
|
project_statistics: %w[namespace_id],
|
Backport the EE schema and migrations to CE
This backports all EE schema changes to CE, including EE migrations,
ensuring both use the same schema.
== Updated tests
A spec related to ghost and support bot users had to be modified to make
it pass. The spec in question assumes that the "support_bot" column
exists when defining the spec. In the single codebase setup this is not
the case, as the column is backported in a later migration. Any attempt
to use a different schema version or use of "around" blocks to
conditionally disable specs won't help, as reverting the backport
migration would also drop the "support_bot" column. Removing the
"support_bot" tests entirely appears to be the only solution.
We also need to update some foreign key tests now that we have
backported the EE columns. Fortunately, these changes are very minor.
== Backporting migrations
This commit moves EE specific migrations (except those for the Geo
tracking database) and related files to CE, and also removes any traces
of the ee/db directory.
Some migrations had to be modified or removed, as they no longer work
with the schema being backported. These migrations were all quite old,
so we opted for removing them where modifying them would take too much
time and effort.
Some old migrations were modified in EE, while also existing in CE. In
these cases we took the EE code, and in one case removed them entirely.
It's not worth spending time trying to merge these changes somehow as we
plan to remove old migrations around the release of 12.0, see
https://gitlab.com/gitlab-org/gitlab-ce/issues/59177 for more details.
2019-04-29 08:16:03 -04:00
|
|
|
projects: %w[creator_id namespace_id ci_id mirror_user_id],
|
2018-10-30 11:03:57 -04:00
|
|
|
redirect_routes: %w[source_id],
|
|
|
|
repository_languages: %w[programming_language_id],
|
|
|
|
routes: %w[source_id],
|
|
|
|
sent_notifications: %w[project_id noteable_id recipient_id commit_id in_reply_to_discussion_id],
|
|
|
|
snippets: %w[author_id],
|
|
|
|
spam_logs: %w[user_id],
|
|
|
|
subscriptions: %w[user_id subscribable_id],
|
Backport the EE schema and migrations to CE
This backports all EE schema changes to CE, including EE migrations,
ensuring both use the same schema.
== Updated tests
A spec related to ghost and support bot users had to be modified to make
it pass. The spec in question assumes that the "support_bot" column
exists when defining the spec. In the single codebase setup this is not
the case, as the column is backported in a later migration. Any attempt
to use a different schema version or use of "around" blocks to
conditionally disable specs won't help, as reverting the backport
migration would also drop the "support_bot" column. Removing the
"support_bot" tests entirely appears to be the only solution.
We also need to update some foreign key tests now that we have
backported the EE columns. Fortunately, these changes are very minor.
== Backporting migrations
This commit moves EE specific migrations (except those for the Geo
tracking database) and related files to CE, and also removes any traces
of the ee/db directory.
Some migrations had to be modified or removed, as they no longer work
with the schema being backported. These migrations were all quite old,
so we opted for removing them where modifying them would take too much
time and effort.
Some old migrations were modified in EE, while also existing in CE. In
these cases we took the EE code, and in one case removed them entirely.
It's not worth spending time trying to merge these changes somehow as we
plan to remove old migrations around the release of 12.0, see
https://gitlab.com/gitlab-org/gitlab-ce/issues/59177 for more details.
2019-04-29 08:16:03 -04:00
|
|
|
slack_integrations: %w[team_id user_id],
|
2018-10-30 11:03:57 -04:00
|
|
|
taggings: %w[tag_id taggable_id tagger_id],
|
|
|
|
timelogs: %w[user_id],
|
|
|
|
todos: %w[target_id commit_id],
|
|
|
|
uploads: %w[model_id],
|
|
|
|
user_agent_details: %w[subject_id],
|
Backport the EE schema and migrations to CE
This backports all EE schema changes to CE, including EE migrations,
ensuring both use the same schema.
== Updated tests
A spec related to ghost and support bot users had to be modified to make
it pass. The spec in question assumes that the "support_bot" column
exists when defining the spec. In the single codebase setup this is not
the case, as the column is backported in a later migration. Any attempt
to use a different schema version or use of "around" blocks to
conditionally disable specs won't help, as reverting the backport
migration would also drop the "support_bot" column. Removing the
"support_bot" tests entirely appears to be the only solution.
We also need to update some foreign key tests now that we have
backported the EE columns. Fortunately, these changes are very minor.
== Backporting migrations
This commit moves EE specific migrations (except those for the Geo
tracking database) and related files to CE, and also removes any traces
of the ee/db directory.
Some migrations had to be modified or removed, as they no longer work
with the schema being backported. These migrations were all quite old,
so we opted for removing them where modifying them would take too much
time and effort.
Some old migrations were modified in EE, while also existing in CE. In
these cases we took the EE code, and in one case removed them entirely.
It's not worth spending time trying to merge these changes somehow as we
plan to remove old migrations around the release of 12.0, see
https://gitlab.com/gitlab-org/gitlab-ce/issues/59177 for more details.
2019-04-29 08:16:03 -04:00
|
|
|
users: %w[color_scheme_id created_by_id theme_id email_opted_in_source_id],
|
2018-10-30 11:03:57 -04:00
|
|
|
users_star_projects: %w[user_id],
|
Backport the EE schema and migrations to CE
This backports all EE schema changes to CE, including EE migrations,
ensuring both use the same schema.
== Updated tests
A spec related to ghost and support bot users had to be modified to make
it pass. The spec in question assumes that the "support_bot" column
exists when defining the spec. In the single codebase setup this is not
the case, as the column is backported in a later migration. Any attempt
to use a different schema version or use of "around" blocks to
conditionally disable specs won't help, as reverting the backport
migration would also drop the "support_bot" column. Removing the
"support_bot" tests entirely appears to be the only solution.
We also need to update some foreign key tests now that we have
backported the EE columns. Fortunately, these changes are very minor.
== Backporting migrations
This commit moves EE specific migrations (except those for the Geo
tracking database) and related files to CE, and also removes any traces
of the ee/db directory.
Some migrations had to be modified or removed, as they no longer work
with the schema being backported. These migrations were all quite old,
so we opted for removing them where modifying them would take too much
time and effort.
Some old migrations were modified in EE, while also existing in CE. In
these cases we took the EE code, and in one case removed them entirely.
It's not worth spending time trying to merge these changes somehow as we
plan to remove old migrations around the release of 12.0, see
https://gitlab.com/gitlab-org/gitlab-ce/issues/59177 for more details.
2019-04-29 08:16:03 -04:00
|
|
|
vulnerability_identifiers: %w[external_id],
|
|
|
|
vulnerability_scanners: %w[external_id],
|
|
|
|
web_hooks: %w[service_id group_id],
|
2018-12-13 14:17:19 -05:00
|
|
|
suggestions: %w[commit_id]
|
2018-10-30 11:03:57 -04:00
|
|
|
}.with_indifferent_access.freeze
|
|
|
|
|
|
|
|
context 'for table' do
|
|
|
|
ActiveRecord::Base.connection.tables.sort.each do |table|
|
|
|
|
describe table do
|
|
|
|
let(:indexes) { connection.indexes(table) }
|
|
|
|
let(:columns) { connection.columns(table) }
|
|
|
|
let(:foreign_keys) { connection.foreign_keys(table) }
|
2019-01-07 12:55:21 -05:00
|
|
|
let(:primary_key_column) { connection.primary_key(table) }
|
2018-10-30 11:03:57 -04:00
|
|
|
|
|
|
|
context 'all foreign keys' do
|
|
|
|
# for index to be effective, the FK constraint has to be at first place
|
|
|
|
it 'are indexed' do
|
|
|
|
first_indexed_column = indexes.map(&:columns).map(&:first)
|
|
|
|
foreign_keys_columns = foreign_keys.map(&:column)
|
|
|
|
|
2019-01-07 12:55:21 -05:00
|
|
|
# Add the primary key column to the list of indexed columns because
|
|
|
|
# postgres and mysql both automatically create an index on the primary
|
|
|
|
# key. Also, the rails connection.indexes() method does not return
|
|
|
|
# automatically generated indexes (like the primary key index).
|
|
|
|
first_indexed_column = first_indexed_column.push(primary_key_column)
|
|
|
|
|
2018-10-30 11:03:57 -04:00
|
|
|
expect(first_indexed_column.uniq).to include(*foreign_keys_columns)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'columns ending with _id' do
|
|
|
|
let(:column_names) { columns.map(&:name) }
|
|
|
|
let(:column_names_with_id) { column_names.select { |column_name| column_name.ends_with?('_id') } }
|
|
|
|
let(:foreign_keys_columns) { foreign_keys.map(&:column) }
|
2018-11-15 06:57:13 -05:00
|
|
|
let(:ignored_columns) { ignored_fk_columns(table) }
|
2018-10-30 11:03:57 -04:00
|
|
|
|
|
|
|
it 'do have the foreign keys' do
|
|
|
|
expect(column_names_with_id - ignored_columns).to contain_exactly(*foreign_keys_columns)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2018-11-15 06:57:13 -05:00
|
|
|
|
|
|
|
private
|
|
|
|
|
|
|
|
def ignored_fk_columns(column)
|
|
|
|
IGNORED_FK_COLUMNS.fetch(column, [])
|
|
|
|
end
|
2018-10-30 11:03:57 -04:00
|
|
|
end
|