2018-08-18 11:19:57 +00:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2014-07-15 15:28:21 +00:00
|
|
|
module DiffHelper
|
2016-01-29 18:37:17 +00:00
|
|
|
def mark_inline_diffs(old_line, new_line)
|
|
|
|
old_diffs, new_diffs = Gitlab::Diff::InlineDiff.new(old_line, new_line).inline_diffs
|
|
|
|
|
2021-03-11 15:09:10 +00:00
|
|
|
marked_old_line = Gitlab::Diff::InlineDiffMarker.new(old_line).mark(old_diffs)
|
|
|
|
marked_new_line = Gitlab::Diff::InlineDiffMarker.new(new_line).mark(new_diffs)
|
2016-01-29 18:37:17 +00:00
|
|
|
|
|
|
|
[marked_old_line, marked_new_line]
|
|
|
|
end
|
|
|
|
|
2017-05-26 23:27:30 +00:00
|
|
|
def diffs_expanded?
|
|
|
|
params[:expanded].present?
|
2016-07-06 12:04:52 +00:00
|
|
|
end
|
|
|
|
|
2015-11-17 15:08:58 +00:00
|
|
|
def diff_view
|
2016-07-21 18:44:12 +00:00
|
|
|
@diff_view ||= begin
|
|
|
|
diff_views = %w(inline parallel)
|
2017-07-28 12:59:57 +00:00
|
|
|
diff_view = params[:view] || cookies[:diff_view]
|
2016-07-21 18:44:12 +00:00
|
|
|
diff_view = diff_views.first unless diff_views.include?(diff_view)
|
|
|
|
diff_view.to_sym
|
2016-04-14 21:32:46 +00:00
|
|
|
end
|
2015-11-17 15:08:58 +00:00
|
|
|
end
|
|
|
|
|
2021-04-29 15:10:07 +00:00
|
|
|
def show_only_context_commits?
|
|
|
|
!!params[:only_context_commits] || @merge_request&.commits&.empty?
|
|
|
|
end
|
|
|
|
|
2016-03-03 17:38:44 +00:00
|
|
|
def diff_options
|
2017-05-26 23:27:30 +00:00
|
|
|
options = { ignore_whitespace_change: hide_whitespace?, expanded: diffs_expanded? }
|
2016-07-08 21:50:06 +00:00
|
|
|
|
|
|
|
if action_name == 'diff_for_path'
|
2017-05-26 23:27:30 +00:00
|
|
|
options[:expanded] = true
|
2016-07-15 07:04:18 +00:00
|
|
|
options[:paths] = params.values_at(:old_path, :new_path)
|
2014-07-15 15:28:21 +00:00
|
|
|
end
|
2016-07-08 21:50:06 +00:00
|
|
|
|
2016-07-20 16:25:36 +00:00
|
|
|
options
|
2016-01-20 13:59:14 +00:00
|
|
|
end
|
|
|
|
|
2016-07-21 18:44:12 +00:00
|
|
|
def diff_match_line(old_pos, new_pos, text: '', view: :inline, bottom: false)
|
2017-09-28 14:55:25 +00:00
|
|
|
content_line_class = %w[line_content match]
|
|
|
|
content_line_class << 'parallel' if view == :parallel
|
|
|
|
|
|
|
|
line_num_class = %w[diff-line-num unfold js-unfold]
|
|
|
|
line_num_class << 'js-unfold-bottom' if bottom
|
2016-07-21 18:44:12 +00:00
|
|
|
|
2018-08-18 11:19:57 +00:00
|
|
|
html = []
|
|
|
|
|
2016-07-21 18:44:12 +00:00
|
|
|
if old_pos
|
2017-09-28 14:55:25 +00:00
|
|
|
html << content_tag(:td, '...', class: [*line_num_class, 'old_line'], data: { linenumber: old_pos })
|
|
|
|
html << content_tag(:td, text, class: [*content_line_class, 'left-side']) if view == :parallel
|
2016-07-21 18:44:12 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
if new_pos
|
2017-09-28 14:55:25 +00:00
|
|
|
html << content_tag(:td, '...', class: [*line_num_class, 'new_line'], data: { linenumber: new_pos })
|
|
|
|
html << content_tag(:td, text, class: [*content_line_class, ('right-side' if view == :parallel)])
|
2016-07-21 18:44:12 +00:00
|
|
|
end
|
2014-09-09 09:10:40 +00:00
|
|
|
|
2018-08-18 11:19:57 +00:00
|
|
|
html.join.html_safe
|
2015-02-08 23:12:44 +00:00
|
|
|
end
|
|
|
|
|
2016-10-27 01:47:14 +00:00
|
|
|
def diff_line_content(line)
|
2014-09-09 09:10:40 +00:00
|
|
|
if line.blank?
|
2016-10-27 01:47:14 +00:00
|
|
|
" ".html_safe
|
2014-09-09 09:10:40 +00:00
|
|
|
else
|
2019-10-08 12:06:01 +00:00
|
|
|
# `sub` and substring-ing would destroy HTML-safeness of `line`
|
|
|
|
if line.start_with?('+', '-', ' ')
|
2020-11-12 18:09:26 +00:00
|
|
|
line[1, line.length]
|
2019-10-08 12:06:01 +00:00
|
|
|
else
|
|
|
|
line
|
|
|
|
end
|
2014-09-09 09:10:40 +00:00
|
|
|
end
|
|
|
|
end
|
2014-09-12 16:43:44 +00:00
|
|
|
|
2020-11-12 18:09:26 +00:00
|
|
|
def diff_link_number(line_type, match, text)
|
|
|
|
line_type == match ? " " : text
|
|
|
|
end
|
|
|
|
|
2016-07-20 22:18:18 +00:00
|
|
|
def parallel_diff_discussions(left, right, diff_file)
|
2017-04-10 03:27:45 +00:00
|
|
|
return unless @grouped_diff_discussions
|
2017-05-11 15:47:44 +00:00
|
|
|
|
2017-03-31 02:34:14 +00:00
|
|
|
discussions_left = discussions_right = nil
|
2014-09-12 17:51:44 +00:00
|
|
|
|
2017-06-19 16:25:21 +00:00
|
|
|
if left && left.discussable? && (left.unchanged? || left.removed?)
|
2016-07-20 22:18:18 +00:00
|
|
|
line_code = diff_file.line_code(left)
|
2017-03-31 02:34:14 +00:00
|
|
|
discussions_left = @grouped_diff_discussions[line_code]
|
2014-09-12 17:51:44 +00:00
|
|
|
end
|
|
|
|
|
2017-06-19 16:25:21 +00:00
|
|
|
if right && right.discussable? && right.added?
|
2016-07-20 22:18:18 +00:00
|
|
|
line_code = diff_file.line_code(right)
|
2017-03-31 02:34:14 +00:00
|
|
|
discussions_right = @grouped_diff_discussions[line_code]
|
2014-09-12 17:51:44 +00:00
|
|
|
end
|
|
|
|
|
2017-03-31 02:34:14 +00:00
|
|
|
[discussions_left, discussions_right]
|
2014-09-12 17:51:44 +00:00
|
|
|
end
|
2014-12-25 12:32:49 +00:00
|
|
|
|
|
|
|
def inline_diff_btn
|
2016-07-21 18:44:12 +00:00
|
|
|
diff_btn('Inline', 'inline', diff_view == :inline)
|
2014-12-25 12:32:49 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
def parallel_diff_btn
|
2016-07-21 18:44:12 +00:00
|
|
|
diff_btn('Side-by-side', 'parallel', diff_view == :parallel)
|
2014-12-25 12:32:49 +00:00
|
|
|
end
|
2015-01-19 13:07:37 +00:00
|
|
|
|
2015-04-13 05:27:45 +00:00
|
|
|
def submodule_link(blob, ref, repository = @repository)
|
2020-09-07 12:08:27 +00:00
|
|
|
urls = submodule_links(blob, ref, repository)
|
|
|
|
|
|
|
|
folder_name = truncate(blob.name, length: 40)
|
|
|
|
folder_name = link_to(folder_name, urls.web) if urls&.web
|
|
|
|
|
|
|
|
commit_id = Commit.truncate_sha(blob.id)
|
|
|
|
commit_id = link_to(commit_id, urls.tree) if urls&.tree
|
2015-01-19 13:07:37 +00:00
|
|
|
|
|
|
|
[
|
2020-09-07 12:08:27 +00:00
|
|
|
content_tag(:span, folder_name),
|
2015-01-19 13:07:37 +00:00
|
|
|
'@',
|
2017-05-11 15:47:44 +00:00
|
|
|
content_tag(:span, commit_id, class: 'commit-sha')
|
2015-01-19 13:07:37 +00:00
|
|
|
].join(' ').html_safe
|
|
|
|
end
|
2015-09-30 10:31:02 +00:00
|
|
|
|
2020-09-07 12:08:27 +00:00
|
|
|
def submodule_diff_compare_link(diff_file)
|
|
|
|
compare_url = submodule_links(diff_file.blob, diff_file.content_sha, diff_file.repository, diff_file)&.compare
|
|
|
|
|
|
|
|
link = ""
|
|
|
|
|
|
|
|
if compare_url
|
|
|
|
|
|
|
|
link_text = [
|
|
|
|
_('Compare'),
|
|
|
|
' ',
|
|
|
|
content_tag(:span, Commit.truncate_sha(diff_file.old_blob.id), class: 'commit-sha'),
|
|
|
|
'...',
|
|
|
|
content_tag(:span, Commit.truncate_sha(diff_file.blob.id), class: 'commit-sha')
|
|
|
|
].join('').html_safe
|
|
|
|
|
|
|
|
tooltip = _('Compare submodule commit revisions')
|
2021-02-09 12:09:48 +00:00
|
|
|
link = content_tag(:span, link_to(link_text, compare_url, class: 'btn gl-button has-tooltip', title: tooltip), class: 'submodule-compare')
|
2020-09-07 12:08:27 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
link
|
|
|
|
end
|
|
|
|
|
2017-12-11 16:23:29 +00:00
|
|
|
def diff_file_blob_raw_url(diff_file, only_path: false)
|
|
|
|
project_raw_url(@project, tree_join(diff_file.content_sha, diff_file.file_path), only_path: only_path)
|
2017-05-15 17:18:19 +00:00
|
|
|
end
|
|
|
|
|
2017-12-11 16:23:29 +00:00
|
|
|
def diff_file_old_blob_raw_url(diff_file, only_path: false)
|
2017-05-15 18:19:49 +00:00
|
|
|
sha = diff_file.old_content_sha
|
|
|
|
return unless sha
|
2017-11-14 09:02:39 +00:00
|
|
|
|
2017-12-11 16:23:29 +00:00
|
|
|
project_raw_url(@project, tree_join(diff_file.old_content_sha, diff_file.old_path), only_path: only_path)
|
|
|
|
end
|
|
|
|
|
|
|
|
def diff_file_blob_raw_path(diff_file)
|
|
|
|
diff_file_blob_raw_url(diff_file, only_path: true)
|
|
|
|
end
|
|
|
|
|
|
|
|
def diff_file_old_blob_raw_path(diff_file)
|
|
|
|
diff_file_old_blob_raw_url(diff_file, only_path: true)
|
2017-05-15 17:18:19 +00:00
|
|
|
end
|
|
|
|
|
2016-08-10 09:28:42 +00:00
|
|
|
def diff_file_html_data(project, diff_file_path, diff_commit_id)
|
2015-09-30 10:31:02 +00:00
|
|
|
{
|
2020-07-02 15:09:08 +00:00
|
|
|
blob_diff_path: project_blob_diff_path(project, tree_join(diff_commit_id, diff_file_path)),
|
2016-07-21 18:44:12 +00:00
|
|
|
view: diff_view
|
2015-09-30 10:31:02 +00:00
|
|
|
}
|
|
|
|
end
|
|
|
|
|
2017-05-15 17:10:29 +00:00
|
|
|
def editable_diff?(diff_file)
|
|
|
|
!diff_file.deleted_file? && @merge_request && @merge_request.source_project
|
2015-09-30 10:31:02 +00:00
|
|
|
end
|
2015-11-17 09:49:23 +00:00
|
|
|
|
2017-07-27 10:01:09 +00:00
|
|
|
def diff_file_changed_icon(diff_file)
|
2018-02-13 18:11:26 +00:00
|
|
|
if diff_file.deleted_file?
|
2017-11-14 10:49:04 +00:00
|
|
|
"file-deletion"
|
2017-07-27 10:01:09 +00:00
|
|
|
elsif diff_file.new_file?
|
2017-11-14 10:49:04 +00:00
|
|
|
"file-addition"
|
2017-07-27 10:01:09 +00:00
|
|
|
else
|
2017-11-14 10:49:04 +00:00
|
|
|
"file-modified"
|
2017-07-27 10:01:09 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
def diff_file_changed_icon_color(diff_file)
|
|
|
|
if diff_file.deleted_file?
|
2021-09-08 18:11:23 +00:00
|
|
|
"danger"
|
2017-07-27 10:01:09 +00:00
|
|
|
elsif diff_file.new_file?
|
2021-09-08 18:11:23 +00:00
|
|
|
"success"
|
2017-07-27 10:01:09 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2019-11-29 15:06:43 +00:00
|
|
|
def render_overflow_warning?(diffs_collection)
|
2021-06-28 09:08:19 +00:00
|
|
|
diffs_collection.overflow?.tap do |overflown|
|
|
|
|
log_overflow_limits(diff_files: diffs_collection.raw_diff_files, collection_overflow: overflown)
|
2019-11-29 15:06:43 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2020-07-12 09:09:08 +00:00
|
|
|
def apply_diff_view_cookie!
|
|
|
|
set_secure_cookie(:diff_view, params.delete(:view), type: CookiesHelper::COOKIE_TYPE_PERMANENT) if params[:view].present?
|
|
|
|
end
|
|
|
|
|
2021-02-03 21:09:17 +00:00
|
|
|
def collapsed_diff_url(diff_file)
|
|
|
|
url_for(
|
|
|
|
safe_params.merge(
|
|
|
|
action: :diff_for_path,
|
|
|
|
old_path: diff_file.old_path,
|
|
|
|
new_path: diff_file.new_path,
|
|
|
|
file_identifier: diff_file.file_identifier
|
|
|
|
)
|
|
|
|
)
|
|
|
|
end
|
|
|
|
|
2021-02-16 15:09:50 +00:00
|
|
|
# As the fork suggestion button is identical every time, we cache it for a full page load
|
|
|
|
def render_fork_suggestion
|
|
|
|
return unless current_user
|
|
|
|
|
|
|
|
strong_memoize(:fork_suggestion) do
|
|
|
|
render partial: "projects/fork_suggestion"
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2015-11-17 09:49:23 +00:00
|
|
|
private
|
|
|
|
|
|
|
|
def diff_btn(title, name, selected)
|
2018-04-08 04:35:30 +00:00
|
|
|
params_copy = safe_params.dup
|
2015-11-17 09:49:23 +00:00
|
|
|
params_copy[:view] = name
|
|
|
|
|
|
|
|
# Always use HTML to handle case where JSON diff rendered this button
|
|
|
|
params_copy.delete(:format)
|
|
|
|
|
2021-03-09 18:09:41 +00:00
|
|
|
link_to url_for(params_copy), id: "#{name}-diff-btn", class: (selected ? 'btn gl-button btn-default selected' : 'btn gl-button btn-default'), data: { view_type: name } do
|
2015-11-17 09:49:23 +00:00
|
|
|
title
|
|
|
|
end
|
|
|
|
end
|
2016-03-23 16:10:17 +00:00
|
|
|
|
2016-04-18 21:51:30 +00:00
|
|
|
def commit_diff_whitespace_link(project, commit, options)
|
2017-06-29 17:06:35 +00:00
|
|
|
url = project_commit_path(project, commit.id, params_with_whitespace)
|
2016-04-18 21:51:30 +00:00
|
|
|
toggle_whitespace_link(url, options)
|
2016-04-12 17:49:34 +00:00
|
|
|
end
|
|
|
|
|
2016-04-18 21:51:30 +00:00
|
|
|
def diff_merge_request_whitespace_link(project, merge_request, options)
|
2017-06-29 17:06:35 +00:00
|
|
|
url = diffs_project_merge_request_path(project, merge_request, params_with_whitespace)
|
2016-04-18 21:51:30 +00:00
|
|
|
toggle_whitespace_link(url, options)
|
2016-04-12 17:49:34 +00:00
|
|
|
end
|
|
|
|
|
2016-06-09 17:26:14 +00:00
|
|
|
def diff_compare_whitespace_link(project, from, to, options)
|
2017-06-29 17:06:35 +00:00
|
|
|
url = project_compare_path(project, from, to, params_with_whitespace)
|
2016-06-09 17:26:14 +00:00
|
|
|
toggle_whitespace_link(url, options)
|
|
|
|
end
|
|
|
|
|
2021-09-08 18:11:23 +00:00
|
|
|
def diff_files_data(diff_files)
|
|
|
|
diffs_map = diff_files.map do |f|
|
|
|
|
{
|
|
|
|
href: "##{hexdigest(f.file_path)}",
|
|
|
|
title: f.new_path,
|
|
|
|
name: f.file_path,
|
|
|
|
path: diff_file_path_text(f),
|
|
|
|
icon: diff_file_changed_icon(f),
|
|
|
|
iconColor: "#{diff_file_changed_icon_color(f)}",
|
|
|
|
added: f.added_lines,
|
|
|
|
removed: f.removed_lines
|
|
|
|
}
|
|
|
|
end
|
|
|
|
|
|
|
|
diffs_map.to_json
|
|
|
|
end
|
|
|
|
|
2016-04-04 17:01:59 +00:00
|
|
|
def hide_whitespace?
|
2016-03-23 16:10:17 +00:00
|
|
|
params[:w] == '1'
|
|
|
|
end
|
|
|
|
|
|
|
|
def params_with_whitespace
|
2016-04-04 17:01:59 +00:00
|
|
|
hide_whitespace? ? request.query_parameters.except(:w) : request.query_parameters.merge(w: 1)
|
2016-03-23 16:10:17 +00:00
|
|
|
end
|
|
|
|
|
2016-04-18 21:51:30 +00:00
|
|
|
def toggle_whitespace_link(url, options)
|
2021-02-09 12:09:48 +00:00
|
|
|
options[:class] = [*options[:class], 'btn gl-button btn-default'].join(' ')
|
2016-04-18 21:51:30 +00:00
|
|
|
link_to "#{hide_whitespace? ? 'Show' : 'Hide'} whitespace changes", url, class: options[:class]
|
2016-03-23 16:10:17 +00:00
|
|
|
end
|
2016-12-30 19:16:25 +00:00
|
|
|
|
2018-01-08 10:45:56 +00:00
|
|
|
def diff_file_path_text(diff_file, max: 60)
|
|
|
|
path = diff_file.new_path
|
|
|
|
|
|
|
|
return path unless path.size > max && max > 3
|
|
|
|
|
2021-12-14 12:13:33 +00:00
|
|
|
"...#{path[-(max - 3)..]}"
|
2018-01-08 10:45:56 +00:00
|
|
|
end
|
2020-11-13 18:09:11 +00:00
|
|
|
|
|
|
|
def code_navigation_path(diffs)
|
2021-01-25 21:09:03 +00:00
|
|
|
Gitlab::CodeNavigationPath.new(merge_request.project, merge_request.diff_head_sha)
|
2020-11-13 18:09:11 +00:00
|
|
|
end
|
|
|
|
|
2021-07-21 21:10:10 +00:00
|
|
|
def conflicts(allow_tree_conflicts: false)
|
2020-11-13 18:09:11 +00:00
|
|
|
return unless options[:merge_ref_head_diff]
|
|
|
|
|
2021-07-21 21:10:10 +00:00
|
|
|
conflicts_service = MergeRequests::Conflicts::ListService.new(merge_request, allow_tree_conflicts: allow_tree_conflicts) # rubocop:disable CodeReuse/ServiceClass
|
2020-11-13 18:09:11 +00:00
|
|
|
|
2021-07-21 21:10:10 +00:00
|
|
|
return unless allow_tree_conflicts || conflicts_service.can_be_resolved_in_ui?
|
2020-11-13 18:09:11 +00:00
|
|
|
|
2021-07-21 21:10:10 +00:00
|
|
|
conflicts_service.conflicts.files.index_by(&:path)
|
2020-11-13 18:09:11 +00:00
|
|
|
end
|
2021-04-14 15:09:04 +00:00
|
|
|
|
2021-06-28 09:08:19 +00:00
|
|
|
def log_overflow_limits(diff_files:, collection_overflow:)
|
2021-04-14 15:09:04 +00:00
|
|
|
if diff_files.any?(&:too_large?)
|
|
|
|
Gitlab::Metrics.add_event(:diffs_overflow_single_file_limits)
|
|
|
|
end
|
|
|
|
|
2021-06-28 09:08:19 +00:00
|
|
|
Gitlab::Metrics.add_event(:diffs_overflow_collection_limits) if collection_overflow
|
2021-04-14 15:09:04 +00:00
|
|
|
Gitlab::Metrics.add_event(:diffs_overflow_max_bytes_limits) if diff_files.overflow_max_bytes?
|
|
|
|
Gitlab::Metrics.add_event(:diffs_overflow_max_files_limits) if diff_files.overflow_max_files?
|
|
|
|
Gitlab::Metrics.add_event(:diffs_overflow_max_lines_limits) if diff_files.overflow_max_lines?
|
|
|
|
Gitlab::Metrics.add_event(:diffs_overflow_collapsed_bytes_limits) if diff_files.collapsed_safe_bytes?
|
|
|
|
Gitlab::Metrics.add_event(:diffs_overflow_collapsed_files_limits) if diff_files.collapsed_safe_files?
|
|
|
|
Gitlab::Metrics.add_event(:diffs_overflow_collapsed_lines_limits) if diff_files.collapsed_safe_lines?
|
|
|
|
end
|
2014-07-15 15:28:21 +00:00
|
|
|
end
|