2019-03-30 07:23:56 +00:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2015-02-23 20:38:30 +00:00
|
|
|
require 'spec_helper'
|
|
|
|
|
2017-07-10 14:24:02 +00:00
|
|
|
describe GitlabIssueTrackerService do
|
2015-02-23 20:38:30 +00:00
|
|
|
describe "Associations" do
|
|
|
|
it { is_expected.to belong_to :project }
|
|
|
|
it { is_expected.to have_one :service_hook }
|
|
|
|
end
|
|
|
|
|
2016-04-21 15:13:14 +00:00
|
|
|
describe 'Validations' do
|
|
|
|
context 'when service is active' do
|
2017-08-02 19:55:11 +00:00
|
|
|
subject { described_class.new(project: create(:project), active: true) }
|
2016-04-21 15:13:14 +00:00
|
|
|
|
|
|
|
it { is_expected.to validate_presence_of(:issues_url) }
|
|
|
|
it_behaves_like 'issue tracker service URL attribute', :issues_url
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when service is inactive' do
|
2017-08-02 19:55:11 +00:00
|
|
|
subject { described_class.new(project: create(:project), active: false) }
|
2016-04-21 15:13:14 +00:00
|
|
|
|
|
|
|
it { is_expected.not_to validate_presence_of(:issues_url) }
|
|
|
|
end
|
|
|
|
end
|
2015-02-23 20:38:30 +00:00
|
|
|
|
|
|
|
describe 'project and issue urls' do
|
2017-08-02 19:55:11 +00:00
|
|
|
let(:project) { create(:project) }
|
2017-07-13 09:31:00 +00:00
|
|
|
let(:service) { project.create_gitlab_issue_tracker_service(active: true) }
|
2015-02-23 20:38:30 +00:00
|
|
|
|
|
|
|
context 'with absolute urls' do
|
|
|
|
before do
|
2017-07-25 17:09:00 +00:00
|
|
|
allow(described_class).to receive(:default_url_options).and_return(script_name: "/gitlab/root")
|
2015-02-23 20:38:30 +00:00
|
|
|
end
|
|
|
|
|
2016-08-01 15:00:44 +00:00
|
|
|
it 'gives the correct path' do
|
2020-03-02 15:08:01 +00:00
|
|
|
expect(service.project_url).to eq("http://#{Gitlab.config.gitlab.host}/gitlab/root/#{project.full_path}/-/issues")
|
|
|
|
expect(service.new_issue_url).to eq("http://#{Gitlab.config.gitlab.host}/gitlab/root/#{project.full_path}/-/issues/new")
|
|
|
|
expect(service.issue_url(432)).to eq("http://#{Gitlab.config.gitlab.host}/gitlab/root/#{project.full_path}/-/issues/432")
|
2015-02-23 20:38:30 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2015-03-25 09:03:55 +00:00
|
|
|
context 'with relative urls' do
|
2015-02-23 20:38:30 +00:00
|
|
|
before do
|
2017-07-25 17:09:00 +00:00
|
|
|
allow(described_class).to receive(:default_url_options).and_return(script_name: "/gitlab/root")
|
2015-02-23 20:38:30 +00:00
|
|
|
end
|
|
|
|
|
2016-08-01 15:00:44 +00:00
|
|
|
it 'gives the correct path' do
|
2020-03-02 15:08:01 +00:00
|
|
|
expect(service.issue_tracker_path).to eq("/gitlab/root/#{project.full_path}/-/issues")
|
|
|
|
expect(service.new_issue_path).to eq("/gitlab/root/#{project.full_path}/-/issues/new")
|
|
|
|
expect(service.issue_path(432)).to eq("/gitlab/root/#{project.full_path}/-/issues/432")
|
2015-02-23 20:38:30 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2019-06-26 14:03:57 +00:00
|
|
|
|
|
|
|
context 'overriding properties' do
|
|
|
|
let(:url) { 'http://gitlab.example.com' }
|
|
|
|
let(:access_params) do
|
|
|
|
{ project_url: url, issues_url: url, new_issue_url: url }
|
|
|
|
end
|
|
|
|
|
2019-10-07 15:05:59 +00:00
|
|
|
# this will be removed as part of https://gitlab.com/gitlab-org/gitlab/issues/29404
|
2019-06-26 14:03:57 +00:00
|
|
|
context 'when data are stored in properties' do
|
|
|
|
let(:properties) { access_params.merge(title: title, description: description) }
|
2019-07-04 17:09:58 +00:00
|
|
|
let(:service) do
|
|
|
|
create(:gitlab_issue_tracker_service, :without_properties_callback, properties: properties)
|
|
|
|
end
|
2019-06-26 14:03:57 +00:00
|
|
|
|
2019-09-16 15:06:26 +00:00
|
|
|
it_behaves_like 'issue tracker fields'
|
2019-06-26 14:03:57 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
context 'when data are stored in separated fields' do
|
|
|
|
let(:service) do
|
|
|
|
create(:gitlab_issue_tracker_service, title: title, description: description, properties: access_params)
|
|
|
|
end
|
|
|
|
|
2019-09-16 15:06:26 +00:00
|
|
|
it_behaves_like 'issue tracker fields'
|
2019-06-26 14:03:57 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
context 'when data are stored in both properties and separated fields' do
|
|
|
|
let(:properties) { access_params.merge(title: 'wrong title', description: 'wrong description') }
|
|
|
|
let(:service) do
|
2019-07-04 17:09:58 +00:00
|
|
|
create(:gitlab_issue_tracker_service, :without_properties_callback, title: title, description: description, properties: properties)
|
2019-06-26 14:03:57 +00:00
|
|
|
end
|
|
|
|
|
2019-09-16 15:06:26 +00:00
|
|
|
it_behaves_like 'issue tracker fields'
|
2019-06-26 14:03:57 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
context 'when no title & description are set' do
|
|
|
|
let(:service) do
|
|
|
|
create(:gitlab_issue_tracker_service, properties: access_params)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns default values' do
|
|
|
|
expect(service.title).to eq('GitLab')
|
|
|
|
expect(service.description).to eq('GitLab issue tracker')
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2015-02-23 20:38:30 +00:00
|
|
|
end
|