2014-12-04 14:49:19 -05:00
|
|
|
require 'spec_helper'
|
|
|
|
|
2017-06-29 00:13:10 -04:00
|
|
|
describe "User Feed" do
|
2014-12-04 14:49:19 -05:00
|
|
|
describe "GET /" do
|
|
|
|
let!(:user) { create(:user) }
|
|
|
|
|
2017-10-12 05:01:12 -04:00
|
|
|
context 'user atom feed via personal access token' do
|
2016-07-25 14:16:19 -04:00
|
|
|
it "renders user atom feed" do
|
2017-10-12 05:01:12 -04:00
|
|
|
personal_access_token = create(:personal_access_token, user: user)
|
|
|
|
|
|
|
|
visit user_path(user, :atom, private_token: personal_access_token.token)
|
2015-02-12 13:53:23 -05:00
|
|
|
expect(body).to have_selector('feed title')
|
2014-12-04 14:49:19 -05:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2017-05-23 16:20:53 -04:00
|
|
|
context 'user atom feed via RSS token' do
|
2017-05-23 09:59:33 -04:00
|
|
|
it "renders user atom feed" do
|
|
|
|
visit user_path(user, :atom, rss_token: user.rss_token)
|
|
|
|
expect(body).to have_selector('feed title')
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2014-12-04 14:49:19 -05:00
|
|
|
context 'feed content' do
|
2017-07-21 17:23:04 -04:00
|
|
|
let(:project) { create(:project, :repository) }
|
2015-02-12 13:53:23 -05:00
|
|
|
let(:issue) do
|
2015-06-23 01:24:39 -04:00
|
|
|
create(:issue,
|
|
|
|
project: project,
|
|
|
|
author: user,
|
|
|
|
description: "Houston, we have a bug!\n\n***\n\nI guess.")
|
2015-02-12 13:53:23 -05:00
|
|
|
end
|
|
|
|
let(:note) do
|
2015-06-23 01:24:39 -04:00
|
|
|
create(:note,
|
|
|
|
noteable: issue,
|
|
|
|
author: user,
|
|
|
|
note: 'Bug confirmed :+1:',
|
|
|
|
project: project)
|
Fix invalid Atom feeds when using emoji, horizontal rules, or images.
Fixes issues #880, #723, #1113: Markdown must be rendered to XHTML, not HTML, when generating summary content for Atom feeds. Otherwise, content-less tags like <img> and <hr>, generated when issue descriptions, merge request descriptions, comments, or commit messages use emoji, horizontal rules, or images, are not terminated and make the Atom XML invalid.
2015-02-21 16:12:13 -05:00
|
|
|
end
|
|
|
|
let(:merge_request) do
|
|
|
|
create(:merge_request,
|
2015-06-23 01:24:39 -04:00
|
|
|
title: 'Fix bug',
|
|
|
|
author: user,
|
|
|
|
source_project: project,
|
|
|
|
target_project: project,
|
Fix invalid Atom feeds when using emoji, horizontal rules, or images.
Fixes issues #880, #723, #1113: Markdown must be rendered to XHTML, not HTML, when generating summary content for Atom feeds. Otherwise, content-less tags like <img> and <hr>, generated when issue descriptions, merge request descriptions, comments, or commit messages use emoji, horizontal rules, or images, are not terminated and make the Atom XML invalid.
2015-02-21 16:12:13 -05:00
|
|
|
description: "Here is the fix: ![an image](image.png)")
|
2015-02-12 13:53:23 -05:00
|
|
|
end
|
2017-08-20 17:18:42 -04:00
|
|
|
let(:push_event) { create(:push_event, project: project, author: user) }
|
|
|
|
let!(:push_event_payload) { create(:push_event_payload, event: push_event) }
|
2014-12-04 14:49:19 -05:00
|
|
|
|
|
|
|
before do
|
|
|
|
project.team << [user, :master]
|
|
|
|
issue_event(issue, user)
|
|
|
|
note_event(note, user)
|
Fix invalid Atom feeds when using emoji, horizontal rules, or images.
Fixes issues #880, #723, #1113: Markdown must be rendered to XHTML, not HTML, when generating summary content for Atom feeds. Otherwise, content-less tags like <img> and <hr>, generated when issue descriptions, merge request descriptions, comments, or commit messages use emoji, horizontal rules, or images, are not terminated and make the Atom XML invalid.
2015-02-21 16:12:13 -05:00
|
|
|
merge_request_event(merge_request, user)
|
2017-05-23 09:59:33 -04:00
|
|
|
visit user_path(user, :atom, rss_token: user.rss_token)
|
2014-12-04 14:49:19 -05:00
|
|
|
end
|
|
|
|
|
2016-07-25 14:16:19 -04:00
|
|
|
it 'has issue opened event' do
|
2015-01-04 08:02:31 -05:00
|
|
|
expect(body).to have_content("#{safe_name} opened issue ##{issue.iid}")
|
2014-12-04 14:49:19 -05:00
|
|
|
end
|
|
|
|
|
2016-07-25 14:16:19 -04:00
|
|
|
it 'has issue comment event' do
|
2017-06-21 09:48:12 -04:00
|
|
|
expect(body)
|
|
|
|
.to have_content("#{safe_name} commented on issue ##{issue.iid}")
|
2014-12-04 14:49:19 -05:00
|
|
|
end
|
Fix invalid Atom feeds when using emoji, horizontal rules, or images.
Fixes issues #880, #723, #1113: Markdown must be rendered to XHTML, not HTML, when generating summary content for Atom feeds. Otherwise, content-less tags like <img> and <hr>, generated when issue descriptions, merge request descriptions, comments, or commit messages use emoji, horizontal rules, or images, are not terminated and make the Atom XML invalid.
2015-02-21 16:12:13 -05:00
|
|
|
|
2016-07-25 14:16:19 -04:00
|
|
|
it 'has XHTML summaries in issue descriptions' do
|
2017-04-28 10:57:17 -04:00
|
|
|
expect(body).to match /<hr ?\/>/
|
Fix invalid Atom feeds when using emoji, horizontal rules, or images.
Fixes issues #880, #723, #1113: Markdown must be rendered to XHTML, not HTML, when generating summary content for Atom feeds. Otherwise, content-less tags like <img> and <hr>, generated when issue descriptions, merge request descriptions, comments, or commit messages use emoji, horizontal rules, or images, are not terminated and make the Atom XML invalid.
2015-02-21 16:12:13 -05:00
|
|
|
end
|
|
|
|
|
2016-07-25 14:16:19 -04:00
|
|
|
it 'has XHTML summaries in notes' do
|
2017-02-27 23:44:34 -05:00
|
|
|
expect(body).to match /Bug confirmed <gl-emoji[^>]*>/
|
Fix invalid Atom feeds when using emoji, horizontal rules, or images.
Fixes issues #880, #723, #1113: Markdown must be rendered to XHTML, not HTML, when generating summary content for Atom feeds. Otherwise, content-less tags like <img> and <hr>, generated when issue descriptions, merge request descriptions, comments, or commit messages use emoji, horizontal rules, or images, are not terminated and make the Atom XML invalid.
2015-02-21 16:12:13 -05:00
|
|
|
end
|
|
|
|
|
2016-07-25 14:16:19 -04:00
|
|
|
it 'has XHTML summaries in merge request descriptions' do
|
2016-08-13 01:13:39 -04:00
|
|
|
expect(body).to match /Here is the fix: <a[^>]*><img[^>]*\/><\/a>/
|
Fix invalid Atom feeds when using emoji, horizontal rules, or images.
Fixes issues #880, #723, #1113: Markdown must be rendered to XHTML, not HTML, when generating summary content for Atom feeds. Otherwise, content-less tags like <img> and <hr>, generated when issue descriptions, merge request descriptions, comments, or commit messages use emoji, horizontal rules, or images, are not terminated and make the Atom XML invalid.
2015-02-21 16:12:13 -05:00
|
|
|
end
|
2017-08-20 17:18:42 -04:00
|
|
|
|
|
|
|
it 'has push event commit ID' do
|
|
|
|
expect(body).to have_content(Commit.truncate_sha(push_event.commit_id))
|
|
|
|
end
|
2014-12-04 14:49:19 -05:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
def issue_event(issue, user)
|
|
|
|
EventCreateService.new.open_issue(issue, user)
|
|
|
|
end
|
|
|
|
|
|
|
|
def note_event(note, user)
|
|
|
|
EventCreateService.new.leave_note(note, user)
|
|
|
|
end
|
2015-01-04 08:02:31 -05:00
|
|
|
|
Fix invalid Atom feeds when using emoji, horizontal rules, or images.
Fixes issues #880, #723, #1113: Markdown must be rendered to XHTML, not HTML, when generating summary content for Atom feeds. Otherwise, content-less tags like <img> and <hr>, generated when issue descriptions, merge request descriptions, comments, or commit messages use emoji, horizontal rules, or images, are not terminated and make the Atom XML invalid.
2015-02-21 16:12:13 -05:00
|
|
|
def merge_request_event(request, user)
|
|
|
|
EventCreateService.new.open_mr(request, user)
|
|
|
|
end
|
|
|
|
|
2015-01-04 08:02:31 -05:00
|
|
|
def safe_name
|
2015-12-11 10:16:07 -05:00
|
|
|
html_escape(user.name)
|
2015-01-04 08:02:31 -05:00
|
|
|
end
|
2014-12-04 14:49:19 -05:00
|
|
|
end
|