2019-03-30 07:23:56 +00:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2012-11-22 19:41:16 +00:00
|
|
|
require 'spec_helper'
|
|
|
|
|
2017-07-10 14:24:02 +00:00
|
|
|
describe Namespace do
|
2017-10-03 15:06:09 +00:00
|
|
|
include ProjectForksHelper
|
2018-10-02 03:21:46 +00:00
|
|
|
include GitHelpers
|
2017-10-03 15:06:09 +00:00
|
|
|
|
2012-11-22 19:41:16 +00:00
|
|
|
let!(:namespace) { create(:namespace) }
|
2017-10-17 10:12:24 +00:00
|
|
|
let(:gitlab_shell) { Gitlab::Shell.new }
|
2018-04-13 10:57:19 +00:00
|
|
|
let(:repository_storage) { 'default' }
|
2012-11-22 19:41:16 +00:00
|
|
|
|
2017-02-06 15:16:50 +00:00
|
|
|
describe 'associations' do
|
|
|
|
it { is_expected.to have_many :projects }
|
|
|
|
it { is_expected.to have_many :project_statistics }
|
|
|
|
it { is_expected.to belong_to :parent }
|
|
|
|
it { is_expected.to have_many :children }
|
2019-06-12 21:11:14 +00:00
|
|
|
it { is_expected.to have_one :root_storage_statistics }
|
|
|
|
it { is_expected.to have_one :aggregation_schedule }
|
2017-02-06 15:16:50 +00:00
|
|
|
end
|
2016-12-02 12:54:57 +00:00
|
|
|
|
2017-02-06 15:16:50 +00:00
|
|
|
describe 'validations' do
|
|
|
|
it { is_expected.to validate_presence_of(:name) }
|
|
|
|
it { is_expected.to validate_length_of(:name).is_at_most(255) }
|
|
|
|
it { is_expected.to validate_length_of(:description).is_at_most(255) }
|
|
|
|
it { is_expected.to validate_presence_of(:path) }
|
|
|
|
it { is_expected.to validate_length_of(:path).is_at_most(255) }
|
|
|
|
it { is_expected.to validate_presence_of(:owner) }
|
2019-12-20 09:24:38 +00:00
|
|
|
it { is_expected.to validate_numericality_of(:max_artifacts_size).only_integer.is_greater_than(0) }
|
2016-12-02 12:54:57 +00:00
|
|
|
|
2017-02-06 15:16:50 +00:00
|
|
|
it 'does not allow too deep nesting' do
|
|
|
|
ancestors = (1..21).to_a
|
|
|
|
nested = build(:namespace, parent: namespace)
|
2016-12-02 12:54:57 +00:00
|
|
|
|
2017-02-06 15:16:50 +00:00
|
|
|
allow(nested).to receive(:ancestors).and_return(ancestors)
|
2016-12-02 12:54:57 +00:00
|
|
|
|
2017-02-06 15:16:50 +00:00
|
|
|
expect(nested).not_to be_valid
|
|
|
|
expect(nested.errors[:parent_id].first).to eq('has too deep level of nesting')
|
|
|
|
end
|
2017-03-06 18:26:58 +00:00
|
|
|
|
|
|
|
describe 'reserved path validation' do
|
|
|
|
context 'nested group' do
|
|
|
|
let(:group) { build(:group, :nested, path: 'tree') }
|
|
|
|
|
|
|
|
it { expect(group).not_to be_valid }
|
2017-04-18 14:27:11 +00:00
|
|
|
|
|
|
|
it 'rejects nested paths' do
|
|
|
|
parent = create(:group, :nested, path: 'environments')
|
2017-05-20 00:46:40 +00:00
|
|
|
namespace = build(:group, path: 'folders', parent: parent)
|
2017-04-18 14:27:11 +00:00
|
|
|
|
|
|
|
expect(namespace).not_to be_valid
|
|
|
|
end
|
2017-03-06 18:26:58 +00:00
|
|
|
end
|
|
|
|
|
2017-06-08 03:32:38 +00:00
|
|
|
context "is case insensitive" do
|
2017-07-17 16:11:07 +00:00
|
|
|
let(:group) { build(:group, path: "Groups") }
|
2017-06-08 03:32:38 +00:00
|
|
|
|
|
|
|
it { expect(group).not_to be_valid }
|
|
|
|
end
|
|
|
|
|
2017-03-06 18:26:58 +00:00
|
|
|
context 'top-level group' do
|
|
|
|
let(:group) { build(:group, path: 'tree') }
|
|
|
|
|
|
|
|
it { expect(group).to be_valid }
|
|
|
|
end
|
|
|
|
end
|
2017-02-06 15:16:50 +00:00
|
|
|
end
|
2012-11-25 09:57:01 +00:00
|
|
|
|
2019-04-16 16:16:52 +00:00
|
|
|
describe 'delegate' do
|
|
|
|
it { is_expected.to delegate_method(:name).to(:owner).with_prefix.with_arguments(allow_nil: true) }
|
|
|
|
it { is_expected.to delegate_method(:avatar_url).to(:owner).with_arguments(allow_nil: true) }
|
|
|
|
end
|
|
|
|
|
2012-11-25 09:57:01 +00:00
|
|
|
describe "Respond to" do
|
2015-02-12 18:17:35 +00:00
|
|
|
it { is_expected.to respond_to(:human_name) }
|
|
|
|
it { is_expected.to respond_to(:to_param) }
|
2017-04-11 14:21:52 +00:00
|
|
|
it { is_expected.to respond_to(:has_parent?) }
|
2012-11-25 09:57:01 +00:00
|
|
|
end
|
2012-11-21 04:14:05 +00:00
|
|
|
|
2017-07-17 10:40:17 +00:00
|
|
|
describe 'inclusions' do
|
|
|
|
it { is_expected.to include_module(Gitlab::VisibilityLevel) }
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#visibility_level_field' do
|
|
|
|
it { expect(namespace.visibility_level_field).to eq(:visibility_level) }
|
|
|
|
end
|
|
|
|
|
2016-07-11 22:12:31 +00:00
|
|
|
describe '#to_param' do
|
2017-02-23 23:55:01 +00:00
|
|
|
it { expect(namespace.to_param).to eq(namespace.full_path) }
|
2012-11-21 04:14:05 +00:00
|
|
|
end
|
|
|
|
|
2016-07-11 22:12:31 +00:00
|
|
|
describe '#human_name' do
|
2015-02-12 18:17:35 +00:00
|
|
|
it { expect(namespace.human_name).to eq(namespace.owner_name) }
|
2012-11-21 04:14:05 +00:00
|
|
|
end
|
|
|
|
|
2018-10-02 03:13:40 +00:00
|
|
|
describe '#first_project_with_container_registry_tags' do
|
|
|
|
let(:container_repository) { create(:container_repository) }
|
|
|
|
let!(:project) { create(:project, namespace: namespace, container_repositories: [container_repository]) }
|
|
|
|
|
|
|
|
before do
|
|
|
|
stub_container_registry_config(enabled: true)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns the project' do
|
|
|
|
stub_container_registry_tags(repository: :any, tags: ['tag'])
|
|
|
|
|
|
|
|
expect(namespace.first_project_with_container_registry_tags).to eq(project)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns no project' do
|
|
|
|
stub_container_registry_tags(repository: :any, tags: nil)
|
|
|
|
|
|
|
|
expect(namespace.first_project_with_container_registry_tags).to be_nil
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2016-03-04 11:15:30 +00:00
|
|
|
describe '.search' do
|
2016-03-04 11:06:25 +00:00
|
|
|
let(:namespace) { create(:namespace) }
|
|
|
|
|
|
|
|
it 'returns namespaces with a matching name' do
|
|
|
|
expect(described_class.search(namespace.name)).to eq([namespace])
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns namespaces with a partially matching name' do
|
|
|
|
expect(described_class.search(namespace.name[0..2])).to eq([namespace])
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns namespaces with a matching name regardless of the casing' do
|
|
|
|
expect(described_class.search(namespace.name.upcase)).to eq([namespace])
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns namespaces with a matching path' do
|
|
|
|
expect(described_class.search(namespace.path)).to eq([namespace])
|
2012-11-21 04:14:05 +00:00
|
|
|
end
|
|
|
|
|
2016-03-04 11:06:25 +00:00
|
|
|
it 'returns namespaces with a partially matching path' do
|
|
|
|
expect(described_class.search(namespace.path[0..2])).to eq([namespace])
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns namespaces with a matching path regardless of the casing' do
|
|
|
|
expect(described_class.search(namespace.path.upcase)).to eq([namespace])
|
|
|
|
end
|
2012-11-21 04:14:05 +00:00
|
|
|
end
|
|
|
|
|
2016-11-22 16:58:10 +00:00
|
|
|
describe '.with_statistics' do
|
|
|
|
let(:namespace) { create :namespace }
|
|
|
|
|
|
|
|
let(:project1) do
|
2017-08-02 19:55:11 +00:00
|
|
|
create(:project,
|
2016-11-22 16:58:10 +00:00
|
|
|
namespace: namespace,
|
|
|
|
statistics: build(:project_statistics,
|
|
|
|
repository_size: 101,
|
2019-02-13 22:38:11 +00:00
|
|
|
wiki_size: 505,
|
2016-11-22 16:58:10 +00:00
|
|
|
lfs_objects_size: 202,
|
2019-05-02 16:04:15 +00:00
|
|
|
build_artifacts_size: 303,
|
|
|
|
packages_size: 404))
|
2016-11-22 16:58:10 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
let(:project2) do
|
2017-08-02 19:55:11 +00:00
|
|
|
create(:project,
|
2016-11-22 16:58:10 +00:00
|
|
|
namespace: namespace,
|
|
|
|
statistics: build(:project_statistics,
|
|
|
|
repository_size: 10,
|
2019-02-13 22:38:11 +00:00
|
|
|
wiki_size: 50,
|
2016-11-22 16:58:10 +00:00
|
|
|
lfs_objects_size: 20,
|
2019-05-02 16:04:15 +00:00
|
|
|
build_artifacts_size: 30,
|
|
|
|
packages_size: 40))
|
2016-11-22 16:58:10 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
it "sums all project storage counters in the namespace" do
|
|
|
|
project1
|
|
|
|
project2
|
2017-07-25 17:09:00 +00:00
|
|
|
statistics = described_class.with_statistics.find(namespace.id)
|
2016-11-22 16:58:10 +00:00
|
|
|
|
2019-02-13 22:38:11 +00:00
|
|
|
expect(statistics.storage_size).to eq 1665
|
2016-11-22 16:58:10 +00:00
|
|
|
expect(statistics.repository_size).to eq 111
|
2019-02-13 22:38:11 +00:00
|
|
|
expect(statistics.wiki_size).to eq 555
|
2016-11-22 16:58:10 +00:00
|
|
|
expect(statistics.lfs_objects_size).to eq 222
|
|
|
|
expect(statistics.build_artifacts_size).to eq 333
|
2019-05-02 16:04:15 +00:00
|
|
|
expect(statistics.packages_size).to eq 444
|
2016-11-22 16:58:10 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
it "correctly handles namespaces without projects" do
|
2017-07-25 17:09:00 +00:00
|
|
|
statistics = described_class.with_statistics.find(namespace.id)
|
2016-11-22 16:58:10 +00:00
|
|
|
|
|
|
|
expect(statistics.storage_size).to eq 0
|
|
|
|
expect(statistics.repository_size).to eq 0
|
2019-02-13 22:38:11 +00:00
|
|
|
expect(statistics.wiki_size).to eq 0
|
2016-11-22 16:58:10 +00:00
|
|
|
expect(statistics.lfs_objects_size).to eq 0
|
|
|
|
expect(statistics.build_artifacts_size).to eq 0
|
2019-05-02 16:04:15 +00:00
|
|
|
expect(statistics.packages_size).to eq 0
|
2016-11-22 16:58:10 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2019-09-25 09:06:04 +00:00
|
|
|
describe '.find_by_pages_host' do
|
|
|
|
it 'finds namespace by GitLab Pages host and is case-insensitive' do
|
|
|
|
namespace = create(:namespace, name: 'topnamespace')
|
|
|
|
create(:namespace, name: 'annother_namespace')
|
|
|
|
host = "TopNamespace.#{Settings.pages.host.upcase}"
|
|
|
|
|
|
|
|
expect(described_class.find_by_pages_host(host)).to eq(namespace)
|
|
|
|
end
|
2019-12-11 12:08:10 +00:00
|
|
|
|
|
|
|
it "returns no result if the provided host is not subdomain of the Pages host" do
|
|
|
|
create(:namespace, name: 'namespace.io')
|
|
|
|
host = "namespace.io"
|
|
|
|
|
|
|
|
expect(described_class.find_by_pages_host(host)).to eq(nil)
|
|
|
|
end
|
2019-09-25 09:06:04 +00:00
|
|
|
end
|
|
|
|
|
2019-07-24 09:20:54 +00:00
|
|
|
describe '#ancestors_upto' do
|
2017-10-10 13:45:35 +00:00
|
|
|
let(:parent) { create(:group) }
|
|
|
|
let(:child) { create(:group, parent: parent) }
|
|
|
|
let(:child2) { create(:group, parent: child) }
|
|
|
|
|
|
|
|
it 'returns all ancestors when no namespace is given' do
|
|
|
|
expect(child2.ancestors_upto).to contain_exactly(child, parent)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'includes ancestors upto but excluding the given ancestor' do
|
|
|
|
expect(child2.ancestors_upto(parent)).to contain_exactly(child)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2017-10-17 10:12:24 +00:00
|
|
|
describe '#move_dir', :request_store do
|
2017-12-01 13:58:49 +00:00
|
|
|
shared_examples "namespace restrictions" do
|
|
|
|
context "when any project has container images" do
|
|
|
|
let(:container_repository) { create(:container_repository) }
|
2017-10-05 13:01:26 +00:00
|
|
|
|
2017-12-01 13:58:49 +00:00
|
|
|
before do
|
|
|
|
stub_container_registry_config(enabled: true)
|
|
|
|
stub_container_registry_tags(repository: :any, tags: ['tag'])
|
2012-11-21 04:14:05 +00:00
|
|
|
|
2017-12-01 13:58:49 +00:00
|
|
|
create(:project, namespace: namespace, container_repositories: [container_repository])
|
2017-10-05 13:01:26 +00:00
|
|
|
|
2017-12-01 13:58:49 +00:00
|
|
|
allow(namespace).to receive(:path_was).and_return(namespace.path)
|
|
|
|
allow(namespace).to receive(:path).and_return('new_path')
|
|
|
|
end
|
2016-05-16 23:03:55 +00:00
|
|
|
|
2017-12-01 13:58:49 +00:00
|
|
|
it 'raises an error about not movable project' do
|
2018-10-02 03:13:40 +00:00
|
|
|
expect { namespace.move_dir }.to raise_error(Gitlab::UpdatePathError,
|
|
|
|
/Namespace .* cannot be moved/)
|
2017-12-01 13:58:49 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2016-12-16 03:24:05 +00:00
|
|
|
|
2017-12-01 13:58:49 +00:00
|
|
|
context 'legacy storage' do
|
|
|
|
let(:namespace) { create(:namespace) }
|
|
|
|
let!(:project) { create(:project_empty_repo, :legacy_storage, namespace: namespace) }
|
2016-05-16 23:03:55 +00:00
|
|
|
|
2017-12-01 13:58:49 +00:00
|
|
|
it_behaves_like 'namespace restrictions'
|
2016-05-16 23:03:55 +00:00
|
|
|
|
2017-12-01 13:58:49 +00:00
|
|
|
it "raises error when directory exists" do
|
|
|
|
expect { namespace.move_dir }.to raise_error("namespace directory cannot be moved")
|
2016-05-16 23:03:55 +00:00
|
|
|
end
|
|
|
|
|
2017-12-01 13:58:49 +00:00
|
|
|
it "moves dir if path changed" do
|
2018-07-02 10:43:06 +00:00
|
|
|
namespace.update(path: namespace.full_path + '_new')
|
2017-12-01 13:58:49 +00:00
|
|
|
|
2019-10-09 09:06:19 +00:00
|
|
|
expect(gitlab_shell.repository_exists?(project.repository_storage, "#{namespace.path}/#{project.path}.git")).to be_truthy
|
2017-04-03 19:25:52 +00:00
|
|
|
end
|
2017-03-28 17:27:44 +00:00
|
|
|
|
2018-07-26 18:44:21 +00:00
|
|
|
context 'when #write_projects_repository_config raises an error' do
|
|
|
|
context 'in test environment' do
|
|
|
|
it 'raises an exception' do
|
|
|
|
expect(namespace).to receive(:write_projects_repository_config).and_raise('foo')
|
|
|
|
|
|
|
|
expect do
|
|
|
|
namespace.update(path: namespace.full_path + '_new')
|
|
|
|
end.to raise_error('foo')
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'in production environment' do
|
|
|
|
it 'does not cancel later callbacks' do
|
|
|
|
expect(namespace).to receive(:write_projects_repository_config).and_raise('foo')
|
|
|
|
expect(namespace).to receive(:move_dir).and_wrap_original do |m, *args|
|
|
|
|
move_dir_result = m.call(*args)
|
|
|
|
|
|
|
|
expect(move_dir_result).to be_truthy # Must be truthy, or else later callbacks would be canceled
|
|
|
|
|
|
|
|
move_dir_result
|
|
|
|
end
|
2019-12-16 12:07:43 +00:00
|
|
|
expect(Gitlab::ErrorTracking).to receive(:should_raise_for_dev?).and_return(false) # like prod
|
2018-07-26 18:44:21 +00:00
|
|
|
|
|
|
|
namespace.update(path: namespace.full_path + '_new')
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2019-11-06 09:06:23 +00:00
|
|
|
shared_examples 'move_dir without repository storage feature' do |storage_version|
|
|
|
|
let(:namespace) { create(:namespace) }
|
|
|
|
let(:gitlab_shell) { namespace.gitlab_shell }
|
|
|
|
let!(:project) { create(:project_empty_repo, namespace: namespace, storage_version: storage_version) }
|
|
|
|
|
|
|
|
it 'calls namespace service' do
|
|
|
|
expect(gitlab_shell).to receive(:add_namespace).and_return(true)
|
|
|
|
expect(gitlab_shell).to receive(:mv_namespace).and_return(true)
|
|
|
|
|
|
|
|
namespace.move_dir
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
shared_examples 'move_dir with repository storage feature' do |storage_version|
|
|
|
|
let(:namespace) { create(:namespace) }
|
|
|
|
let(:gitlab_shell) { namespace.gitlab_shell }
|
|
|
|
let!(:project) { create(:project_empty_repo, namespace: namespace, storage_version: storage_version) }
|
|
|
|
|
|
|
|
it 'does not call namespace service' do
|
|
|
|
expect(gitlab_shell).not_to receive(:add_namespace)
|
|
|
|
expect(gitlab_shell).not_to receive(:mv_namespace)
|
|
|
|
|
|
|
|
namespace.move_dir
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'project is without repository storage feature' do
|
|
|
|
[nil, 0].each do |storage_version|
|
|
|
|
it_behaves_like 'move_dir without repository storage feature', storage_version
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'project has repository storage feature' do
|
|
|
|
[1, 2].each do |storage_version|
|
|
|
|
it_behaves_like 'move_dir with repository storage feature', storage_version
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2019-07-24 09:20:54 +00:00
|
|
|
context 'with subgroups' do
|
2017-12-01 13:58:49 +00:00
|
|
|
let(:parent) { create(:group, name: 'parent', path: 'parent') }
|
2018-03-08 22:16:21 +00:00
|
|
|
let(:new_parent) { create(:group, name: 'new_parent', path: 'new_parent') }
|
2017-12-01 13:58:49 +00:00
|
|
|
let(:child) { create(:group, name: 'child', path: 'child', parent: parent) }
|
|
|
|
let!(:project) { create(:project_empty_repo, :legacy_storage, path: 'the-project', namespace: child, skip_disk_validation: true) }
|
|
|
|
let(:uploads_dir) { FileUploader.root }
|
|
|
|
let(:pages_dir) { File.join(TestEnv.pages_path) }
|
2017-03-28 17:27:44 +00:00
|
|
|
|
2018-03-08 22:16:21 +00:00
|
|
|
def expect_project_directories_at(namespace_path)
|
|
|
|
expected_repository_path = File.join(TestEnv.repos_path, namespace_path, 'the-project.git')
|
|
|
|
expected_upload_path = File.join(uploads_dir, namespace_path, 'the-project')
|
|
|
|
expected_pages_path = File.join(pages_dir, namespace_path, 'the-project')
|
|
|
|
|
2018-03-09 17:17:14 +00:00
|
|
|
expect(File.directory?(expected_repository_path)).to be_truthy
|
|
|
|
expect(File.directory?(expected_upload_path)).to be_truthy
|
|
|
|
expect(File.directory?(expected_pages_path)).to be_truthy
|
2018-03-08 22:16:21 +00:00
|
|
|
end
|
|
|
|
|
2017-12-01 13:58:49 +00:00
|
|
|
before do
|
2018-03-08 22:16:21 +00:00
|
|
|
FileUtils.mkdir_p(File.join(TestEnv.repos_path, "#{project.full_path}.git"))
|
2017-12-01 13:58:49 +00:00
|
|
|
FileUtils.mkdir_p(File.join(uploads_dir, project.full_path))
|
|
|
|
FileUtils.mkdir_p(File.join(pages_dir, project.full_path))
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'renaming child' do
|
|
|
|
it 'correctly moves the repository, uploads and pages' do
|
2018-03-08 22:16:21 +00:00
|
|
|
child.update!(path: 'renamed')
|
2017-03-28 17:27:44 +00:00
|
|
|
|
2018-03-08 22:16:21 +00:00
|
|
|
expect_project_directories_at('parent/renamed')
|
2017-12-01 13:58:49 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'renaming parent' do
|
|
|
|
it 'correctly moves the repository, uploads and pages' do
|
2018-03-08 22:16:21 +00:00
|
|
|
parent.update!(path: 'renamed')
|
|
|
|
|
|
|
|
expect_project_directories_at('renamed/child')
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'moving from one parent to another' do
|
|
|
|
it 'correctly moves the repository, uploads and pages' do
|
|
|
|
child.update!(parent: new_parent)
|
2017-03-28 17:27:44 +00:00
|
|
|
|
2018-03-08 22:16:21 +00:00
|
|
|
expect_project_directories_at('new_parent/child')
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'moving from having a parent to root' do
|
|
|
|
it 'correctly moves the repository, uploads and pages' do
|
|
|
|
child.update!(parent: nil)
|
|
|
|
|
|
|
|
expect_project_directories_at('child')
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'moving from root to having a parent' do
|
|
|
|
it 'correctly moves the repository, uploads and pages' do
|
|
|
|
parent.update!(parent: new_parent)
|
2017-12-01 13:58:49 +00:00
|
|
|
|
2018-03-08 22:16:21 +00:00
|
|
|
expect_project_directories_at('new_parent/parent/child')
|
2017-12-01 13:58:49 +00:00
|
|
|
end
|
2017-04-03 15:48:17 +00:00
|
|
|
end
|
|
|
|
end
|
2017-12-01 13:58:49 +00:00
|
|
|
end
|
2017-04-03 15:48:17 +00:00
|
|
|
|
2017-12-01 13:58:49 +00:00
|
|
|
context 'hashed storage' do
|
|
|
|
let(:namespace) { create(:namespace) }
|
|
|
|
let!(:project) { create(:project_empty_repo, namespace: namespace) }
|
2017-04-03 15:48:17 +00:00
|
|
|
|
2017-12-01 13:58:49 +00:00
|
|
|
it_behaves_like 'namespace restrictions'
|
2017-04-03 15:48:17 +00:00
|
|
|
|
2017-12-01 13:58:49 +00:00
|
|
|
it "repository directory remains unchanged if path changed" do
|
|
|
|
before_disk_path = project.disk_path
|
2018-07-02 10:43:06 +00:00
|
|
|
namespace.update(path: namespace.full_path + '_new')
|
2017-12-01 13:58:49 +00:00
|
|
|
|
|
|
|
expect(before_disk_path).to eq(project.disk_path)
|
2019-10-09 09:06:19 +00:00
|
|
|
expect(gitlab_shell.repository_exists?(project.repository_storage, "#{project.disk_path}.git")).to be_truthy
|
2017-03-28 17:27:44 +00:00
|
|
|
end
|
|
|
|
end
|
2017-12-19 19:42:51 +00:00
|
|
|
|
2018-12-21 15:31:14 +00:00
|
|
|
context 'for each project inside the namespace' do
|
|
|
|
let!(:parent) { create(:group, name: 'mygroup', path: 'mygroup') }
|
|
|
|
let!(:subgroup) { create(:group, name: 'mysubgroup', path: 'mysubgroup', parent: parent) }
|
|
|
|
let!(:project_in_parent_group) { create(:project, :legacy_storage, :repository, namespace: parent, name: 'foo1') }
|
|
|
|
let!(:hashed_project_in_subgroup) { create(:project, :repository, namespace: subgroup, name: 'foo2') }
|
|
|
|
let!(:legacy_project_in_subgroup) { create(:project, :legacy_storage, :repository, namespace: subgroup, name: 'foo3') }
|
|
|
|
|
|
|
|
it 'updates project full path in .git/config' do
|
|
|
|
parent.update(path: 'mygroup_new')
|
|
|
|
|
|
|
|
expect(project_rugged(project_in_parent_group).config['gitlab.fullpath']).to eq "mygroup_new/#{project_in_parent_group.path}"
|
|
|
|
expect(project_rugged(hashed_project_in_subgroup).config['gitlab.fullpath']).to eq "mygroup_new/mysubgroup/#{hashed_project_in_subgroup.path}"
|
|
|
|
expect(project_rugged(legacy_project_in_subgroup).config['gitlab.fullpath']).to eq "mygroup_new/mysubgroup/#{legacy_project_in_subgroup.path}"
|
2018-07-02 15:09:49 +00:00
|
|
|
end
|
|
|
|
|
2018-12-21 15:31:14 +00:00
|
|
|
it 'updates the project storage location' do
|
|
|
|
repository_project_in_parent_group = create(:project_repository, project: project_in_parent_group)
|
|
|
|
repository_hashed_project_in_subgroup = create(:project_repository, project: hashed_project_in_subgroup)
|
|
|
|
repository_legacy_project_in_subgroup = create(:project_repository, project: legacy_project_in_subgroup)
|
|
|
|
|
|
|
|
parent.update(path: 'mygroup_moved')
|
|
|
|
|
|
|
|
expect(repository_project_in_parent_group.reload.disk_path).to eq "mygroup_moved/#{project_in_parent_group.path}"
|
|
|
|
expect(repository_hashed_project_in_subgroup.reload.disk_path).to eq hashed_project_in_subgroup.disk_path
|
|
|
|
expect(repository_legacy_project_in_subgroup.reload.disk_path).to eq "mygroup_moved/mysubgroup/#{legacy_project_in_subgroup.path}"
|
|
|
|
end
|
|
|
|
|
|
|
|
def project_rugged(project)
|
|
|
|
# Routes are loaded when creating the projects, so we need to manually
|
|
|
|
# reload them for the below code to be aware of the above UPDATE.
|
|
|
|
project.route.reload
|
2018-01-05 11:29:01 +00:00
|
|
|
|
2018-12-21 15:31:14 +00:00
|
|
|
rugged_repo(project.repository)
|
|
|
|
end
|
2017-12-19 19:42:51 +00:00
|
|
|
end
|
2012-11-21 04:14:05 +00:00
|
|
|
end
|
|
|
|
|
2017-07-10 14:24:02 +00:00
|
|
|
describe '#rm_dir', 'callback' do
|
2018-06-05 15:51:14 +00:00
|
|
|
let(:repository_storage_path) do
|
|
|
|
Gitlab::GitalyClient::StorageSettings.allow_disk_access do
|
|
|
|
Gitlab.config.repositories.storages.default.legacy_disk_path
|
|
|
|
end
|
|
|
|
end
|
2017-03-28 17:27:44 +00:00
|
|
|
let(:path_in_dir) { File.join(repository_storage_path, namespace.full_path) }
|
|
|
|
let(:deleted_path) { namespace.full_path.gsub(namespace.path, "#{namespace.full_path}+#{namespace.id}+deleted") }
|
|
|
|
let(:deleted_path_in_dir) { File.join(repository_storage_path, deleted_path) }
|
|
|
|
|
2017-12-01 13:58:49 +00:00
|
|
|
context 'legacy storage' do
|
|
|
|
let!(:project) { create(:project_empty_repo, :legacy_storage, namespace: namespace) }
|
2017-03-28 17:27:44 +00:00
|
|
|
|
|
|
|
it 'renames its dirs when deleted' do
|
|
|
|
allow(GitlabShellWorker).to receive(:perform_in)
|
|
|
|
|
2017-12-01 13:58:49 +00:00
|
|
|
namespace.destroy
|
2017-03-28 17:27:44 +00:00
|
|
|
|
|
|
|
expect(File.exist?(deleted_path_in_dir)).to be(true)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'schedules the namespace for deletion' do
|
2018-04-13 10:57:19 +00:00
|
|
|
expect(GitlabShellWorker).to receive(:perform_in).with(5.minutes, :rm_namespace, repository_storage, deleted_path)
|
2017-03-28 17:27:44 +00:00
|
|
|
|
2017-12-01 13:58:49 +00:00
|
|
|
namespace.destroy
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'in sub-groups' do
|
|
|
|
let(:parent) { create(:group, path: 'parent') }
|
|
|
|
let(:child) { create(:group, parent: parent, path: 'child') }
|
|
|
|
let!(:project) { create(:project_empty_repo, :legacy_storage, namespace: child) }
|
|
|
|
let(:path_in_dir) { File.join(repository_storage_path, 'parent', 'child') }
|
|
|
|
let(:deleted_path) { File.join('parent', "child+#{child.id}+deleted") }
|
|
|
|
let(:deleted_path_in_dir) { File.join(repository_storage_path, deleted_path) }
|
|
|
|
|
|
|
|
it 'renames its dirs when deleted' do
|
|
|
|
allow(GitlabShellWorker).to receive(:perform_in)
|
|
|
|
|
|
|
|
child.destroy
|
|
|
|
|
|
|
|
expect(File.exist?(deleted_path_in_dir)).to be(true)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'schedules the namespace for deletion' do
|
2018-04-13 10:57:19 +00:00
|
|
|
expect(GitlabShellWorker).to receive(:perform_in).with(5.minutes, :rm_namespace, repository_storage, deleted_path)
|
2017-12-01 13:58:49 +00:00
|
|
|
|
|
|
|
child.destroy
|
|
|
|
end
|
|
|
|
end
|
2012-11-21 04:14:05 +00:00
|
|
|
end
|
2017-01-04 19:13:29 +00:00
|
|
|
|
2017-12-01 13:58:49 +00:00
|
|
|
context 'hashed storage' do
|
|
|
|
let!(:project) { create(:project_empty_repo, namespace: namespace) }
|
|
|
|
|
|
|
|
it 'has no repositories base directories to remove' do
|
|
|
|
allow(GitlabShellWorker).to receive(:perform_in)
|
|
|
|
|
|
|
|
expect(File.exist?(path_in_dir)).to be(false)
|
2017-01-04 19:13:29 +00:00
|
|
|
|
2017-12-01 13:58:49 +00:00
|
|
|
namespace.destroy
|
|
|
|
|
|
|
|
expect(File.exist?(deleted_path_in_dir)).to be(false)
|
|
|
|
end
|
2017-01-04 19:13:29 +00:00
|
|
|
end
|
2012-11-21 04:14:05 +00:00
|
|
|
end
|
2015-03-03 07:06:59 +00:00
|
|
|
|
2016-07-11 22:12:31 +00:00
|
|
|
describe '.find_by_path_or_name' do
|
2015-03-03 07:06:59 +00:00
|
|
|
before do
|
|
|
|
@namespace = create(:namespace, name: 'WoW', path: 'woW')
|
|
|
|
end
|
|
|
|
|
2017-07-25 17:09:00 +00:00
|
|
|
it { expect(described_class.find_by_path_or_name('wow')).to eq(@namespace) }
|
|
|
|
it { expect(described_class.find_by_path_or_name('WOW')).to eq(@namespace) }
|
|
|
|
it { expect(described_class.find_by_path_or_name('unknown')).to eq(nil) }
|
2015-03-03 07:06:59 +00:00
|
|
|
end
|
2015-03-24 13:53:30 +00:00
|
|
|
|
|
|
|
describe ".clean_path" do
|
|
|
|
let!(:user) { create(:user, username: "johngitlab-etc") }
|
|
|
|
let!(:namespace) { create(:namespace, path: "JohnGitLab-etc1") }
|
|
|
|
|
|
|
|
it "cleans the path and makes sure it's available" do
|
2017-07-25 17:09:00 +00:00
|
|
|
expect(described_class.clean_path("-john+gitlab-ETC%.git@gmail.com")).to eq("johngitlab-ETC2")
|
|
|
|
expect(described_class.clean_path("--%+--valid_*&%name=.git.%.atom.atom.@email.com")).to eq("valid_name")
|
2015-03-24 13:53:30 +00:00
|
|
|
end
|
|
|
|
end
|
2016-10-31 11:00:53 +00:00
|
|
|
|
2019-07-24 09:20:54 +00:00
|
|
|
describe '#self_and_hierarchy' do
|
2018-04-26 19:53:13 +00:00
|
|
|
let!(:group) { create(:group, path: 'git_lab') }
|
|
|
|
let!(:nested_group) { create(:group, parent: group) }
|
|
|
|
let!(:deep_nested_group) { create(:group, parent: nested_group) }
|
|
|
|
let!(:very_deep_nested_group) { create(:group, parent: deep_nested_group) }
|
|
|
|
let!(:another_group) { create(:group, path: 'gitllab') }
|
|
|
|
let!(:another_group_nested) { create(:group, path: 'foo', parent: another_group) }
|
|
|
|
|
|
|
|
it 'returns the correct tree' do
|
|
|
|
expect(group.self_and_hierarchy).to contain_exactly(group, nested_group, deep_nested_group, very_deep_nested_group)
|
|
|
|
expect(nested_group.self_and_hierarchy).to contain_exactly(group, nested_group, deep_nested_group, very_deep_nested_group)
|
|
|
|
expect(very_deep_nested_group.self_and_hierarchy).to contain_exactly(group, nested_group, deep_nested_group, very_deep_nested_group)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2019-07-24 09:20:54 +00:00
|
|
|
describe '#ancestors' do
|
2016-12-13 14:59:49 +00:00
|
|
|
let(:group) { create(:group) }
|
|
|
|
let(:nested_group) { create(:group, parent: group) }
|
|
|
|
let(:deep_nested_group) { create(:group, parent: nested_group) }
|
2016-12-13 18:49:25 +00:00
|
|
|
let(:very_deep_nested_group) { create(:group, parent: deep_nested_group) }
|
2016-12-13 14:59:49 +00:00
|
|
|
|
2017-01-05 12:43:50 +00:00
|
|
|
it 'returns the correct ancestors' do
|
Use CTEs for nested groups and authorizations
This commit introduces the usage of Common Table Expressions (CTEs) to
efficiently retrieve nested group hierarchies, without having to rely on
the "routes" table (which is an _incredibly_ inefficient way of getting
the data). This requires a patch to ActiveRecord (found in the added
initializer) to work properly as ActiveRecord doesn't support WITH
statements properly out of the box.
Unfortunately MySQL provides no efficient way of getting nested groups.
For example, the old routes setup could easily take 5-10 seconds
depending on the amount of "routes" in a database. Providing vastly
different logic for both MySQL and PostgreSQL will negatively impact the
development process. Because of this the various nested groups related
methods return empty relations when used in combination with MySQL.
For project authorizations the logic is split up into two classes:
* Gitlab::ProjectAuthorizations::WithNestedGroups
* Gitlab::ProjectAuthorizations::WithoutNestedGroups
Both classes get the fresh project authorizations (= as they should be
in the "project_authorizations" table), including nested groups if
PostgreSQL is used. The logic of these two classes is quite different
apart from their public interface. This complicates development a bit,
but unfortunately there is no way around this.
This commit also introduces Gitlab::GroupHierarchy. This class can be
used to get the ancestors and descendants of a base relation, or both by
using a UNION. This in turn is used by methods such as:
* Namespace#ancestors
* Namespace#descendants
* User#all_expanded_groups
Again this class relies on CTEs and thus only works on PostgreSQL. The
Namespace methods will return an empty relation when MySQL is used,
while User#all_expanded_groups will return only the groups a user is a
direct member of.
Performance wise the impact is quite large. For example, on GitLab.com
Namespace#descendants used to take around 580 ms to retrieve data for a
particular user. Using CTEs we are able to reduce this down to roughly 1
millisecond, returning the exact same data.
== On The Fly Refreshing
Refreshing of authorizations on the fly (= when
users.authorized_projects_populated was not set) is removed with this
commit. This simplifies the code, and ensures any queries used for
authorizations are not mutated because they are executed in a Rails
scope (e.g. Project.visible_to_user).
This commit includes a migration to schedule refreshing authorizations
for all users, ensuring all of them have their authorizations in place.
Said migration schedules users in batches of 5000, with 5 minutes
between every batch to smear the load around a bit.
== Spec Changes
This commit also introduces some changes to various specs. For example,
some specs for ProjectTeam assumed that creating a personal project
would _not_ lead to the owner having access, which is incorrect. Because
we also no longer refresh authorizations on the fly for new users some
code had to be added to the "empty_project" factory. This chunk of code
ensures that the owner's permissions are refreshed after creating the
project, something that is normally done in Projects::CreateService.
2017-04-24 15:19:22 +00:00
|
|
|
expect(very_deep_nested_group.ancestors).to include(group, nested_group, deep_nested_group)
|
|
|
|
expect(deep_nested_group.ancestors).to include(group, nested_group)
|
|
|
|
expect(nested_group.ancestors).to include(group)
|
2017-01-05 12:43:50 +00:00
|
|
|
expect(group.ancestors).to eq([])
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2019-07-24 09:20:54 +00:00
|
|
|
describe '#self_and_ancestors' do
|
2017-08-11 14:19:11 +00:00
|
|
|
let(:group) { create(:group) }
|
|
|
|
let(:nested_group) { create(:group, parent: group) }
|
|
|
|
let(:deep_nested_group) { create(:group, parent: nested_group) }
|
|
|
|
let(:very_deep_nested_group) { create(:group, parent: deep_nested_group) }
|
|
|
|
|
|
|
|
it 'returns the correct ancestors' do
|
|
|
|
expect(very_deep_nested_group.self_and_ancestors).to contain_exactly(group, nested_group, deep_nested_group, very_deep_nested_group)
|
|
|
|
expect(deep_nested_group.self_and_ancestors).to contain_exactly(group, nested_group, deep_nested_group)
|
|
|
|
expect(nested_group.self_and_ancestors).to contain_exactly(group, nested_group)
|
|
|
|
expect(group.self_and_ancestors).to contain_exactly(group)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2019-07-24 09:20:54 +00:00
|
|
|
describe '#descendants' do
|
2017-03-22 11:17:01 +00:00
|
|
|
let!(:group) { create(:group, path: 'git_lab') }
|
2017-01-05 12:43:50 +00:00
|
|
|
let!(:nested_group) { create(:group, parent: group) }
|
|
|
|
let!(:deep_nested_group) { create(:group, parent: nested_group) }
|
|
|
|
let!(:very_deep_nested_group) { create(:group, parent: deep_nested_group) }
|
2017-03-22 11:17:01 +00:00
|
|
|
let!(:another_group) { create(:group, path: 'gitllab') }
|
|
|
|
let!(:another_group_nested) { create(:group, path: 'foo', parent: another_group) }
|
2017-01-05 12:43:50 +00:00
|
|
|
|
|
|
|
it 'returns the correct descendants' do
|
|
|
|
expect(very_deep_nested_group.descendants.to_a).to eq([])
|
Use CTEs for nested groups and authorizations
This commit introduces the usage of Common Table Expressions (CTEs) to
efficiently retrieve nested group hierarchies, without having to rely on
the "routes" table (which is an _incredibly_ inefficient way of getting
the data). This requires a patch to ActiveRecord (found in the added
initializer) to work properly as ActiveRecord doesn't support WITH
statements properly out of the box.
Unfortunately MySQL provides no efficient way of getting nested groups.
For example, the old routes setup could easily take 5-10 seconds
depending on the amount of "routes" in a database. Providing vastly
different logic for both MySQL and PostgreSQL will negatively impact the
development process. Because of this the various nested groups related
methods return empty relations when used in combination with MySQL.
For project authorizations the logic is split up into two classes:
* Gitlab::ProjectAuthorizations::WithNestedGroups
* Gitlab::ProjectAuthorizations::WithoutNestedGroups
Both classes get the fresh project authorizations (= as they should be
in the "project_authorizations" table), including nested groups if
PostgreSQL is used. The logic of these two classes is quite different
apart from their public interface. This complicates development a bit,
but unfortunately there is no way around this.
This commit also introduces Gitlab::GroupHierarchy. This class can be
used to get the ancestors and descendants of a base relation, or both by
using a UNION. This in turn is used by methods such as:
* Namespace#ancestors
* Namespace#descendants
* User#all_expanded_groups
Again this class relies on CTEs and thus only works on PostgreSQL. The
Namespace methods will return an empty relation when MySQL is used,
while User#all_expanded_groups will return only the groups a user is a
direct member of.
Performance wise the impact is quite large. For example, on GitLab.com
Namespace#descendants used to take around 580 ms to retrieve data for a
particular user. Using CTEs we are able to reduce this down to roughly 1
millisecond, returning the exact same data.
== On The Fly Refreshing
Refreshing of authorizations on the fly (= when
users.authorized_projects_populated was not set) is removed with this
commit. This simplifies the code, and ensures any queries used for
authorizations are not mutated because they are executed in a Rails
scope (e.g. Project.visible_to_user).
This commit includes a migration to schedule refreshing authorizations
for all users, ensuring all of them have their authorizations in place.
Said migration schedules users in batches of 5000, with 5 minutes
between every batch to smear the load around a bit.
== Spec Changes
This commit also introduces some changes to various specs. For example,
some specs for ProjectTeam assumed that creating a personal project
would _not_ lead to the owner having access, which is incorrect. Because
we also no longer refresh authorizations on the fly for new users some
code had to be added to the "empty_project" factory. This chunk of code
ensures that the owner's permissions are refreshed after creating the
project, something that is normally done in Projects::CreateService.
2017-04-24 15:19:22 +00:00
|
|
|
expect(deep_nested_group.descendants.to_a).to include(very_deep_nested_group)
|
|
|
|
expect(nested_group.descendants.to_a).to include(deep_nested_group, very_deep_nested_group)
|
|
|
|
expect(group.descendants.to_a).to include(nested_group, deep_nested_group, very_deep_nested_group)
|
2016-12-13 18:49:25 +00:00
|
|
|
end
|
2016-12-13 14:59:49 +00:00
|
|
|
end
|
2017-02-07 13:55:42 +00:00
|
|
|
|
2019-07-24 09:20:54 +00:00
|
|
|
describe '#self_and_descendants' do
|
2017-08-11 14:19:11 +00:00
|
|
|
let!(:group) { create(:group, path: 'git_lab') }
|
|
|
|
let!(:nested_group) { create(:group, parent: group) }
|
|
|
|
let!(:deep_nested_group) { create(:group, parent: nested_group) }
|
|
|
|
let!(:very_deep_nested_group) { create(:group, parent: deep_nested_group) }
|
|
|
|
let!(:another_group) { create(:group, path: 'gitllab') }
|
|
|
|
let!(:another_group_nested) { create(:group, path: 'foo', parent: another_group) }
|
|
|
|
|
|
|
|
it 'returns the correct descendants' do
|
|
|
|
expect(very_deep_nested_group.self_and_descendants).to contain_exactly(very_deep_nested_group)
|
|
|
|
expect(deep_nested_group.self_and_descendants).to contain_exactly(deep_nested_group, very_deep_nested_group)
|
|
|
|
expect(nested_group.self_and_descendants).to contain_exactly(nested_group, deep_nested_group, very_deep_nested_group)
|
|
|
|
expect(group.self_and_descendants).to contain_exactly(group, nested_group, deep_nested_group, very_deep_nested_group)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2019-07-24 09:20:54 +00:00
|
|
|
describe '#users_with_descendants' do
|
2017-06-27 20:35:35 +00:00
|
|
|
let(:user_a) { create(:user) }
|
|
|
|
let(:user_b) { create(:user) }
|
|
|
|
|
|
|
|
let(:group) { create(:group) }
|
|
|
|
let(:nested_group) { create(:group, parent: group) }
|
|
|
|
let(:deep_nested_group) { create(:group, parent: nested_group) }
|
|
|
|
|
|
|
|
it 'returns member users on every nest level without duplication' do
|
|
|
|
group.add_developer(user_a)
|
|
|
|
nested_group.add_developer(user_b)
|
2018-12-06 13:15:29 +00:00
|
|
|
deep_nested_group.add_maintainer(user_a)
|
2017-06-27 20:35:35 +00:00
|
|
|
|
|
|
|
expect(group.users_with_descendants).to contain_exactly(user_a, user_b)
|
|
|
|
expect(nested_group.users_with_descendants).to contain_exactly(user_a, user_b)
|
|
|
|
expect(deep_nested_group.users_with_descendants).to contain_exactly(user_a)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2017-02-07 13:55:42 +00:00
|
|
|
describe '#user_ids_for_project_authorizations' do
|
|
|
|
it 'returns the user IDs for which to refresh authorizations' do
|
2017-06-21 13:48:12 +00:00
|
|
|
expect(namespace.user_ids_for_project_authorizations)
|
|
|
|
.to eq([namespace.owner_id])
|
2017-02-07 13:55:42 +00:00
|
|
|
end
|
|
|
|
end
|
2017-04-03 15:48:17 +00:00
|
|
|
|
|
|
|
describe '#all_projects' do
|
|
|
|
let(:group) { create(:group) }
|
|
|
|
let(:child) { create(:group, parent: group) }
|
|
|
|
let!(:project1) { create(:project_empty_repo, namespace: group) }
|
|
|
|
let!(:project2) { create(:project_empty_repo, namespace: child) }
|
|
|
|
|
2017-08-15 10:27:37 +00:00
|
|
|
it { expect(group.all_projects.to_a).to match_array([project2, project1]) }
|
2018-11-23 03:19:53 +00:00
|
|
|
it { expect(child.all_projects.to_a).to match_array([project2]) }
|
2017-04-03 15:48:17 +00:00
|
|
|
end
|
2017-09-01 23:49:09 +00:00
|
|
|
|
2018-11-05 23:56:52 +00:00
|
|
|
describe '#all_pipelines' do
|
|
|
|
let(:group) { create(:group) }
|
|
|
|
let(:child) { create(:group, parent: group) }
|
|
|
|
let!(:project1) { create(:project_empty_repo, namespace: group) }
|
|
|
|
let!(:project2) { create(:project_empty_repo, namespace: child) }
|
|
|
|
let!(:pipeline1) { create(:ci_empty_pipeline, project: project1) }
|
|
|
|
let!(:pipeline2) { create(:ci_empty_pipeline, project: project2) }
|
|
|
|
|
|
|
|
it { expect(group.all_pipelines.to_a).to match_array([pipeline1, pipeline2]) }
|
|
|
|
end
|
|
|
|
|
2019-07-24 09:20:54 +00:00
|
|
|
describe '#share_with_group_lock with subgroups' do
|
2017-09-01 23:49:09 +00:00
|
|
|
context 'when creating a subgroup' do
|
|
|
|
let(:subgroup) { create(:group, parent: root_group )}
|
|
|
|
|
2017-09-06 18:31:45 +00:00
|
|
|
context 'under a parent with "Share with group lock" enabled' do
|
2017-09-01 23:49:09 +00:00
|
|
|
let(:root_group) { create(:group, share_with_group_lock: true) }
|
|
|
|
|
2017-09-06 18:31:45 +00:00
|
|
|
it 'enables "Share with group lock" on the subgroup' do
|
2017-09-01 23:49:09 +00:00
|
|
|
expect(subgroup.share_with_group_lock).to be_truthy
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2017-09-06 18:31:45 +00:00
|
|
|
context 'under a parent with "Share with group lock" disabled' do
|
2017-09-01 23:49:09 +00:00
|
|
|
let(:root_group) { create(:group) }
|
|
|
|
|
2017-09-06 18:31:45 +00:00
|
|
|
it 'does not enable "Share with group lock" on the subgroup' do
|
2017-09-01 23:49:09 +00:00
|
|
|
expect(subgroup.share_with_group_lock).to be_falsey
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2017-09-06 18:31:45 +00:00
|
|
|
context 'when enabling the parent group "Share with group lock"' do
|
2017-09-01 23:49:09 +00:00
|
|
|
let(:root_group) { create(:group) }
|
|
|
|
let!(:subgroup) { create(:group, parent: root_group )}
|
|
|
|
|
2017-09-06 18:31:45 +00:00
|
|
|
it 'the subgroup "Share with group lock" becomes enabled' do
|
2017-09-06 00:10:30 +00:00
|
|
|
root_group.update!(share_with_group_lock: true)
|
2017-09-01 23:49:09 +00:00
|
|
|
|
|
|
|
expect(subgroup.reload.share_with_group_lock).to be_truthy
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2017-09-06 18:31:45 +00:00
|
|
|
context 'when disabling the parent group "Share with group lock" (which was already enabled)' do
|
2017-09-01 23:49:09 +00:00
|
|
|
let(:root_group) { create(:group, share_with_group_lock: true) }
|
|
|
|
|
2017-09-06 18:31:45 +00:00
|
|
|
context 'and the subgroup "Share with group lock" is enabled' do
|
2017-09-01 23:49:09 +00:00
|
|
|
let(:subgroup) { create(:group, parent: root_group, share_with_group_lock: true )}
|
|
|
|
|
2017-09-06 18:31:45 +00:00
|
|
|
it 'the subgroup "Share with group lock" does not change' do
|
2017-09-06 00:10:30 +00:00
|
|
|
root_group.update!(share_with_group_lock: false)
|
2017-09-01 23:49:09 +00:00
|
|
|
|
|
|
|
expect(subgroup.reload.share_with_group_lock).to be_truthy
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2017-09-06 18:31:45 +00:00
|
|
|
context 'but the subgroup "Share with group lock" is disabled' do
|
2017-09-01 23:49:09 +00:00
|
|
|
let(:subgroup) { create(:group, parent: root_group )}
|
|
|
|
|
2017-09-06 18:31:45 +00:00
|
|
|
it 'the subgroup "Share with group lock" does not change' do
|
2017-09-06 00:10:30 +00:00
|
|
|
root_group.update!(share_with_group_lock: false)
|
2017-09-01 23:49:09 +00:00
|
|
|
|
|
|
|
expect(subgroup.reload.share_with_group_lock?).to be_falsey
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when a group is transferred into a root group' do
|
2017-09-06 18:31:45 +00:00
|
|
|
context 'when the root group "Share with group lock" is enabled' do
|
2017-09-01 23:49:09 +00:00
|
|
|
let(:root_group) { create(:group, share_with_group_lock: true) }
|
|
|
|
|
2017-09-06 18:31:45 +00:00
|
|
|
context 'when the subgroup "Share with group lock" is enabled' do
|
2017-09-01 23:49:09 +00:00
|
|
|
let(:subgroup) { create(:group, share_with_group_lock: true )}
|
|
|
|
|
2017-09-06 18:31:45 +00:00
|
|
|
it 'the subgroup "Share with group lock" does not change' do
|
2017-09-01 23:49:09 +00:00
|
|
|
subgroup.parent = root_group
|
|
|
|
subgroup.save!
|
|
|
|
|
|
|
|
expect(subgroup.share_with_group_lock).to be_truthy
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2017-09-06 18:31:45 +00:00
|
|
|
context 'when the subgroup "Share with group lock" is disabled' do
|
2017-09-01 23:49:09 +00:00
|
|
|
let(:subgroup) { create(:group)}
|
|
|
|
|
2017-09-06 18:31:45 +00:00
|
|
|
it 'the subgroup "Share with group lock" becomes enabled' do
|
2017-09-01 23:49:09 +00:00
|
|
|
subgroup.parent = root_group
|
|
|
|
subgroup.save!
|
|
|
|
|
|
|
|
expect(subgroup.share_with_group_lock).to be_truthy
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2017-09-06 18:31:45 +00:00
|
|
|
context 'when the root group "Share with group lock" is disabled' do
|
2017-09-01 23:49:09 +00:00
|
|
|
let(:root_group) { create(:group) }
|
|
|
|
|
2017-09-06 18:31:45 +00:00
|
|
|
context 'when the subgroup "Share with group lock" is enabled' do
|
2017-09-01 23:49:09 +00:00
|
|
|
let(:subgroup) { create(:group, share_with_group_lock: true )}
|
|
|
|
|
2017-09-06 18:31:45 +00:00
|
|
|
it 'the subgroup "Share with group lock" does not change' do
|
2017-09-01 23:49:09 +00:00
|
|
|
subgroup.parent = root_group
|
|
|
|
subgroup.save!
|
|
|
|
|
|
|
|
expect(subgroup.share_with_group_lock).to be_truthy
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2017-09-06 18:31:45 +00:00
|
|
|
context 'when the subgroup "Share with group lock" is disabled' do
|
2017-09-01 23:49:09 +00:00
|
|
|
let(:subgroup) { create(:group)}
|
|
|
|
|
2017-09-06 18:31:45 +00:00
|
|
|
it 'the subgroup "Share with group lock" does not change' do
|
2017-09-01 23:49:09 +00:00
|
|
|
subgroup.parent = root_group
|
|
|
|
subgroup.save!
|
|
|
|
|
|
|
|
expect(subgroup.share_with_group_lock).to be_falsey
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2017-10-03 15:06:09 +00:00
|
|
|
|
2017-11-30 13:26:08 +00:00
|
|
|
describe '#find_fork_of?' do
|
2017-10-03 15:06:09 +00:00
|
|
|
let(:project) { create(:project, :public) }
|
|
|
|
let!(:forked_project) { fork_project(project, namespace.owner, namespace: namespace) }
|
|
|
|
|
|
|
|
before do
|
|
|
|
# Reset the fork network relation
|
|
|
|
project.reload
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'knows if there is a direct fork in the namespace' do
|
|
|
|
expect(namespace.find_fork_of(project)).to eq(forked_project)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'knows when there is as fork-of-fork in the namespace' do
|
|
|
|
other_namespace = create(:namespace)
|
|
|
|
other_fork = fork_project(forked_project, other_namespace.owner, namespace: other_namespace)
|
|
|
|
|
|
|
|
expect(other_namespace.find_fork_of(project)).to eq(other_fork)
|
|
|
|
end
|
2017-11-30 13:26:08 +00:00
|
|
|
|
|
|
|
context 'with request store enabled', :request_store do
|
|
|
|
it 'only queries once' do
|
|
|
|
expect(project.fork_network).to receive(:find_forks_in).once.and_call_original
|
|
|
|
|
|
|
|
2.times { namespace.find_fork_of(project) }
|
|
|
|
end
|
|
|
|
end
|
2017-10-03 15:06:09 +00:00
|
|
|
end
|
2017-12-08 17:42:43 +00:00
|
|
|
|
2018-06-26 09:58:51 +00:00
|
|
|
describe '#root_ancestor' do
|
2019-07-24 09:20:54 +00:00
|
|
|
it 'returns the top most ancestor' do
|
2018-06-26 09:58:51 +00:00
|
|
|
root_group = create(:group)
|
|
|
|
nested_group = create(:group, parent: root_group)
|
|
|
|
deep_nested_group = create(:group, parent: nested_group)
|
|
|
|
very_deep_nested_group = create(:group, parent: deep_nested_group)
|
|
|
|
|
2018-11-29 00:50:19 +00:00
|
|
|
expect(root_group.root_ancestor).to eq(root_group)
|
2018-06-26 09:58:51 +00:00
|
|
|
expect(nested_group.root_ancestor).to eq(root_group)
|
|
|
|
expect(deep_nested_group.root_ancestor).to eq(root_group)
|
|
|
|
expect(very_deep_nested_group.root_ancestor).to eq(root_group)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2019-04-23 09:30:18 +00:00
|
|
|
describe '#full_path_before_last_save' do
|
2018-02-06 00:10:58 +00:00
|
|
|
context 'when the group has no parent' do
|
2019-04-23 09:30:18 +00:00
|
|
|
it 'returns the path before last save' do
|
|
|
|
group = create(:group)
|
|
|
|
|
|
|
|
group.update(parent: nil)
|
|
|
|
|
|
|
|
expect(group.full_path_before_last_save).to eq(group.path_before_last_save)
|
2018-02-06 00:10:58 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when a parent is assigned to a group with no previous parent' do
|
2019-04-23 09:30:18 +00:00
|
|
|
it 'returns the path before last save' do
|
2018-02-06 00:10:58 +00:00
|
|
|
group = create(:group, parent: nil)
|
|
|
|
parent = create(:group)
|
|
|
|
|
2019-04-23 09:30:18 +00:00
|
|
|
group.update(parent: parent)
|
|
|
|
|
|
|
|
expect(group.full_path_before_last_save).to eq("#{group.path_before_last_save}")
|
2018-02-06 00:10:58 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when a parent is removed from the group' do
|
2019-04-05 08:43:27 +00:00
|
|
|
it 'returns the parent full path' do
|
2018-02-06 00:10:58 +00:00
|
|
|
parent = create(:group)
|
|
|
|
group = create(:group, parent: parent)
|
|
|
|
|
2019-04-23 09:30:18 +00:00
|
|
|
group.update(parent: nil)
|
|
|
|
|
|
|
|
expect(group.full_path_before_last_save).to eq("#{parent.full_path}/#{group.path}")
|
2018-02-06 00:10:58 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when changing parents' do
|
2019-04-05 08:43:27 +00:00
|
|
|
it 'returns the previous parent full path' do
|
2018-02-06 00:10:58 +00:00
|
|
|
parent = create(:group)
|
|
|
|
group = create(:group, parent: parent)
|
|
|
|
new_parent = create(:group)
|
2019-04-23 09:30:18 +00:00
|
|
|
|
|
|
|
group.update(parent: new_parent)
|
|
|
|
|
|
|
|
expect(group.full_path_before_last_save).to eq("#{parent.full_path}/#{group.path}")
|
2018-02-06 00:10:58 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2019-03-12 10:15:33 +00:00
|
|
|
|
|
|
|
describe '#auto_devops_enabled' do
|
|
|
|
context 'with users' do
|
|
|
|
let(:user) { create(:user) }
|
|
|
|
|
|
|
|
subject { user.namespace.auto_devops_enabled? }
|
|
|
|
|
|
|
|
before do
|
|
|
|
user.namespace.update!(auto_devops_enabled: auto_devops_enabled)
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when auto devops is explicitly enabled' do
|
|
|
|
let(:auto_devops_enabled) { true }
|
|
|
|
|
|
|
|
it { is_expected.to eq(true) }
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when auto devops is explicitly disabled' do
|
|
|
|
let(:auto_devops_enabled) { false }
|
|
|
|
|
|
|
|
it { is_expected.to eq(false) }
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2019-04-16 16:16:52 +00:00
|
|
|
|
|
|
|
describe '#user?' do
|
|
|
|
subject { namespace.user? }
|
|
|
|
|
|
|
|
context 'when type is a user' do
|
|
|
|
let(:user) { create(:user) }
|
|
|
|
let(:namespace) { user.namespace }
|
|
|
|
|
|
|
|
it { is_expected.to be_truthy }
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when type is a group' do
|
|
|
|
let(:namespace) { create(:group) }
|
|
|
|
|
|
|
|
it { is_expected.to be_falsy }
|
|
|
|
end
|
|
|
|
end
|
2019-07-02 14:44:39 +00:00
|
|
|
|
|
|
|
describe '#aggregation_scheduled?' do
|
|
|
|
let(:namespace) { create(:namespace) }
|
|
|
|
|
|
|
|
subject { namespace.aggregation_scheduled? }
|
|
|
|
|
|
|
|
context 'with an aggregation scheduled association' do
|
|
|
|
let(:namespace) { create(:namespace, :with_aggregation_schedule) }
|
|
|
|
|
|
|
|
it { is_expected.to be_truthy }
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'without an aggregation scheduled association' do
|
|
|
|
it { is_expected.to be_falsy }
|
|
|
|
end
|
|
|
|
end
|
2019-08-15 17:37:36 +00:00
|
|
|
|
|
|
|
describe '#emails_disabled?' do
|
|
|
|
context 'when not a subgroup' do
|
|
|
|
it 'returns false' do
|
|
|
|
group = create(:group, emails_disabled: false)
|
|
|
|
|
|
|
|
expect(group.emails_disabled?).to be_falsey
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns true' do
|
|
|
|
group = create(:group, emails_disabled: true)
|
|
|
|
|
|
|
|
expect(group.emails_disabled?).to be_truthy
|
|
|
|
end
|
2020-01-16 21:08:24 +00:00
|
|
|
|
|
|
|
it 'does not query the db when there is no parent group' do
|
|
|
|
group = create(:group, emails_disabled: true)
|
|
|
|
|
|
|
|
expect { group.emails_disabled? }.not_to exceed_query_limit(0)
|
|
|
|
end
|
2019-08-15 17:37:36 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
context 'when a subgroup' do
|
|
|
|
let(:grandparent) { create(:group) }
|
|
|
|
let(:parent) { create(:group, parent: grandparent) }
|
|
|
|
let(:group) { create(:group, parent: parent) }
|
|
|
|
|
|
|
|
it 'returns false' do
|
|
|
|
expect(group.emails_disabled?).to be_falsey
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when ancestor emails are disabled' do
|
|
|
|
it 'returns true' do
|
|
|
|
grandparent.update_attribute(:emails_disabled, true)
|
|
|
|
|
|
|
|
expect(group.emails_disabled?).to be_truthy
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2019-09-25 09:06:04 +00:00
|
|
|
|
|
|
|
describe '#pages_virtual_domain' do
|
|
|
|
let(:project) { create(:project, namespace: namespace) }
|
|
|
|
|
|
|
|
context 'when there are pages deployed for the project' do
|
2019-10-01 12:05:59 +00:00
|
|
|
context 'but pages metadata is not migrated' do
|
|
|
|
before do
|
|
|
|
generic_commit_status = create(:generic_commit_status, :success, stage: 'deploy', name: 'pages:deploy')
|
|
|
|
generic_commit_status.update!(project: project)
|
|
|
|
project.pages_metadatum.destroy!
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'migrates pages metadata and returns the virual domain' do
|
|
|
|
virtual_domain = namespace.pages_virtual_domain
|
|
|
|
|
|
|
|
expect(project.reload.pages_metadatum.deployed).to eq(true)
|
|
|
|
|
|
|
|
expect(virtual_domain).to be_an_instance_of(Pages::VirtualDomain)
|
|
|
|
expect(virtual_domain.lookup_paths).not_to be_empty
|
|
|
|
end
|
2019-09-25 09:06:04 +00:00
|
|
|
end
|
|
|
|
|
2019-10-01 12:05:59 +00:00
|
|
|
context 'and pages metadata is migrated' do
|
|
|
|
before do
|
|
|
|
project.mark_pages_as_deployed
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns the virual domain' do
|
|
|
|
virtual_domain = namespace.pages_virtual_domain
|
|
|
|
|
|
|
|
expect(virtual_domain).to be_an_instance_of(Pages::VirtualDomain)
|
|
|
|
expect(virtual_domain.lookup_paths).not_to be_empty
|
|
|
|
end
|
2019-09-25 09:06:04 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2019-10-07 15:05:59 +00:00
|
|
|
|
|
|
|
describe '#has_parent?' do
|
|
|
|
it 'returns true when the group has a parent' do
|
|
|
|
group = create(:group, :nested)
|
|
|
|
|
|
|
|
expect(group.has_parent?).to be_truthy
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns true when the group has an unsaved parent' do
|
|
|
|
parent = build(:group)
|
|
|
|
group = build(:group, parent: parent)
|
|
|
|
|
|
|
|
expect(group.has_parent?).to be_truthy
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns false when the group has no parent' do
|
|
|
|
group = create(:group, parent: nil)
|
|
|
|
|
|
|
|
expect(group.has_parent?).to be_falsy
|
|
|
|
end
|
|
|
|
end
|
2019-10-08 12:06:01 +00:00
|
|
|
|
|
|
|
describe '#closest_setting' do
|
|
|
|
using RSpec::Parameterized::TableSyntax
|
|
|
|
|
|
|
|
shared_examples_for 'fetching closest setting' do
|
|
|
|
let!(:root_namespace) { create(:namespace) }
|
|
|
|
let!(:namespace) { create(:namespace, parent: root_namespace) }
|
|
|
|
|
|
|
|
let(:setting) { namespace.closest_setting(setting_name) }
|
|
|
|
|
|
|
|
before do
|
|
|
|
root_namespace.update_attribute(setting_name, root_setting)
|
|
|
|
namespace.update_attribute(setting_name, child_setting)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns closest non-nil value' do
|
|
|
|
expect(setting).to eq(result)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when setting is of non-boolean type' do
|
|
|
|
where(:root_setting, :child_setting, :result) do
|
|
|
|
100 | 200 | 200
|
|
|
|
100 | nil | 100
|
|
|
|
nil | nil | nil
|
|
|
|
end
|
|
|
|
|
|
|
|
with_them do
|
|
|
|
let(:setting_name) { :max_artifacts_size }
|
|
|
|
|
|
|
|
it_behaves_like 'fetching closest setting'
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when setting is of boolean type' do
|
|
|
|
where(:root_setting, :child_setting, :result) do
|
|
|
|
true | false | false
|
|
|
|
true | nil | true
|
|
|
|
nil | nil | nil
|
|
|
|
end
|
|
|
|
|
|
|
|
with_them do
|
|
|
|
let(:setting_name) { :lfs_enabled }
|
|
|
|
|
|
|
|
it_behaves_like 'fetching closest setting'
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2012-11-22 19:41:16 +00:00
|
|
|
end
|