gitlab-org--gitlab-foss/spec/bin/storage_check_spec.rb

require 'spec_helper'

describe 'bin/storage_check' do
  it 'is executable' do
    command = %w[bin/storage_check -t unix://the/path/to/a/unix-socket.sock -i 10 -d]
    expected_output = 'Checking unix://the/path/to/a/unix-socket.sock every 10 seconds'

    output, status = Gitlab::Popen.popen(command, Rails.root.to_s)

    expect(status).to eq(0)
    expect(output).to include(expected_output)
  end
end
Move the circuitbreaker check out in a separate process Moving the check out of the general requests, makes sure we don't have any slowdown in the regular requests. To keep the process performing this checks small, the check is still performed inside a unicorn. But that is called from a process running on the same server. Because the checks are now done outside normal request, we can have a simpler failure strategy: The check is now performed in the background every `circuitbreaker_check_interval`. Failures are logged in redis. The failures are reset when the check succeeds. Per check we will try `circuitbreaker_access_retries` times within `circuitbreaker_storage_timeout` seconds. When the number of failures exceeds `circuitbreaker_failure_count_threshold`, we will block access to the storage. After `failure_reset_time` of no checks, we will clear the stored failures. This could happen when the process that performs the checks is not running. 2017-11-13 15:52:07 +00:00			`require 'spec_helper'`

			`describe 'bin/storage_check' do`
			`it 'is executable' do`
			`command = %w[bin/storage_check -t unix://the/path/to/a/unix-socket.sock -i 10 -d]`
			`expected_output = 'Checking unix://the/path/to/a/unix-socket.sock every 10 seconds'`

			`output, status = Gitlab::Popen.popen(command, Rails.root.to_s)`

			`expect(status).to eq(0)`
			`expect(output).to include(expected_output)`
			`end`
			`end`