2015-01-28 21:18:22 +00:00
|
|
|
require 'spec_helper'
|
|
|
|
|
|
|
|
describe UsersController do
|
2015-07-18 21:54:56 +00:00
|
|
|
let(:user) { create(:user) }
|
2018-07-24 12:46:19 +00:00
|
|
|
let(:private_user) { create(:user, private_profile: true) }
|
|
|
|
let(:public_user) { create(:user) }
|
2015-01-28 21:18:22 +00:00
|
|
|
|
2015-03-13 10:39:26 +00:00
|
|
|
describe 'GET #show' do
|
2015-07-18 21:54:56 +00:00
|
|
|
context 'with rendered views' do
|
|
|
|
render_views
|
|
|
|
|
2015-11-18 11:32:35 +00:00
|
|
|
describe 'when logged in' do
|
|
|
|
before do
|
|
|
|
sign_in(user)
|
|
|
|
end
|
2015-07-18 21:54:56 +00:00
|
|
|
|
2015-11-18 11:32:35 +00:00
|
|
|
it 'renders the show template' do
|
|
|
|
get :show, username: user.username
|
2015-07-18 21:54:56 +00:00
|
|
|
|
2015-11-18 11:32:35 +00:00
|
|
|
expect(response).to be_success
|
|
|
|
expect(response).to render_template('show')
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'when logged out' do
|
|
|
|
it 'renders the show template' do
|
|
|
|
get :show, username: user.username
|
|
|
|
|
2017-10-19 18:28:19 +00:00
|
|
|
expect(response).to have_gitlab_http_status(200)
|
2015-11-18 11:32:35 +00:00
|
|
|
expect(response).to render_template('show')
|
|
|
|
end
|
2015-07-18 21:54:56 +00:00
|
|
|
end
|
2015-01-28 21:18:22 +00:00
|
|
|
end
|
2016-03-30 20:14:21 +00:00
|
|
|
|
2016-04-05 21:56:07 +00:00
|
|
|
context 'when public visibility level is restricted' do
|
2016-03-30 20:14:21 +00:00
|
|
|
before do
|
|
|
|
stub_application_setting(restricted_visibility_levels: [Gitlab::VisibilityLevel::PUBLIC])
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when logged out' do
|
2017-05-04 21:20:13 +00:00
|
|
|
it 'redirects to login page' do
|
2016-03-30 20:14:21 +00:00
|
|
|
get :show, username: user.username
|
2017-05-04 21:20:13 +00:00
|
|
|
expect(response).to redirect_to new_user_session_path
|
2016-03-30 20:14:21 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when logged in' do
|
2017-06-14 18:18:56 +00:00
|
|
|
before do
|
|
|
|
sign_in(user)
|
|
|
|
end
|
2016-03-30 20:14:21 +00:00
|
|
|
|
2016-03-31 14:36:40 +00:00
|
|
|
it 'renders show' do
|
2016-03-30 20:14:21 +00:00
|
|
|
get :show, username: user.username
|
2017-10-19 18:28:19 +00:00
|
|
|
expect(response).to have_gitlab_http_status(200)
|
2016-03-31 14:36:40 +00:00
|
|
|
expect(response).to render_template('show')
|
2016-03-30 20:14:21 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2017-05-01 20:46:30 +00:00
|
|
|
|
2017-05-03 22:26:44 +00:00
|
|
|
context 'when a user by that username does not exist' do
|
|
|
|
context 'when logged out' do
|
2017-05-04 21:20:13 +00:00
|
|
|
it 'redirects to login page' do
|
2017-05-03 22:26:44 +00:00
|
|
|
get :show, username: 'nonexistent'
|
2017-05-04 21:20:13 +00:00
|
|
|
expect(response).to redirect_to new_user_session_path
|
2017-05-03 22:26:44 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when logged in' do
|
2017-06-14 18:18:56 +00:00
|
|
|
before do
|
|
|
|
sign_in(user)
|
|
|
|
end
|
2017-05-03 22:26:44 +00:00
|
|
|
|
|
|
|
it 'renders 404' do
|
|
|
|
get :show, username: 'nonexistent'
|
2017-10-19 18:28:19 +00:00
|
|
|
expect(response).to have_gitlab_http_status(404)
|
2017-05-03 22:26:44 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2017-12-11 14:21:06 +00:00
|
|
|
|
|
|
|
context 'json with events' do
|
|
|
|
let(:project) { create(:project) }
|
|
|
|
before do
|
|
|
|
project.add_developer(user)
|
|
|
|
Gitlab::DataBuilder::Push.build_sample(project, user)
|
|
|
|
|
|
|
|
sign_in(user)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'loads events' do
|
|
|
|
get :show, username: user, format: :json
|
|
|
|
|
|
|
|
expect(assigns(:events)).not_to be_empty
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'hides events if the user cannot read cross project' do
|
|
|
|
allow(Ability).to receive(:allowed?).and_call_original
|
|
|
|
expect(Ability).to receive(:allowed?).with(user, :read_cross_project) { false }
|
|
|
|
|
|
|
|
get :show, username: user, format: :json
|
|
|
|
|
|
|
|
expect(assigns(:events)).to be_empty
|
|
|
|
end
|
2018-07-24 12:46:19 +00:00
|
|
|
|
|
|
|
it 'hides events if the user has a private profile' do
|
|
|
|
Gitlab::DataBuilder::Push.build_sample(project, private_user)
|
|
|
|
|
|
|
|
get :show, username: private_user.username, format: :json
|
|
|
|
|
|
|
|
expect(assigns(:events)).to be_empty
|
|
|
|
end
|
2017-12-11 14:21:06 +00:00
|
|
|
end
|
2015-01-29 16:55:57 +00:00
|
|
|
end
|
2015-01-28 21:18:22 +00:00
|
|
|
|
2015-03-13 10:39:26 +00:00
|
|
|
describe 'GET #calendar' do
|
2018-07-24 12:46:19 +00:00
|
|
|
context 'for user' do
|
|
|
|
let(:project) { create(:project) }
|
|
|
|
|
|
|
|
before do
|
|
|
|
sign_in(user)
|
|
|
|
project.add_developer(user)
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'with public profile' do
|
|
|
|
it 'renders calendar' do
|
|
|
|
push_data = Gitlab::DataBuilder::Push.build_sample(project, public_user)
|
|
|
|
EventCreateService.new.push(project, public_user, push_data)
|
|
|
|
|
|
|
|
get :calendar, username: public_user.username, format: :json
|
2015-07-18 21:54:56 +00:00
|
|
|
|
2018-07-24 12:46:19 +00:00
|
|
|
expect(response).to have_gitlab_http_status(200)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'with private profile' do
|
|
|
|
it 'does not render calendar' do
|
|
|
|
push_data = Gitlab::DataBuilder::Push.build_sample(project, private_user)
|
|
|
|
EventCreateService.new.push(project, private_user, push_data)
|
2015-07-18 21:54:56 +00:00
|
|
|
|
2018-07-24 12:46:19 +00:00
|
|
|
get :calendar, username: private_user.username, format: :json
|
|
|
|
|
|
|
|
expect(response).to have_gitlab_http_status(:not_found)
|
|
|
|
end
|
|
|
|
end
|
2015-01-28 21:18:22 +00:00
|
|
|
end
|
2016-02-22 14:46:29 +00:00
|
|
|
|
|
|
|
context 'forked project' do
|
2017-08-02 19:55:11 +00:00
|
|
|
let(:project) { create(:project) }
|
2016-09-19 18:28:41 +00:00
|
|
|
let(:forked_project) { Projects::ForkService.new(project, user).execute }
|
2016-02-22 14:46:29 +00:00
|
|
|
|
|
|
|
before do
|
|
|
|
sign_in(user)
|
2017-12-22 08:18:28 +00:00
|
|
|
project.add_developer(user)
|
Migrate events into a new format
This commit migrates events data in such a way that push events are
stored much more efficiently. This is done by creating a shadow table
called "events_for_migration", and a table called "push_event_payloads"
which is used for storing push data of push events. The background
migration in this commit will copy events from the "events" table into
the "events_for_migration" table, push events in will also have a row
created in "push_event_payloads".
This approach allows us to reclaim space in the next release by simply
swapping the "events" and "events_for_migration" tables, then dropping
the old events (now "events_for_migration") table.
The new table structure is also optimised for storage space, and does
not include the unused "title" column nor the "data" column (since this
data is moved to "push_event_payloads").
== Newly Created Events
Newly created events are inserted into both "events" and
"events_for_migration", both using the exact same primary key value. The
table "push_event_payloads" in turn has a foreign key to the _shadow_
table. This removes the need for recreating and validating the foreign
key after swapping the tables. Since the shadow table also has a foreign
key to "projects.id" we also don't have to worry about orphaned rows.
This approach however does require some additional storage as we're
duplicating a portion of the events data for at least 1 release. The
exact amount is hard to estimate, but for GitLab.com this is expected to
be between 10 and 20 GB at most. The background migration in this commit
deliberately does _not_ update the "events" table as doing so would put
a lot of pressure on PostgreSQL's auto vacuuming system.
== Supporting Both Old And New Events
Application code has also been adjusted to support push events using
both the old and new data formats. This is done by creating a PushEvent
class which extends the regular Event class. Using Rails' Single Table
Inheritance system we can ensure the right class is used for the right
data, which in this case is based on the value of `events.action`. To
support displaying old and new data at the same time the PushEvent class
re-defines a few methods of the Event class, falling back to their
original implementations for push events in the old format.
Once all existing events have been migrated the various push event
related methods can be removed from the Event model, and the calls to
`super` can be removed from the methods in the PushEvent model.
The UI and event atom feed have also been slightly changed to better
handle this new setup, fortunately only a few changes were necessary to
make this work.
== API Changes
The API only displays push data of events in the new format. Supporting
both formats in the API is a bit more difficult compared to the UI.
Since the old push data was not really well documented (apart from one
example that used an incorrect "action" nmae) I decided that supporting
both was not worth the effort, especially since events will be migrated
in a few days _and_ new events are created in the correct format.
2017-07-10 15:43:57 +00:00
|
|
|
|
|
|
|
push_data = Gitlab::DataBuilder::Push.build_sample(project, user)
|
|
|
|
|
|
|
|
fork_push_data = Gitlab::DataBuilder::Push
|
|
|
|
.build_sample(forked_project, user)
|
|
|
|
|
|
|
|
EventCreateService.new.push(project, user, push_data)
|
|
|
|
EventCreateService.new.push(forked_project, user, fork_push_data)
|
2016-02-22 14:46:29 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
it 'includes forked projects' do
|
|
|
|
get :calendar, username: user.username
|
|
|
|
expect(assigns(:contributions_calendar).projects.count).to eq(2)
|
|
|
|
end
|
|
|
|
end
|
2015-01-28 21:18:22 +00:00
|
|
|
end
|
|
|
|
|
2015-03-13 10:39:26 +00:00
|
|
|
describe 'GET #calendar_activities' do
|
2017-08-02 19:55:11 +00:00
|
|
|
let!(:project) { create(:project) }
|
2017-05-01 20:46:30 +00:00
|
|
|
let(:user) { create(:user) }
|
2015-03-13 10:39:26 +00:00
|
|
|
|
|
|
|
before do
|
|
|
|
allow_any_instance_of(User).to receive(:contributed_projects_ids).and_return([project.id])
|
2015-07-18 21:54:56 +00:00
|
|
|
|
|
|
|
sign_in(user)
|
2017-12-22 08:18:28 +00:00
|
|
|
project.add_developer(user)
|
2015-03-13 10:39:26 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
it 'assigns @calendar_date' do
|
2015-03-22 18:14:42 +00:00
|
|
|
get :calendar_activities, username: user.username, date: '2014-07-31'
|
2015-03-13 10:39:26 +00:00
|
|
|
expect(assigns(:calendar_date)).to eq(Date.parse('2014-07-31'))
|
|
|
|
end
|
|
|
|
|
2018-07-24 12:46:19 +00:00
|
|
|
context 'for user' do
|
|
|
|
context 'with public profile' do
|
|
|
|
it 'renders calendar_activities' do
|
|
|
|
push_data = Gitlab::DataBuilder::Push.build_sample(project, public_user)
|
|
|
|
EventCreateService.new.push(project, public_user, push_data)
|
|
|
|
|
|
|
|
get :calendar_activities, username: public_user.username
|
|
|
|
expect(assigns[:events]).not_to be_empty
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'with private profile' do
|
|
|
|
it 'does not render calendar_activities' do
|
|
|
|
push_data = Gitlab::DataBuilder::Push.build_sample(project, private_user)
|
|
|
|
EventCreateService.new.push(project, private_user, push_data)
|
|
|
|
|
|
|
|
get :calendar_activities, username: private_user.username
|
|
|
|
expect(response).to have_gitlab_http_status(:not_found)
|
|
|
|
end
|
|
|
|
end
|
2015-03-13 10:39:26 +00:00
|
|
|
end
|
|
|
|
end
|
2016-05-08 15:06:19 +00:00
|
|
|
|
|
|
|
describe 'GET #snippets' do
|
|
|
|
before do
|
|
|
|
sign_in(user)
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'format html' do
|
|
|
|
it 'renders snippets page' do
|
|
|
|
get :snippets, username: user.username
|
2017-10-19 18:28:19 +00:00
|
|
|
expect(response).to have_gitlab_http_status(200)
|
2016-05-08 15:06:19 +00:00
|
|
|
expect(response).to render_template('show')
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'format json' do
|
|
|
|
it 'response with snippets json data' do
|
|
|
|
get :snippets, username: user.username, format: :json
|
2017-10-19 18:28:19 +00:00
|
|
|
expect(response).to have_gitlab_http_status(200)
|
2016-05-08 15:06:19 +00:00
|
|
|
expect(JSON.parse(response.body)).to have_key('html')
|
|
|
|
end
|
|
|
|
end
|
2017-05-01 20:46:30 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
describe 'GET #exists' do
|
|
|
|
before do
|
|
|
|
sign_in(user)
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when user exists' do
|
|
|
|
it 'returns JSON indicating the user exists' do
|
|
|
|
get :exists, username: user.username
|
|
|
|
|
|
|
|
expected_json = { exists: true }.to_json
|
|
|
|
expect(response.body).to eq(expected_json)
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when the casing is different' do
|
|
|
|
let(:user) { create(:user, username: 'CamelCaseUser') }
|
|
|
|
|
|
|
|
it 'returns JSON indicating the user exists' do
|
|
|
|
get :exists, username: user.username.downcase
|
|
|
|
|
|
|
|
expected_json = { exists: true }.to_json
|
|
|
|
expect(response.body).to eq(expected_json)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when the user does not exist' do
|
|
|
|
it 'returns JSON indicating the user does not exist' do
|
|
|
|
get :exists, username: 'foo'
|
|
|
|
|
|
|
|
expected_json = { exists: false }.to_json
|
|
|
|
expect(response.body).to eq(expected_json)
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when a user changed their username' do
|
|
|
|
let(:redirect_route) { user.namespace.redirect_routes.create(path: 'old-username') }
|
|
|
|
|
|
|
|
it 'returns JSON indicating a user by that username does not exist' do
|
|
|
|
get :exists, username: 'old-username'
|
|
|
|
|
|
|
|
expected_json = { exists: false }.to_json
|
|
|
|
expect(response.body).to eq(expected_json)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2016-05-08 15:06:19 +00:00
|
|
|
end
|
2017-05-11 20:57:03 +00:00
|
|
|
|
2017-05-18 19:56:39 +00:00
|
|
|
describe '#ensure_canonical_path' do
|
|
|
|
before do
|
|
|
|
sign_in(user)
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'for a GET request' do
|
|
|
|
context 'when requesting users at the root path' do
|
|
|
|
context 'when requesting the canonical path' do
|
|
|
|
let(:user) { create(:user, username: 'CamelCaseUser') }
|
|
|
|
|
|
|
|
context 'with exactly matching casing' do
|
|
|
|
it 'responds with success' do
|
|
|
|
get :show, username: user.username
|
|
|
|
|
|
|
|
expect(response).to be_success
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'with different casing' do
|
|
|
|
it 'redirects to the correct casing' do
|
|
|
|
get :show, username: user.username.downcase
|
|
|
|
|
|
|
|
expect(response).to redirect_to(user)
|
|
|
|
expect(controller).not_to set_flash[:notice]
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when requesting a redirected path' do
|
|
|
|
let(:redirect_route) { user.namespace.redirect_routes.create(path: 'old-path') }
|
|
|
|
|
|
|
|
it 'redirects to the canonical path' do
|
|
|
|
get :show, username: redirect_route.path
|
|
|
|
|
|
|
|
expect(response).to redirect_to(user)
|
|
|
|
expect(controller).to set_flash[:notice].to(user_moved_message(redirect_route, user))
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when the old path is a substring of the scheme or host' do
|
|
|
|
let(:redirect_route) { user.namespace.redirect_routes.create(path: 'http') }
|
|
|
|
|
|
|
|
it 'does not modify the requested host' do
|
|
|
|
get :show, username: redirect_route.path
|
|
|
|
|
|
|
|
expect(response).to redirect_to(user)
|
|
|
|
expect(controller).to set_flash[:notice].to(user_moved_message(redirect_route, user))
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when the old path is substring of users' do
|
|
|
|
let(:redirect_route) { user.namespace.redirect_routes.create(path: 'ser') }
|
|
|
|
|
|
|
|
it 'redirects to the canonical path' do
|
|
|
|
get :show, username: redirect_route.path
|
|
|
|
|
|
|
|
expect(response).to redirect_to(user)
|
|
|
|
expect(controller).to set_flash[:notice].to(user_moved_message(redirect_route, user))
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when requesting users under the /users path' do
|
|
|
|
context 'when requesting the canonical path' do
|
|
|
|
let(:user) { create(:user, username: 'CamelCaseUser') }
|
|
|
|
|
|
|
|
context 'with exactly matching casing' do
|
|
|
|
it 'responds with success' do
|
|
|
|
get :projects, username: user.username
|
|
|
|
|
|
|
|
expect(response).to be_success
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'with different casing' do
|
|
|
|
it 'redirects to the correct casing' do
|
|
|
|
get :projects, username: user.username.downcase
|
|
|
|
|
|
|
|
expect(response).to redirect_to(user_projects_path(user))
|
|
|
|
expect(controller).not_to set_flash[:notice]
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when requesting a redirected path' do
|
|
|
|
let(:redirect_route) { user.namespace.redirect_routes.create(path: 'old-path') }
|
|
|
|
|
|
|
|
it 'redirects to the canonical path' do
|
|
|
|
get :projects, username: redirect_route.path
|
|
|
|
|
|
|
|
expect(response).to redirect_to(user_projects_path(user))
|
|
|
|
expect(controller).to set_flash[:notice].to(user_moved_message(redirect_route, user))
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when the old path is a substring of the scheme or host' do
|
|
|
|
let(:redirect_route) { user.namespace.redirect_routes.create(path: 'http') }
|
|
|
|
|
|
|
|
it 'does not modify the requested host' do
|
|
|
|
get :projects, username: redirect_route.path
|
|
|
|
|
|
|
|
expect(response).to redirect_to(user_projects_path(user))
|
|
|
|
expect(controller).to set_flash[:notice].to(user_moved_message(redirect_route, user))
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when the old path is substring of users' do
|
|
|
|
let(:redirect_route) { user.namespace.redirect_routes.create(path: 'ser') }
|
|
|
|
|
|
|
|
# I.e. /users/ser should not become /ufoos/ser
|
|
|
|
it 'does not modify the /users part of the path' do
|
|
|
|
get :projects, username: redirect_route.path
|
|
|
|
|
|
|
|
expect(response).to redirect_to(user_projects_path(user))
|
|
|
|
expect(controller).to set_flash[:notice].to(user_moved_message(redirect_route, user))
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2017-05-11 20:57:03 +00:00
|
|
|
def user_moved_message(redirect_route, user)
|
|
|
|
"User '#{redirect_route.path}' was moved to '#{user.full_path}'. Please update any links and bookmarks that may still have the old path."
|
|
|
|
end
|
2015-03-13 10:39:26 +00:00
|
|
|
end
|