2019-10-16 05:07:51 -04:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2016-07-07 12:19:21 -04:00
|
|
|
require 'spec_helper'
|
|
|
|
|
2020-06-16 14:09:01 -04:00
|
|
|
RSpec.describe BranchesFinder do
|
2016-07-07 12:19:21 -04:00
|
|
|
let(:user) { create(:user) }
|
2017-01-25 16:49:52 -05:00
|
|
|
let(:project) { create(:project, :repository) }
|
2016-07-07 12:19:21 -04:00
|
|
|
let(:repository) { project.repository }
|
|
|
|
|
2020-07-17 05:09:43 -04:00
|
|
|
let(:branch_finder) { described_class.new(repository, params) }
|
|
|
|
let(:params) { {} }
|
|
|
|
|
2016-07-07 12:19:21 -04:00
|
|
|
describe '#execute' do
|
2020-07-17 05:09:43 -04:00
|
|
|
subject { branch_finder.execute }
|
|
|
|
|
2016-07-07 12:19:21 -04:00
|
|
|
context 'sort only' do
|
2020-07-17 05:09:43 -04:00
|
|
|
context 'by name' do
|
|
|
|
let(:params) { {} }
|
2016-07-07 12:19:21 -04:00
|
|
|
|
2020-07-17 05:09:43 -04:00
|
|
|
it 'sorts' do
|
|
|
|
result = subject
|
2016-07-07 12:19:21 -04:00
|
|
|
|
2020-07-17 05:09:43 -04:00
|
|
|
expect(result.first.name).to eq("'test'")
|
|
|
|
end
|
2016-07-07 12:19:21 -04:00
|
|
|
end
|
|
|
|
|
2020-07-17 05:09:43 -04:00
|
|
|
context 'by recently_updated' do
|
|
|
|
let(:params) { { sort: 'updated_desc' } }
|
2016-07-12 14:00:43 -04:00
|
|
|
|
2020-07-17 05:09:43 -04:00
|
|
|
it 'sorts' do
|
|
|
|
result = subject
|
2016-07-07 12:19:21 -04:00
|
|
|
|
2020-07-17 05:09:43 -04:00
|
|
|
recently_updated_branch = repository.branches.max do |a, b|
|
|
|
|
repository.commit(a.dereferenced_target).committed_date <=> repository.commit(b.dereferenced_target).committed_date
|
|
|
|
end
|
2016-07-30 22:09:19 -04:00
|
|
|
|
2020-07-17 05:09:43 -04:00
|
|
|
expect(result.first.name).to eq(recently_updated_branch.name)
|
|
|
|
end
|
2016-07-07 12:19:21 -04:00
|
|
|
end
|
|
|
|
|
2020-07-17 05:09:43 -04:00
|
|
|
context 'by last_updated' do
|
|
|
|
let(:params) { { sort: 'updated_asc' } }
|
2016-07-07 12:19:21 -04:00
|
|
|
|
2020-07-17 05:09:43 -04:00
|
|
|
it 'sorts' do
|
|
|
|
result = subject
|
2016-07-07 12:19:21 -04:00
|
|
|
|
2020-07-17 05:09:43 -04:00
|
|
|
expect(result.first.name).to eq('feature')
|
|
|
|
end
|
2016-07-07 12:19:21 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'filter only' do
|
2020-07-17 05:09:43 -04:00
|
|
|
context 'by name' do
|
|
|
|
let(:params) { { search: 'fix' } }
|
2016-07-07 12:19:21 -04:00
|
|
|
|
2020-07-17 05:09:43 -04:00
|
|
|
it 'filters branches' do
|
|
|
|
result = subject
|
2016-07-07 12:19:21 -04:00
|
|
|
|
2020-07-17 05:09:43 -04:00
|
|
|
expect(result.first.name).to eq('fix')
|
|
|
|
expect(result.count).to eq(1)
|
|
|
|
end
|
2017-10-22 10:50:58 -04:00
|
|
|
end
|
|
|
|
|
2020-07-17 05:09:43 -04:00
|
|
|
context 'by name ignoring letter case' do
|
|
|
|
let(:params) { { search: 'FiX' } }
|
2017-10-22 10:50:58 -04:00
|
|
|
|
2020-07-17 05:09:43 -04:00
|
|
|
it 'filters branches' do
|
|
|
|
result = subject
|
2017-10-22 10:50:58 -04:00
|
|
|
|
2020-07-17 05:09:43 -04:00
|
|
|
expect(result.first.name).to eq('fix')
|
|
|
|
expect(result.count).to eq(1)
|
|
|
|
end
|
2016-07-07 12:19:21 -04:00
|
|
|
end
|
|
|
|
|
2020-07-17 05:09:43 -04:00
|
|
|
context 'with an unknown name' do
|
|
|
|
let(:params) { { search: 'random' } }
|
2016-07-07 12:19:21 -04:00
|
|
|
|
2020-07-17 05:09:43 -04:00
|
|
|
it 'does not find any branch' do
|
|
|
|
result = subject
|
2016-07-07 12:19:21 -04:00
|
|
|
|
2020-07-17 05:09:43 -04:00
|
|
|
expect(result.count).to eq(0)
|
|
|
|
end
|
2016-07-07 12:19:21 -04:00
|
|
|
end
|
2019-06-18 10:20:11 -04:00
|
|
|
|
2020-07-17 05:09:43 -04:00
|
|
|
context 'by provided names' do
|
|
|
|
let(:params) { { names: %w[fix csv lfs does-not-exist] } }
|
2019-06-18 10:20:11 -04:00
|
|
|
|
2020-07-17 05:09:43 -04:00
|
|
|
it 'filters branches' do
|
|
|
|
result = subject
|
2019-06-18 10:20:11 -04:00
|
|
|
|
2020-07-17 05:09:43 -04:00
|
|
|
expect(result.count).to eq(3)
|
|
|
|
expect(result.map(&:name)).to eq(%w{csv fix lfs})
|
|
|
|
end
|
2019-06-18 10:20:11 -04:00
|
|
|
end
|
2016-07-07 12:19:21 -04:00
|
|
|
|
2020-07-17 05:09:43 -04:00
|
|
|
context 'by name that begins with' do
|
|
|
|
let(:params) { { search: '^feature_' } }
|
2016-07-07 12:19:21 -04:00
|
|
|
|
2020-07-17 05:09:43 -04:00
|
|
|
it 'filters branches' do
|
|
|
|
result = subject
|
2016-07-07 12:19:21 -04:00
|
|
|
|
2020-07-17 05:09:43 -04:00
|
|
|
expect(result.first.name).to eq('feature_conflict')
|
|
|
|
expect(result.count).to eq(1)
|
|
|
|
end
|
2016-07-07 12:19:21 -04:00
|
|
|
end
|
|
|
|
|
2020-07-17 05:09:43 -04:00
|
|
|
context 'by name that ends with' do
|
|
|
|
let(:params) { { search: 'feature$' } }
|
2018-10-11 10:25:30 -04:00
|
|
|
|
2020-07-17 05:09:43 -04:00
|
|
|
it 'filters branches' do
|
|
|
|
result = subject
|
2018-10-11 10:25:30 -04:00
|
|
|
|
2020-07-17 05:09:43 -04:00
|
|
|
expect(result.first.name).to eq('feature')
|
|
|
|
expect(result.count).to eq(1)
|
|
|
|
end
|
2018-10-11 10:25:30 -04:00
|
|
|
end
|
|
|
|
|
2020-07-17 05:09:43 -04:00
|
|
|
context 'by nonexistent name that begins with' do
|
|
|
|
let(:params) { { search: '^nope' } }
|
2016-07-07 12:19:21 -04:00
|
|
|
|
2020-07-17 05:09:43 -04:00
|
|
|
it 'filters branches' do
|
|
|
|
result = subject
|
2016-07-07 12:19:21 -04:00
|
|
|
|
2020-07-17 05:09:43 -04:00
|
|
|
expect(result.count).to eq(0)
|
|
|
|
end
|
2016-07-07 12:19:21 -04:00
|
|
|
end
|
2018-10-11 10:25:30 -04:00
|
|
|
|
2020-07-17 05:09:43 -04:00
|
|
|
context 'by nonexistent name that ends with' do
|
|
|
|
let(:params) { { search: 'nope$' } }
|
2019-11-05 07:06:20 -05:00
|
|
|
|
2020-07-17 05:09:43 -04:00
|
|
|
it 'filters branches' do
|
|
|
|
result = subject
|
2019-11-05 07:06:20 -05:00
|
|
|
|
2020-07-17 05:09:43 -04:00
|
|
|
expect(result.count).to eq(0)
|
|
|
|
end
|
2019-11-05 07:06:20 -05:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'filter and sort' do
|
2020-07-17 05:09:43 -04:00
|
|
|
context 'by name and sorts by recently_updated' do
|
|
|
|
let(:params) { { sort: 'updated_desc', search: 'feat' } }
|
|
|
|
|
|
|
|
it 'filters branches' do
|
|
|
|
result = subject
|
|
|
|
|
|
|
|
expect(result.first.name).to eq('feature_conflict')
|
|
|
|
expect(result.count).to eq(2)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'by name and sorts by recently_updated, with exact matches first' do
|
|
|
|
let(:params) { { sort: 'updated_desc', search: 'feature' } }
|
|
|
|
|
|
|
|
it 'filters branches' do
|
|
|
|
result = subject
|
|
|
|
|
|
|
|
expect(result.first.name).to eq('feature')
|
|
|
|
expect(result.second.name).to eq('feature_conflict')
|
|
|
|
expect(result.count).to eq(2)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'by name and sorts by last_updated' do
|
|
|
|
let(:params) { { sort: 'updated_asc', search: 'feature' } }
|
|
|
|
|
|
|
|
it 'filters branches' do
|
|
|
|
result = subject
|
|
|
|
|
|
|
|
expect(result.first.name).to eq('feature')
|
|
|
|
expect(result.count).to eq(2)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2018-10-11 10:25:30 -04:00
|
|
|
|
2020-07-17 05:09:43 -04:00
|
|
|
context 'with gitaly pagination' do
|
|
|
|
subject { branch_finder.execute(gitaly_pagination: true) }
|
2018-10-11 10:25:30 -04:00
|
|
|
|
2020-07-17 05:09:43 -04:00
|
|
|
context 'by page_token and per_page' do
|
|
|
|
let(:params) { { page_token: 'feature', per_page: 2 } }
|
|
|
|
|
|
|
|
it 'filters branches' do
|
|
|
|
result = subject
|
|
|
|
|
2022-07-04 05:09:31 -04:00
|
|
|
expect(result.map(&:name)).to eq(%w(feature_conflict few-commits))
|
2020-07-17 05:09:43 -04:00
|
|
|
end
|
2018-10-11 10:25:30 -04:00
|
|
|
end
|
|
|
|
|
2020-07-17 05:09:43 -04:00
|
|
|
context 'by next page_token and per_page' do
|
2022-07-04 05:09:31 -04:00
|
|
|
let(:params) { { page_token: 'few-commits', per_page: 2 } }
|
2018-10-11 10:25:30 -04:00
|
|
|
|
2020-07-17 05:09:43 -04:00
|
|
|
it 'filters branches' do
|
|
|
|
result = subject
|
2018-10-11 10:25:30 -04:00
|
|
|
|
2022-07-04 05:09:31 -04:00
|
|
|
expect(result.map(&:name)).to eq(%w(fix flatten-dir))
|
2020-07-17 05:09:43 -04:00
|
|
|
end
|
2019-11-05 07:06:20 -05:00
|
|
|
end
|
|
|
|
|
2020-07-17 05:09:43 -04:00
|
|
|
context 'by per_page only' do
|
|
|
|
let(:params) { { per_page: 2 } }
|
|
|
|
|
|
|
|
it 'filters branches' do
|
|
|
|
result = subject
|
|
|
|
|
|
|
|
expect(result.map(&:name)).to eq(["'test'", '2-mb-file'])
|
|
|
|
end
|
|
|
|
end
|
2019-11-05 07:06:20 -05:00
|
|
|
|
2020-07-17 05:09:43 -04:00
|
|
|
context 'by page_token only' do
|
|
|
|
let(:params) { { page_token: 'feature' } }
|
2019-11-05 07:06:20 -05:00
|
|
|
|
2021-10-22 08:09:12 -04:00
|
|
|
it 'raises an error' do
|
|
|
|
expect do
|
|
|
|
subject
|
|
|
|
end.to raise_error(Gitlab::Git::CommandError, '13:could not find page token.')
|
2020-07-17 05:09:43 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'pagination and sort' do
|
|
|
|
context 'by per_page' do
|
|
|
|
let(:params) { { sort: 'updated_asc', per_page: 5 } }
|
|
|
|
|
|
|
|
it 'filters branches' do
|
|
|
|
result = subject
|
|
|
|
|
|
|
|
expect(result.map(&:name)).to eq(%w(feature improve/awesome merge-test markdown feature_conflict))
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'by page_token and per_page' do
|
|
|
|
let(:params) { { sort: 'updated_asc', page_token: 'improve/awesome', per_page: 2 } }
|
|
|
|
|
|
|
|
it 'filters branches' do
|
|
|
|
result = subject
|
|
|
|
|
|
|
|
expect(result.map(&:name)).to eq(%w(merge-test markdown))
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'pagination and names' do
|
|
|
|
let(:params) { { page_token: 'fix', per_page: 2, names: %w[fix csv lfs does-not-exist] } }
|
|
|
|
|
|
|
|
it 'falls back to default execute and ignore paginations' do
|
|
|
|
result = subject
|
|
|
|
|
|
|
|
expect(result.count).to eq(3)
|
|
|
|
expect(result.map(&:name)).to eq(%w{csv fix lfs})
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'pagination and search' do
|
|
|
|
let(:params) { { page_token: 'feature', per_page: 2, search: '^f' } }
|
|
|
|
|
|
|
|
it 'falls back to default execute and ignore paginations' do
|
|
|
|
result = subject
|
|
|
|
|
2022-07-04 05:09:31 -04:00
|
|
|
expect(result.map(&:name)).to eq(%w(feature feature_conflict few-commits fix flatten-dir))
|
2020-07-17 05:09:43 -04:00
|
|
|
end
|
2018-10-11 10:25:30 -04:00
|
|
|
end
|
2016-07-07 12:19:21 -04:00
|
|
|
end
|
|
|
|
end
|
2021-09-14 14:12:06 -04:00
|
|
|
|
|
|
|
describe '#total' do
|
|
|
|
subject { branch_finder.total }
|
|
|
|
|
|
|
|
it { is_expected.to be_an(Integer) }
|
|
|
|
it { is_expected.to eq(repository.branch_count) }
|
|
|
|
end
|
2016-07-07 12:19:21 -04:00
|
|
|
end
|