2012-11-19 18:14:05 +00:00
|
|
|
require 'spec_helper'
|
|
|
|
|
2017-07-10 14:24:02 +00:00
|
|
|
describe Service do
|
2012-11-19 18:14:05 +00:00
|
|
|
describe "Associations" do
|
2015-02-12 18:17:35 +00:00
|
|
|
it { is_expected.to belong_to :project }
|
|
|
|
it { is_expected.to have_one :service_hook }
|
2012-11-19 18:14:05 +00:00
|
|
|
end
|
|
|
|
|
2017-04-25 15:47:57 +00:00
|
|
|
describe 'Validations' do
|
2017-04-25 15:48:12 +00:00
|
|
|
it { is_expected.to validate_presence_of(:type) }
|
2017-04-25 15:47:57 +00:00
|
|
|
end
|
|
|
|
|
2018-04-03 11:00:33 +00:00
|
|
|
describe 'Scopes' do
|
|
|
|
describe '.confidential_note_hooks' do
|
|
|
|
it 'includes services where confidential_note_events is true' do
|
|
|
|
create(:service, active: true, confidential_note_events: true)
|
|
|
|
|
|
|
|
expect(described_class.confidential_note_hooks.count).to eq 1
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'excludes services where confidential_note_events is false' do
|
|
|
|
create(:service, active: true, confidential_note_events: false)
|
|
|
|
|
|
|
|
expect(described_class.confidential_note_hooks.count).to eq 0
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2013-08-09 18:14:02 +00:00
|
|
|
describe "Test Button" do
|
2017-04-24 15:23:51 +00:00
|
|
|
describe '#can_test?' do
|
|
|
|
let(:service) { create(:service, project: project) }
|
2013-08-09 18:14:02 +00:00
|
|
|
|
2017-04-24 15:23:51 +00:00
|
|
|
context 'when repository is not empty' do
|
|
|
|
let(:project) { create(:project, :repository) }
|
2013-08-09 18:14:02 +00:00
|
|
|
|
2017-04-24 15:23:51 +00:00
|
|
|
it 'returns true' do
|
|
|
|
expect(service.can_test?).to be true
|
|
|
|
end
|
2013-08-09 18:14:02 +00:00
|
|
|
end
|
|
|
|
|
2017-04-24 15:23:51 +00:00
|
|
|
context 'when repository is empty' do
|
2017-08-02 19:55:11 +00:00
|
|
|
let(:project) { create(:project) }
|
2017-04-24 15:23:51 +00:00
|
|
|
|
|
|
|
it 'returns true' do
|
|
|
|
expect(service.can_test?).to be true
|
|
|
|
end
|
2013-08-09 18:14:02 +00:00
|
|
|
end
|
2017-04-24 15:23:51 +00:00
|
|
|
end
|
2015-08-12 07:40:54 +00:00
|
|
|
|
2017-04-24 15:23:51 +00:00
|
|
|
describe '#test' do
|
|
|
|
let(:data) { 'test' }
|
|
|
|
let(:service) { create(:service, project: project) }
|
|
|
|
|
|
|
|
context 'when repository is not empty' do
|
|
|
|
let(:project) { create(:project, :repository) }
|
2015-08-12 07:40:54 +00:00
|
|
|
|
|
|
|
it 'test runs execute' do
|
2017-04-24 15:23:51 +00:00
|
|
|
expect(service).to receive(:execute).with(data)
|
2015-08-12 07:40:54 +00:00
|
|
|
|
2017-04-24 15:23:51 +00:00
|
|
|
service.test(data)
|
2015-08-12 07:40:54 +00:00
|
|
|
end
|
|
|
|
end
|
2013-08-09 18:14:02 +00:00
|
|
|
|
2017-04-24 15:23:51 +00:00
|
|
|
context 'when repository is empty' do
|
2017-08-02 19:55:11 +00:00
|
|
|
let(:project) { create(:project) }
|
2013-08-09 18:14:02 +00:00
|
|
|
|
2017-04-24 15:23:51 +00:00
|
|
|
it 'test runs execute' do
|
|
|
|
expect(service).to receive(:execute).with(data)
|
2013-08-09 18:14:02 +00:00
|
|
|
|
2017-04-24 15:23:51 +00:00
|
|
|
service.test(data)
|
|
|
|
end
|
2013-08-09 18:14:02 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2015-02-12 18:53:01 +00:00
|
|
|
|
|
|
|
describe "Template" do
|
2018-03-27 15:33:29 +00:00
|
|
|
describe '.build_from_template' do
|
|
|
|
context 'when template is invalid' do
|
|
|
|
it 'sets service template to inactive when template is invalid' do
|
|
|
|
project = create(:project)
|
|
|
|
template = JiraService.new(template: true, active: true)
|
|
|
|
template.save(validate: false)
|
|
|
|
|
|
|
|
service = described_class.build_from_template(project.id, template)
|
|
|
|
|
|
|
|
expect(service).to be_valid
|
|
|
|
expect(service.active).to be false
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2015-02-12 18:53:01 +00:00
|
|
|
describe "for pushover service" do
|
2016-11-16 11:46:07 +00:00
|
|
|
let!(:service_template) do
|
2015-06-22 20:00:54 +00:00
|
|
|
PushoverService.create(
|
|
|
|
template: true,
|
|
|
|
properties: {
|
|
|
|
device: 'MyDevice',
|
|
|
|
sound: 'mic',
|
|
|
|
priority: 4,
|
|
|
|
api_key: '123456789'
|
|
|
|
})
|
|
|
|
end
|
2017-08-02 19:55:11 +00:00
|
|
|
let(:project) { create(:project) }
|
2015-02-12 18:53:01 +00:00
|
|
|
|
2016-08-01 15:00:44 +00:00
|
|
|
describe 'is prefilled for projects pushover service' do
|
|
|
|
it "has all fields prefilled" do
|
2016-11-16 11:46:07 +00:00
|
|
|
service = project.find_or_initialize_service('pushover')
|
|
|
|
|
2015-02-12 18:53:01 +00:00
|
|
|
expect(service.template).to eq(false)
|
|
|
|
expect(service.device).to eq('MyDevice')
|
|
|
|
expect(service.sound).to eq('mic')
|
|
|
|
expect(service.priority).to eq(4)
|
|
|
|
expect(service.api_key).to eq('123456789')
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2015-10-09 10:20:38 +00:00
|
|
|
|
2015-10-15 07:09:01 +00:00
|
|
|
describe "{property}_changed?" do
|
2015-10-09 10:20:38 +00:00
|
|
|
let(:service) do
|
|
|
|
BambooService.create(
|
2017-08-02 19:55:11 +00:00
|
|
|
project: create(:project),
|
2015-10-09 10:20:38 +00:00
|
|
|
properties: {
|
|
|
|
bamboo_url: 'http://gitlab.com',
|
|
|
|
username: 'mic',
|
|
|
|
password: "password"
|
|
|
|
}
|
|
|
|
)
|
|
|
|
end
|
|
|
|
|
2015-10-15 07:09:01 +00:00
|
|
|
it "returns false when the property has not been assigned a new value" do
|
2015-10-09 10:20:38 +00:00
|
|
|
service.username = "key_changed"
|
2015-10-15 07:09:01 +00:00
|
|
|
expect(service.bamboo_url_changed?).to be_falsy
|
2015-10-09 10:20:38 +00:00
|
|
|
end
|
|
|
|
|
2015-10-15 07:09:01 +00:00
|
|
|
it "returns true when the property has been assigned a different value" do
|
|
|
|
service.bamboo_url = "http://example.com"
|
|
|
|
expect(service.bamboo_url_changed?).to be_truthy
|
|
|
|
end
|
|
|
|
|
|
|
|
it "returns true when the property has been assigned a different value twice" do
|
|
|
|
service.bamboo_url = "http://example.com"
|
|
|
|
service.bamboo_url = "http://example.com"
|
|
|
|
expect(service.bamboo_url_changed?).to be_truthy
|
|
|
|
end
|
|
|
|
|
|
|
|
it "returns false when the property has been re-assigned the same value" do
|
|
|
|
service.bamboo_url = 'http://gitlab.com'
|
|
|
|
expect(service.bamboo_url_changed?).to be_falsy
|
|
|
|
end
|
|
|
|
|
|
|
|
it "returns false when the property has been assigned a new value then saved" do
|
|
|
|
service.bamboo_url = 'http://example.com'
|
|
|
|
service.save
|
|
|
|
expect(service.bamboo_url_changed?).to be_falsy
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe "{property}_touched?" do
|
|
|
|
let(:service) do
|
|
|
|
BambooService.create(
|
2017-08-02 19:55:11 +00:00
|
|
|
project: create(:project),
|
2015-10-15 07:09:01 +00:00
|
|
|
properties: {
|
|
|
|
bamboo_url: 'http://gitlab.com',
|
|
|
|
username: 'mic',
|
|
|
|
password: "password"
|
|
|
|
}
|
|
|
|
)
|
|
|
|
end
|
|
|
|
|
|
|
|
it "returns false when the property has not been assigned a new value" do
|
|
|
|
service.username = "key_changed"
|
|
|
|
expect(service.bamboo_url_touched?).to be_falsy
|
|
|
|
end
|
|
|
|
|
|
|
|
it "returns true when the property has been assigned a different value" do
|
|
|
|
service.bamboo_url = "http://example.com"
|
|
|
|
expect(service.bamboo_url_touched?).to be_truthy
|
|
|
|
end
|
|
|
|
|
|
|
|
it "returns true when the property has been assigned a different value twice" do
|
|
|
|
service.bamboo_url = "http://example.com"
|
|
|
|
service.bamboo_url = "http://example.com"
|
|
|
|
expect(service.bamboo_url_touched?).to be_truthy
|
|
|
|
end
|
|
|
|
|
|
|
|
it "returns true when the property has been re-assigned the same value" do
|
|
|
|
service.bamboo_url = 'http://gitlab.com'
|
|
|
|
expect(service.bamboo_url_touched?).to be_truthy
|
|
|
|
end
|
|
|
|
|
|
|
|
it "returns false when the property has been assigned a new value then saved" do
|
|
|
|
service.bamboo_url = 'http://example.com'
|
|
|
|
service.save
|
|
|
|
expect(service.bamboo_url_changed?).to be_falsy
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe "{property}_was" do
|
|
|
|
let(:service) do
|
|
|
|
BambooService.create(
|
2017-08-02 19:55:11 +00:00
|
|
|
project: create(:project),
|
2015-10-15 07:09:01 +00:00
|
|
|
properties: {
|
|
|
|
bamboo_url: 'http://gitlab.com',
|
|
|
|
username: 'mic',
|
|
|
|
password: "password"
|
|
|
|
}
|
|
|
|
)
|
|
|
|
end
|
|
|
|
|
|
|
|
it "returns nil when the property has not been assigned a new value" do
|
|
|
|
service.username = "key_changed"
|
|
|
|
expect(service.bamboo_url_was).to be_nil
|
|
|
|
end
|
|
|
|
|
|
|
|
it "returns the previous value when the property has been assigned a different value" do
|
|
|
|
service.bamboo_url = "http://example.com"
|
|
|
|
expect(service.bamboo_url_was).to eq('http://gitlab.com')
|
|
|
|
end
|
|
|
|
|
|
|
|
it "returns initial value when the property has been re-assigned the same value" do
|
|
|
|
service.bamboo_url = 'http://gitlab.com'
|
|
|
|
expect(service.bamboo_url_was).to eq('http://gitlab.com')
|
|
|
|
end
|
|
|
|
|
|
|
|
it "returns initial value when the property has been assigned multiple values" do
|
|
|
|
service.bamboo_url = "http://example.com"
|
|
|
|
service.bamboo_url = "http://example2.com"
|
|
|
|
expect(service.bamboo_url_was).to eq('http://gitlab.com')
|
|
|
|
end
|
|
|
|
|
|
|
|
it "returns nil when the property has been assigned a new value then saved" do
|
|
|
|
service.bamboo_url = 'http://example.com'
|
|
|
|
service.save
|
|
|
|
expect(service.bamboo_url_was).to be_nil
|
2015-10-09 10:20:38 +00:00
|
|
|
end
|
|
|
|
end
|
2016-06-03 08:21:18 +00:00
|
|
|
|
2016-10-04 08:01:32 +00:00
|
|
|
describe 'initialize service with no properties' do
|
|
|
|
let(:service) do
|
|
|
|
GitlabIssueTrackerService.create(
|
2017-08-02 19:55:11 +00:00
|
|
|
project: create(:project),
|
2016-10-04 08:01:32 +00:00
|
|
|
title: 'random title'
|
|
|
|
)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not raise error' do
|
|
|
|
expect { service }.not_to raise_error
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'creates the properties' do
|
|
|
|
expect(service.properties).to eq({ "title" => "random title" })
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2016-06-03 08:21:18 +00:00
|
|
|
describe "callbacks" do
|
2017-08-02 19:55:11 +00:00
|
|
|
let(:project) { create(:project) }
|
2016-06-03 08:21:18 +00:00
|
|
|
let!(:service) do
|
|
|
|
RedmineService.new(
|
|
|
|
project: project,
|
|
|
|
active: true,
|
|
|
|
properties: {
|
|
|
|
project_url: 'http://redmine/projects/project_name_in_redmine',
|
|
|
|
issues_url: "http://redmine/#{project.id}/project_name_in_redmine/:id",
|
|
|
|
new_issue_url: 'http://redmine/projects/project_name_in_redmine/issues/new'
|
|
|
|
}
|
|
|
|
)
|
|
|
|
end
|
|
|
|
|
|
|
|
describe "on create" do
|
|
|
|
it "updates the has_external_issue_tracker boolean" do
|
|
|
|
expect do
|
|
|
|
service.save!
|
2016-10-06 21:17:11 +00:00
|
|
|
end.to change { service.project.has_external_issue_tracker }.from(false).to(true)
|
2016-06-03 08:21:18 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe "on update" do
|
|
|
|
it "updates the has_external_issue_tracker boolean" do
|
|
|
|
service.save!
|
|
|
|
|
|
|
|
expect do
|
|
|
|
service.update_attributes(active: false)
|
|
|
|
end.to change { service.project.has_external_issue_tracker }.from(true).to(false)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2018-01-04 09:33:51 +00:00
|
|
|
|
|
|
|
describe "#deprecated?" do
|
|
|
|
let(:project) { create(:project, :repository) }
|
|
|
|
|
|
|
|
it 'should return false by default' do
|
|
|
|
service = create(:service, project: project)
|
|
|
|
expect(service.deprecated?).to be_falsy
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe "#deprecation_message" do
|
|
|
|
let(:project) { create(:project, :repository) }
|
|
|
|
|
|
|
|
it 'should be empty by default' do
|
|
|
|
service = create(:service, project: project)
|
|
|
|
expect(service.deprecation_message).to be_nil
|
|
|
|
end
|
|
|
|
end
|
2018-01-04 22:35:41 +00:00
|
|
|
|
|
|
|
describe '.find_by_template' do
|
|
|
|
let!(:kubernetes_service) { create(:kubernetes_service, template: true) }
|
|
|
|
|
|
|
|
it 'returns service template' do
|
|
|
|
expect(KubernetesService.find_by_template).to eq(kubernetes_service)
|
2018-01-17 01:08:03 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2018-01-06 06:18:13 +00:00
|
|
|
describe '#api_field_names' do
|
|
|
|
let(:fake_service) do
|
|
|
|
Class.new(Service) do
|
|
|
|
def fields
|
|
|
|
[
|
|
|
|
{ name: 'token' },
|
|
|
|
{ name: 'api_token' },
|
|
|
|
{ name: 'key' },
|
|
|
|
{ name: 'api_key' },
|
|
|
|
{ name: 'password' },
|
|
|
|
{ name: 'password_field' },
|
|
|
|
{ name: 'safe_field' }
|
|
|
|
]
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
let(:service) do
|
|
|
|
fake_service.new(properties: [
|
|
|
|
{ token: 'token-value' },
|
|
|
|
{ api_token: 'api_token-value' },
|
|
|
|
{ key: 'key-value' },
|
|
|
|
{ api_key: 'api_key-value' },
|
|
|
|
{ password: 'password-value' },
|
|
|
|
{ password_field: 'password_field-value' },
|
|
|
|
{ safe_field: 'safe_field-value' }
|
|
|
|
])
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'filters out sensitive fields' do
|
|
|
|
expect(service.api_field_names).to eq(['safe_field'])
|
2018-01-04 22:35:41 +00:00
|
|
|
end
|
|
|
|
end
|
2012-11-19 18:14:05 +00:00
|
|
|
end
|