2019-04-11 08:17:24 -04:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2016-11-08 08:20:58 -05:00
|
|
|
require 'spec_helper'
|
|
|
|
|
2020-06-24 02:09:01 -04:00
|
|
|
RSpec.describe Ci::StopEnvironmentsService do
|
2020-02-13 19:09:07 -05:00
|
|
|
include CreateEnvironmentsHelpers
|
|
|
|
|
2017-03-27 17:14:01 -04:00
|
|
|
let(:project) { create(:project, :private, :repository) }
|
2016-11-08 08:20:58 -05:00
|
|
|
let(:user) { create(:user) }
|
|
|
|
|
|
|
|
let(:service) { described_class.new(project, user) }
|
|
|
|
|
|
|
|
describe '#execute' do
|
2016-11-09 07:31:33 -05:00
|
|
|
context 'when environment with review app exists' do
|
2016-11-08 08:20:58 -05:00
|
|
|
before do
|
2016-11-14 08:10:54 -05:00
|
|
|
create(:environment, :with_review_app, project: project,
|
|
|
|
ref: 'feature')
|
2016-11-08 08:20:58 -05:00
|
|
|
end
|
|
|
|
|
2016-11-14 07:54:23 -05:00
|
|
|
context 'when user has permission to stop environment' do
|
|
|
|
before do
|
2017-12-22 03:18:28 -05:00
|
|
|
project.add_developer(user)
|
2016-11-14 07:54:23 -05:00
|
|
|
end
|
2016-11-08 08:20:58 -05:00
|
|
|
|
2016-11-14 08:10:54 -05:00
|
|
|
context 'when environment is associated with removed branch' do
|
|
|
|
it 'stops environment' do
|
|
|
|
expect_environment_stopped_on('feature')
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when environment is associated with different branch' do
|
|
|
|
it 'does not stop environment' do
|
|
|
|
expect_environment_not_stopped_on('master')
|
|
|
|
end
|
2016-11-14 07:54:23 -05:00
|
|
|
end
|
2016-11-09 07:31:33 -05:00
|
|
|
|
2016-11-14 07:54:23 -05:00
|
|
|
context 'when specified branch does not exist' do
|
|
|
|
it 'does not stop environment' do
|
|
|
|
expect_environment_not_stopped_on('non/existent/branch')
|
|
|
|
end
|
|
|
|
end
|
2016-11-09 07:31:33 -05:00
|
|
|
|
2016-11-14 07:54:23 -05:00
|
|
|
context 'when no branch not specified' do
|
|
|
|
it 'does not stop environment' do
|
|
|
|
expect_environment_not_stopped_on(nil)
|
|
|
|
end
|
2016-11-09 07:31:33 -05:00
|
|
|
end
|
|
|
|
|
2017-02-06 10:50:03 -05:00
|
|
|
context 'when environment is not stopped' do
|
2016-11-14 07:54:23 -05:00
|
|
|
before do
|
|
|
|
allow_any_instance_of(Environment)
|
2017-02-06 10:50:03 -05:00
|
|
|
.to receive(:state).and_return(:stopped)
|
2016-11-14 07:54:23 -05:00
|
|
|
end
|
2016-11-09 07:31:33 -05:00
|
|
|
|
2016-11-14 07:54:23 -05:00
|
|
|
it 'does not stop environment' do
|
2016-11-14 08:10:54 -05:00
|
|
|
expect_environment_not_stopped_on('feature')
|
2016-11-14 07:54:23 -05:00
|
|
|
end
|
2016-11-09 07:31:33 -05:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2016-11-14 07:54:23 -05:00
|
|
|
context 'when user does not have permission to stop environment' do
|
2017-04-06 09:19:52 -04:00
|
|
|
context 'when user has no access to manage deployments' do
|
|
|
|
before do
|
2017-12-22 03:18:28 -05:00
|
|
|
project.add_guest(user)
|
2017-04-06 09:19:52 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not stop environment' do
|
|
|
|
expect_environment_not_stopped_on('master')
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when branch for stop action is protected' do
|
2016-11-09 07:31:33 -05:00
|
|
|
before do
|
2017-04-06 09:19:52 -04:00
|
|
|
project.add_developer(user)
|
|
|
|
create(:protected_branch, :no_one_can_push,
|
|
|
|
name: 'master', project: project)
|
2016-11-09 07:31:33 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not stop environment' do
|
2016-11-14 07:54:23 -05:00
|
|
|
expect_environment_not_stopped_on('master')
|
2016-11-09 07:31:33 -05:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when there is no environment associated with review app' do
|
|
|
|
before do
|
|
|
|
create(:environment, project: project)
|
|
|
|
end
|
|
|
|
|
2016-11-14 07:54:23 -05:00
|
|
|
context 'when user has permission to stop environments' do
|
|
|
|
before do
|
2018-07-11 10:36:08 -04:00
|
|
|
project.add_maintainer(user)
|
2016-11-14 07:54:23 -05:00
|
|
|
end
|
2016-11-09 07:31:33 -05:00
|
|
|
|
2016-11-14 07:54:23 -05:00
|
|
|
it 'does not stop environment' do
|
|
|
|
expect_environment_not_stopped_on('master')
|
|
|
|
end
|
2016-11-09 07:31:33 -05:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when environment does not exist' do
|
|
|
|
it 'does not raise error' do
|
|
|
|
expect { service.execute('master') }
|
|
|
|
.not_to raise_error
|
|
|
|
end
|
2016-11-08 08:20:58 -05:00
|
|
|
end
|
|
|
|
end
|
2016-11-14 07:54:23 -05:00
|
|
|
|
2019-04-24 07:37:29 -04:00
|
|
|
describe '#execute_for_merge_request' do
|
|
|
|
subject { service.execute_for_merge_request(merge_request) }
|
|
|
|
|
|
|
|
let(:merge_request) { create(:merge_request, source_branch: 'feature', target_branch: 'master') }
|
|
|
|
let(:project) { merge_request.project }
|
|
|
|
let(:user) { create(:user) }
|
|
|
|
|
|
|
|
let(:pipeline) do
|
|
|
|
create(:ci_pipeline,
|
|
|
|
source: :merge_request_event,
|
|
|
|
merge_request: merge_request,
|
|
|
|
project: project,
|
|
|
|
sha: merge_request.diff_head_sha,
|
|
|
|
merge_requests_as_head_pipeline: [merge_request])
|
|
|
|
end
|
|
|
|
|
2019-10-15 08:06:06 -04:00
|
|
|
let!(:review_job) { create(:ci_build, :with_deployment, :start_review_app, pipeline: pipeline, project: project) }
|
|
|
|
let!(:stop_review_job) { create(:ci_build, :with_deployment, :stop_review_app, :manual, pipeline: pipeline, project: project) }
|
2019-04-24 07:37:29 -04:00
|
|
|
|
|
|
|
before do
|
|
|
|
review_job.deployment.success!
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'has active environment at first' do
|
|
|
|
expect(pipeline.environments.first).to be_available
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when user is a developer' do
|
|
|
|
before do
|
|
|
|
project.add_developer(user)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'stops the active environment' do
|
|
|
|
subject
|
|
|
|
|
|
|
|
expect(pipeline.environments.first).to be_stopped
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when user is a reporter' do
|
|
|
|
before do
|
|
|
|
project.add_reporter(user)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not stop the active environment' do
|
|
|
|
subject
|
|
|
|
|
|
|
|
expect(pipeline.environments.first).to be_available
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when pipeline is not associated with environments' do
|
|
|
|
let!(:job) { create(:ci_build, pipeline: pipeline, project: project) }
|
|
|
|
|
|
|
|
it 'does not raise exception' do
|
|
|
|
expect { subject }.not_to raise_exception
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when pipeline is not a pipeline for merge request' do
|
|
|
|
let(:pipeline) do
|
|
|
|
create(:ci_pipeline,
|
|
|
|
project: project,
|
|
|
|
ref: 'feature',
|
|
|
|
sha: merge_request.diff_head_sha,
|
|
|
|
merge_requests_as_head_pipeline: [merge_request])
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not stop the active environment' do
|
|
|
|
subject
|
|
|
|
|
|
|
|
expect(pipeline.environments.first).to be_available
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2020-02-13 19:09:07 -05:00
|
|
|
describe '.execute_in_batch' do
|
|
|
|
subject { described_class.execute_in_batch(environments) }
|
|
|
|
|
|
|
|
let_it_be(:project) { create(:project, :repository) }
|
|
|
|
let_it_be(:user) { create(:user) }
|
|
|
|
let(:environments) { Environment.available }
|
|
|
|
|
|
|
|
before_all do
|
|
|
|
project.add_developer(user)
|
|
|
|
project.repository.add_branch(user, 'review/feature-1', 'master')
|
|
|
|
project.repository.add_branch(user, 'review/feature-2', 'master')
|
|
|
|
end
|
|
|
|
|
|
|
|
before do
|
|
|
|
create_review_app(user, project, 'review/feature-1')
|
|
|
|
create_review_app(user, project, 'review/feature-2')
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'stops environments' do
|
|
|
|
expect { subject }
|
|
|
|
.to change { project.environments.all.map(&:state).uniq }
|
|
|
|
.from(['available']).to(['stopped'])
|
|
|
|
|
|
|
|
expect(project.environments.all.map(&:auto_stop_at).uniq).to eq([nil])
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'plays stop actions' do
|
|
|
|
expect { subject }
|
|
|
|
.to change { Ci::Build.where(name: 'stop_review_app').map(&:status).uniq }
|
|
|
|
.from(['manual']).to(['pending'])
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when user does not have a permission to play the stop action' do
|
|
|
|
before do
|
2020-02-15 01:09:11 -05:00
|
|
|
project.team.truncate
|
2020-02-13 19:09:07 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
it 'tracks the exception' do
|
|
|
|
expect(Gitlab::ErrorTracking)
|
2020-06-02 23:08:23 -04:00
|
|
|
.to receive(:track_exception)
|
|
|
|
.with(Gitlab::Access::AccessDeniedError, anything)
|
|
|
|
.twice
|
|
|
|
.and_call_original
|
2020-02-13 19:09:07 -05:00
|
|
|
|
|
|
|
subject
|
|
|
|
end
|
2020-02-15 01:09:11 -05:00
|
|
|
|
|
|
|
after do
|
|
|
|
project.add_developer(user)
|
|
|
|
end
|
2020-02-13 19:09:07 -05:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2016-11-14 07:54:23 -05:00
|
|
|
def expect_environment_stopped_on(branch)
|
|
|
|
expect_any_instance_of(Environment)
|
|
|
|
.to receive(:stop!)
|
|
|
|
|
|
|
|
service.execute(branch)
|
|
|
|
end
|
|
|
|
|
|
|
|
def expect_environment_not_stopped_on(branch)
|
|
|
|
expect_any_instance_of(Environment)
|
|
|
|
.not_to receive(:stop!)
|
|
|
|
|
|
|
|
service.execute(branch)
|
|
|
|
end
|
2016-11-08 08:20:58 -05:00
|
|
|
end
|