gitlab-org--gitlab-foss/config/initializers/forbid_sidekiq_in_transactions.rb

56 lines
1.7 KiB
Ruby
Raw Normal View History

module Sidekiq
module Worker
EnqueueFromTransactionError = Class.new(StandardError)
2017-06-02 13:12:08 -04:00
mattr_accessor :skip_transaction_check
self.skip_transaction_check = false
def self.skipping_transaction_check(&block)
skip_transaction_check = self.skip_transaction_check
self.skip_transaction_check = true
yield
ensure
self.skip_transaction_check = skip_transaction_check
end
module ClassMethods
module NoEnqueueingFromTransactions
%i(perform_async perform_at perform_in).each do |name|
define_method(name) do |*args|
2017-11-29 10:30:17 -05:00
if !Sidekiq::Worker.skip_transaction_check && AfterCommitQueue.inside_transaction?
begin
raise Sidekiq::Worker::EnqueueFromTransactionError, <<~MSG
2017-11-29 10:30:17 -05:00
`#{self}.#{name}` cannot be called inside a transaction as this can lead to
race conditions when the worker runs before the transaction is committed and
tries to access a model that has not been saved yet.
2017-11-29 10:30:17 -05:00
Use an `after_commit` hook, or include `AfterCommitQueue` and use a `run_after_commit` block instead.
MSG
rescue Sidekiq::Worker::EnqueueFromTransactionError => e
::Rails.logger.error(e.message) if ::Rails.env.production?
Gitlab::Sentry.track_exception(e)
end
2017-11-29 10:30:17 -05:00
end
2017-11-29 10:30:17 -05:00
super(*args)
end
end
end
prepend NoEnqueueingFromTransactions
end
end
end
module ActiveRecord
class Base
2017-06-02 13:12:08 -04:00
module SkipTransactionCheckAfterCommit
def committed!(*)
2017-06-02 13:12:08 -04:00
Sidekiq::Worker.skipping_transaction_check { super }
end
end
2017-06-02 13:12:08 -04:00
prepend SkipTransactionCheckAfterCommit
end
end