2015-03-26 22:06:19 -04:00
|
|
|
require 'spec_helper'
|
|
|
|
|
|
|
|
describe AutocompleteController do
|
2017-08-10 03:45:03 -04:00
|
|
|
let(:project) { create(:project) }
|
|
|
|
let(:user) { project.owner }
|
2015-03-26 22:06:19 -04:00
|
|
|
|
2016-11-29 06:21:50 -05:00
|
|
|
context 'GET users' do
|
2016-08-05 09:29:20 -04:00
|
|
|
let!(:user2) { create(:user) }
|
|
|
|
let!(:non_member) { create(:user) }
|
2015-03-26 22:06:19 -04:00
|
|
|
|
2016-08-05 09:29:20 -04:00
|
|
|
context 'project members' do
|
2015-07-11 09:16:59 -04:00
|
|
|
before do
|
2016-08-05 09:29:20 -04:00
|
|
|
sign_in(user)
|
2015-07-11 09:16:59 -04:00
|
|
|
end
|
|
|
|
|
2016-08-05 09:29:20 -04:00
|
|
|
describe 'GET #users with project ID' do
|
|
|
|
before do
|
|
|
|
get(:users, project_id: project.id)
|
|
|
|
end
|
2016-02-17 06:49:38 -05:00
|
|
|
|
2017-08-10 03:45:03 -04:00
|
|
|
it 'returns the project members' do
|
|
|
|
expect(json_response).to be_kind_of(Array)
|
|
|
|
expect(json_response.size).to eq(1)
|
|
|
|
expect(json_response.map { |u| u["username"] }).to include(user.username)
|
|
|
|
end
|
2015-07-11 09:16:59 -04:00
|
|
|
end
|
|
|
|
|
2016-08-05 09:29:20 -04:00
|
|
|
describe 'GET #users with unknown project' do
|
|
|
|
before do
|
|
|
|
get(:users, project_id: 'unknown')
|
|
|
|
end
|
2015-03-26 22:06:19 -04:00
|
|
|
|
2017-10-19 14:28:19 -04:00
|
|
|
it { expect(response).to have_gitlab_http_status(404) }
|
2016-08-05 09:29:20 -04:00
|
|
|
end
|
2015-03-26 22:06:19 -04:00
|
|
|
end
|
|
|
|
|
2016-08-05 09:29:20 -04:00
|
|
|
context 'group members' do
|
|
|
|
let(:group) { create(:group) }
|
2015-03-26 22:06:19 -04:00
|
|
|
|
2015-07-11 09:16:59 -04:00
|
|
|
before do
|
2016-08-05 09:29:20 -04:00
|
|
|
group.add_owner(user)
|
2017-08-10 03:45:03 -04:00
|
|
|
sign_in(user)
|
2015-07-11 09:16:59 -04:00
|
|
|
end
|
|
|
|
|
2016-08-05 09:29:20 -04:00
|
|
|
describe 'GET #users with group ID' do
|
|
|
|
before do
|
|
|
|
get(:users, group_id: group.id)
|
|
|
|
end
|
|
|
|
|
2017-08-10 03:45:03 -04:00
|
|
|
it 'returns the group members' do
|
|
|
|
expect(json_response).to be_kind_of(Array)
|
|
|
|
expect(json_response.size).to eq(1)
|
|
|
|
expect(json_response.first["username"]).to eq user.username
|
|
|
|
end
|
2016-08-05 09:29:20 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
describe 'GET #users with unknown group ID' do
|
|
|
|
before do
|
|
|
|
get(:users, group_id: 'unknown')
|
|
|
|
end
|
|
|
|
|
2017-10-19 14:28:19 -04:00
|
|
|
it { expect(response).to have_gitlab_http_status(404) }
|
2016-08-05 09:29:20 -04:00
|
|
|
end
|
2015-07-11 09:16:59 -04:00
|
|
|
end
|
|
|
|
|
2016-08-05 09:29:20 -04:00
|
|
|
context 'non-member login for public project' do
|
2017-08-10 03:45:03 -04:00
|
|
|
let(:project) { create(:project, :public) }
|
2016-08-05 09:29:20 -04:00
|
|
|
|
2015-07-11 09:16:59 -04:00
|
|
|
before do
|
2016-08-05 09:29:20 -04:00
|
|
|
sign_in(non_member)
|
2015-07-11 09:16:59 -04:00
|
|
|
end
|
|
|
|
|
2016-08-05 09:29:20 -04:00
|
|
|
describe 'GET #users with project ID' do
|
|
|
|
before do
|
|
|
|
get(:users, project_id: project.id, current_user: true)
|
|
|
|
end
|
2015-08-06 03:20:41 -04:00
|
|
|
|
2017-08-10 03:45:03 -04:00
|
|
|
it 'returns the project members and non-members' do
|
|
|
|
expect(json_response).to be_kind_of(Array)
|
|
|
|
expect(json_response.size).to eq(2)
|
|
|
|
expect(json_response.map { |u| u['username'] }).to include(user.username, non_member.username)
|
|
|
|
end
|
2016-08-05 09:29:20 -04:00
|
|
|
end
|
2015-08-06 03:20:41 -04:00
|
|
|
end
|
|
|
|
|
2016-08-05 09:29:20 -04:00
|
|
|
context 'all users' do
|
2015-08-06 03:20:41 -04:00
|
|
|
before do
|
2016-08-05 09:29:20 -04:00
|
|
|
sign_in(user)
|
|
|
|
get(:users)
|
2015-08-06 03:20:41 -04:00
|
|
|
end
|
|
|
|
|
2017-08-10 03:45:03 -04:00
|
|
|
it { expect(json_response).to be_kind_of(Array) }
|
|
|
|
it { expect(json_response.size).to eq User.count }
|
2015-08-06 03:20:41 -04:00
|
|
|
end
|
|
|
|
|
2017-07-14 07:16:20 -04:00
|
|
|
context 'user order' do
|
|
|
|
it 'shows exact matches first' do
|
|
|
|
reported_user = create(:user, username: 'reported_user', name: 'Doug')
|
|
|
|
user = create(:user, username: 'user', name: 'User')
|
|
|
|
user1 = create(:user, username: 'user1', name: 'Ian')
|
|
|
|
|
|
|
|
sign_in(user)
|
|
|
|
get(:users, search: 'user')
|
|
|
|
|
2017-08-10 03:45:03 -04:00
|
|
|
response_usernames = json_response.map { |user| user['username'] }
|
2017-07-14 07:16:20 -04:00
|
|
|
|
|
|
|
expect(response_usernames.take(3)).to match_array([user.username, reported_user.username, user1.username])
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2017-05-26 13:59:00 -04:00
|
|
|
context 'limited users per page' do
|
|
|
|
before do
|
2018-02-15 13:33:35 -05:00
|
|
|
25.times do
|
|
|
|
create(:user)
|
|
|
|
end
|
|
|
|
|
2017-05-26 13:59:00 -04:00
|
|
|
sign_in(user)
|
2018-02-15 13:33:35 -05:00
|
|
|
get(:users)
|
2017-05-26 13:59:00 -04:00
|
|
|
end
|
|
|
|
|
2017-08-10 03:45:03 -04:00
|
|
|
it { expect(json_response).to be_kind_of(Array) }
|
2018-02-15 13:33:35 -05:00
|
|
|
it { expect(json_response.size).to eq(20) }
|
2017-05-26 13:59:00 -04:00
|
|
|
end
|
|
|
|
|
2016-08-05 09:29:20 -04:00
|
|
|
context 'unauthenticated user' do
|
2017-08-02 15:55:11 -04:00
|
|
|
let(:public_project) { create(:project, :public) }
|
2015-03-26 22:06:19 -04:00
|
|
|
|
2016-08-05 09:29:20 -04:00
|
|
|
describe 'GET #users with public project' do
|
|
|
|
before do
|
2016-11-18 07:52:39 -05:00
|
|
|
public_project.add_guest(user)
|
2016-08-05 09:29:20 -04:00
|
|
|
get(:users, project_id: public_project.id)
|
|
|
|
end
|
2015-03-26 22:06:19 -04:00
|
|
|
|
2017-08-10 03:45:03 -04:00
|
|
|
it { expect(json_response).to be_kind_of(Array) }
|
|
|
|
it { expect(json_response.size).to eq 2 }
|
2016-08-05 09:29:20 -04:00
|
|
|
end
|
2015-07-10 20:36:24 -04:00
|
|
|
|
2016-08-05 09:29:20 -04:00
|
|
|
describe 'GET #users with project' do
|
|
|
|
before do
|
|
|
|
get(:users, project_id: project.id)
|
|
|
|
end
|
2015-07-10 20:36:24 -04:00
|
|
|
|
2017-10-19 14:28:19 -04:00
|
|
|
it { expect(response).to have_gitlab_http_status(404) }
|
2015-07-10 20:36:24 -04:00
|
|
|
end
|
|
|
|
|
2016-08-05 09:29:20 -04:00
|
|
|
describe 'GET #users with unknown project' do
|
|
|
|
before do
|
|
|
|
get(:users, project_id: 'unknown')
|
|
|
|
end
|
2015-07-10 20:36:24 -04:00
|
|
|
|
2017-10-19 14:28:19 -04:00
|
|
|
it { expect(response).to have_gitlab_http_status(404) }
|
2015-07-11 09:16:59 -04:00
|
|
|
end
|
|
|
|
|
2016-08-05 09:29:20 -04:00
|
|
|
describe 'GET #users with inaccessible group' do
|
|
|
|
before do
|
2016-11-18 07:52:39 -05:00
|
|
|
project.add_guest(user)
|
2016-08-05 09:29:20 -04:00
|
|
|
get(:users, group_id: user.namespace.id)
|
|
|
|
end
|
2015-07-11 09:16:59 -04:00
|
|
|
|
2017-10-19 14:28:19 -04:00
|
|
|
it { expect(response).to have_gitlab_http_status(404) }
|
2015-07-11 09:16:59 -04:00
|
|
|
end
|
|
|
|
|
2016-08-05 09:29:20 -04:00
|
|
|
describe 'GET #users with no project' do
|
|
|
|
before do
|
|
|
|
get(:users)
|
|
|
|
end
|
|
|
|
|
2017-08-10 03:45:03 -04:00
|
|
|
it { expect(json_response).to be_kind_of(Array) }
|
|
|
|
it { expect(json_response).to be_empty }
|
2016-08-05 09:29:20 -04:00
|
|
|
end
|
2016-11-29 04:49:43 -05:00
|
|
|
|
|
|
|
describe 'GET #users with todo filter' do
|
|
|
|
it 'gives an array of users' do
|
|
|
|
get :users, todo_filter: true
|
|
|
|
|
|
|
|
expect(response.status).to eq 200
|
2017-08-10 03:45:03 -04:00
|
|
|
expect(json_response).to be_kind_of(Array)
|
2016-11-29 04:49:43 -05:00
|
|
|
end
|
|
|
|
end
|
2015-07-11 09:16:59 -04:00
|
|
|
end
|
|
|
|
|
2016-08-05 09:29:20 -04:00
|
|
|
context 'author of issuable included' do
|
2017-06-08 12:52:27 -04:00
|
|
|
context 'authenticated' do
|
|
|
|
before do
|
|
|
|
sign_in(user)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'includes the author' do
|
|
|
|
get(:users, author_id: non_member.id)
|
|
|
|
|
2017-08-10 03:45:03 -04:00
|
|
|
expect(json_response.first["username"]).to eq non_member.username
|
2017-06-08 12:52:27 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
it 'rejects non existent user ids' do
|
|
|
|
get(:users, author_id: 99999)
|
2016-08-05 09:29:20 -04:00
|
|
|
|
2017-08-10 03:45:03 -04:00
|
|
|
expect(json_response.collect { |u| u['id'] }).not_to include(99999)
|
2017-06-08 12:52:27 -04:00
|
|
|
end
|
2015-07-10 20:36:24 -04:00
|
|
|
end
|
|
|
|
|
2017-06-08 12:52:27 -04:00
|
|
|
context 'without authenticating' do
|
|
|
|
it 'returns empty result' do
|
|
|
|
get(:users, author_id: non_member.id)
|
2016-08-05 09:29:20 -04:00
|
|
|
|
2017-08-10 03:45:03 -04:00
|
|
|
expect(json_response).to be_empty
|
2017-06-08 12:52:27 -04:00
|
|
|
end
|
2016-08-05 09:29:20 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'skip_users parameter included' do
|
2017-06-14 14:18:56 -04:00
|
|
|
before do
|
|
|
|
sign_in(user)
|
|
|
|
end
|
2016-08-05 09:29:20 -04:00
|
|
|
|
|
|
|
it 'skips the user IDs passed' do
|
|
|
|
get(:users, skip_users: [user, user2].map(&:id))
|
|
|
|
|
2017-08-10 03:45:03 -04:00
|
|
|
response_user_ids = json_response.map { |user| user['id'] }
|
2016-08-05 09:29:20 -04:00
|
|
|
|
2017-08-10 03:45:03 -04:00
|
|
|
expect(response_user_ids).to contain_exactly(non_member.id)
|
2016-08-05 09:29:20 -04:00
|
|
|
end
|
2015-07-10 20:36:24 -04:00
|
|
|
end
|
|
|
|
end
|
2016-02-09 06:02:52 -05:00
|
|
|
|
2016-11-29 06:21:50 -05:00
|
|
|
context 'GET projects' do
|
2017-08-02 15:55:11 -04:00
|
|
|
let(:authorized_project) { create(:project) }
|
|
|
|
let(:authorized_search_project) { create(:project, name: 'rugged') }
|
2016-08-05 09:29:20 -04:00
|
|
|
|
2016-02-09 06:02:52 -05:00
|
|
|
before do
|
|
|
|
sign_in(user)
|
2016-11-18 07:52:39 -05:00
|
|
|
project.add_master(user)
|
2016-02-09 06:02:52 -05:00
|
|
|
end
|
|
|
|
|
2016-08-05 09:29:20 -04:00
|
|
|
context 'authorized projects' do
|
|
|
|
before do
|
2016-11-18 07:52:39 -05:00
|
|
|
authorized_project.add_master(user)
|
2016-08-05 09:29:20 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
describe 'GET #projects with project ID' do
|
|
|
|
before do
|
|
|
|
get(:projects, project_id: project.id)
|
|
|
|
end
|
|
|
|
|
2017-08-10 03:45:03 -04:00
|
|
|
it 'returns projects' do
|
|
|
|
expect(json_response).to be_kind_of(Array)
|
2017-08-14 03:26:19 -04:00
|
|
|
expect(json_response.size).to eq(1)
|
2016-02-09 06:02:52 -05:00
|
|
|
|
2017-08-14 03:26:19 -04:00
|
|
|
expect(json_response.first['id']).to eq authorized_project.id
|
2018-03-05 11:25:52 -05:00
|
|
|
expect(json_response.first['name_with_namespace']).to eq authorized_project.full_name
|
2016-08-05 09:29:20 -04:00
|
|
|
end
|
|
|
|
end
|
2016-02-09 06:02:52 -05:00
|
|
|
end
|
2016-04-06 03:37:46 -04:00
|
|
|
|
2016-08-05 09:29:20 -04:00
|
|
|
context 'authorized projects and search' do
|
|
|
|
before do
|
2016-11-18 07:52:39 -05:00
|
|
|
authorized_project.add_master(user)
|
|
|
|
authorized_search_project.add_master(user)
|
2016-08-05 09:29:20 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
describe 'GET #projects with project ID and search' do
|
|
|
|
before do
|
|
|
|
get(:projects, project_id: project.id, search: 'rugged')
|
|
|
|
end
|
|
|
|
|
2017-08-10 03:45:03 -04:00
|
|
|
it 'returns projects' do
|
|
|
|
expect(json_response).to be_kind_of(Array)
|
2017-08-14 03:26:19 -04:00
|
|
|
expect(json_response.size).to eq(1)
|
2016-08-05 09:29:20 -04:00
|
|
|
|
2017-08-14 03:26:19 -04:00
|
|
|
expect(json_response.first['id']).to eq authorized_search_project.id
|
2018-03-05 11:25:52 -05:00
|
|
|
expect(json_response.first['name_with_namespace']).to eq authorized_search_project.full_name
|
2016-08-05 09:29:20 -04:00
|
|
|
end
|
|
|
|
end
|
2016-04-06 03:37:46 -04:00
|
|
|
end
|
2016-07-13 10:38:21 -04:00
|
|
|
|
2016-08-05 09:29:20 -04:00
|
|
|
context 'authorized projects apply limit' do
|
|
|
|
before do
|
2017-08-02 15:55:11 -04:00
|
|
|
authorized_project2 = create(:project)
|
|
|
|
authorized_project3 = create(:project)
|
2016-08-05 09:29:20 -04:00
|
|
|
|
2016-11-18 07:52:39 -05:00
|
|
|
authorized_project.add_master(user)
|
|
|
|
authorized_project2.add_master(user)
|
|
|
|
authorized_project3.add_master(user)
|
2016-08-05 09:29:20 -04:00
|
|
|
|
|
|
|
stub_const 'MoveToProjectFinder::PAGE_SIZE', 2
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'GET #projects with project ID' do
|
|
|
|
before do
|
|
|
|
get(:projects, project_id: project.id)
|
|
|
|
end
|
|
|
|
|
2017-08-10 03:45:03 -04:00
|
|
|
it 'returns projects' do
|
|
|
|
expect(json_response).to be_kind_of(Array)
|
2017-08-14 03:26:19 -04:00
|
|
|
expect(json_response.size).to eq 2 # Of a total of 3
|
2016-08-05 09:29:20 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'authorized projects with offset' do
|
|
|
|
before do
|
2017-08-02 15:55:11 -04:00
|
|
|
authorized_project2 = create(:project)
|
|
|
|
authorized_project3 = create(:project)
|
2016-08-05 09:29:20 -04:00
|
|
|
|
2016-11-18 07:52:39 -05:00
|
|
|
authorized_project.add_master(user)
|
|
|
|
authorized_project2.add_master(user)
|
|
|
|
authorized_project3.add_master(user)
|
2016-08-05 09:29:20 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
describe 'GET #projects with project ID and offset_id' do
|
|
|
|
before do
|
|
|
|
get(:projects, project_id: project.id, offset_id: authorized_project.id)
|
|
|
|
end
|
|
|
|
|
2017-08-14 03:26:19 -04:00
|
|
|
it 'returns projects' do
|
|
|
|
expect(json_response).to be_kind_of(Array)
|
|
|
|
expect(json_response.size).to eq 2 # Of a total of 3
|
2016-08-05 09:29:20 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2016-08-05 09:29:20 -04:00
|
|
|
context 'authorized projects without admin_issue ability' do
|
2017-08-10 18:31:42 -04:00
|
|
|
before do
|
2016-11-18 07:52:39 -05:00
|
|
|
authorized_project.add_guest(user)
|
2016-08-05 09:29:20 -04:00
|
|
|
|
|
|
|
expect(user.can?(:admin_issue, authorized_project)).to eq(false)
|
|
|
|
end
|
2016-07-13 10:38:21 -04:00
|
|
|
|
2016-08-05 09:29:20 -04:00
|
|
|
describe 'GET #projects with project ID' do
|
|
|
|
before do
|
|
|
|
get(:projects, project_id: project.id)
|
|
|
|
end
|
2016-07-13 10:38:21 -04:00
|
|
|
|
2017-08-14 03:26:19 -04:00
|
|
|
it 'returns no projects' do
|
2017-08-10 03:45:03 -04:00
|
|
|
expect(json_response).to be_kind_of(Array)
|
2017-08-14 03:26:19 -04:00
|
|
|
expect(json_response.size).to eq(0)
|
2016-08-05 09:29:20 -04:00
|
|
|
end
|
|
|
|
end
|
2016-07-13 10:38:21 -04:00
|
|
|
end
|
|
|
|
end
|
2017-08-30 03:48:55 -04:00
|
|
|
|
|
|
|
context 'GET award_emojis' do
|
|
|
|
let(:user2) { create(:user) }
|
|
|
|
let!(:award_emoji1) { create_list(:award_emoji, 2, user: user, name: 'thumbsup') }
|
|
|
|
let!(:award_emoji2) { create_list(:award_emoji, 1, user: user, name: 'thumbsdown') }
|
|
|
|
let!(:award_emoji3) { create_list(:award_emoji, 3, user: user, name: 'star') }
|
|
|
|
let!(:award_emoji4) { create_list(:award_emoji, 1, user: user, name: 'tea') }
|
|
|
|
|
|
|
|
context 'unauthorized user' do
|
|
|
|
it 'returns empty json' do
|
|
|
|
get :award_emojis
|
|
|
|
|
|
|
|
expect(json_response).to be_empty
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'sign in as user without award emoji' do
|
|
|
|
it 'returns empty json' do
|
|
|
|
sign_in(user2)
|
|
|
|
get :award_emojis
|
|
|
|
|
|
|
|
expect(json_response).to be_empty
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'sign in as user with award emoji' do
|
|
|
|
it 'returns json sorted by name count' do
|
|
|
|
sign_in(user)
|
|
|
|
get :award_emojis
|
|
|
|
|
|
|
|
expect(json_response.count).to eq 4
|
|
|
|
expect(json_response[0]).to match('name' => 'star')
|
|
|
|
expect(json_response[1]).to match('name' => 'thumbsup')
|
|
|
|
expect(json_response[2]).to match('name' => 'tea')
|
|
|
|
expect(json_response[3]).to match('name' => 'thumbsdown')
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2015-03-26 22:06:19 -04:00
|
|
|
end
|