gitlab-org--gitlab-foss/app/controllers/concerns/issuable_actions.rb

264 lines
7.6 KiB
Ruby
Raw Normal View History

# frozen_string_literal: true
2016-03-21 09:12:52 -04:00
module IssuableActions
extend ActiveSupport::Concern
include Gitlab::Utils::StrongMemoize
2016-03-21 09:12:52 -04:00
included do
before_action :authorize_destroy_issuable!, only: :destroy
before_action :check_destroy_confirmation!, only: :destroy
before_action :authorize_admin_issuable!, only: :bulk_update
before_action only: :show do
push_frontend_feature_flag(:scoped_labels, default_enabled: true)
end
2016-03-21 09:12:52 -04:00
end
def permitted_keys
[
:issuable_ids,
:assignee_id,
:milestone_id,
:state_event,
:subscription_event,
label_ids: [],
add_label_ids: [],
remove_label_ids: []
]
end
2017-11-01 13:35:14 -04:00
def show
respond_to do |format|
format.html do
@issuable_sidebar = serializer.represent(issuable, serializer: 'sidebar') # rubocop:disable Gitlab/ModuleWithInstanceVariables
render 'show'
end
2017-11-01 13:35:14 -04:00
format.json do
render json: serializer.represent(issuable, serializer: params[:serializer])
end
end
end
def update
@issuable = update_service.execute(issuable) # rubocop:disable Gitlab/ModuleWithInstanceVariables
2017-11-01 13:35:14 -04:00
respond_to do |format|
format.html do
recaptcha_check_if_spammable { render :edit }
2017-11-01 13:35:14 -04:00
end
format.json do
recaptcha_check_if_spammable(false) { render_entity_json }
2017-11-01 13:35:14 -04:00
end
end
rescue ActiveRecord::StaleObjectError
render_conflict_response
end
def realtime_changes
Gitlab::PollingInterval.set_header(response, interval: 3_000)
response = {
title: view_context.markdown_field(issuable, :title),
title_text: issuable.title,
description: view_context.markdown_field(issuable, :description),
description_text: issuable.description,
2018-12-20 19:19:17 -05:00
task_status: issuable.task_status,
lock_version: issuable.lock_version
2017-11-01 13:35:14 -04:00
}
if issuable.edited?
response[:updated_at] = issuable.last_edited_at.to_time.iso8601
2017-11-01 13:35:14 -04:00
response[:updated_by_name] = issuable.last_edited_by.name
response[:updated_by_path] = user_path(issuable.last_edited_by)
end
render json: response
end
2016-03-21 09:12:52 -04:00
def destroy
2017-11-29 05:27:36 -05:00
Issuable::DestroyService.new(issuable.project, current_user).execute(issuable)
2016-03-21 09:12:52 -04:00
name = issuable.human_class_name
2016-03-21 09:12:52 -04:00
flash[:notice] = "The #{name} was successfully deleted."
2017-11-02 10:51:42 -04:00
index_path = polymorphic_path([parent, issuable.class])
respond_to do |format|
format.html { redirect_to index_path }
format.json do
render json: {
web_url: index_path
}
end
end
2016-03-21 09:12:52 -04:00
end
def check_destroy_confirmation!
return true if params[:destroy_confirm]
error_message = "Destroy confirmation not provided for #{issuable.human_class_name}"
exception = RuntimeError.new(error_message)
Gitlab::ErrorTracking.track_exception(
exception,
project_path: issuable.project.full_path,
issuable_type: issuable.class.name,
issuable_id: issuable.id
)
index_path = polymorphic_path([parent, issuable.class])
respond_to do |format|
format.html do
flash[:notice] = error_message
redirect_to index_path
end
format.json do
render json: { errors: error_message }, status: :unprocessable_entity
end
end
end
def bulk_update
result = Issuable::BulkUpdateService.new(parent, current_user, bulk_update_params).execute(resource_name)
quantity = result[:count]
render json: { notice: "#{quantity} #{resource_name.pluralize(quantity)} updated" }
end
# rubocop:disable CodeReuse/ActiveRecord
def discussions
notes = NotesFinder.new(current_user, finder_params_for_issuable).execute
.inc_relations_for_view
.includes(:noteable)
.fresh
if notes_filter != UserPreference::NOTES_FILTERS[:only_comments]
notes = ResourceEvents::MergeIntoNotesService.new(issuable, current_user).execute(notes)
end
notes = prepare_notes_for_rendering(notes)
2019-08-09 08:54:57 -04:00
notes = notes.select { |n| n.visible_for?(current_user) }
discussions = Discussion.build_collection(notes, issuable)
2018-04-03 12:03:00 -04:00
render json: discussion_serializer.represent(discussions, context: self)
end
# rubocop:enable CodeReuse/ActiveRecord
2016-03-21 09:12:52 -04:00
private
def notes_filter
strong_memoize(:notes_filter) do
notes_filter_param = params[:notes_filter]&.to_i
# GitLab Geo does not expect database UPDATE or INSERT statements to happen
# on GET requests.
# This is just a fail-safe in case notes_filter is sent via GET request in GitLab Geo.
# In some cases, we also force the filter to not be persisted with the `persist_filter` param
if Gitlab::Database.read_only? || params[:persist_filter] == 'false'
notes_filter_param || current_user&.notes_filter_for(issuable)
else
notes_filter = current_user&.set_notes_filter(notes_filter_param, issuable) || notes_filter_param
# We need to invalidate the cache for polling notes otherwise it will
# ignore the filter.
# The ideal would be to invalidate the cache for each user.
issuable.expire_note_etag_cache if notes_filter_updated?
notes_filter
end
end
end
def notes_filter_updated?
current_user&.user_preference&.previous_changes&.any?
end
2018-04-03 12:03:00 -04:00
def discussion_serializer
DiscussionSerializer.new(project: project, noteable: issuable, current_user: current_user, note_entity: ProjectNoteEntity)
end
def recaptcha_check_if_spammable(should_redirect = true, &block)
2017-12-15 06:37:57 -05:00
return yield unless issuable.is_a? Spammable
recaptcha_check_with_fallback(should_redirect, &block)
end
def render_conflict_response
respond_to do |format|
format.html do
@conflict = true # rubocop:disable Gitlab/ModuleWithInstanceVariables
render :edit
end
format.json do
render json: {
errors: [
"Someone edited this #{issuable.human_class_name} at the same time you did. Please refresh your browser and make sure your changes will not unintentionally remove theirs."
]
2018-07-02 06:43:06 -04:00
}, status: :conflict
end
end
end
2016-03-21 09:12:52 -04:00
def authorize_destroy_issuable!
unless can?(current_user, :"destroy_#{issuable.to_ability_name}", issuable)
2016-03-21 09:12:52 -04:00
return access_denied!
end
end
def authorize_admin_issuable!
unless can?(current_user, :"admin_#{resource_name}", parent)
return access_denied!
end
end
2017-11-01 13:35:14 -04:00
def authorize_update_issuable!
render_404 unless can?(current_user, :"update_#{resource_name}", issuable)
end
def bulk_update_params
permitted_keys_array = permitted_keys.dup
permitted_keys_array << { assignee_ids: [] }
params.require(:update).permit(permitted_keys_array)
end
def resource_name
@resource_name ||= controller_name.singularize
end
2017-11-01 13:35:14 -04:00
# rubocop:disable Gitlab/ModuleWithInstanceVariables
2017-11-01 13:35:14 -04:00
def render_entity_json
if @issuable.valid?
render json: serializer.represent(@issuable)
else
render json: { errors: @issuable.errors.full_messages }, status: :unprocessable_entity
end
end
# rubocop:enable Gitlab/ModuleWithInstanceVariables
2017-11-01 13:35:14 -04:00
def serializer
raise NotImplementedError
end
def update_service
raise NotImplementedError
end
2017-11-02 10:51:42 -04:00
def parent
@project || @group # rubocop:disable Gitlab/ModuleWithInstanceVariables
2017-11-02 10:51:42 -04:00
end
# rubocop:disable Gitlab/ModuleWithInstanceVariables
def finder_params_for_issuable
{
target: @issuable,
notes_filter: notes_filter
2019-08-01 04:42:12 -04:00
}.tap { |new_params| new_params[:project] = project if respond_to?(:project, true) }
end
# rubocop:enable Gitlab/ModuleWithInstanceVariables
2016-03-21 09:12:52 -04:00
end
IssuableActions.prepend_if_ee('EE::IssuableActions')