2020-10-14 18:08:47 +00:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
|
|
|
require 'spec_helper'
|
|
|
|
|
2021-02-16 00:09:01 +00:00
|
|
|
RSpec.describe WhatsNewController, :clean_gitlab_redis_cache do
|
|
|
|
after do
|
|
|
|
ReleaseHighlight.instance_variable_set(:@file_paths, nil)
|
|
|
|
end
|
|
|
|
|
2020-10-14 18:08:47 +00:00
|
|
|
describe 'whats_new_path' do
|
2020-12-10 15:10:12 +00:00
|
|
|
let(:item) { double(:item) }
|
|
|
|
let(:highlights) { double(:highlight, items: [item], map: [item].map, next_page: 2) }
|
|
|
|
|
2021-01-21 09:08:52 +00:00
|
|
|
context 'with no page param' do
|
|
|
|
it 'responds with paginated data and headers' do
|
|
|
|
allow(ReleaseHighlight).to receive(:paginated).with(page: 1).and_return(highlights)
|
2020-11-24 18:09:14 +00:00
|
|
|
|
2021-01-21 09:08:52 +00:00
|
|
|
get whats_new_path, xhr: true
|
2020-11-02 09:08:35 +00:00
|
|
|
|
2021-01-21 09:08:52 +00:00
|
|
|
expect(response.body).to eq(highlights.items.to_json)
|
|
|
|
expect(response.headers['X-Next-Page']).to eq(2)
|
2020-11-02 09:08:35 +00:00
|
|
|
end
|
2021-01-21 09:08:52 +00:00
|
|
|
end
|
2020-11-02 09:08:35 +00:00
|
|
|
|
2021-01-21 09:08:52 +00:00
|
|
|
context 'with page param' do
|
|
|
|
it 'passes the page parameter' do
|
|
|
|
expect(ReleaseHighlight).to receive(:paginated).with(page: 2).and_call_original
|
2020-11-02 09:08:35 +00:00
|
|
|
|
2021-01-21 09:08:52 +00:00
|
|
|
get whats_new_path(page: 2), xhr: true
|
2020-10-14 18:08:47 +00:00
|
|
|
end
|
2020-12-10 15:10:12 +00:00
|
|
|
|
2021-01-21 09:08:52 +00:00
|
|
|
it 'returns a 404 if page param is negative' do
|
|
|
|
get whats_new_path(page: -1), xhr: true
|
2020-12-10 15:10:12 +00:00
|
|
|
|
2021-01-21 09:08:52 +00:00
|
|
|
expect(response).to have_gitlab_http_status(:not_found)
|
2020-12-10 15:10:12 +00:00
|
|
|
end
|
2020-10-14 18:08:47 +00:00
|
|
|
end
|
|
|
|
|
2021-01-21 09:08:52 +00:00
|
|
|
context 'with version param' do
|
|
|
|
it 'returns items without pagination headers' do
|
|
|
|
allow(ReleaseHighlight).to receive(:for_version).with(version: '42').and_return(highlights)
|
2020-10-14 18:08:47 +00:00
|
|
|
|
2021-01-21 09:08:52 +00:00
|
|
|
get whats_new_path(version: 42), xhr: true
|
2020-10-14 18:08:47 +00:00
|
|
|
|
2021-01-21 09:08:52 +00:00
|
|
|
expect(response.body).to eq(highlights.items.to_json)
|
|
|
|
expect(response.headers['X-Next-Page']).to be_nil
|
2020-10-14 18:08:47 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|