2020-08-25 11:10:17 -04:00
#!/usr/bin/env ruby
2021-02-12 07:09:02 -05:00
# frozen_string_literal: true
2020-08-25 11:10:17 -04:00
require 'set'
# These tests run a sanity check on the mapping file `tests.yml`
# used with the `test_file_finder` gem (`tff`) to identify matching test files.
# The verification depend on the presence of actual test files,
# so they would fail if one of the test files mentioned here is deleted.
# To minimize the chance of this test failing due to unrelated changes,
2021-04-15 14:09:01 -04:00
# the test files are chosen to be critical files that are unlikely to be deleted in a typical merge request
2020-08-25 11:10:17 -04:00
tests = [
{
explanation: 'EE code should map to respective spec',
source: 'ee/app/controllers/admin/licenses_controller.rb',
expected: ['ee/spec/controllers/admin/licenses_controller_spec.rb']
},
{
explanation: 'FOSS code should map to respective spec',
source: 'app/finders/admin/projects_finder.rb',
expected: ['spec/finders/admin/projects_finder_spec.rb']
},
{
explanation: 'EE extension should map to its EE extension spec and its FOSS class spec',
source: 'ee/app/finders/ee/projects_finder.rb',
expected: ['ee/spec/finders/ee/projects_finder_spec.rb', 'spec/finders/projects_finder_spec.rb']
},
{
2020-11-18 04:09:02 -05:00
explanation: 'Some EE extensions have specs placement that do not follow the recommendation: https://docs.gitlab.com/ee/development/ee_features.html#testing-ee-features-based-on-ce-features. `tff` should still find these misplaced specs.',
source: 'ee/app/models/ee/project.rb',
expected: ['ee/spec/models/project_spec.rb', 'spec/models/project_spec.rb']
2020-08-25 11:10:17 -04:00
},
{
explanation: 'FOSS lib should map to respective spec',
source: 'lib/gitaly/server.rb',
expected: ['spec/lib/gitaly/server_spec.rb']
},
{
explanation: 'Tooling should map to respective spec',
2021-01-13 10:10:40 -05:00
source: 'tooling/lib/tooling/helm3_client.rb',
expected: ['spec/tooling/lib/tooling/helm3_client_spec.rb']
2020-08-25 11:10:17 -04:00
},
{
explanation: 'FOSS spec code should map to itself',
source: 'spec/models/issue_spec.rb',
expected: ['spec/models/issue_spec.rb']
},
{
explanation: 'EE spec code should map to itself',
2020-11-18 04:09:02 -05:00
source: 'ee/spec/models/ee/user_spec.rb',
expected: ['ee/spec/models/ee/user_spec.rb', 'spec/models/user_spec.rb']
2020-08-25 11:10:17 -04:00
},
{
explanation: 'EE extension spec should map to itself and the FOSS class spec',
source: 'ee/spec/services/ee/notification_service_spec.rb',
expected: ['ee/spec/services/ee/notification_service_spec.rb', 'spec/services/notification_service_spec.rb']
},
{
explanation: 'FOSS factory should map to factories spec',
source: 'spec/factories/users.rb',
2022-06-15 02:08:36 -04:00
expected: ['spec/models/factories_spec.rb']
2020-08-25 11:10:17 -04:00
},
{
explanation: 'EE factory should map to factories spec',
source: 'ee/spec/factories/users.rb',
2022-06-15 02:08:36 -04:00
expected: ['spec/models/factories_spec.rb']
2020-08-25 11:10:17 -04:00
},
{
explanation: 'Initializers should map to respective spec',
source: 'config/initializers/action_mailer_hooks.rb',
expected: ['spec/initializers/action_mailer_hooks_spec.rb']
},
{
explanation: 'FOSS views should map to respective spec',
2021-06-09 20:10:09 -04:00
source: 'app/views/admin/dashboard/index.html.haml',
expected: ['spec/views/admin/dashboard/index.html.haml_spec.rb']
2020-08-25 11:10:17 -04:00
},
{
explanation: 'EE views should map to respective spec',
2021-07-19 08:10:08 -04:00
source: 'ee/app/views/subscriptions/new.html.haml',
expected: ['ee/spec/views/subscriptions/new.html.haml_spec.rb']
2020-08-25 11:10:17 -04:00
},
{
explanation: 'DB structure should map to schema spec',
source: 'db/structure.sql',
expected: ['spec/db/schema_spec.rb']
},
{
explanation: 'Migration should map to its non-timestamped spec',
2021-11-15 16:14:31 -05:00
source: 'db/migrate/20210818220234_add_default_project_approval_rules_vuln_allowed.rb',
expected: ['spec/migrations/add_default_project_approval_rules_vuln_allowed_spec.rb']
2020-08-25 11:10:17 -04:00
},
{
explanation: 'Migration should map to its timestamped spec',
2021-10-18 08:13:41 -04:00
source: 'db/post_migrate/20210915022415_cleanup_bigint_conversion_for_ci_builds.rb',
expected: ['spec/migrations/20210915022415_cleanup_bigint_conversion_for_ci_builds_spec.rb']
2021-03-01 07:11:29 -05:00
},
{
explanation: 'Whats New should map to its respective spec',
source: 'data/whats_new/202101140001_13_08.yml',
expected: ['spec/lib/release_highlights/validator_spec.rb']
2022-08-31 20:09:48 -04:00
},
{
explanation: 'Spec for every sidekiq worker',
source: 'app/workers/new_worker.rb',
expected: ['spec/workers/every_sidekiq_worker_spec.rb']
},
{
explanation: 'Known events',
source: 'lib/gitlab/usage_data_counters/known_events/common.yml',
expected: ['spec/lib/gitlab/usage_data_counters/hll_redis_counter_spec.rb', 'spec/lib/gitlab/usage_data_spec.rb']
2020-08-25 11:10:17 -04:00
}
]
class MappingTest
def initialize(explanation:, source:, expected:, mapping: 'tests.yml')
@explanation = explanation
@source = source
@mapping = mapping
@expected_set = Set.new(expected)
@actual_set = Set.new(actual)
end
def passed?
expected_set.eql?(actual_set)
end
def failed?
!passed?
end
def failure_message
"#{explanation}: #{source}: Expected #{expected_set.to_a}, got #{actual_set.to_a}."
end
private
attr_reader :explanation, :source, :expected_set, :actual_set, :mapping
def actual
`tff -f #{mapping} #{source}`.split(' ')
end
end
2022-04-08 14:08:29 -04:00
results = tests.map { |test| MappingTest.new(**test) }
2020-08-25 11:10:17 -04:00
failed_tests = results.select(&:failed?)
if failed_tests.any?
puts <<~MESSAGE
tff mapping verification failed:
#{failed_tests.map(&:failure_message).join("\n")}
MESSAGE
exit 1
end
puts 'tff mapping verification passed.'