2018-02-27 19:10:43 -05:00
|
|
|
require 'spec_helper'
|
|
|
|
|
|
|
|
describe DiscussionEntity do
|
|
|
|
include RepoHelpers
|
|
|
|
|
|
|
|
let(:user) { create(:user) }
|
|
|
|
let(:note) { create(:discussion_note_on_merge_request) }
|
|
|
|
let(:discussion) { note.discussion }
|
2018-04-03 12:03:00 -04:00
|
|
|
let(:request) { double('request', note_entity: ProjectNoteEntity) }
|
2018-02-27 19:10:43 -05:00
|
|
|
let(:controller) { double('controller') }
|
|
|
|
let(:entity) { described_class.new(discussion, request: request, context: controller) }
|
|
|
|
|
|
|
|
subject { entity.as_json }
|
|
|
|
|
|
|
|
before do
|
|
|
|
allow(controller).to receive(:render_to_string)
|
|
|
|
allow(request).to receive(:current_user).and_return(user)
|
|
|
|
allow(request).to receive(:noteable).and_return(note.noteable)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'exposes correct attributes' do
|
2018-06-21 08:22:40 -04:00
|
|
|
expect(subject.keys.sort).to include(
|
|
|
|
:diff_discussion,
|
|
|
|
:expanded,
|
|
|
|
:id,
|
|
|
|
:individual_note,
|
|
|
|
:notes,
|
|
|
|
:resolvable,
|
|
|
|
:resolve_path,
|
|
|
|
:resolve_with_issue_path,
|
|
|
|
:resolved,
|
|
|
|
:discussion_path,
|
|
|
|
:resolved_at,
|
|
|
|
:for_commit,
|
|
|
|
:commit_id
|
2018-02-27 19:10:43 -05:00
|
|
|
)
|
|
|
|
end
|
|
|
|
|
2018-10-01 09:53:08 -04:00
|
|
|
it 'resolved_by matches note_user_entity schema' do
|
|
|
|
Notes::ResolveService.new(note.project, user).execute(note)
|
|
|
|
|
|
|
|
expect(subject[:resolved_by].with_indifferent_access)
|
|
|
|
.to match_schema('entities/note_user_entity')
|
|
|
|
end
|
|
|
|
|
2018-06-27 09:54:10 -04:00
|
|
|
context 'when is LegacyDiffDiscussion' do
|
|
|
|
let(:project) { create(:project) }
|
|
|
|
let(:merge_request) { create(:merge_request, source_project: project) }
|
|
|
|
let(:discussion) { create(:legacy_diff_note_on_merge_request, noteable: merge_request, project: project).to_discussion }
|
|
|
|
|
|
|
|
it 'exposes correct attributes' do
|
|
|
|
expect(subject.keys.sort).to include(
|
|
|
|
:diff_discussion,
|
|
|
|
:expanded,
|
|
|
|
:id,
|
|
|
|
:individual_note,
|
|
|
|
:notes,
|
|
|
|
:discussion_path,
|
|
|
|
:for_commit,
|
|
|
|
:commit_id
|
|
|
|
)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2018-02-27 19:10:43 -05:00
|
|
|
context 'when diff file is present' do
|
|
|
|
let(:note) { create(:diff_note_on_merge_request) }
|
|
|
|
|
|
|
|
it 'exposes diff file attributes' do
|
2018-06-21 08:22:40 -04:00
|
|
|
expect(subject.keys.sort).to include(
|
|
|
|
:diff_file,
|
|
|
|
:truncated_diff_lines,
|
|
|
|
:position,
|
|
|
|
:line_code,
|
|
|
|
:active
|
|
|
|
)
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when diff file is a image' do
|
|
|
|
it 'exposes image attributes' do
|
|
|
|
allow(discussion).to receive(:on_image?).and_return(true)
|
|
|
|
|
|
|
|
expect(subject.keys).to include(:image_diff_html)
|
|
|
|
end
|
2018-02-27 19:10:43 -05:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|