kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity
gitlab-org--gitlab-foss/Dangerfile

16 lines
791 B
Ruby
Raw Normal View History

Create helper to get all changed files Danger apparently has three different objects which could contain files you often want to check: - git.added_files - git.modified_files - git.renamed_files The problem: If a file is renamed, `modified_files` contains the file path before the rename. In some Danger checks we use `added_files` + `modified_files`, which might contain the deleted paths of renamed files, but missing the new paths of renamed files. So we need to consider `renamed_files` as well.
2018-10-16 09:56:03 -04:00
danger.import_plugin('danger/plugins/helper.rb')
Start to use Danger for automating MR reviews Signed-off-by: Rémy Coutable <remy@rymai.me>
2018-05-21 12:41:21 -04:00
danger.import_dangerfile(path: 'danger/metadata')
danger.import_dangerfile(path: 'danger/changes_size')
danger.import_dangerfile(path: 'danger/changelog')
danger.import_dangerfile(path: 'danger/specs')
danger.import_dangerfile(path: 'danger/gemfile')
danger.import_dangerfile(path: 'danger/database')
Add Documentation Dangerfile Every time a doc change is made, a comment to ping the @gl-docsteam is added.
2018-08-27 11:26:28 -04:00
danger.import_dangerfile(path: 'danger/documentation')
Add Dangerfile for frozen_string_literal Checks that new Ruby files will enable frozen string literal. Partially addresses #47424.
2018-07-22 14:28:17 -04:00
danger.import_dangerfile(path: 'danger/frozen_string')
Added Danger file to lint commit messages This Dangerfile ensures that commit authors write good commit messages. We also prevent the use of Emoji, since these add no value and may not always be displayed properly. Merge commits are currently ignored. In the future we most likely want to stop using these, but this is a separate discussion, hence we ignore them for the time being. The rules enforced by this Dangerfile are based on the article found at https://chris.beams.io/posts/git-commit/. For more information, refer to https://gitlab.com/gitlab-org/gitlab-ce/issues/50003. Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/50003
2018-09-05 08:27:01 -04:00
danger.import_dangerfile(path: 'danger/commit_messages')
Add danger check for duplicate yarn dependencies This danger check utilises `yarn-deduplicate` in order to show duplicate dependencies in the yarn.lock dependency tree. Often when introducing new dependencies or updating existing ones, yarn does not seem to build the most optimal dependency tree. In order to prevent those unnecessary dependency updates we are nudging developers and maintainers to resolve these issues in MRs. Automating this with danger especially helps, as yarn.lock files are not that easy to review.
2018-09-07 07:20:06 -04:00
danger.import_dangerfile(path: 'danger/duplicate_yarn_dependencies')
Danger check for unprettified JavaScript This adds a Dangerfile which executes `prettier` to find out if someone touched Frontend files and forgot to run it on their current branch.
2018-09-21 11:36:26 -04:00
danger.import_dangerfile(path: 'danger/prettier')
Danger check for ignored eslint rules We disabled a lot of eslint rules on a per-file basis. This checks touched files for those and reminds you to re-enable the rules and fix them.
2018-09-21 12:26:48 -04:00
danger.import_dangerfile(path: 'danger/eslint')
Reviewer roulette via Danger Make danger pick reviewers and maintainers at random, for feontend, backend, database, etc, changes, whenever files belonging to those teams get changed.
2019-02-05 12:16:18 -05:00
danger.import_dangerfile(path: 'danger/roulette')
Set specific reviewers for single codebase effort This extends Danger so it informs MR authors that single codebase merge requests need to be approved by a specific group of engineers. Co-authored-by: Yorick Peterse <yorickpeterse@gmail.com>
2019-02-27 08:39:31 -05:00
danger.import_dangerfile(path: 'danger/single_codebase')
Copy permalink