2019-03-28 06:33:06 -04:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2015-09-30 23:50:53 -04:00
|
|
|
require 'spec_helper'
|
|
|
|
|
2020-06-24 05:08:32 -04:00
|
|
|
RSpec.describe MergeRequestsHelper do
|
2017-12-01 14:08:30 -05:00
|
|
|
include ActionView::Helpers::UrlHelper
|
2017-09-29 04:04:50 -04:00
|
|
|
include ProjectForksHelper
|
2017-12-01 14:08:30 -05:00
|
|
|
|
2019-11-22 16:06:19 -05:00
|
|
|
describe '#state_name_with_icon' do
|
|
|
|
using RSpec::Parameterized::TableSyntax
|
|
|
|
|
|
|
|
let(:merge_request) { MergeRequest.new }
|
|
|
|
|
|
|
|
where(:state, :expected_name, :expected_icon) do
|
|
|
|
:merged? | 'Merged' | 'git-merge'
|
|
|
|
:closed? | 'Closed' | 'close'
|
|
|
|
:opened? | 'Open' | 'issue-open-m'
|
|
|
|
end
|
|
|
|
|
|
|
|
with_them do
|
|
|
|
before do
|
|
|
|
allow(merge_request).to receive(state).and_return(true)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns name and icon' do
|
|
|
|
name, icon = helper.state_name_with_icon(merge_request)
|
|
|
|
|
|
|
|
expect(name).to eq(expected_name)
|
|
|
|
expect(icon).to eq(expected_icon)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2015-12-17 17:08:14 -05:00
|
|
|
describe '#format_mr_branch_names' do
|
|
|
|
describe 'within the same project' do
|
2015-09-30 23:50:53 -04:00
|
|
|
let(:merge_request) { create(:merge_request) }
|
2019-12-17 13:07:48 -05:00
|
|
|
|
2015-09-30 23:50:53 -04:00
|
|
|
subject { format_mr_branch_names(merge_request) }
|
|
|
|
|
|
|
|
it { is_expected.to eq([merge_request.source_branch, merge_request.target_branch]) }
|
|
|
|
end
|
|
|
|
|
2015-12-17 17:08:14 -05:00
|
|
|
describe 'within different projects' do
|
2017-08-02 15:55:11 -04:00
|
|
|
let(:project) { create(:project) }
|
2017-09-29 04:04:50 -04:00
|
|
|
let(:forked_project) { fork_project(project) }
|
|
|
|
let(:merge_request) { create(:merge_request, source_project: forked_project, target_project: project) }
|
2015-09-30 23:50:53 -04:00
|
|
|
subject { format_mr_branch_names(merge_request) }
|
2019-10-18 07:11:44 -04:00
|
|
|
|
2017-09-29 04:04:50 -04:00
|
|
|
let(:source_title) { "#{forked_project.full_path}:#{merge_request.source_branch}" }
|
2017-07-20 05:34:09 -04:00
|
|
|
let(:target_title) { "#{project.full_path}:#{merge_request.target_branch}" }
|
2015-09-30 23:50:53 -04:00
|
|
|
|
|
|
|
it { is_expected.to eq([source_title, target_title]) }
|
|
|
|
end
|
|
|
|
end
|
2017-12-01 14:08:30 -05:00
|
|
|
|
|
|
|
describe '#tab_link_for' do
|
|
|
|
let(:merge_request) { create(:merge_request, :simple) }
|
2020-09-02 11:10:54 -04:00
|
|
|
let(:options) { {} }
|
2017-12-01 14:08:30 -05:00
|
|
|
|
|
|
|
subject { tab_link_for(merge_request, :show, options) { 'Discussion' } }
|
|
|
|
|
|
|
|
describe 'supports the :force_link option' do
|
|
|
|
let(:options) { { force_link: true } }
|
|
|
|
|
|
|
|
it 'removes the data-toggle attributes' do
|
2018-06-30 09:17:46 -04:00
|
|
|
is_expected.not_to match(/data-toggle="tabvue"/)
|
2017-12-01 14:08:30 -05:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2021-01-04 19:10:20 -05:00
|
|
|
|
|
|
|
describe '#user_merge_requests_counts' do
|
|
|
|
let(:user) do
|
|
|
|
double(
|
|
|
|
assigned_open_merge_requests_count: 1,
|
|
|
|
review_requested_open_merge_requests_count: 2
|
|
|
|
)
|
|
|
|
end
|
|
|
|
|
|
|
|
subject { helper.user_merge_requests_counts }
|
|
|
|
|
|
|
|
before do
|
|
|
|
allow(helper).to receive(:current_user).and_return(user)
|
|
|
|
end
|
|
|
|
|
|
|
|
it "returns assigned, review requested and total merge request counts" do
|
|
|
|
expect(subject).to eq(
|
|
|
|
assigned: user.assigned_open_merge_requests_count,
|
|
|
|
review_requested: user.review_requested_open_merge_requests_count,
|
|
|
|
total: user.assigned_open_merge_requests_count + user.review_requested_open_merge_requests_count
|
|
|
|
)
|
|
|
|
end
|
|
|
|
end
|
2021-03-02 01:10:53 -05:00
|
|
|
|
|
|
|
describe '#reviewers_label' do
|
|
|
|
let(:merge_request) { build_stubbed(:merge_request) }
|
|
|
|
let(:reviewer1) { build_stubbed(:user, name: 'Jane Doe') }
|
|
|
|
let(:reviewer2) { build_stubbed(:user, name: 'John Doe') }
|
|
|
|
|
|
|
|
before do
|
|
|
|
allow(merge_request).to receive(:reviewers).and_return(reviewers)
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when multiple reviewers exist' do
|
|
|
|
let(:reviewers) { [reviewer1, reviewer2] }
|
|
|
|
|
|
|
|
it 'returns reviewer label with reviewer names' do
|
|
|
|
expect(helper.reviewers_label(merge_request)).to eq("Reviewers: Jane Doe and John Doe")
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns reviewer label only with include_value: false' do
|
|
|
|
expect(helper.reviewers_label(merge_request, include_value: false)).to eq("Reviewers")
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when the name contains a URL' do
|
|
|
|
let(:reviewers) { [build_stubbed(:user, name: 'www.gitlab.com')] }
|
|
|
|
|
|
|
|
it 'returns sanitized name' do
|
|
|
|
expect(helper.reviewers_label(merge_request)).to eq("Reviewer: www_gitlab_com")
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when one reviewer exists' do
|
|
|
|
let(:reviewers) { [reviewer1] }
|
|
|
|
|
|
|
|
it 'returns reviewer label with no names' do
|
|
|
|
expect(helper.reviewers_label(merge_request)).to eq("Reviewer: Jane Doe")
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns reviewer label only with include_value: false' do
|
|
|
|
expect(helper.reviewers_label(merge_request, include_value: false)).to eq("Reviewer")
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when no reviewers exist' do
|
|
|
|
let(:reviewers) { [] }
|
|
|
|
|
|
|
|
it 'returns reviewer label with no names' do
|
|
|
|
expect(helper.reviewers_label(merge_request)).to eq("Reviewers: ")
|
|
|
|
end
|
|
|
|
it 'returns reviewer label only with include_value: false' do
|
|
|
|
expect(helper.reviewers_label(merge_request, include_value: false)).to eq("Reviewers")
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2015-09-30 23:50:53 -04:00
|
|
|
end
|