2015-05-23 23:34:03 -04:00
|
|
|
require 'spec_helper'
|
|
|
|
|
|
|
|
describe BlobHelper do
|
2016-07-30 00:04:04 -04:00
|
|
|
include TreeHelper
|
|
|
|
|
2016-01-19 08:52:41 -05:00
|
|
|
describe '#highlight' do
|
2018-09-11 00:37:44 -04:00
|
|
|
it 'wraps highlighted content' do
|
|
|
|
expect(helper.highlight('test.rb', '52')).to eq(%q[<pre class="code highlight"><code><span id="LC1" class="line" lang="ruby"><span class="mi">52</span></span></code></pre>])
|
2018-01-15 10:00:58 -05:00
|
|
|
end
|
|
|
|
|
2018-09-11 00:37:44 -04:00
|
|
|
it 'handles plain version' do
|
|
|
|
expect(helper.highlight('test.rb', '52', plain: true)).to eq(%q[<pre class="code highlight"><code><span id="LC1" class="line" lang="">52</span></code></pre>])
|
2015-08-10 02:08:28 -04:00
|
|
|
end
|
2015-05-23 23:34:03 -04:00
|
|
|
end
|
2016-01-19 08:52:41 -05:00
|
|
|
|
2017-04-20 19:01:47 -04:00
|
|
|
describe "#sanitize_svg_data" do
|
2016-03-25 01:39:58 -04:00
|
|
|
let(:input_svg_path) { File.join(Rails.root, 'spec', 'fixtures', 'unsanitized.svg') }
|
2018-07-02 09:57:38 -04:00
|
|
|
let(:data) { File.read(input_svg_path) }
|
2016-03-25 01:39:58 -04:00
|
|
|
let(:expected_svg_path) { File.join(Rails.root, 'spec', 'fixtures', 'sanitized.svg') }
|
2018-07-02 09:57:38 -04:00
|
|
|
let(:expected) { File.read(expected_svg_path) }
|
2016-03-25 01:39:58 -04:00
|
|
|
|
2016-07-25 14:16:19 -04:00
|
|
|
it 'retains essential elements' do
|
2017-04-20 19:01:47 -04:00
|
|
|
expect(sanitize_svg_data(data)).to eq(expected)
|
2016-03-25 01:39:58 -04:00
|
|
|
end
|
|
|
|
end
|
2016-07-30 00:04:04 -04:00
|
|
|
|
2018-02-23 10:52:18 -05:00
|
|
|
describe "#edit_blob_link" do
|
2016-08-17 11:05:00 -04:00
|
|
|
let(:namespace) { create(:namespace, name: 'gitlab' )}
|
2017-01-25 17:10:32 -05:00
|
|
|
let(:project) { create(:project, :repository, namespace: namespace) }
|
2016-07-30 00:04:04 -04:00
|
|
|
|
|
|
|
before do
|
2017-04-06 12:36:38 -04:00
|
|
|
allow(self).to receive(:current_user).and_return(nil)
|
2016-08-17 11:05:00 -04:00
|
|
|
allow(self).to receive(:can_collaborate_with_project?).and_return(true)
|
2016-07-30 00:04:04 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
it 'verifies blob is text' do
|
2016-08-17 11:05:00 -04:00
|
|
|
expect(helper).not_to receive(:blob_text_viewable?)
|
2016-07-30 00:04:04 -04:00
|
|
|
|
2018-02-22 07:54:19 -05:00
|
|
|
button = edit_blob_button(project, 'refs/heads/master', 'README.md')
|
2016-07-30 00:04:04 -04:00
|
|
|
|
|
|
|
expect(button).to start_with('<button')
|
|
|
|
end
|
2016-08-17 11:05:00 -04:00
|
|
|
|
|
|
|
it 'uses the passed blob instead retrieve from repository' do
|
|
|
|
blob = project.repository.blob_at('refs/heads/master', 'README.md')
|
|
|
|
|
|
|
|
expect(project.repository).not_to receive(:blob_at)
|
|
|
|
|
2018-02-22 07:54:19 -05:00
|
|
|
edit_blob_button(project, 'refs/heads/master', 'README.md', blob: blob)
|
2016-08-17 11:05:00 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns a link with the proper route' do
|
2019-02-12 12:29:22 -05:00
|
|
|
stub_feature_flags(web_ide_default: false)
|
2018-02-22 07:54:19 -05:00
|
|
|
link = edit_blob_button(project, 'master', 'README.md')
|
2016-08-17 11:05:00 -04:00
|
|
|
|
2017-08-22 19:19:35 -04:00
|
|
|
expect(Capybara.string(link).find_link('Edit')[:href]).to eq("/#{project.full_path}/edit/master/README.md")
|
2016-08-17 11:05:00 -04:00
|
|
|
end
|
|
|
|
|
2019-02-12 12:29:22 -05:00
|
|
|
it 'returns a link with a Web IDE route' do
|
|
|
|
link = edit_blob_button(project, 'master', 'README.md')
|
|
|
|
|
|
|
|
expect(Capybara.string(link).find_link('Edit')[:href]).to eq("/-/ide/project/#{project.full_path}/edit/master/-/README.md")
|
|
|
|
end
|
|
|
|
|
2016-08-17 11:05:00 -04:00
|
|
|
it 'returns a link with the passed link_opts on the expected route' do
|
2019-02-12 12:29:22 -05:00
|
|
|
stub_feature_flags(web_ide_default: false)
|
2018-02-22 07:54:19 -05:00
|
|
|
link = edit_blob_button(project, 'master', 'README.md', link_opts: { mr_id: 10 })
|
2016-08-17 11:05:00 -04:00
|
|
|
|
2017-08-22 19:19:35 -04:00
|
|
|
expect(Capybara.string(link).find_link('Edit')[:href]).to eq("/#{project.full_path}/edit/master/README.md?mr_id=10")
|
2016-08-17 11:05:00 -04:00
|
|
|
end
|
2016-07-30 00:04:04 -04:00
|
|
|
end
|
2017-04-25 16:22:56 -04:00
|
|
|
|
|
|
|
context 'viewer related' do
|
|
|
|
include FakeBlobHelpers
|
|
|
|
|
2017-08-02 15:55:11 -04:00
|
|
|
let(:project) { build(:project, lfs_enabled: true) }
|
2017-04-26 16:48:49 -04:00
|
|
|
|
|
|
|
before do
|
|
|
|
allow(Gitlab.config.lfs).to receive(:enabled).and_return(true)
|
|
|
|
end
|
2017-04-25 16:22:56 -04:00
|
|
|
|
|
|
|
let(:viewer_class) do
|
|
|
|
Class.new(BlobViewer::Base) do
|
2017-05-12 15:43:06 -04:00
|
|
|
include BlobViewer::ServerSide
|
|
|
|
|
2017-05-26 19:27:30 -04:00
|
|
|
self.collapse_limit = 1.megabyte
|
|
|
|
self.size_limit = 5.megabytes
|
2017-04-25 16:22:56 -04:00
|
|
|
self.type = :rich
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
let(:viewer) { viewer_class.new(blob) }
|
|
|
|
let(:blob) { fake_blob }
|
|
|
|
|
|
|
|
describe '#blob_render_error_reason' do
|
|
|
|
context 'for error :too_large' do
|
2017-05-26 19:27:30 -04:00
|
|
|
context 'when the blob size is larger than the absolute size limit' do
|
2017-04-25 16:22:56 -04:00
|
|
|
let(:blob) { fake_blob(size: 10.megabytes) }
|
|
|
|
|
|
|
|
it 'returns an error message' do
|
2017-04-26 16:48:49 -04:00
|
|
|
expect(helper.blob_render_error_reason(viewer)).to eq('it is larger than 5 MB')
|
2017-04-25 16:22:56 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2017-05-26 19:27:30 -04:00
|
|
|
context 'when the blob size is larger than the size limit' do
|
2017-04-25 16:22:56 -04:00
|
|
|
let(:blob) { fake_blob(size: 2.megabytes) }
|
|
|
|
|
|
|
|
it 'returns an error message' do
|
2017-04-26 16:48:49 -04:00
|
|
|
expect(helper.blob_render_error_reason(viewer)).to eq('it is larger than 1 MB')
|
2017-04-25 16:22:56 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2017-05-02 18:45:50 -04:00
|
|
|
context 'for error :server_side_but_stored_externally' do
|
2017-04-26 16:48:49 -04:00
|
|
|
let(:blob) { fake_blob(lfs: true) }
|
|
|
|
|
2017-04-25 16:22:56 -04:00
|
|
|
it 'returns an error message' do
|
2017-04-26 16:48:49 -04:00
|
|
|
expect(helper.blob_render_error_reason(viewer)).to eq('it is stored in LFS')
|
2017-04-25 16:22:56 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#blob_render_error_options' do
|
2017-04-26 16:48:49 -04:00
|
|
|
before do
|
|
|
|
assign(:project, project)
|
2017-04-13 12:47:28 -04:00
|
|
|
assign(:blob, blob)
|
2017-04-26 16:48:49 -04:00
|
|
|
assign(:id, File.join('master', blob.path))
|
|
|
|
|
|
|
|
controller.params[:controller] = 'projects/blob'
|
|
|
|
controller.params[:action] = 'show'
|
|
|
|
controller.params[:namespace_id] = project.namespace.to_param
|
|
|
|
controller.params[:project_id] = project.to_param
|
|
|
|
controller.params[:id] = File.join('master', blob.path)
|
|
|
|
end
|
|
|
|
|
2017-05-30 22:48:30 -04:00
|
|
|
context 'for error :collapsed' do
|
|
|
|
let(:blob) { fake_blob(size: 2.megabytes) }
|
2017-04-25 16:22:56 -04:00
|
|
|
|
2017-05-30 22:48:30 -04:00
|
|
|
it 'includes a "load it anyway" link' do
|
|
|
|
expect(helper.blob_render_error_options(viewer)).to include(/load it anyway/)
|
2017-04-25 16:22:56 -04:00
|
|
|
end
|
2017-05-30 22:48:30 -04:00
|
|
|
end
|
2017-04-25 16:22:56 -04:00
|
|
|
|
2017-05-30 22:48:30 -04:00
|
|
|
context 'for error :too_large' do
|
|
|
|
let(:blob) { fake_blob(size: 10.megabytes) }
|
2017-04-25 16:22:56 -04:00
|
|
|
|
2017-05-30 22:48:30 -04:00
|
|
|
it 'does not include a "load it anyway" link' do
|
|
|
|
expect(helper.blob_render_error_options(viewer)).not_to include(/load it anyway/)
|
2017-04-25 16:22:56 -04:00
|
|
|
end
|
|
|
|
|
2017-05-02 18:45:50 -04:00
|
|
|
context 'when the viewer is rich' do
|
|
|
|
context 'the blob is rendered as text' do
|
|
|
|
let(:blob) { fake_blob(path: 'file.md', size: 2.megabytes) }
|
|
|
|
|
|
|
|
it 'includes a "view the source" link' do
|
|
|
|
expect(helper.blob_render_error_options(viewer)).to include(/view the source/)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'the blob is not rendered as text' do
|
|
|
|
let(:blob) { fake_blob(path: 'file.pdf', binary: true, size: 2.megabytes) }
|
2017-04-25 16:22:56 -04:00
|
|
|
|
2017-05-02 18:45:50 -04:00
|
|
|
it 'does not include a "view the source" link' do
|
|
|
|
expect(helper.blob_render_error_options(viewer)).not_to include(/view the source/)
|
|
|
|
end
|
2017-04-25 16:22:56 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2017-05-02 18:45:50 -04:00
|
|
|
context 'when the viewer is not rich' do
|
|
|
|
before do
|
|
|
|
viewer_class.type = :simple
|
|
|
|
end
|
|
|
|
|
|
|
|
let(:blob) { fake_blob(path: 'file.md', size: 2.megabytes) }
|
2017-04-25 16:22:56 -04:00
|
|
|
|
|
|
|
it 'does not include a "view the source" link' do
|
2017-04-26 16:48:49 -04:00
|
|
|
expect(helper.blob_render_error_options(viewer)).not_to include(/view the source/)
|
2017-04-25 16:22:56 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2017-05-02 18:45:50 -04:00
|
|
|
it 'includes a "download it" link' do
|
|
|
|
expect(helper.blob_render_error_options(viewer)).to include(/download it/)
|
2017-04-25 16:22:56 -04:00
|
|
|
end
|
2017-05-02 18:45:50 -04:00
|
|
|
end
|
2017-04-25 16:22:56 -04:00
|
|
|
|
2017-05-02 18:45:50 -04:00
|
|
|
context 'for error :server_side_but_stored_externally' do
|
2017-04-26 16:48:49 -04:00
|
|
|
let(:blob) { fake_blob(path: 'file.md', lfs: true) }
|
2017-04-25 16:22:56 -04:00
|
|
|
|
2017-05-02 18:45:50 -04:00
|
|
|
it 'does not include a "load it anyway" link' do
|
|
|
|
expect(helper.blob_render_error_options(viewer)).not_to include(/load it anyway/)
|
|
|
|
end
|
|
|
|
|
2017-04-25 16:22:56 -04:00
|
|
|
it 'does not include a "view the source" link' do
|
2017-04-26 16:48:49 -04:00
|
|
|
expect(helper.blob_render_error_options(viewer)).not_to include(/view the source/)
|
2017-04-25 16:22:56 -04:00
|
|
|
end
|
|
|
|
|
2017-05-02 18:45:50 -04:00
|
|
|
it 'includes a "download it" link' do
|
|
|
|
expect(helper.blob_render_error_options(viewer)).to include(/download it/)
|
|
|
|
end
|
2017-04-25 16:22:56 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2018-04-25 09:48:21 -04:00
|
|
|
|
|
|
|
describe '#ide_edit_path' do
|
|
|
|
let(:project) { create(:project) }
|
|
|
|
|
2018-04-25 13:34:48 -04:00
|
|
|
around do |example|
|
|
|
|
old_script_name = Rails.application.routes.default_url_options[:script_name]
|
2018-04-25 12:27:18 -04:00
|
|
|
begin
|
|
|
|
example.run
|
|
|
|
ensure
|
|
|
|
Rails.application.routes.default_url_options[:script_name] = old_script_name
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2018-04-25 09:48:21 -04:00
|
|
|
it 'returns full IDE path' do
|
2018-04-25 12:27:18 -04:00
|
|
|
Rails.application.routes.default_url_options[:script_name] = nil
|
|
|
|
|
2018-05-23 05:36:41 -04:00
|
|
|
expect(helper.ide_edit_path(project, "master", "")).to eq("/-/ide/project/#{project.namespace.path}/#{project.path}/edit/master")
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns full IDE path with second -' do
|
|
|
|
Rails.application.routes.default_url_options[:script_name] = nil
|
|
|
|
|
|
|
|
expect(helper.ide_edit_path(project, "testing/slashes", "readme.md")).to eq("/-/ide/project/#{project.namespace.path}/#{project.path}/edit/testing/slashes/-/readme.md")
|
2018-04-25 09:48:21 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns IDE path without relative_url_root' do
|
|
|
|
Rails.application.routes.default_url_options[:script_name] = "/gitlab"
|
|
|
|
|
2018-05-23 05:36:41 -04:00
|
|
|
expect(helper.ide_edit_path(project, "master", "")).to eq("/gitlab/-/ide/project/#{project.namespace.path}/#{project.path}/edit/master")
|
2018-04-25 09:48:21 -04:00
|
|
|
end
|
2019-04-03 07:38:46 -04:00
|
|
|
|
|
|
|
it 'escapes special characters' do
|
|
|
|
Rails.application.routes.default_url_options[:script_name] = nil
|
|
|
|
|
|
|
|
expect(helper.ide_edit_path(project, "testing/#hashes", "readme.md#test")).to eq("/-/ide/project/#{project.namespace.path}/#{project.path}/edit/testing/#hashes/-/readme.md%23test")
|
|
|
|
expect(helper.ide_edit_path(project, "testing/#hashes", "src#/readme.md#test")).to eq("/-/ide/project/#{project.namespace.path}/#{project.path}/edit/testing/#hashes/-/src%23/readme.md%23test")
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not escape "/" character' do
|
|
|
|
Rails.application.routes.default_url_options[:script_name] = nil
|
|
|
|
|
|
|
|
expect(helper.ide_edit_path(project, "testing/slashes", "readme.md/")).to eq("/-/ide/project/#{project.namespace.path}/#{project.path}/edit/testing/slashes/-/readme.md/")
|
|
|
|
end
|
2018-04-25 09:48:21 -04:00
|
|
|
end
|
2015-05-23 23:34:03 -04:00
|
|
|
end
|