kotovalexarian-likes-gitlab
/
gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity
gitlab-org--gitlab-foss/spec/support/json_response_helpers.rb

10 lines
268 B
Ruby
Raw Normal View History

Implement `json_response` as a `let` variable This is not a good idea to memoize `json_response` using an instance variable because `rspec-retry` doesn't clear instance variables on retries, only `let` variables. This will avoid issues where retries would fail on a different line that the original failure, blurrying what's the real failure. Also, automatically add api: true to specs under /spec/requests/(ci/)?api/, and include JsonHelpers in controller, request and API specs. Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-03-08 23:41:02 +00:00
shared_context 'JSON response' do
let(:json_response) { JSON.parse(response.body) }
end
RSpec.configure do |config|
Remove superfluous type defs in specs Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-06-29 04:13:10 +00:00
config.include_context 'JSON response'
Implement `json_response` as a `let` variable This is not a good idea to memoize `json_response` using an instance variable because `rspec-retry` doesn't clear instance variables on retries, only `let` variables. This will avoid issues where retries would fail on a different line that the original failure, blurrying what's the real failure. Also, automatically add api: true to specs under /spec/requests/(ci/)?api/, and include JsonHelpers in controller, request and API specs. Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-03-08 23:41:02 +00:00
config.include_context 'JSON response', type: :request
config.include_context 'JSON response', :api
end