2019-04-11 12:17:24 +00:00
|
|
|
|
# frozen_string_literal: true
|
|
|
|
|
|
2016-03-16 22:44:33 +00:00
|
|
|
|
require 'spec_helper'
|
|
|
|
|
|
2017-07-10 14:24:02 +00:00
|
|
|
|
describe Groups::CreateService, '#execute' do
|
2016-12-26 09:56:19 +00:00
|
|
|
|
let!(:user) { create(:user) }
|
2016-03-18 12:28:16 +00:00
|
|
|
|
let!(:group_params) { { path: "group_path", visibility_level: Gitlab::VisibilityLevel::PUBLIC } }
|
2016-03-16 22:44:33 +00:00
|
|
|
|
|
2017-02-03 10:29:56 +00:00
|
|
|
|
subject { service.execute }
|
|
|
|
|
|
2016-12-26 09:56:19 +00:00
|
|
|
|
describe 'visibility level restrictions' do
|
|
|
|
|
let!(:service) { described_class.new(user, group_params) }
|
|
|
|
|
|
2016-03-16 22:44:33 +00:00
|
|
|
|
context "create groups without restricted visibility level" do
|
2016-03-17 22:42:46 +00:00
|
|
|
|
it { is_expected.to be_persisted }
|
2016-03-16 22:44:33 +00:00
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
context "cannot create group with restricted visibility level" do
|
2017-06-14 18:18:56 +00:00
|
|
|
|
before do
|
|
|
|
|
allow_any_instance_of(ApplicationSetting).to receive(:restricted_visibility_levels).and_return([Gitlab::VisibilityLevel::PUBLIC])
|
|
|
|
|
end
|
2016-12-26 09:56:19 +00:00
|
|
|
|
|
2016-05-23 23:37:59 +00:00
|
|
|
|
it { is_expected.not_to be_persisted }
|
2016-03-16 22:44:33 +00:00
|
|
|
|
end
|
|
|
|
|
end
|
2016-12-26 09:56:19 +00:00
|
|
|
|
|
2020-04-24 09:09:44 +00:00
|
|
|
|
context 'creating a group with `default_branch_protection` attribute' do
|
|
|
|
|
let(:params) { group_params.merge(default_branch_protection: Gitlab::Access::PROTECTION_NONE) }
|
|
|
|
|
let(:service) { described_class.new(user, params) }
|
|
|
|
|
let(:created_group) { service.execute }
|
|
|
|
|
|
|
|
|
|
context 'for users who have the ability to create a group with `default_branch_protection`' do
|
|
|
|
|
it 'creates group with the specified branch protection level' do
|
|
|
|
|
expect(created_group.default_branch_protection).to eq(Gitlab::Access::PROTECTION_NONE)
|
|
|
|
|
end
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
context 'for users who do not have the ability to create a group with `default_branch_protection`' do
|
|
|
|
|
it 'does not create the group with the specified branch protection level' do
|
|
|
|
|
allow(Ability).to receive(:allowed?).and_call_original
|
|
|
|
|
allow(Ability).to receive(:allowed?).with(user, :create_group_with_default_branch_protection) { false }
|
|
|
|
|
|
|
|
|
|
expect(created_group.default_branch_protection).not_to eq(Gitlab::Access::PROTECTION_NONE)
|
|
|
|
|
end
|
|
|
|
|
end
|
|
|
|
|
end
|
|
|
|
|
|
2017-09-07 18:35:45 +00:00
|
|
|
|
describe 'creating a top level group' do
|
|
|
|
|
let(:service) { described_class.new(user, group_params) }
|
|
|
|
|
|
|
|
|
|
context 'when user can create a group' do
|
|
|
|
|
before do
|
|
|
|
|
user.update_attribute(:can_create_group, true)
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
it { is_expected.to be_persisted }
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
context 'when user can not create a group' do
|
|
|
|
|
before do
|
|
|
|
|
user.update_attribute(:can_create_group, false)
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
it { is_expected.not_to be_persisted }
|
|
|
|
|
end
|
|
|
|
|
end
|
|
|
|
|
|
2019-07-24 09:20:54 +00:00
|
|
|
|
describe 'creating subgroup' do
|
2016-12-26 09:56:19 +00:00
|
|
|
|
let!(:group) { create(:group) }
|
|
|
|
|
let!(:service) { described_class.new(user, group_params.merge(parent_id: group.id)) }
|
|
|
|
|
|
|
|
|
|
context 'as group owner' do
|
2017-06-14 18:18:56 +00:00
|
|
|
|
before do
|
|
|
|
|
group.add_owner(user)
|
|
|
|
|
end
|
2016-12-26 09:56:19 +00:00
|
|
|
|
|
|
|
|
|
it { is_expected.to be_persisted }
|
2019-07-24 09:20:54 +00:00
|
|
|
|
end
|
2017-08-09 10:58:00 +00:00
|
|
|
|
|
2019-07-24 09:20:54 +00:00
|
|
|
|
context 'as guest' do
|
|
|
|
|
it 'does not save group and returns an error' do
|
|
|
|
|
is_expected.not_to be_persisted
|
2017-08-09 10:58:00 +00:00
|
|
|
|
|
2019-12-12 12:07:33 +00:00
|
|
|
|
expect(subject.errors[:parent_id].first).to eq(s_('CreateGroup|You don’t have permission to create a subgroup in this group.'))
|
2019-07-24 09:20:54 +00:00
|
|
|
|
expect(subject.parent_id).to be_nil
|
2017-08-09 10:58:00 +00:00
|
|
|
|
end
|
2016-12-26 09:56:19 +00:00
|
|
|
|
end
|
|
|
|
|
|
2019-07-24 09:20:54 +00:00
|
|
|
|
context 'as owner' do
|
2017-09-07 18:35:45 +00:00
|
|
|
|
before do
|
2019-07-24 09:20:54 +00:00
|
|
|
|
group.add_owner(user)
|
2017-09-07 18:35:45 +00:00
|
|
|
|
end
|
|
|
|
|
|
2019-07-24 09:20:54 +00:00
|
|
|
|
it { is_expected.to be_persisted }
|
|
|
|
|
end
|
2017-08-09 10:58:00 +00:00
|
|
|
|
|
2019-07-24 09:20:54 +00:00
|
|
|
|
context 'as maintainer' do
|
|
|
|
|
before do
|
|
|
|
|
group.add_maintainer(user)
|
2016-12-26 09:56:19 +00:00
|
|
|
|
end
|
2019-06-16 18:07:17 +00:00
|
|
|
|
|
2019-07-24 09:20:54 +00:00
|
|
|
|
it { is_expected.to be_persisted }
|
2016-12-26 09:56:19 +00:00
|
|
|
|
end
|
|
|
|
|
end
|
2017-02-03 10:29:56 +00:00
|
|
|
|
|
2019-04-12 05:00:50 +00:00
|
|
|
|
describe "when visibility level is passed as a string" do
|
|
|
|
|
let(:service) { described_class.new(user, group_params) }
|
|
|
|
|
let(:group_params) { { path: 'group_path', visibility: 'public' } }
|
|
|
|
|
|
|
|
|
|
it "assigns the correct visibility level" do
|
|
|
|
|
group = service.execute
|
|
|
|
|
|
|
|
|
|
expect(group.visibility_level).to eq(Gitlab::VisibilityLevel::PUBLIC)
|
|
|
|
|
end
|
|
|
|
|
end
|
|
|
|
|
|
2017-02-03 10:29:56 +00:00
|
|
|
|
describe 'creating a mattermost team' do
|
2017-02-24 12:25:42 +00:00
|
|
|
|
let!(:params) { group_params.merge(create_chat_team: "true") }
|
2017-02-03 10:29:56 +00:00
|
|
|
|
let!(:service) { described_class.new(user, params) }
|
|
|
|
|
|
2017-02-24 12:25:42 +00:00
|
|
|
|
before do
|
2017-03-28 12:12:32 +00:00
|
|
|
|
stub_mattermost_setting(enabled: true)
|
2017-02-24 12:25:42 +00:00
|
|
|
|
end
|
|
|
|
|
|
2017-02-20 12:41:50 +00:00
|
|
|
|
it 'create the chat team with the group' do
|
|
|
|
|
allow_any_instance_of(Mattermost::Team).to receive(:create)
|
|
|
|
|
.and_return({ 'name' => 'tanuki', 'id' => 'lskdjfwlekfjsdifjj' })
|
|
|
|
|
|
|
|
|
|
expect { subject }.to change { ChatTeam.count }.from(0).to(1)
|
|
|
|
|
end
|
2017-02-03 10:29:56 +00:00
|
|
|
|
end
|
2016-03-16 22:44:33 +00:00
|
|
|
|
end
|