2016-09-16 11:02:42 +00:00
|
|
|
require 'spec_helper'
|
|
|
|
|
|
|
|
feature 'Check if mergeable with unresolved discussions', js: true, feature: true do
|
2016-10-26 17:19:17 +00:00
|
|
|
let(:user) { create(:user) }
|
|
|
|
let(:project) { create(:project) }
|
|
|
|
let!(:merge_request) { create(:merge_request_with_diff_notes, source_project: project, author: user) }
|
2016-09-16 11:02:42 +00:00
|
|
|
|
|
|
|
before do
|
|
|
|
login_as user
|
|
|
|
project.team << [user, :master]
|
|
|
|
end
|
|
|
|
|
2016-10-26 17:19:17 +00:00
|
|
|
context 'when project.only_allow_merge_if_all_discussions_are_resolved == true' do
|
|
|
|
before do
|
|
|
|
project.update_column(:only_allow_merge_if_all_discussions_are_resolved, true)
|
2016-09-16 11:02:42 +00:00
|
|
|
end
|
|
|
|
|
2016-10-26 17:19:17 +00:00
|
|
|
context 'with unresolved discussions' do
|
|
|
|
it 'does not allow to merge' do
|
|
|
|
visit_merge_request(merge_request)
|
2016-09-16 11:02:42 +00:00
|
|
|
|
2016-10-26 17:19:17 +00:00
|
|
|
expect(page).not_to have_button 'Accept Merge Request'
|
|
|
|
expect(page).to have_content('This merge request has unresolved discussions')
|
|
|
|
end
|
|
|
|
end
|
2016-09-16 11:02:42 +00:00
|
|
|
|
2016-10-26 17:19:17 +00:00
|
|
|
context 'with all discussions resolved' do
|
2016-09-16 11:02:42 +00:00
|
|
|
before do
|
|
|
|
merge_request.discussions.each { |d| d.resolve!(user) }
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'allows MR to be merged' do
|
|
|
|
visit_merge_request(merge_request)
|
|
|
|
|
|
|
|
expect(page).to have_button 'Accept Merge Request'
|
|
|
|
end
|
|
|
|
end
|
2016-10-26 17:19:17 +00:00
|
|
|
end
|
2016-09-16 11:02:42 +00:00
|
|
|
|
2016-10-26 17:19:17 +00:00
|
|
|
context 'when project.only_allow_merge_if_all_discussions_are_resolved == false' do
|
|
|
|
before do
|
|
|
|
project.update_column(:only_allow_merge_if_all_discussions_are_resolved, false)
|
|
|
|
end
|
2016-09-16 11:02:42 +00:00
|
|
|
|
2016-10-26 17:19:17 +00:00
|
|
|
context 'with unresolved discussions' do
|
2016-09-16 11:02:42 +00:00
|
|
|
it 'does not allow to merge' do
|
|
|
|
visit_merge_request(merge_request)
|
|
|
|
|
2016-10-26 17:19:17 +00:00
|
|
|
expect(page).to have_button 'Accept Merge Request'
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'with all discussions resolved' do
|
|
|
|
before do
|
|
|
|
merge_request.discussions.each { |d| d.resolve!(user) }
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'allows MR to be merged' do
|
|
|
|
visit_merge_request(merge_request)
|
|
|
|
|
|
|
|
expect(page).to have_button 'Accept Merge Request'
|
2016-09-16 11:02:42 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
def visit_merge_request(merge_request)
|
|
|
|
visit namespace_project_merge_request_path(merge_request.project.namespace, merge_request.project, merge_request)
|
|
|
|
end
|
|
|
|
end
|