2014-10-29 13:46:42 +00:00
|
|
|
require 'spec_helper'
|
|
|
|
|
2015-12-17 22:08:14 +00:00
|
|
|
describe Mentionable do
|
2016-09-29 14:28:45 +00:00
|
|
|
class Example
|
|
|
|
include Mentionable
|
2015-12-17 22:08:14 +00:00
|
|
|
|
2016-09-29 14:28:45 +00:00
|
|
|
attr_accessor :project, :message
|
|
|
|
attr_mentionable :message
|
|
|
|
|
|
|
|
def author
|
|
|
|
nil
|
|
|
|
end
|
2015-12-24 19:34:13 +00:00
|
|
|
end
|
|
|
|
|
2016-07-11 22:12:31 +00:00
|
|
|
describe 'references' do
|
2017-01-26 22:44:58 +00:00
|
|
|
let(:project) { create(:empty_project) }
|
2016-09-29 14:28:45 +00:00
|
|
|
let(:mentionable) { Example.new }
|
2015-12-17 22:08:14 +00:00
|
|
|
|
|
|
|
it 'excludes JIRA references' do
|
|
|
|
allow(project).to receive_messages(jira_tracker?: true)
|
2016-09-29 14:28:45 +00:00
|
|
|
|
|
|
|
mentionable.project = project
|
|
|
|
mentionable.message = 'JIRA-123'
|
|
|
|
expect(mentionable.referenced_mentionables).to be_empty
|
2015-12-17 22:08:14 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2014-10-29 13:46:42 +00:00
|
|
|
describe Issue, "Mentionable" do
|
2015-06-08 22:13:14 +00:00
|
|
|
describe '#mentioned_users' do
|
2014-10-29 13:46:42 +00:00
|
|
|
let!(:user) { create(:user, username: 'stranger') }
|
|
|
|
let!(:user2) { create(:user, username: 'john') }
|
2017-01-18 23:37:55 +00:00
|
|
|
let!(:user3) { create(:user, username: 'jim') }
|
|
|
|
let(:issue) { create(:issue, description: "#{user.to_reference} mentioned") }
|
2014-10-29 13:46:42 +00:00
|
|
|
|
|
|
|
subject { issue.mentioned_users }
|
|
|
|
|
2017-01-20 10:28:40 +00:00
|
|
|
it { expect(subject).to contain_exactly(user) }
|
2017-01-18 23:37:55 +00:00
|
|
|
|
|
|
|
context 'when a note on personal snippet' do
|
|
|
|
let!(:note) { create(:note_on_personal_snippet, note: "#{user.to_reference} mentioned #{user3.to_reference}") }
|
|
|
|
|
|
|
|
subject { note.mentioned_users }
|
|
|
|
|
2017-01-20 10:28:40 +00:00
|
|
|
it { expect(subject).to contain_exactly(user, user3) }
|
2017-01-18 23:37:55 +00:00
|
|
|
end
|
2014-10-29 13:46:42 +00:00
|
|
|
end
|
2015-06-08 22:13:14 +00:00
|
|
|
|
2016-06-27 12:24:08 +00:00
|
|
|
describe '#referenced_mentionables' do
|
|
|
|
context 'with an issue on a private project' do
|
|
|
|
let(:project) { create(:empty_project, :public) }
|
|
|
|
let(:issue) { create(:issue, project: project) }
|
|
|
|
let(:public_issue) { create(:issue, project: project) }
|
|
|
|
let(:private_project) { create(:empty_project, :private) }
|
|
|
|
let(:private_issue) { create(:issue, project: private_project) }
|
|
|
|
let(:user) { create(:user) }
|
|
|
|
|
|
|
|
def referenced_issues(current_user)
|
2016-09-29 14:28:45 +00:00
|
|
|
issue.title = "#{private_issue.to_reference(project)} and #{public_issue.to_reference}"
|
|
|
|
issue.referenced_mentionables(current_user)
|
2016-06-27 12:24:08 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
context 'when the current user can see the issue' do
|
|
|
|
before { private_project.team << [user, Gitlab::Access::DEVELOPER] }
|
|
|
|
|
|
|
|
it 'includes the reference' do
|
|
|
|
expect(referenced_issues(user)).to contain_exactly(private_issue, public_issue)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when the current user cannot see the issue' do
|
|
|
|
it 'does not include the reference' do
|
|
|
|
expect(referenced_issues(user)).to contain_exactly(public_issue)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when there is no current user' do
|
|
|
|
it 'does not include the reference' do
|
|
|
|
expect(referenced_issues(nil)).to contain_exactly(public_issue)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2015-06-08 22:13:14 +00:00
|
|
|
describe '#create_cross_references!' do
|
2017-01-26 22:44:58 +00:00
|
|
|
let(:project) { create(:project, :repository) }
|
2016-07-20 18:13:02 +00:00
|
|
|
let(:author) { build(:user) }
|
2015-06-08 22:13:14 +00:00
|
|
|
let(:commit) { project.commit }
|
|
|
|
let(:commit2) { project.commit }
|
|
|
|
|
|
|
|
let!(:issue) do
|
2017-01-26 22:44:58 +00:00
|
|
|
create(:issue, project: project, description: "See #{commit.to_reference}")
|
2015-06-08 22:13:14 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
it 'correctly removes already-mentioned Commits' do
|
2015-06-18 00:59:19 +00:00
|
|
|
expect(SystemNoteService).not_to receive(:cross_reference)
|
2015-06-08 22:13:14 +00:00
|
|
|
|
2015-10-12 09:54:46 +00:00
|
|
|
issue.create_cross_references!(author, [commit2])
|
2015-06-08 22:13:14 +00:00
|
|
|
end
|
|
|
|
end
|
2015-07-13 22:28:10 +00:00
|
|
|
|
2015-07-13 22:33:50 +00:00
|
|
|
describe '#create_new_cross_references!' do
|
2017-01-26 22:44:58 +00:00
|
|
|
let(:project) { create(:empty_project) }
|
2016-03-17 20:39:50 +00:00
|
|
|
let(:author) { create(:author) }
|
|
|
|
let(:issues) { create_list(:issue, 2, project: project, author: author) }
|
2015-07-13 22:28:10 +00:00
|
|
|
|
2016-07-20 18:13:02 +00:00
|
|
|
before do
|
|
|
|
project.team << [author, Gitlab::Access::DEVELOPER]
|
|
|
|
end
|
|
|
|
|
2015-07-13 22:28:10 +00:00
|
|
|
context 'before changes are persisted' do
|
|
|
|
it 'ignores pre-existing references' do
|
|
|
|
issue = create_issue(description: issues[0].to_reference)
|
|
|
|
|
|
|
|
expect(SystemNoteService).not_to receive(:cross_reference)
|
|
|
|
|
|
|
|
issue.description = 'New description'
|
2015-07-13 22:33:50 +00:00
|
|
|
issue.create_new_cross_references!
|
2015-07-13 22:28:10 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
it 'notifies new references' do
|
|
|
|
issue = create_issue(description: issues[0].to_reference)
|
|
|
|
|
|
|
|
expect(SystemNoteService).to receive(:cross_reference).with(issues[1], any_args)
|
|
|
|
|
|
|
|
issue.description = issues[1].to_reference
|
2015-07-13 22:33:50 +00:00
|
|
|
issue.create_new_cross_references!
|
2015-07-13 22:28:10 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'after changes are persisted' do
|
|
|
|
it 'ignores pre-existing references' do
|
|
|
|
issue = create_issue(description: issues[0].to_reference)
|
|
|
|
|
|
|
|
expect(SystemNoteService).not_to receive(:cross_reference)
|
|
|
|
|
|
|
|
issue.update_attributes(description: 'New description')
|
2015-07-13 22:33:50 +00:00
|
|
|
issue.create_new_cross_references!
|
2015-07-13 22:28:10 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
it 'notifies new references' do
|
|
|
|
issue = create_issue(description: issues[0].to_reference)
|
|
|
|
|
|
|
|
expect(SystemNoteService).to receive(:cross_reference).with(issues[1], any_args)
|
|
|
|
|
|
|
|
issue.update_attributes(description: issues[1].to_reference)
|
2015-07-13 22:33:50 +00:00
|
|
|
issue.create_new_cross_references!
|
2015-07-13 22:28:10 +00:00
|
|
|
end
|
2017-01-05 13:36:06 +00:00
|
|
|
|
|
|
|
it 'notifies new references from project snippet note' do
|
|
|
|
snippet = create(:snippet, project: project)
|
|
|
|
note = create(:note, note: issues[0].to_reference, noteable: snippet, project: project, author: author)
|
|
|
|
|
|
|
|
expect(SystemNoteService).to receive(:cross_reference).with(issues[1], any_args)
|
|
|
|
|
|
|
|
note.update_attributes(note: issues[1].to_reference)
|
|
|
|
note.create_new_cross_references!
|
|
|
|
end
|
2015-07-13 22:28:10 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
def create_issue(description:)
|
2016-03-17 20:39:50 +00:00
|
|
|
create(:issue, project: project, description: description, author: author)
|
2015-07-13 22:28:10 +00:00
|
|
|
end
|
|
|
|
end
|
2014-10-29 13:46:42 +00:00
|
|
|
end
|