2014-01-27 16:34:05 -05:00
|
|
|
require 'carrierwave/orm/activerecord'
|
|
|
|
|
2012-11-22 13:34:16 -05:00
|
|
|
class Group < Namespace
|
2015-08-24 10:46:06 -04:00
|
|
|
include Gitlab::ConfigHelper
|
2016-04-18 12:53:32 -04:00
|
|
|
include AccessRequestable
|
2017-05-10 00:26:17 -04:00
|
|
|
include Avatarable
|
2015-05-02 23:11:21 -04:00
|
|
|
include Referable
|
2016-10-11 08:25:17 -04:00
|
|
|
include SelectForProjectAuthorization
|
2016-03-01 10:22:29 -05:00
|
|
|
|
2017-06-08 11:16:27 -04:00
|
|
|
has_many :group_members, -> { where(requested_at: nil) }, dependent: :destroy, as: :source # rubocop:disable Cop/ActiveRecordDependent
|
2015-11-11 10:42:27 -05:00
|
|
|
alias_method :members, :group_members
|
2016-06-27 10:20:57 -04:00
|
|
|
has_many :users, through: :group_members
|
2016-06-15 09:22:05 -04:00
|
|
|
has_many :owners,
|
2016-06-27 10:20:57 -04:00
|
|
|
-> { where(members: { access_level: Gitlab::Access::OWNER }) },
|
2016-06-15 09:22:05 -04:00
|
|
|
through: :group_members,
|
|
|
|
source: :user
|
|
|
|
|
2017-06-08 11:16:27 -04:00
|
|
|
has_many :requesters, -> { where.not(requested_at: nil) }, dependent: :destroy, as: :source, class_name: 'GroupMember' # rubocop:disable Cop/ActiveRecordDependent
|
2016-06-27 10:20:57 -04:00
|
|
|
|
2017-07-07 11:08:49 -04:00
|
|
|
has_many :milestones
|
2017-06-08 11:16:27 -04:00
|
|
|
has_many :project_group_links, dependent: :destroy # rubocop:disable Cop/ActiveRecordDependent
|
2016-03-11 11:47:05 -05:00
|
|
|
has_many :shared_projects, through: :project_group_links, source: :project
|
2017-06-08 11:16:27 -04:00
|
|
|
has_many :notification_settings, dependent: :destroy, as: :source # rubocop:disable Cop/ActiveRecordDependent
|
2016-09-19 11:04:38 -04:00
|
|
|
has_many :labels, class_name: 'GroupLabel'
|
2017-05-03 14:51:55 -04:00
|
|
|
has_many :variables, class_name: 'Ci::GroupVariable'
|
2013-04-02 18:28:12 -04:00
|
|
|
|
2015-05-06 17:33:39 -04:00
|
|
|
validate :avatar_type, if: ->(user) { user.avatar.present? && user.avatar_changed? }
|
2016-03-18 08:28:16 -04:00
|
|
|
validate :visibility_level_allowed_by_projects
|
|
|
|
|
2015-01-02 08:54:51 -05:00
|
|
|
validates :avatar, file_size: { maximum: 200.kilobytes.to_i }
|
2014-01-27 16:34:05 -05:00
|
|
|
|
2017-01-24 16:09:58 -05:00
|
|
|
validates :two_factor_grace_period, presence: true, numericality: { greater_than_or_equal_to: 0 }
|
|
|
|
|
2015-02-20 09:19:50 -05:00
|
|
|
mount_uploader :avatar, AvatarUploader
|
2017-06-08 11:16:27 -04:00
|
|
|
has_many :uploads, as: :model, dependent: :destroy # rubocop:disable Cop/ActiveRecordDependent
|
2014-05-28 12:03:01 -04:00
|
|
|
|
2014-08-21 06:53:32 -04:00
|
|
|
after_create :post_create_hook
|
|
|
|
after_destroy :post_destroy_hook
|
2017-01-24 16:09:58 -05:00
|
|
|
after_save :update_two_factor_requirement
|
2014-08-21 06:53:32 -04:00
|
|
|
|
2015-02-05 22:15:05 -05:00
|
|
|
class << self
|
Use CTEs for nested groups and authorizations
This commit introduces the usage of Common Table Expressions (CTEs) to
efficiently retrieve nested group hierarchies, without having to rely on
the "routes" table (which is an _incredibly_ inefficient way of getting
the data). This requires a patch to ActiveRecord (found in the added
initializer) to work properly as ActiveRecord doesn't support WITH
statements properly out of the box.
Unfortunately MySQL provides no efficient way of getting nested groups.
For example, the old routes setup could easily take 5-10 seconds
depending on the amount of "routes" in a database. Providing vastly
different logic for both MySQL and PostgreSQL will negatively impact the
development process. Because of this the various nested groups related
methods return empty relations when used in combination with MySQL.
For project authorizations the logic is split up into two classes:
* Gitlab::ProjectAuthorizations::WithNestedGroups
* Gitlab::ProjectAuthorizations::WithoutNestedGroups
Both classes get the fresh project authorizations (= as they should be
in the "project_authorizations" table), including nested groups if
PostgreSQL is used. The logic of these two classes is quite different
apart from their public interface. This complicates development a bit,
but unfortunately there is no way around this.
This commit also introduces Gitlab::GroupHierarchy. This class can be
used to get the ancestors and descendants of a base relation, or both by
using a UNION. This in turn is used by methods such as:
* Namespace#ancestors
* Namespace#descendants
* User#all_expanded_groups
Again this class relies on CTEs and thus only works on PostgreSQL. The
Namespace methods will return an empty relation when MySQL is used,
while User#all_expanded_groups will return only the groups a user is a
direct member of.
Performance wise the impact is quite large. For example, on GitLab.com
Namespace#descendants used to take around 580 ms to retrieve data for a
particular user. Using CTEs we are able to reduce this down to roughly 1
millisecond, returning the exact same data.
== On The Fly Refreshing
Refreshing of authorizations on the fly (= when
users.authorized_projects_populated was not set) is removed with this
commit. This simplifies the code, and ensures any queries used for
authorizations are not mutated because they are executed in a Rails
scope (e.g. Project.visible_to_user).
This commit includes a migration to schedule refreshing authorizations
for all users, ensuring all of them have their authorizations in place.
Said migration schedules users in batches of 5000, with 5 minutes
between every batch to smear the load around a bit.
== Spec Changes
This commit also introduces some changes to various specs. For example,
some specs for ProjectTeam assumed that creating a personal project
would _not_ lead to the owner having access, which is incorrect. Because
we also no longer refresh authorizations on the fly for new users some
code had to be added to the "empty_project" factory. This chunk of code
ensures that the owner's permissions are refreshed after creating the
project, something that is normally done in Projects::CreateService.
2017-04-24 11:19:22 -04:00
|
|
|
def supports_nested_groups?
|
|
|
|
Gitlab::Database.postgresql?
|
|
|
|
end
|
|
|
|
|
2016-03-01 10:15:42 -05:00
|
|
|
# Searches for groups matching the given query.
|
|
|
|
#
|
|
|
|
# This method uses ILIKE on PostgreSQL and LIKE on MySQL.
|
|
|
|
#
|
|
|
|
# query - The search query as a String
|
|
|
|
#
|
|
|
|
# Returns an ActiveRecord::Relation.
|
2015-02-05 22:15:05 -05:00
|
|
|
def search(query)
|
2016-03-04 06:01:21 -05:00
|
|
|
table = Namespace.arel_table
|
2016-03-01 10:15:42 -05:00
|
|
|
pattern = "%#{query}%"
|
|
|
|
|
|
|
|
where(table[:name].matches(pattern).or(table[:path].matches(pattern)))
|
2015-02-05 22:15:05 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
def sort(method)
|
2016-11-22 11:58:10 -05:00
|
|
|
if method == 'storage_size_desc'
|
|
|
|
# storage_size is a virtual column so we need to
|
|
|
|
# pass a string to avoid AR adding the table name
|
|
|
|
reorder('storage_size DESC, namespaces.id DESC')
|
|
|
|
else
|
|
|
|
order_by(method)
|
|
|
|
end
|
2015-02-05 22:15:05 -05:00
|
|
|
end
|
2015-05-02 23:11:21 -04:00
|
|
|
|
|
|
|
def reference_prefix
|
2015-05-14 16:59:39 -04:00
|
|
|
User.reference_prefix
|
|
|
|
end
|
|
|
|
|
|
|
|
def reference_pattern
|
|
|
|
User.reference_pattern
|
2015-05-02 23:11:21 -04:00
|
|
|
end
|
2015-11-18 06:27:21 -05:00
|
|
|
|
|
|
|
def visible_to_user(user)
|
|
|
|
where(id: user.authorized_groups.select(:id).reorder(nil))
|
|
|
|
end
|
2016-10-11 08:25:17 -04:00
|
|
|
|
|
|
|
def select_for_project_authorization
|
|
|
|
if current_scope.joins_values.include?(:shared_projects)
|
2016-11-21 08:33:58 -05:00
|
|
|
joins('INNER JOIN namespaces project_namespace ON project_namespace.id = projects.namespace_id')
|
|
|
|
.where('project_namespace.share_with_group_lock = ?', false)
|
Use CTEs for nested groups and authorizations
This commit introduces the usage of Common Table Expressions (CTEs) to
efficiently retrieve nested group hierarchies, without having to rely on
the "routes" table (which is an _incredibly_ inefficient way of getting
the data). This requires a patch to ActiveRecord (found in the added
initializer) to work properly as ActiveRecord doesn't support WITH
statements properly out of the box.
Unfortunately MySQL provides no efficient way of getting nested groups.
For example, the old routes setup could easily take 5-10 seconds
depending on the amount of "routes" in a database. Providing vastly
different logic for both MySQL and PostgreSQL will negatively impact the
development process. Because of this the various nested groups related
methods return empty relations when used in combination with MySQL.
For project authorizations the logic is split up into two classes:
* Gitlab::ProjectAuthorizations::WithNestedGroups
* Gitlab::ProjectAuthorizations::WithoutNestedGroups
Both classes get the fresh project authorizations (= as they should be
in the "project_authorizations" table), including nested groups if
PostgreSQL is used. The logic of these two classes is quite different
apart from their public interface. This complicates development a bit,
but unfortunately there is no way around this.
This commit also introduces Gitlab::GroupHierarchy. This class can be
used to get the ancestors and descendants of a base relation, or both by
using a UNION. This in turn is used by methods such as:
* Namespace#ancestors
* Namespace#descendants
* User#all_expanded_groups
Again this class relies on CTEs and thus only works on PostgreSQL. The
Namespace methods will return an empty relation when MySQL is used,
while User#all_expanded_groups will return only the groups a user is a
direct member of.
Performance wise the impact is quite large. For example, on GitLab.com
Namespace#descendants used to take around 580 ms to retrieve data for a
particular user. Using CTEs we are able to reduce this down to roughly 1
millisecond, returning the exact same data.
== On The Fly Refreshing
Refreshing of authorizations on the fly (= when
users.authorized_projects_populated was not set) is removed with this
commit. This simplifies the code, and ensures any queries used for
authorizations are not mutated because they are executed in a Rails
scope (e.g. Project.visible_to_user).
This commit includes a migration to schedule refreshing authorizations
for all users, ensuring all of them have their authorizations in place.
Said migration schedules users in batches of 5000, with 5 minutes
between every batch to smear the load around a bit.
== Spec Changes
This commit also introduces some changes to various specs. For example,
some specs for ProjectTeam assumed that creating a personal project
would _not_ lead to the owner having access, which is incorrect. Because
we also no longer refresh authorizations on the fly for new users some
code had to be added to the "empty_project" factory. This chunk of code
ensures that the owner's permissions are refreshed after creating the
project, something that is normally done in Projects::CreateService.
2017-04-24 11:19:22 -04:00
|
|
|
.select("projects.id AS project_id, LEAST(project_group_links.group_access, members.access_level) AS access_level")
|
2016-10-11 08:25:17 -04:00
|
|
|
else
|
|
|
|
super
|
|
|
|
end
|
|
|
|
end
|
2015-05-02 23:11:21 -04:00
|
|
|
end
|
|
|
|
|
2016-12-21 11:41:33 -05:00
|
|
|
def to_reference(_from_project = nil, full: nil)
|
2017-02-13 06:26:33 -05:00
|
|
|
"#{self.class.reference_prefix}#{full_path}"
|
2015-02-05 22:15:05 -05:00
|
|
|
end
|
|
|
|
|
2016-06-02 10:14:02 -04:00
|
|
|
def web_url
|
2016-10-26 14:13:58 -04:00
|
|
|
Gitlab::Routing.url_helpers.group_canonical_url(self)
|
2016-06-02 10:14:02 -04:00
|
|
|
end
|
|
|
|
|
2012-11-22 23:11:09 -05:00
|
|
|
def human_name
|
2016-12-13 10:00:06 -05:00
|
|
|
full_name
|
2012-11-22 23:11:09 -05:00
|
|
|
end
|
2012-12-30 07:26:19 -05:00
|
|
|
|
2016-03-18 08:28:16 -04:00
|
|
|
def visibility_level_allowed_by_projects
|
2016-03-21 19:09:20 -04:00
|
|
|
allowed_by_projects = self.projects.where('visibility_level > ?', self.visibility_level).none?
|
2016-03-18 08:28:16 -04:00
|
|
|
|
|
|
|
unless allowed_by_projects
|
|
|
|
level_name = Gitlab::VisibilityLevel.level_name(visibility_level).downcase
|
|
|
|
self.errors.add(:visibility_level, "#{level_name} is not allowed since there are projects with higher visibility.")
|
|
|
|
end
|
|
|
|
|
|
|
|
allowed_by_projects
|
|
|
|
end
|
|
|
|
|
2017-05-10 00:26:17 -04:00
|
|
|
def avatar_url(**args)
|
|
|
|
# We use avatar_path instead of overriding avatar_url because of carrierwave.
|
|
|
|
# See https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/11001/diffs#note_28659864
|
|
|
|
avatar_path(args)
|
2015-07-28 09:49:44 -04:00
|
|
|
end
|
|
|
|
|
2016-09-01 19:49:48 -04:00
|
|
|
def lfs_enabled?
|
|
|
|
return false unless Gitlab.config.lfs.enabled
|
|
|
|
return Gitlab.config.lfs.enabled if self[:lfs_enabled].nil?
|
|
|
|
|
|
|
|
self[:lfs_enabled]
|
|
|
|
end
|
|
|
|
|
2016-09-16 11:54:21 -04:00
|
|
|
def add_users(users, access_level, current_user: nil, expires_at: nil)
|
2017-04-21 10:07:42 -04:00
|
|
|
GroupMember.add_users(
|
2016-09-16 11:54:21 -04:00
|
|
|
self,
|
|
|
|
users,
|
|
|
|
access_level,
|
|
|
|
current_user: current_user,
|
|
|
|
expires_at: expires_at
|
|
|
|
)
|
2013-06-18 09:56:31 -04:00
|
|
|
end
|
|
|
|
|
2016-08-18 12:01:50 -04:00
|
|
|
def add_user(user, access_level, current_user: nil, expires_at: nil)
|
2016-09-16 11:54:21 -04:00
|
|
|
GroupMember.add_user(
|
|
|
|
self,
|
|
|
|
user,
|
|
|
|
access_level,
|
|
|
|
current_user: current_user,
|
|
|
|
expires_at: expires_at
|
|
|
|
)
|
2013-09-25 07:05:35 -04:00
|
|
|
end
|
|
|
|
|
2015-08-07 00:20:02 -04:00
|
|
|
def add_guest(user, current_user = nil)
|
2016-09-16 11:54:21 -04:00
|
|
|
add_user(user, :guest, current_user: current_user)
|
2015-08-07 00:20:02 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
def add_reporter(user, current_user = nil)
|
2016-09-16 11:54:21 -04:00
|
|
|
add_user(user, :reporter, current_user: current_user)
|
2015-08-07 00:20:02 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
def add_developer(user, current_user = nil)
|
2016-09-16 11:54:21 -04:00
|
|
|
add_user(user, :developer, current_user: current_user)
|
2015-08-07 00:20:02 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
def add_master(user, current_user = nil)
|
2016-09-16 11:54:21 -04:00
|
|
|
add_user(user, :master, current_user: current_user)
|
2015-08-07 00:20:02 -04:00
|
|
|
end
|
|
|
|
|
2015-11-17 09:49:37 -05:00
|
|
|
def add_owner(user, current_user = nil)
|
2016-09-16 11:54:21 -04:00
|
|
|
add_user(user, :owner, current_user: current_user)
|
2015-11-17 09:49:37 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
def has_owner?(user)
|
2017-07-24 06:35:54 -04:00
|
|
|
return false unless user
|
|
|
|
|
2016-12-13 13:59:39 -05:00
|
|
|
members_with_parents.owners.where(user_id: user).any?
|
2015-11-17 09:49:37 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
def has_master?(user)
|
2017-07-24 06:35:54 -04:00
|
|
|
return false unless user
|
|
|
|
|
2016-12-13 13:59:39 -05:00
|
|
|
members_with_parents.masters.where(user_id: user).any?
|
2015-11-17 09:49:37 -05:00
|
|
|
end
|
|
|
|
|
2016-12-13 13:59:39 -05:00
|
|
|
# Check if user is a last owner of the group.
|
|
|
|
# Parent owners are ignored for nested groups.
|
2015-11-17 09:49:37 -05:00
|
|
|
def last_owner?(user)
|
2016-12-13 13:59:39 -05:00
|
|
|
owners.include?(user) && owners.size == 1
|
2015-11-17 09:49:37 -05:00
|
|
|
end
|
|
|
|
|
2014-01-27 16:34:05 -05:00
|
|
|
def avatar_type
|
|
|
|
unless self.avatar.image?
|
|
|
|
self.errors.add :avatar, "only images allowed"
|
|
|
|
end
|
|
|
|
end
|
2014-06-05 13:37:35 -04:00
|
|
|
|
2014-08-21 06:53:32 -04:00
|
|
|
def post_create_hook
|
2015-06-03 10:15:58 -04:00
|
|
|
Gitlab::AppLogger.info("Group \"#{name}\" was created")
|
|
|
|
|
2014-08-21 06:53:32 -04:00
|
|
|
system_hook_service.execute_hooks_for(self, :create)
|
|
|
|
end
|
|
|
|
|
|
|
|
def post_destroy_hook
|
2015-06-03 10:15:58 -04:00
|
|
|
Gitlab::AppLogger.info("Group \"#{name}\" was removed")
|
|
|
|
|
2014-08-21 06:53:32 -04:00
|
|
|
system_hook_service.execute_hooks_for(self, :destroy)
|
|
|
|
end
|
|
|
|
|
|
|
|
def system_hook_service
|
|
|
|
SystemHooksService.new
|
|
|
|
end
|
2016-10-11 08:25:17 -04:00
|
|
|
|
2017-08-23 10:28:16 -04:00
|
|
|
def refresh_members_authorized_projects(blocking: true)
|
2017-06-21 09:48:12 -04:00
|
|
|
UserProjectAccessChangedService.new(user_ids_for_project_authorizations)
|
2017-08-23 10:28:16 -04:00
|
|
|
.execute(blocking: blocking)
|
2017-02-07 08:55:42 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
def user_ids_for_project_authorizations
|
2017-08-11 10:19:11 -04:00
|
|
|
members_with_parents.pluck(:user_id)
|
2016-12-13 13:59:39 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
def members_with_parents
|
2017-08-11 10:19:11 -04:00
|
|
|
# Avoids an unnecessary SELECT when the group has no parents
|
|
|
|
source_ids =
|
|
|
|
if parent_id
|
|
|
|
self_and_ancestors.reorder(nil).select(:id)
|
|
|
|
else
|
|
|
|
id
|
|
|
|
end
|
|
|
|
|
|
|
|
GroupMember
|
|
|
|
.active_without_invites
|
|
|
|
.where(source_id: source_ids)
|
|
|
|
end
|
|
|
|
|
|
|
|
def members_with_descendants
|
|
|
|
GroupMember
|
|
|
|
.active_without_invites
|
|
|
|
.where(source_id: self_and_descendants.reorder(nil).select(:id))
|
2016-12-13 13:59:39 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
def users_with_parents
|
2017-08-11 10:19:11 -04:00
|
|
|
User
|
|
|
|
.where(id: members_with_parents.select(:user_id))
|
|
|
|
.reorder(nil)
|
2016-10-11 08:25:17 -04:00
|
|
|
end
|
2017-03-01 14:34:29 -05:00
|
|
|
|
2017-06-27 16:35:35 -04:00
|
|
|
def users_with_descendants
|
2017-08-11 10:19:11 -04:00
|
|
|
User
|
|
|
|
.where(id: members_with_descendants.select(:user_id))
|
|
|
|
.reorder(nil)
|
2017-06-27 16:35:35 -04:00
|
|
|
end
|
|
|
|
|
2017-06-02 10:13:10 -04:00
|
|
|
def max_member_access_for_user(user)
|
|
|
|
return GroupMember::OWNER if user.admin?
|
|
|
|
|
2017-06-21 09:48:12 -04:00
|
|
|
members_with_parents
|
|
|
|
.where(user_id: user)
|
|
|
|
.reorder(access_level: :desc)
|
|
|
|
.first&.
|
2017-06-02 10:13:10 -04:00
|
|
|
access_level || GroupMember::NO_ACCESS
|
|
|
|
end
|
|
|
|
|
2017-03-01 14:34:29 -05:00
|
|
|
def mattermost_team_params
|
|
|
|
max_length = 59
|
|
|
|
|
|
|
|
{
|
|
|
|
name: path[0..max_length],
|
|
|
|
display_name: name[0..max_length],
|
|
|
|
type: public? ? 'O' : 'I' # Open vs Invite-only
|
|
|
|
}
|
|
|
|
end
|
2017-01-24 16:09:58 -05:00
|
|
|
|
2017-05-03 14:51:55 -04:00
|
|
|
def secret_variables_for(ref, project)
|
2017-07-05 11:13:01 -04:00
|
|
|
list_of_ids = [self] + ancestors
|
|
|
|
variables = Ci::GroupVariable.where(group: list_of_ids)
|
|
|
|
variables = variables.unprotected unless project.protected_for?(ref)
|
|
|
|
variables = variables.group_by(&:group_id)
|
|
|
|
list_of_ids.reverse.map { |group| variables[group.id] }.compact.flatten
|
2017-05-03 14:51:55 -04:00
|
|
|
end
|
|
|
|
|
2017-01-24 16:09:58 -05:00
|
|
|
protected
|
|
|
|
|
|
|
|
def update_two_factor_requirement
|
|
|
|
return unless require_two_factor_authentication_changed? || two_factor_grace_period_changed?
|
|
|
|
|
|
|
|
users.find_each(&:update_two_factor_requirement)
|
|
|
|
end
|
2012-10-02 11:17:12 -04:00
|
|
|
end
|