2017-01-27 16:25:39 +00:00
|
|
|
require 'spec_helper'
|
|
|
|
|
|
|
|
describe SpamService, services: true do
|
2017-02-14 19:07:11 +00:00
|
|
|
describe '#when_recaptcha_verified' do
|
|
|
|
def check_spam(issue, request, recaptcha_verified)
|
|
|
|
described_class.new(issue, request).when_recaptcha_verified(recaptcha_verified) do
|
|
|
|
'yielded'
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'yields block when recaptcha was already verified' do
|
|
|
|
issue = build_stubbed(:issue)
|
2017-01-27 16:25:39 +00:00
|
|
|
|
2017-02-14 19:07:11 +00:00
|
|
|
expect(check_spam(issue, nil, true)).to eql('yielded')
|
2017-01-27 16:25:39 +00:00
|
|
|
end
|
|
|
|
|
2017-02-14 19:07:11 +00:00
|
|
|
context 'when recaptcha was not verified' do
|
|
|
|
let(:project) { create(:project, :public) }
|
|
|
|
let(:issue) { create(:issue, project: project) }
|
|
|
|
let(:request) { double(:request, env: {}) }
|
2017-01-27 16:25:39 +00:00
|
|
|
|
2017-03-21 02:37:29 +00:00
|
|
|
context 'when spammable attributes have not changed' do
|
|
|
|
before do
|
|
|
|
issue.closed_at = Time.zone.now
|
2017-01-27 16:25:39 +00:00
|
|
|
|
2017-03-21 02:37:29 +00:00
|
|
|
allow(AkismetService).to receive(:new).and_return(double(is_spam?: true))
|
2017-02-14 19:07:11 +00:00
|
|
|
end
|
2017-01-27 16:25:39 +00:00
|
|
|
|
2017-03-21 02:37:29 +00:00
|
|
|
it 'returns false' do
|
|
|
|
expect(check_spam(issue, request, false)).to be_falsey
|
2017-02-14 19:07:11 +00:00
|
|
|
end
|
2017-01-27 16:25:39 +00:00
|
|
|
|
2017-03-21 02:37:29 +00:00
|
|
|
it 'does not create a spam log' do
|
2017-02-14 19:07:11 +00:00
|
|
|
expect { check_spam(issue, request, false) }
|
2017-03-21 02:37:29 +00:00
|
|
|
.not_to change { SpamLog.count }
|
2017-02-14 19:07:11 +00:00
|
|
|
end
|
2017-03-21 02:37:29 +00:00
|
|
|
end
|
2017-01-27 16:25:39 +00:00
|
|
|
|
2017-03-21 02:37:29 +00:00
|
|
|
context 'when spammable attributes have changed' do
|
|
|
|
before do
|
|
|
|
issue.description = 'SPAM!'
|
2017-02-14 19:07:11 +00:00
|
|
|
end
|
2017-01-27 16:25:39 +00:00
|
|
|
|
2017-03-21 02:37:29 +00:00
|
|
|
context 'when indicated as spam by akismet' do
|
|
|
|
before do
|
|
|
|
allow(AkismetService).to receive(:new).and_return(double(is_spam?: true))
|
|
|
|
end
|
2017-02-14 19:07:11 +00:00
|
|
|
|
2017-03-21 02:37:29 +00:00
|
|
|
it 'doesnt check as spam when request is missing' do
|
|
|
|
check_spam(issue, nil, false)
|
|
|
|
|
|
|
|
expect(issue.spam).to be_falsey
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'checks as spam' do
|
|
|
|
check_spam(issue, request, false)
|
|
|
|
|
|
|
|
expect(issue.spam).to be_truthy
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'creates a spam log' do
|
|
|
|
expect { check_spam(issue, request, false) }
|
|
|
|
.to change { SpamLog.count }.from(0).to(1)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'doesnt yield block' do
|
|
|
|
expect(check_spam(issue, request, false))
|
|
|
|
.to eql(SpamLog.last)
|
|
|
|
end
|
2017-02-14 19:07:11 +00:00
|
|
|
end
|
|
|
|
|
2017-03-21 02:37:29 +00:00
|
|
|
context 'when not indicated as spam by akismet' do
|
|
|
|
before { allow(AkismetService).to receive(:new).and_return(double(is_spam?: false)) }
|
|
|
|
|
|
|
|
it 'returns false' do
|
|
|
|
expect(check_spam(issue, request, false)).to be_falsey
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not create a spam log' do
|
|
|
|
expect { check_spam(issue, request, false) }
|
|
|
|
.not_to change { SpamLog.count }
|
|
|
|
end
|
2017-02-14 19:07:11 +00:00
|
|
|
end
|
2017-01-27 16:25:39 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|