2019-11-06 04:06:23 -05:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
|
|
|
require 'spec_helper'
|
|
|
|
|
2020-06-24 14:09:03 -04:00
|
|
|
RSpec.describe Gitlab::SlashCommands::IssueComment do
|
2019-11-06 04:06:23 -05:00
|
|
|
describe '#execute' do
|
|
|
|
let(:project) { create(:project, :public) }
|
|
|
|
let(:issue) { create(:issue, project: project) }
|
|
|
|
let(:user) { issue.author }
|
|
|
|
let(:chat_name) { double(:chat_name, user: user) }
|
|
|
|
let(:regex_match) { described_class.match("issue comment #{issue.iid}\nComment body") }
|
|
|
|
|
|
|
|
subject { described_class.new(project, chat_name).execute(regex_match) }
|
|
|
|
|
|
|
|
context 'when the issue exists' do
|
|
|
|
context 'when project is private' do
|
|
|
|
let(:project) { create(:project) }
|
|
|
|
|
|
|
|
context 'when the user is not a member of the project' do
|
|
|
|
let(:chat_name) { double(:chat_name, user: create(:user)) }
|
|
|
|
|
|
|
|
it 'does not allow the user to comment' do
|
|
|
|
expect(subject[:response_type]).to be(:ephemeral)
|
|
|
|
expect(subject[:text]).to match('not found')
|
|
|
|
expect(issue.reload.notes.count).to be_zero
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when the user is not a member of the project' do
|
|
|
|
let(:chat_name) { double(:chat_name, user: create(:user)) }
|
|
|
|
|
|
|
|
context 'when the discussion is locked in the issue' do
|
|
|
|
before do
|
|
|
|
issue.update!(discussion_locked: true)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not allow the user to comment' do
|
|
|
|
expect(subject[:response_type]).to be(:ephemeral)
|
|
|
|
expect(subject[:text]).to match('You are not allowed')
|
|
|
|
expect(issue.reload.notes.count).to be_zero
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when the user can comment on the issue' do
|
|
|
|
context 'when comment body exists' do
|
|
|
|
it 'creates a new comment' do
|
|
|
|
expect { subject }.to change { issue.notes.count }.by(1)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'a new comment has a correct body' do
|
|
|
|
subject
|
|
|
|
|
|
|
|
expect(issue.notes.last.note).to eq('Comment body')
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when comment body does not exist' do
|
|
|
|
let(:regex_match) { described_class.match("issue comment #{issue.iid}") }
|
|
|
|
|
|
|
|
it 'does not create a new comment' do
|
|
|
|
expect { subject }.not_to change { issue.notes.count }
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'displays the errors' do
|
|
|
|
expect(subject[:response_type]).to be(:ephemeral)
|
|
|
|
expect(subject[:text]).to match("- Note can't be blank")
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when the issue does not exist' do
|
|
|
|
let(:regex_match) { described_class.match("issue comment 2343242\nComment body") }
|
|
|
|
|
|
|
|
it 'returns not found' do
|
|
|
|
expect(subject[:response_type]).to be(:ephemeral)
|
|
|
|
expect(subject[:text]).to match('not found')
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '.match' do
|
|
|
|
subject(:match) { described_class.match(command) }
|
|
|
|
|
|
|
|
context 'when a command has an issue ID' do
|
|
|
|
context 'when command has a comment body' do
|
|
|
|
let(:command) { "issue comment 503\nComment body" }
|
|
|
|
|
|
|
|
it 'matches an issue ID' do
|
|
|
|
expect(match[:iid]).to eq('503')
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'matches an note body' do
|
|
|
|
expect(match[:note_body]).to eq('Comment body')
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when a command has a reference prefix for issue ID' do
|
|
|
|
let(:command) { "issue comment #503\nComment body" }
|
|
|
|
|
|
|
|
it 'matches an issue ID' do
|
|
|
|
expect(match[:iid]).to eq('503')
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when a command does not have an issue ID' do
|
|
|
|
let(:command) { 'issue comment' }
|
|
|
|
|
|
|
|
it 'does not match' do
|
|
|
|
is_expected.to be_nil
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|