gitlab-org--gitlab-foss/spec/controllers/admin/health_check_controller_spec.rb

# frozen_string_literal: true

require 'spec_helper'

describe Admin::HealthCheckController do
  let(:admin) { create(:admin) }

  before do
    sign_in(admin)
  end

  describe 'GET show' do
    it 'loads the health information' do
      get :show

      expect(assigns[:errors]).not_to be_nil
    end
  end
end
Add some frozen string to spec/*/.rb Adds frozen string to the following: * spec/bin/*/.rb * spec/config/*/.rb * spec/controllers/*/.rb xref https://gitlab.com/gitlab-org/gitlab-ce/issues/59758 2019-04-15 06:17:05 -04:00			`# frozen_string_literal: true`

Add a Circuitbreaker for storage paths 2017-05-17 12:17:15 -04:00			`require 'spec_helper'`

Move the circuitbreaker check out in a separate process Moving the check out of the general requests, makes sure we don't have any slowdown in the regular requests. To keep the process performing this checks small, the check is still performed inside a unicorn. But that is called from a process running on the same server. Because the checks are now done outside normal request, we can have a simpler failure strategy: The check is now performed in the background every `circuitbreaker_check_interval`. Failures are logged in redis. The failures are reset when the check succeeds. Per check we will try `circuitbreaker_access_retries` times within `circuitbreaker_storage_timeout` seconds. When the number of failures exceeds `circuitbreaker_failure_count_threshold`, we will block access to the storage. After `failure_reset_time` of no checks, we will clear the stored failures. This could happen when the process that performs the checks is not running. 2017-11-13 10:52:07 -05:00			`describe Admin::HealthCheckController do`
Add a Circuitbreaker for storage paths 2017-05-17 12:17:15 -04:00			`let(:admin) { create(:admin) }`

			`before do`
			`sign_in(admin)`
			`end`

			`describe 'GET show' do`
Remove Git circuit breaker Was introduced in the time that GitLab still used NFS, which is not required anymore in most cases. By removing this, the API it calls will return empty responses. This interface has to be removed in the next major release, expected to be 12.0. 2018-10-09 01:59:42 -04:00			`it 'loads the health information' do`
Add a Circuitbreaker for storage paths 2017-05-17 12:17:15 -04:00			`get :show`

Remove Git circuit breaker Was introduced in the time that GitLab still used NFS, which is not required anymore in most cases. By removing this, the API it calls will return empty responses. This interface has to be removed in the next major release, expected to be 12.0. 2018-10-09 01:59:42 -04:00			`expect(assigns[:errors]).not_to be_nil`
Add a Circuitbreaker for storage paths 2017-05-17 12:17:15 -04:00			`end`
			`end`
			`end`