2017-02-01 18:41:01 +00:00
|
|
|
module RelativePositioning
|
|
|
|
extend ActiveSupport::Concern
|
|
|
|
|
2017-02-27 11:40:26 +00:00
|
|
|
MIN_POSITION = 0
|
2017-03-10 15:12:31 +00:00
|
|
|
START_POSITION = Gitlab::Database::MAX_INT_VALUE / 2
|
2017-02-27 11:40:26 +00:00
|
|
|
MAX_POSITION = Gitlab::Database::MAX_INT_VALUE
|
2017-03-10 17:04:37 +00:00
|
|
|
IDEAL_DISTANCE = 500
|
2017-02-01 18:41:01 +00:00
|
|
|
|
2017-03-07 17:57:24 +00:00
|
|
|
included do
|
|
|
|
after_save :save_positionable_neighbours
|
|
|
|
end
|
|
|
|
|
2017-02-01 18:41:01 +00:00
|
|
|
def max_relative_position
|
2017-02-27 11:16:26 +00:00
|
|
|
self.class.in_projects(project.id).maximum(:relative_position)
|
2017-02-01 18:41:01 +00:00
|
|
|
end
|
|
|
|
|
2017-03-07 17:57:24 +00:00
|
|
|
def prev_relative_position
|
|
|
|
prev_pos = nil
|
|
|
|
|
|
|
|
if self.relative_position
|
2017-06-21 13:48:12 +00:00
|
|
|
prev_pos = self.class
|
|
|
|
.in_projects(project.id)
|
|
|
|
.where('relative_position < ?', self.relative_position)
|
|
|
|
.maximum(:relative_position)
|
2017-03-07 17:57:24 +00:00
|
|
|
end
|
|
|
|
|
2017-03-10 15:12:31 +00:00
|
|
|
prev_pos
|
2017-03-07 17:57:24 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
def next_relative_position
|
|
|
|
next_pos = nil
|
|
|
|
|
|
|
|
if self.relative_position
|
2017-06-21 13:48:12 +00:00
|
|
|
next_pos = self.class
|
|
|
|
.in_projects(project.id)
|
|
|
|
.where('relative_position > ?', self.relative_position)
|
|
|
|
.minimum(:relative_position)
|
2017-03-07 17:57:24 +00:00
|
|
|
end
|
|
|
|
|
2017-03-10 15:12:31 +00:00
|
|
|
next_pos
|
2017-03-07 17:57:24 +00:00
|
|
|
end
|
|
|
|
|
2017-02-01 18:41:01 +00:00
|
|
|
def move_between(before, after)
|
2017-03-07 17:57:24 +00:00
|
|
|
return move_after(before) unless after
|
|
|
|
return move_before(after) unless before
|
2017-02-01 18:41:01 +00:00
|
|
|
|
2017-03-10 17:04:37 +00:00
|
|
|
# If there is no place to insert an issue we need to create one by moving the before issue closer
|
|
|
|
# to its predecessor. This process will recursively move all the predecessors until we have a place
|
|
|
|
if (after.relative_position - before.relative_position) < 2
|
|
|
|
before.move_before
|
|
|
|
@positionable_neighbours = [before]
|
|
|
|
end
|
|
|
|
|
|
|
|
self.relative_position = position_between(before.relative_position, after.relative_position)
|
|
|
|
end
|
|
|
|
|
|
|
|
def move_after(before = self)
|
2017-02-01 18:41:01 +00:00
|
|
|
pos_before = before.relative_position
|
2017-03-10 17:04:37 +00:00
|
|
|
pos_after = before.next_relative_position
|
2017-02-01 18:41:01 +00:00
|
|
|
|
2017-03-10 17:04:37 +00:00
|
|
|
if before.shift_after?
|
|
|
|
issue_to_move = self.class.in_projects(project.id).find_by!(relative_position: pos_after)
|
|
|
|
issue_to_move.move_after
|
|
|
|
@positionable_neighbours = [issue_to_move]
|
2017-03-07 17:57:24 +00:00
|
|
|
|
2017-03-10 17:04:37 +00:00
|
|
|
pos_after = issue_to_move.relative_position
|
2017-02-01 18:41:01 +00:00
|
|
|
end
|
|
|
|
|
2017-03-10 17:04:37 +00:00
|
|
|
self.relative_position = position_between(pos_before, pos_after)
|
2017-02-01 18:41:01 +00:00
|
|
|
end
|
|
|
|
|
2017-03-10 17:04:37 +00:00
|
|
|
def move_before(after = self)
|
|
|
|
pos_after = after.relative_position
|
|
|
|
pos_before = after.prev_relative_position
|
|
|
|
|
|
|
|
if after.shift_before?
|
|
|
|
issue_to_move = self.class.in_projects(project.id).find_by!(relative_position: pos_before)
|
|
|
|
issue_to_move.move_before
|
|
|
|
@positionable_neighbours = [issue_to_move]
|
|
|
|
|
|
|
|
pos_before = issue_to_move.relative_position
|
|
|
|
end
|
|
|
|
|
|
|
|
self.relative_position = position_between(pos_before, pos_after)
|
2017-02-01 18:41:01 +00:00
|
|
|
end
|
|
|
|
|
2017-03-07 17:57:24 +00:00
|
|
|
def move_to_end
|
2017-03-10 15:12:31 +00:00
|
|
|
self.relative_position = position_between(max_relative_position || START_POSITION, MAX_POSITION)
|
2017-02-01 18:41:01 +00:00
|
|
|
end
|
|
|
|
|
2017-03-10 17:04:37 +00:00
|
|
|
# Indicates if there is an issue that should be shifted to free the place
|
|
|
|
def shift_after?
|
|
|
|
next_pos = next_relative_position
|
|
|
|
next_pos && (next_pos - relative_position) == 1
|
|
|
|
end
|
|
|
|
|
|
|
|
# Indicates if there is an issue that should be shifted to free the place
|
|
|
|
def shift_before?
|
|
|
|
prev_pos = prev_relative_position
|
|
|
|
prev_pos && (relative_position - prev_pos) == 1
|
|
|
|
end
|
|
|
|
|
2017-02-01 18:41:01 +00:00
|
|
|
private
|
|
|
|
|
2017-03-03 18:10:07 +00:00
|
|
|
# This method takes two integer values (positions) and
|
2017-03-09 14:51:20 +00:00
|
|
|
# calculates the position between them. The range is huge as
|
2017-03-10 17:04:37 +00:00
|
|
|
# the maximum integer value is 2147483647. We are incrementing position by IDEAL_DISTANCE * 2 every time
|
|
|
|
# when we have enough space. If distance is less then IDEAL_DISTANCE we are calculating an average number
|
2017-02-01 18:41:01 +00:00
|
|
|
def position_between(pos_before, pos_after)
|
2017-03-02 16:09:48 +00:00
|
|
|
pos_before ||= MIN_POSITION
|
|
|
|
pos_after ||= MAX_POSITION
|
|
|
|
|
2017-02-01 18:41:01 +00:00
|
|
|
pos_before, pos_after = [pos_before, pos_after].sort
|
|
|
|
|
2017-03-10 17:04:37 +00:00
|
|
|
halfway = (pos_after + pos_before) / 2
|
|
|
|
distance_to_halfway = pos_after - halfway
|
|
|
|
|
|
|
|
if distance_to_halfway < IDEAL_DISTANCE
|
|
|
|
halfway
|
2017-03-09 14:51:20 +00:00
|
|
|
else
|
2017-03-10 15:12:31 +00:00
|
|
|
if pos_before == MIN_POSITION
|
2017-03-10 17:04:37 +00:00
|
|
|
pos_after - IDEAL_DISTANCE
|
2017-03-10 15:12:31 +00:00
|
|
|
elsif pos_after == MAX_POSITION
|
2017-03-10 17:04:37 +00:00
|
|
|
pos_before + IDEAL_DISTANCE
|
2017-03-10 15:12:31 +00:00
|
|
|
else
|
2017-03-10 17:04:37 +00:00
|
|
|
halfway
|
2017-03-10 15:12:31 +00:00
|
|
|
end
|
2017-03-09 14:51:20 +00:00
|
|
|
end
|
2017-02-01 18:41:01 +00:00
|
|
|
end
|
2017-03-07 17:57:24 +00:00
|
|
|
|
|
|
|
def save_positionable_neighbours
|
|
|
|
return unless @positionable_neighbours
|
|
|
|
|
|
|
|
status = @positionable_neighbours.all?(&:save)
|
|
|
|
@positionable_neighbours = nil
|
|
|
|
|
|
|
|
status
|
|
|
|
end
|
2017-02-01 18:41:01 +00:00
|
|
|
end
|