2012-10-02 15:17:12 +00:00
|
|
|
require 'spec_helper'
|
|
|
|
|
2015-12-09 09:50:51 +00:00
|
|
|
describe Group, models: true do
|
2016-11-11 12:51:50 +00:00
|
|
|
let!(:group) { create(:group, :access_requestable) }
|
2012-10-02 15:20:46 +00:00
|
|
|
|
2015-05-03 03:11:21 +00:00
|
|
|
describe 'associations' do
|
2015-02-12 18:17:35 +00:00
|
|
|
it { is_expected.to have_many :projects }
|
2016-04-18 16:53:32 +00:00
|
|
|
it { is_expected.to have_many(:group_members).dependent(:destroy) }
|
|
|
|
it { is_expected.to have_many(:users).through(:group_members) }
|
2016-06-27 14:20:57 +00:00
|
|
|
it { is_expected.to have_many(:owners).through(:group_members) }
|
|
|
|
it { is_expected.to have_many(:requesters).dependent(:destroy) }
|
2016-04-18 16:53:32 +00:00
|
|
|
it { is_expected.to have_many(:project_group_links).dependent(:destroy) }
|
|
|
|
it { is_expected.to have_many(:shared_projects).through(:project_group_links) }
|
|
|
|
it { is_expected.to have_many(:notification_settings).dependent(:destroy) }
|
2016-09-19 15:04:38 +00:00
|
|
|
it { is_expected.to have_many(:labels).class_name('GroupLabel') }
|
2016-06-27 14:20:57 +00:00
|
|
|
|
|
|
|
describe '#members & #requesters' do
|
|
|
|
let(:requester) { create(:user) }
|
|
|
|
let(:developer) { create(:user) }
|
|
|
|
before do
|
|
|
|
group.request_access(requester)
|
|
|
|
group.add_developer(developer)
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#members' do
|
|
|
|
it 'includes members and exclude requesters' do
|
|
|
|
member_user_ids = group.members.pluck(:user_id)
|
|
|
|
|
|
|
|
expect(member_user_ids).to include(developer.id)
|
|
|
|
expect(member_user_ids).not_to include(requester.id)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#requesters' do
|
|
|
|
it 'does not include requesters' do
|
|
|
|
requester_user_ids = group.requesters.pluck(:user_id)
|
|
|
|
|
|
|
|
expect(requester_user_ids).to include(requester.id)
|
|
|
|
expect(requester_user_ids).not_to include(developer.id)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2013-06-26 12:32:09 +00:00
|
|
|
end
|
|
|
|
|
2015-05-03 03:11:21 +00:00
|
|
|
describe 'modules' do
|
|
|
|
subject { described_class }
|
|
|
|
|
|
|
|
it { is_expected.to include_module(Referable) }
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'validations' do
|
|
|
|
it { is_expected.to validate_presence_of :name }
|
2016-12-07 17:15:26 +00:00
|
|
|
it { is_expected.to validate_uniqueness_of(:name).scoped_to(:parent_id) }
|
2015-05-03 03:11:21 +00:00
|
|
|
it { is_expected.to validate_presence_of :path }
|
|
|
|
it { is_expected.not_to validate_presence_of :owner }
|
|
|
|
end
|
|
|
|
|
2015-11-18 11:27:21 +00:00
|
|
|
describe '.visible_to_user' do
|
|
|
|
let!(:group) { create(:group) }
|
|
|
|
let!(:user) { create(:user) }
|
|
|
|
|
|
|
|
subject { described_class.visible_to_user(user) }
|
|
|
|
|
|
|
|
describe 'when the user has access to a group' do
|
|
|
|
before do
|
|
|
|
group.add_user(user, Gitlab::Access::MASTER)
|
|
|
|
end
|
|
|
|
|
|
|
|
it { is_expected.to eq([group]) }
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'when the user does not have access to any groups' do
|
|
|
|
it { is_expected.to eq([]) }
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2016-03-01 15:22:29 +00:00
|
|
|
describe 'scopes' do
|
2016-03-18 12:28:16 +00:00
|
|
|
let!(:private_group) { create(:group, :private) }
|
|
|
|
let!(:internal_group) { create(:group, :internal) }
|
2016-03-01 15:22:29 +00:00
|
|
|
|
|
|
|
describe 'public_only' do
|
2016-03-18 12:28:16 +00:00
|
|
|
subject { described_class.public_only.to_a }
|
2016-03-01 15:22:29 +00:00
|
|
|
|
2017-01-20 11:25:53 +00:00
|
|
|
it { is_expected.to eq([group]) }
|
2016-03-01 15:22:29 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
describe 'public_and_internal_only' do
|
2016-03-21 23:09:20 +00:00
|
|
|
subject { described_class.public_and_internal_only.to_a }
|
2016-03-01 15:22:29 +00:00
|
|
|
|
2017-01-20 11:25:53 +00:00
|
|
|
it { is_expected.to match_array([group, internal_group]) }
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'non_public_only' do
|
|
|
|
subject { described_class.non_public_only.to_a }
|
|
|
|
|
|
|
|
it { is_expected.to match_array([private_group, internal_group]) }
|
2016-03-01 15:22:29 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2015-05-03 03:11:21 +00:00
|
|
|
describe '#to_reference' do
|
|
|
|
it 'returns a String reference to the object' do
|
|
|
|
expect(group.to_reference).to eq "@#{group.name}"
|
|
|
|
end
|
|
|
|
end
|
2012-11-21 04:14:05 +00:00
|
|
|
|
2016-07-11 22:12:31 +00:00
|
|
|
describe '#users' do
|
2015-02-12 18:17:35 +00:00
|
|
|
it { expect(group.users).to eq(group.owners) }
|
2012-11-21 04:14:05 +00:00
|
|
|
end
|
|
|
|
|
2016-07-11 22:12:31 +00:00
|
|
|
describe '#human_name' do
|
2015-02-12 18:17:35 +00:00
|
|
|
it { expect(group.human_name).to eq(group.name) }
|
2012-11-21 04:14:05 +00:00
|
|
|
end
|
2013-06-26 12:32:09 +00:00
|
|
|
|
2016-07-11 22:12:31 +00:00
|
|
|
describe '#add_user' do
|
2013-06-26 12:32:09 +00:00
|
|
|
let(:user) { create(:user) }
|
2014-09-14 16:32:51 +00:00
|
|
|
before { group.add_user(user, GroupMember::MASTER) }
|
2013-06-26 12:32:09 +00:00
|
|
|
|
2015-02-12 18:17:35 +00:00
|
|
|
it { expect(group.group_members.masters.map(&:user)).to include(user) }
|
2013-06-26 12:32:09 +00:00
|
|
|
end
|
2013-10-14 12:27:27 +00:00
|
|
|
|
2016-07-11 22:12:31 +00:00
|
|
|
describe '#add_users' do
|
2013-10-14 12:27:27 +00:00
|
|
|
let(:user) { create(:user) }
|
2014-09-14 16:32:51 +00:00
|
|
|
before { group.add_users([user.id], GroupMember::GUEST) }
|
2013-10-14 12:27:27 +00:00
|
|
|
|
2016-08-01 15:00:44 +00:00
|
|
|
it "updates the group permission" do
|
2015-02-12 18:17:35 +00:00
|
|
|
expect(group.group_members.guests.map(&:user)).to include(user)
|
2014-09-14 16:32:51 +00:00
|
|
|
group.add_users([user.id], GroupMember::DEVELOPER)
|
2015-02-12 18:17:35 +00:00
|
|
|
expect(group.group_members.developers.map(&:user)).to include(user)
|
|
|
|
expect(group.group_members.guests.map(&:user)).not_to include(user)
|
2013-10-14 12:27:27 +00:00
|
|
|
end
|
|
|
|
end
|
2014-01-27 21:34:05 +00:00
|
|
|
|
2016-07-11 22:12:31 +00:00
|
|
|
describe '#avatar_type' do
|
2014-01-27 21:34:05 +00:00
|
|
|
let(:user) { create(:user) }
|
2014-09-14 16:32:51 +00:00
|
|
|
before { group.add_user(user, GroupMember::MASTER) }
|
2014-01-27 21:34:05 +00:00
|
|
|
|
2016-08-01 15:00:44 +00:00
|
|
|
it "is true if avatar is image" do
|
2014-01-27 21:34:05 +00:00
|
|
|
group.update_attribute(:avatar, 'uploads/avatar.png')
|
2015-02-12 18:17:35 +00:00
|
|
|
expect(group.avatar_type).to be_truthy
|
2014-01-27 21:34:05 +00:00
|
|
|
end
|
|
|
|
|
2016-08-01 15:00:44 +00:00
|
|
|
it "is false if avatar is html page" do
|
2014-01-27 21:34:05 +00:00
|
|
|
group.update_attribute(:avatar, 'uploads/avatar.html')
|
2015-02-12 18:17:35 +00:00
|
|
|
expect(group.avatar_type).to eq(["only images allowed"])
|
2014-01-27 21:34:05 +00:00
|
|
|
end
|
|
|
|
end
|
2016-03-01 15:15:42 +00:00
|
|
|
|
|
|
|
describe '.search' do
|
|
|
|
it 'returns groups with a matching name' do
|
|
|
|
expect(described_class.search(group.name)).to eq([group])
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns groups with a partially matching name' do
|
|
|
|
expect(described_class.search(group.name[0..2])).to eq([group])
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns groups with a matching name regardless of the casing' do
|
|
|
|
expect(described_class.search(group.name.upcase)).to eq([group])
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns groups with a matching path' do
|
|
|
|
expect(described_class.search(group.path)).to eq([group])
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns groups with a partially matching path' do
|
|
|
|
expect(described_class.search(group.path[0..2])).to eq([group])
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns groups with a matching path regardless of the casing' do
|
|
|
|
expect(described_class.search(group.path.upcase)).to eq([group])
|
|
|
|
end
|
|
|
|
end
|
2016-04-18 16:53:32 +00:00
|
|
|
|
|
|
|
describe '#has_owner?' do
|
|
|
|
before { @members = setup_group_members(group) }
|
|
|
|
|
|
|
|
it { expect(group.has_owner?(@members[:owner])).to be_truthy }
|
|
|
|
it { expect(group.has_owner?(@members[:master])).to be_falsey }
|
|
|
|
it { expect(group.has_owner?(@members[:developer])).to be_falsey }
|
|
|
|
it { expect(group.has_owner?(@members[:reporter])).to be_falsey }
|
|
|
|
it { expect(group.has_owner?(@members[:guest])).to be_falsey }
|
|
|
|
it { expect(group.has_owner?(@members[:requester])).to be_falsey }
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#has_master?' do
|
|
|
|
before { @members = setup_group_members(group) }
|
|
|
|
|
|
|
|
it { expect(group.has_master?(@members[:owner])).to be_falsey }
|
|
|
|
it { expect(group.has_master?(@members[:master])).to be_truthy }
|
|
|
|
it { expect(group.has_master?(@members[:developer])).to be_falsey }
|
|
|
|
it { expect(group.has_master?(@members[:reporter])).to be_falsey }
|
|
|
|
it { expect(group.has_master?(@members[:guest])).to be_falsey }
|
|
|
|
it { expect(group.has_master?(@members[:requester])).to be_falsey }
|
|
|
|
end
|
|
|
|
|
2016-09-06 16:48:00 +00:00
|
|
|
describe '#lfs_enabled?' do
|
|
|
|
context 'LFS enabled globally' do
|
|
|
|
before do
|
|
|
|
allow(Gitlab.config.lfs).to receive(:enabled).and_return(true)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns true when nothing is set' do
|
|
|
|
expect(group.lfs_enabled?).to be_truthy
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns false when set to false' do
|
|
|
|
group.update_attribute(:lfs_enabled, false)
|
|
|
|
|
|
|
|
expect(group.lfs_enabled?).to be_falsey
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns true when set to true' do
|
|
|
|
group.update_attribute(:lfs_enabled, true)
|
|
|
|
|
|
|
|
expect(group.lfs_enabled?).to be_truthy
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'LFS disabled globally' do
|
|
|
|
before do
|
|
|
|
allow(Gitlab.config.lfs).to receive(:enabled).and_return(false)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns false when nothing is set' do
|
|
|
|
expect(group.lfs_enabled?).to be_falsey
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns false when set to false' do
|
|
|
|
group.update_attribute(:lfs_enabled, false)
|
|
|
|
|
|
|
|
expect(group.lfs_enabled?).to be_falsey
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns false when set to true' do
|
|
|
|
group.update_attribute(:lfs_enabled, true)
|
|
|
|
|
|
|
|
expect(group.lfs_enabled?).to be_falsey
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2016-06-15 13:22:05 +00:00
|
|
|
describe '#owners' do
|
|
|
|
let(:owner) { create(:user) }
|
|
|
|
let(:developer) { create(:user) }
|
|
|
|
|
|
|
|
it 'returns the owners of a Group' do
|
|
|
|
group.add_owner(owner)
|
|
|
|
group.add_developer(developer)
|
|
|
|
|
|
|
|
expect(group.owners).to eq([owner])
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2016-04-18 16:53:32 +00:00
|
|
|
def setup_group_members(group)
|
|
|
|
members = {
|
|
|
|
owner: create(:user),
|
|
|
|
master: create(:user),
|
|
|
|
developer: create(:user),
|
|
|
|
reporter: create(:user),
|
|
|
|
guest: create(:user),
|
|
|
|
requester: create(:user)
|
|
|
|
}
|
|
|
|
|
|
|
|
group.add_user(members[:owner], GroupMember::OWNER)
|
|
|
|
group.add_user(members[:master], GroupMember::MASTER)
|
|
|
|
group.add_user(members[:developer], GroupMember::DEVELOPER)
|
|
|
|
group.add_user(members[:reporter], GroupMember::REPORTER)
|
|
|
|
group.add_user(members[:guest], GroupMember::GUEST)
|
|
|
|
group.request_access(members[:requester])
|
|
|
|
|
|
|
|
members
|
|
|
|
end
|
2016-10-26 18:13:58 +00:00
|
|
|
|
|
|
|
describe '#web_url' do
|
|
|
|
it 'returns the canonical URL' do
|
|
|
|
expect(group.web_url).to include("groups/#{group.name}")
|
|
|
|
end
|
2017-01-24 13:40:01 +00:00
|
|
|
|
|
|
|
context 'nested group' do
|
|
|
|
let(:nested_group) { create(:group, :nested) }
|
|
|
|
|
|
|
|
it { expect(nested_group.web_url).to include("groups/#{nested_group.full_path}") }
|
|
|
|
end
|
2016-10-26 18:13:58 +00:00
|
|
|
end
|
2016-12-07 17:16:17 +00:00
|
|
|
|
|
|
|
describe 'nested group' do
|
2016-12-13 17:46:06 +00:00
|
|
|
subject { build(:group, :nested) }
|
2016-12-07 17:16:17 +00:00
|
|
|
|
|
|
|
it { is_expected.to be_valid }
|
|
|
|
it { expect(subject.parent).to be_kind_of(Group) }
|
|
|
|
end
|
2016-12-13 18:59:39 +00:00
|
|
|
|
|
|
|
describe '#members_with_parents' do
|
|
|
|
let!(:group) { create(:group, :nested) }
|
|
|
|
let!(:master) { group.parent.add_user(create(:user), GroupMember::MASTER) }
|
|
|
|
let!(:developer) { group.add_user(create(:user), GroupMember::DEVELOPER) }
|
|
|
|
|
|
|
|
it 'returns parents members' do
|
|
|
|
expect(group.members_with_parents).to include(developer)
|
|
|
|
expect(group.members_with_parents).to include(master)
|
|
|
|
end
|
|
|
|
end
|
2017-02-07 13:55:42 +00:00
|
|
|
|
|
|
|
describe '#user_ids_for_project_authorizations' do
|
|
|
|
it 'returns the user IDs for which to refresh authorizations' do
|
|
|
|
master = create(:user)
|
|
|
|
developer = create(:user)
|
|
|
|
|
|
|
|
group.add_user(master, GroupMember::MASTER)
|
|
|
|
group.add_user(developer, GroupMember::DEVELOPER)
|
|
|
|
|
|
|
|
expect(group.user_ids_for_project_authorizations).
|
|
|
|
to include(master.id, developer.id)
|
|
|
|
end
|
|
|
|
end
|
2012-10-02 15:17:12 +00:00
|
|
|
end
|