gitlab-org--gitlab-foss/spec/finders/groups_finder_spec.rb

278 lines
11 KiB
Ruby
Raw Normal View History

# frozen_string_literal: true
2016-03-01 10:22:29 -05:00
require 'spec_helper'
RSpec.describe GroupsFinder do
include AdminModeHelper
shared_examples '#execute' do
let(:user) { create(:user) }
2016-03-01 10:22:29 -05:00
describe 'root level groups' do
using RSpec::Parameterized::TableSyntax
where(:user_type, :params, :results) do
nil | { all_available: true } | %i(public_group user_public_group)
nil | { all_available: false } | %i(public_group user_public_group)
nil | {} | %i(public_group user_public_group)
:regular | { all_available: true } | %i(public_group internal_group user_public_group user_internal_group
user_private_group)
:regular | { all_available: false } | %i(user_public_group user_internal_group user_private_group)
:regular | {} | %i(public_group internal_group user_public_group user_internal_group user_private_group)
:regular | { min_access_level: Gitlab::Access::DEVELOPER } | %i(user_public_group user_internal_group user_private_group)
:external | { all_available: true } | %i(public_group user_public_group user_internal_group user_private_group)
:external | { all_available: false } | %i(user_public_group user_internal_group user_private_group)
:external | {} | %i(public_group user_public_group user_internal_group user_private_group)
2016-03-01 10:22:29 -05:00
:admin_without_admin_mode | { all_available: true } | %i(public_group internal_group user_public_group
user_internal_group user_private_group)
:admin_without_admin_mode | { all_available: false } | %i(user_public_group user_internal_group user_private_group)
:admin_without_admin_mode | {} | %i(public_group internal_group user_public_group user_internal_group user_private_group)
:admin_with_admin_mode | { all_available: true } | %i(public_group internal_group private_group user_public_group
user_internal_group user_private_group)
:admin_with_admin_mode | { all_available: false } | %i(user_public_group user_internal_group user_private_group)
:admin_with_admin_mode | {} | %i(public_group internal_group private_group user_public_group user_internal_group
user_private_group)
2016-03-01 10:22:29 -05:00
end
with_them do
before do
# Fixme: Because of an issue: https://github.com/tomykaira/rspec-parameterized/issues/8#issuecomment-381888428
# The groups need to be created here, not with let syntax, and also compared by name and not ids
2016-03-01 10:22:29 -05:00
@groups = {
private_group: create(:group, :private, name: 'private_group'),
internal_group: create(:group, :internal, name: 'internal_group'),
public_group: create(:group, :public, name: 'public_group'),
2016-03-17 18:42:46 -04:00
user_private_group: create(:group, :private, name: 'user_private_group'),
user_internal_group: create(:group, :internal, name: 'user_internal_group'),
user_public_group: create(:group, :public, name: 'user_public_group')
}
2016-03-18 08:28:16 -04:00
if user_type
user =
case user_type
when :regular
create(:user)
when :external
create(:user, external: true)
when :admin_without_admin_mode
create(:user, :admin)
when :admin_with_admin_mode
admin = create(:user, :admin)
enable_admin_mode!(admin)
admin
end
@groups.values_at(:user_private_group, :user_internal_group, :user_public_group).each do |group|
group.add_developer(user)
end
end
end
subject { described_class.new(User.last, params).execute.to_a }
it { is_expected.to match_array(@groups.values_at(*results)) }
end
end
context 'subgroups' do
let(:user) { create(:user) }
let!(:parent_group) { create(:group, :public) }
let!(:public_subgroup) { create(:group, :public, parent: parent_group) }
let!(:internal_subgroup) { create(:group, :internal, parent: parent_group) }
let!(:private_subgroup) { create(:group, :private, parent: parent_group) }
context 'with [nil] parent' do
it 'returns only top-level groups' do
expect(described_class.new(user, parent: [nil]).execute).to contain_exactly(parent_group)
end
end
context 'without a user' do
it 'only returns parent and public subgroups' do
expect(described_class.new(nil).execute).to contain_exactly(parent_group, public_subgroup)
end
end
context 'with a user' do
subject { described_class.new(user).execute }
it 'returns parent, public, and internal subgroups' do
is_expected.to contain_exactly(parent_group, public_subgroup, internal_subgroup)
end
context 'being member' do
it 'returns parent, public subgroups, internal subgroups, and private subgroups user is member of' do
private_subgroup.add_guest(user)
is_expected.to contain_exactly(parent_group, public_subgroup, internal_subgroup, private_subgroup)
end
end
context 'parent group private' do
before do
parent_group.update_attribute(:visibility_level, Gitlab::VisibilityLevel::PRIVATE)
end
context 'being member of parent group' do
it 'returns all subgroups' do
parent_group.add_guest(user)
is_expected.to contain_exactly(parent_group, public_subgroup, internal_subgroup, private_subgroup)
end
end
context 'authorized to private project' do
context 'project one level deep' do
let!(:subproject) { create(:project, :private, namespace: private_subgroup) }
before do
subproject.add_guest(user)
end
it 'includes the subgroup of the project' do
is_expected.to include(private_subgroup)
end
it 'does not include private subgroups deeper down' do
subsubgroup = create(:group, :private, parent: private_subgroup)
is_expected.not_to include(subsubgroup)
end
end
context 'project two levels deep' do
let!(:private_subsubgroup) { create(:group, :private, parent: private_subgroup) }
let!(:subsubproject) { create(:project, :private, namespace: private_subsubgroup) }
before do
subsubproject.add_guest(user)
end
it 'returns all the ancestor groups' do
is_expected.to include(private_subsubgroup, private_subgroup, parent_group)
end
it 'returns the groups for a given parent' do
expect(described_class.new(user, parent: parent_group).execute).to include(private_subgroup)
end
end
end
context 'being minimal access member of parent group' do
it 'do not return group with minimal_access access' do
create(:group_member, :minimal_access, user: user, source: parent_group)
is_expected.to contain_exactly(public_subgroup, internal_subgroup)
end
end
2016-03-17 18:42:46 -04:00
end
2016-03-01 10:22:29 -05:00
end
end
context 'with include parent group descendants' do
let_it_be(:user) { create(:user) }
let_it_be(:parent_group) { create(:group, :public) }
let_it_be(:public_subgroup) { create(:group, :public, parent: parent_group) }
let_it_be(:internal_sub_subgroup) { create(:group, :internal, parent: public_subgroup) }
let_it_be(:private_sub_subgroup) { create(:group, :private, parent: public_subgroup) }
let_it_be(:public_sub_subgroup) { create(:group, :public, parent: public_subgroup) }
let(:params) { { include_parent_descendants: true, parent: parent_group } }
context 'with nil parent' do
it 'returns all accessible groups' do
params[:parent] = nil
expect(described_class.new(user, params).execute).to contain_exactly(
parent_group,
public_subgroup,
internal_sub_subgroup,
public_sub_subgroup
)
end
end
context 'without a user' do
it 'only returns the group public descendants' do
expect(described_class.new(nil, params).execute).to contain_exactly(
public_subgroup,
public_sub_subgroup
)
end
end
context 'when a user is present' do
it 'returns the group public and internal descendants' do
expect(described_class.new(user, params).execute).to contain_exactly(
public_subgroup,
public_sub_subgroup,
internal_sub_subgroup
)
end
end
context 'when a parent group member is present' do
before do
parent_group.add_developer(user)
end
it 'returns all group descendants' do
expect(described_class.new(user, params).execute).to contain_exactly(
public_subgroup,
public_sub_subgroup,
internal_sub_subgroup,
private_sub_subgroup
)
end
end
end
context 'with search' do
let_it_be(:parent_group) { create(:group, :public, name: 'Parent Group') }
let_it_be(:test_group) { create(:group, :public, path: 'test-path') }
it 'returns all groups with matching title' do
expect(described_class.new(user, { search: 'parent' }).execute).to contain_exactly(parent_group)
end
it 'returns all groups with matching path' do
expect(described_class.new(user, { search: 'test' }).execute).to contain_exactly(test_group)
end
it 'does not search in full path if parent is set' do
matching_subgroup = create(:group, parent: parent_group, path: "#{parent_group.path}-subgroup")
expect(described_class.new(user, { search: 'parent', parent: parent_group }).execute).to contain_exactly(matching_subgroup)
end
context 'with group descendants' do
let_it_be(:sub_group) { create(:group, :public, name: 'Sub Group', parent: parent_group) }
let(:params) { { search: parent_group.path } }
it 'searches in full path if descendant groups are not included' do
params[:include_parent_descendants] = false
expect(described_class.new(user, params).execute).to contain_exactly(parent_group, sub_group)
end
end
end
2016-03-01 10:22:29 -05:00
end
describe '#execute' do
include_examples '#execute'
context 'when use_traversal_ids_groups_finder feature flags is disabled' do
before do
stub_feature_flags(use_traversal_ids_groups_finder: false)
end
include_examples '#execute'
end
end
2016-03-01 10:22:29 -05:00
end