gitlab-org--gitlab-foss/spec/features/merge_requests/only_allow_merge_if_build_s...

151 lines
3.8 KiB
Ruby
Raw Normal View History

require 'spec_helper'
feature 'Only allow merge requests to be merged if the pipeline succeeds', :js do
let(:merge_request) { create(:merge_request_with_diffs) }
let(:project) { merge_request.target_project }
before do
sign_in merge_request.author
project.add_master(merge_request.author)
end
context 'project does not have CI enabled', :js do
it 'allows MR to be merged' do
visit_merge_request(merge_request)
wait_for_requests
2017-05-09 04:15:34 +00:00
expect(page).to have_button 'Merge'
end
end
context 'when project has CI enabled', :js do
given!(:pipeline) do
create(:ci_empty_pipeline,
project: project,
sha: merge_request.diff_head_sha,
ref: merge_request.source_branch,
status: status, head_pipeline_of: merge_request)
end
context 'when merge requests can only be merged if the pipeline succeeds' do
before do
project.update_attribute(:only_allow_merge_if_pipeline_succeeds, true)
end
context 'when CI is running' do
given(:status) { :running }
it 'does not allow to merge immediately' do
visit_merge_request(merge_request)
wait_for_requests
2017-05-09 04:15:34 +00:00
expect(page).to have_button 'Merge when pipeline succeeds'
2017-08-07 02:29:37 +00:00
expect(page).not_to have_button '.js-merge-moment'
end
end
context 'when CI failed' do
given(:status) { :failed }
it 'does not allow MR to be merged' do
visit_merge_request(merge_request)
wait_for_requests
2017-05-09 04:15:34 +00:00
expect(page).to have_css('button[disabled="disabled"]', text: 'Merge')
2017-08-07 02:29:37 +00:00
expect(page).to have_content('Please retry the job or push a new commit to fix the failure')
end
end
context 'when CI canceled' do
given(:status) { :canceled }
it 'does not allow MR to be merged' do
visit_merge_request(merge_request)
wait_for_requests
2017-05-09 04:15:34 +00:00
expect(page).not_to have_button 'Merge'
2017-08-07 02:29:37 +00:00
expect(page).to have_content('Please retry the job or push a new commit to fix the failure')
end
end
context 'when CI succeeded' do
given(:status) { :success }
it 'allows MR to be merged' do
visit_merge_request(merge_request)
wait_for_requests
2017-05-09 04:15:34 +00:00
expect(page).to have_button 'Merge'
end
end
context 'when CI skipped' do
given(:status) { :skipped }
it 'allows MR to be merged' do
visit_merge_request(merge_request)
wait_for_requests
2017-05-09 04:15:34 +00:00
expect(page).to have_button 'Merge'
end
end
end
context 'when merge requests can be merged when the build failed' do
before do
project.update_attribute(:only_allow_merge_if_pipeline_succeeds, false)
end
context 'when CI is running' do
given(:status) { :running }
2017-05-09 04:15:34 +00:00
it 'allows MR to be merged immediately' do
visit_merge_request(merge_request)
wait_for_requests
2017-05-09 04:15:34 +00:00
expect(page).to have_button 'Merge when pipeline succeeds'
2017-08-07 02:29:37 +00:00
page.find('.js-merge-moment').click
expect(page).to have_content 'Merge immediately'
end
end
context 'when CI failed' do
given(:status) { :failed }
it 'allows MR to be merged' do
visit_merge_request(merge_request)
wait_for_requests
2017-05-09 04:15:34 +00:00
expect(page).to have_button 'Merge'
end
end
context 'when CI succeeded' do
given(:status) { :success }
it 'allows MR to be merged' do
visit_merge_request(merge_request)
wait_for_requests
2017-05-09 04:15:34 +00:00
expect(page).to have_button 'Merge'
end
end
end
end
def visit_merge_request(merge_request)
visit project_merge_request_path(merge_request.project, merge_request)
end
end