2021-05-19 11:10:40 -04:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
|
|
|
require 'spec_helper'
|
|
|
|
|
|
|
|
RSpec.describe Ci::PendingBuild do
|
|
|
|
let_it_be(:project) { create(:project) }
|
|
|
|
let_it_be(:pipeline) { create(:ci_pipeline, project: project) }
|
|
|
|
|
|
|
|
let(:build) { create(:ci_build, :created, pipeline: pipeline) }
|
|
|
|
|
2021-08-03 08:09:42 -04:00
|
|
|
describe 'associations' do
|
|
|
|
it { is_expected.to belong_to :project }
|
|
|
|
it { is_expected.to belong_to :build }
|
|
|
|
it { is_expected.to belong_to :namespace }
|
|
|
|
end
|
|
|
|
|
2021-08-10 08:11:00 -04:00
|
|
|
describe 'scopes' do
|
|
|
|
describe '.with_instance_runners' do
|
|
|
|
subject(:pending_builds) { described_class.with_instance_runners }
|
|
|
|
|
|
|
|
let!(:pending_build_1) { create(:ci_pending_build, instance_runners_enabled: false) }
|
|
|
|
|
|
|
|
context 'when pending builds cannot be picked up by runner' do
|
|
|
|
it 'returns an empty collection of pending builds' do
|
|
|
|
expect(pending_builds).to be_empty
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when pending builds can be picked up by runner' do
|
|
|
|
let!(:pending_build_2) { create(:ci_pending_build) }
|
|
|
|
|
|
|
|
it 'returns matching pending builds' do
|
|
|
|
expect(pending_builds).to contain_exactly(pending_build_2)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2021-09-16 08:09:35 -04:00
|
|
|
|
|
|
|
describe '.for_tags' do
|
|
|
|
subject(:pending_builds) { described_class.for_tags(tag_ids) }
|
|
|
|
|
|
|
|
let_it_be(:pending_build_with_tags) { create(:ci_pending_build, tag_ids: [1, 2]) }
|
|
|
|
let_it_be(:pending_build_without_tags) { create(:ci_pending_build) }
|
|
|
|
|
|
|
|
context 'when tag_ids match pending builds' do
|
|
|
|
let(:tag_ids) { [1, 2] }
|
|
|
|
|
|
|
|
it 'returns matching pending builds' do
|
|
|
|
expect(pending_builds).to contain_exactly(pending_build_with_tags, pending_build_without_tags)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when tag_ids does not match pending builds' do
|
|
|
|
let(:tag_ids) { [non_existing_record_id] }
|
|
|
|
|
|
|
|
it 'returns matching pending builds without tags' do
|
|
|
|
expect(pending_builds).to contain_exactly(pending_build_without_tags)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when tag_ids is not provided' do
|
|
|
|
context 'with a nil value' do
|
|
|
|
let(:tag_ids) { nil }
|
|
|
|
|
|
|
|
it 'returns matching pending builds without tags' do
|
|
|
|
expect(pending_builds).to contain_exactly(pending_build_without_tags)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'with an empty array' do
|
|
|
|
let(:tag_ids) { [] }
|
|
|
|
|
|
|
|
it 'returns matching pending builds without tags' do
|
|
|
|
expect(pending_builds).to contain_exactly(pending_build_without_tags)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2021-08-10 08:11:00 -04:00
|
|
|
end
|
|
|
|
|
2021-05-19 11:10:40 -04:00
|
|
|
describe '.upsert_from_build!' do
|
|
|
|
context 'another pending entry does not exist' do
|
|
|
|
it 'creates a new pending entry' do
|
|
|
|
result = described_class.upsert_from_build!(build)
|
|
|
|
|
|
|
|
expect(result.rows.dig(0, 0)).to eq build.id
|
|
|
|
expect(build.reload.queuing_entry).to be_present
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when another queuing entry exists for given build' do
|
|
|
|
before do
|
2021-06-21 11:07:30 -04:00
|
|
|
create(:ci_pending_build, build: build, project: project)
|
2021-05-19 11:10:40 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns a build id as a result' do
|
|
|
|
result = described_class.upsert_from_build!(build)
|
|
|
|
|
|
|
|
expect(result.rows.dig(0, 0)).to eq build.id
|
|
|
|
end
|
|
|
|
end
|
2021-07-13 11:08:38 -04:00
|
|
|
|
2021-09-15 11:10:13 -04:00
|
|
|
context 'when project does not have shared runners enabled' do
|
|
|
|
before do
|
|
|
|
project.shared_runners_enabled = false
|
|
|
|
end
|
|
|
|
|
2021-07-13 11:08:38 -04:00
|
|
|
it 'sets instance_runners_enabled to false' do
|
|
|
|
described_class.upsert_from_build!(build)
|
|
|
|
|
|
|
|
expect(described_class.last.instance_runners_enabled).to be_falsey
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when project has shared runner' do
|
|
|
|
let_it_be(:runner) { create(:ci_runner, :instance) }
|
|
|
|
|
2021-09-15 11:10:13 -04:00
|
|
|
before do
|
|
|
|
project.shared_runners_enabled = true
|
|
|
|
end
|
|
|
|
|
2021-11-30 13:14:49 -05:00
|
|
|
context 'when ci_pending_builds_maintain_denormalized_data is enabled' do
|
2021-07-13 11:08:38 -04:00
|
|
|
it 'sets instance_runners_enabled to true' do
|
|
|
|
described_class.upsert_from_build!(build)
|
|
|
|
|
|
|
|
expect(described_class.last.instance_runners_enabled).to be_truthy
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when project is about to be deleted' do
|
|
|
|
before do
|
|
|
|
build.project.update!(pending_delete: true)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'sets instance_runners_enabled to false' do
|
|
|
|
described_class.upsert_from_build!(build)
|
|
|
|
|
|
|
|
expect(described_class.last.instance_runners_enabled).to be_falsey
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when builds are disabled' do
|
|
|
|
before do
|
|
|
|
build.project.project_feature.update!(builds_access_level: false)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'sets instance_runners_enabled to false' do
|
|
|
|
described_class.upsert_from_build!(build)
|
|
|
|
|
|
|
|
expect(described_class.last.instance_runners_enabled).to be_falsey
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2021-11-30 13:14:49 -05:00
|
|
|
context 'when ci_pending_builds_maintain_denormalized_data is disabled' do
|
2021-07-13 11:08:38 -04:00
|
|
|
before do
|
2021-11-30 13:14:49 -05:00
|
|
|
stub_feature_flags(ci_pending_builds_maintain_denormalized_data: false)
|
2021-07-13 11:08:38 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
it 'sets instance_runners_enabled to false' do
|
|
|
|
described_class.upsert_from_build!(build)
|
|
|
|
|
|
|
|
expect(described_class.last.instance_runners_enabled).to be_falsey
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2021-08-20 08:09:31 -04:00
|
|
|
|
|
|
|
context 'when build has tags' do
|
|
|
|
let!(:build) { create(:ci_build, :tags) }
|
|
|
|
|
|
|
|
subject(:ci_pending_build) { described_class.last }
|
|
|
|
|
2021-11-30 13:14:49 -05:00
|
|
|
context 'when ci_pending_builds_maintain_denormalized_data is enabled' do
|
2021-08-20 08:09:31 -04:00
|
|
|
it 'sets tag_ids' do
|
|
|
|
described_class.upsert_from_build!(build)
|
|
|
|
|
|
|
|
expect(ci_pending_build.tag_ids).to eq(build.tags_ids)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2021-11-30 13:14:49 -05:00
|
|
|
context 'when ci_pending_builds_maintain_denormalized_data is disabled' do
|
2021-08-20 08:09:31 -04:00
|
|
|
before do
|
2021-11-30 13:14:49 -05:00
|
|
|
stub_feature_flags(ci_pending_builds_maintain_denormalized_data: false)
|
2021-08-20 08:09:31 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not set tag_ids' do
|
|
|
|
described_class.upsert_from_build!(build)
|
|
|
|
|
|
|
|
expect(ci_pending_build.tag_ids).to be_empty
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2021-09-15 11:10:13 -04:00
|
|
|
|
|
|
|
context 'when a build project is nested in a subgroup' do
|
|
|
|
let(:group) { create(:group, :with_hierarchy, depth: 2, children: 1) }
|
|
|
|
let(:project) { create(:project, namespace: group.descendants.first) }
|
|
|
|
let(:pipeline) { create(:ci_pipeline, project: project) }
|
|
|
|
let(:build) { create(:ci_build, :created, pipeline: pipeline) }
|
|
|
|
|
|
|
|
subject { described_class.last }
|
|
|
|
|
|
|
|
context 'when build can be picked by a group runner' do
|
|
|
|
before do
|
|
|
|
project.group_runners_enabled = true
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'denormalizes namespace traversal ids' do
|
|
|
|
described_class.upsert_from_build!(build)
|
|
|
|
|
|
|
|
expect(subject.namespace_traversal_ids).not_to be_empty
|
|
|
|
expect(subject.namespace_traversal_ids).to eq [group.id, project.namespace.id]
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when build can not be picked by a group runner' do
|
|
|
|
before do
|
|
|
|
project.group_runners_enabled = false
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'creates an empty namespace traversal ids array' do
|
|
|
|
described_class.upsert_from_build!(build)
|
|
|
|
|
|
|
|
expect(subject.namespace_traversal_ids).to be_empty
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2021-05-19 11:10:40 -04:00
|
|
|
end
|
2022-01-07 07:10:47 -05:00
|
|
|
|
|
|
|
it_behaves_like 'cleanup by a loose foreign key' do
|
|
|
|
let!(:parent) { create(:namespace) }
|
|
|
|
let!(:model) { create(:ci_pending_build, namespace: parent) }
|
|
|
|
end
|
2022-01-13 07:14:38 -05:00
|
|
|
|
|
|
|
it_behaves_like 'cleanup by a loose foreign key' do
|
|
|
|
let!(:parent) { create(:project) }
|
|
|
|
let!(:model) { create(:ci_pending_build, project: parent) }
|
|
|
|
end
|
2021-05-19 11:10:40 -04:00
|
|
|
end
|