2019-08-20 11:25:04 -04:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
|
|
|
require 'spec_helper'
|
|
|
|
|
2019-09-10 08:12:05 -04:00
|
|
|
describe Gitlab::SidekiqDaemon::Monitor do
|
2019-08-20 11:25:04 -04:00
|
|
|
let(:monitor) { described_class.new }
|
|
|
|
|
|
|
|
describe '#within_job' do
|
|
|
|
it 'tracks thread' do
|
|
|
|
blk = proc do
|
2019-09-18 14:06:14 -04:00
|
|
|
expect(monitor.jobs.dig('jid', :thread)).not_to be_nil
|
2019-08-20 11:25:04 -04:00
|
|
|
|
|
|
|
"OK"
|
|
|
|
end
|
|
|
|
|
2019-09-18 14:06:14 -04:00
|
|
|
expect(monitor.within_job('worker_class', 'jid', 'queue', &blk)).to eq("OK")
|
2019-08-20 11:25:04 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
context 'when job is canceled' do
|
|
|
|
let(:jid) { SecureRandom.hex }
|
|
|
|
|
|
|
|
before do
|
|
|
|
described_class.cancel_job(jid)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not execute a block' do
|
|
|
|
expect do |blk|
|
2019-09-18 14:06:14 -04:00
|
|
|
monitor.within_job('worker_class', jid, 'queue', &blk)
|
2019-08-20 11:25:04 -04:00
|
|
|
rescue described_class::CancelledError
|
|
|
|
end.not_to yield_control
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'raises exception' do
|
2019-09-18 14:06:14 -04:00
|
|
|
expect { monitor.within_job('worker_class', jid, 'queue') }.to raise_error(
|
2019-08-21 05:32:45 -04:00
|
|
|
described_class::CancelledError)
|
2019-08-20 11:25:04 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2019-10-16 05:07:51 -04:00
|
|
|
describe '#run_thread when notification channel not enabled' do
|
|
|
|
subject { monitor.send(:run_thread) }
|
2019-09-18 14:06:14 -04:00
|
|
|
|
|
|
|
it 'return directly' do
|
|
|
|
allow(monitor).to receive(:notification_channel_enabled?).and_return(nil)
|
|
|
|
|
|
|
|
expect(Sidekiq.logger).not_to receive(:info)
|
|
|
|
expect(Sidekiq.logger).not_to receive(:warn)
|
|
|
|
expect(monitor).not_to receive(:enabled?)
|
|
|
|
expect(monitor).not_to receive(:process_messages)
|
|
|
|
|
|
|
|
subject
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2019-10-16 05:07:51 -04:00
|
|
|
describe '#run_thread when notification channel enabled' do
|
|
|
|
subject { monitor.send(:run_thread) }
|
2019-08-20 11:25:04 -04:00
|
|
|
|
2019-08-21 05:32:45 -04:00
|
|
|
before do
|
|
|
|
# we want to run at most once cycle
|
|
|
|
# we toggle `enabled?` flag after the first call
|
2019-09-10 08:12:05 -04:00
|
|
|
stub_const('Gitlab::SidekiqDaemon::Monitor::RECONNECT_TIME', 0)
|
2019-08-21 05:32:45 -04:00
|
|
|
allow(monitor).to receive(:enabled?).and_return(true, false)
|
2019-09-18 14:06:14 -04:00
|
|
|
allow(monitor).to receive(:notification_channel_enabled?).and_return(1)
|
2019-08-21 05:32:45 -04:00
|
|
|
|
|
|
|
allow(Sidekiq.logger).to receive(:info)
|
|
|
|
allow(Sidekiq.logger).to receive(:warn)
|
|
|
|
end
|
2019-08-20 11:25:04 -04:00
|
|
|
|
2019-08-21 05:32:45 -04:00
|
|
|
context 'when structured logging is used' do
|
2019-08-20 11:25:04 -04:00
|
|
|
it 'logs start message' do
|
|
|
|
expect(Sidekiq.logger).to receive(:info)
|
|
|
|
.with(
|
2019-08-21 06:03:42 -04:00
|
|
|
class: described_class.to_s,
|
2019-08-20 11:25:04 -04:00
|
|
|
action: 'start',
|
|
|
|
message: 'Starting Monitor Daemon')
|
|
|
|
|
2019-08-21 05:32:45 -04:00
|
|
|
expect(::Gitlab::Redis::SharedState).to receive(:with)
|
|
|
|
|
2019-08-20 11:25:04 -04:00
|
|
|
subject
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'logs stop message' do
|
|
|
|
expect(Sidekiq.logger).to receive(:warn)
|
|
|
|
.with(
|
2019-08-21 06:03:42 -04:00
|
|
|
class: described_class.to_s,
|
2019-08-20 11:25:04 -04:00
|
|
|
action: 'stop',
|
|
|
|
message: 'Stopping Monitor Daemon')
|
|
|
|
|
2019-08-21 05:32:45 -04:00
|
|
|
expect(::Gitlab::Redis::SharedState).to receive(:with)
|
|
|
|
|
2019-08-20 11:25:04 -04:00
|
|
|
subject
|
|
|
|
end
|
|
|
|
|
2019-08-21 05:32:45 -04:00
|
|
|
it 'logs StandardError message' do
|
|
|
|
expect(Sidekiq.logger).to receive(:warn)
|
|
|
|
.with(
|
2019-08-21 06:03:42 -04:00
|
|
|
class: described_class.to_s,
|
2019-08-21 05:32:45 -04:00
|
|
|
action: 'exception',
|
|
|
|
message: 'My Exception')
|
|
|
|
|
|
|
|
expect(::Gitlab::Redis::SharedState).to receive(:with)
|
|
|
|
.and_raise(StandardError, 'My Exception')
|
|
|
|
|
|
|
|
expect { subject }.not_to raise_error
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'logs and raises Exception message' do
|
2019-08-20 11:25:04 -04:00
|
|
|
expect(Sidekiq.logger).to receive(:warn)
|
|
|
|
.with(
|
2019-08-21 06:03:42 -04:00
|
|
|
class: described_class.to_s,
|
2019-08-20 11:25:04 -04:00
|
|
|
action: 'exception',
|
|
|
|
message: 'My Exception')
|
|
|
|
|
|
|
|
expect(::Gitlab::Redis::SharedState).to receive(:with)
|
|
|
|
.and_raise(Exception, 'My Exception')
|
|
|
|
|
|
|
|
expect { subject }.to raise_error(Exception, 'My Exception')
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2019-08-21 05:32:45 -04:00
|
|
|
context 'when StandardError is raised' do
|
|
|
|
it 'does retry connection' do
|
|
|
|
expect(::Gitlab::Redis::SharedState).to receive(:with)
|
|
|
|
.and_raise(StandardError, 'My Exception')
|
|
|
|
|
|
|
|
expect(::Gitlab::Redis::SharedState).to receive(:with)
|
|
|
|
|
|
|
|
# we expect to run `process_messages` twice
|
|
|
|
expect(monitor).to receive(:enabled?).and_return(true, true, false)
|
|
|
|
|
|
|
|
subject
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2019-08-20 11:25:04 -04:00
|
|
|
context 'when message is published' do
|
|
|
|
let(:subscribed) { double }
|
|
|
|
|
|
|
|
before do
|
|
|
|
expect_any_instance_of(::Redis).to receive(:subscribe)
|
|
|
|
.and_yield(subscribed)
|
|
|
|
|
|
|
|
expect(subscribed).to receive(:message)
|
|
|
|
.and_yield(
|
|
|
|
described_class::NOTIFICATION_CHANNEL,
|
|
|
|
payload
|
|
|
|
)
|
|
|
|
|
|
|
|
expect(Sidekiq.logger).to receive(:info)
|
|
|
|
.with(
|
2019-08-21 06:03:42 -04:00
|
|
|
class: described_class.to_s,
|
2019-08-20 11:25:04 -04:00
|
|
|
action: 'start',
|
|
|
|
message: 'Starting Monitor Daemon')
|
|
|
|
|
|
|
|
expect(Sidekiq.logger).to receive(:info)
|
|
|
|
.with(
|
2019-08-21 06:03:42 -04:00
|
|
|
class: described_class.to_s,
|
2019-08-20 11:25:04 -04:00
|
|
|
channel: described_class::NOTIFICATION_CHANNEL,
|
|
|
|
message: 'Received payload on channel',
|
|
|
|
payload: payload
|
|
|
|
)
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'and message is valid' do
|
|
|
|
let(:payload) { '{"action":"cancel","jid":"my-jid"}' }
|
|
|
|
|
|
|
|
it 'processes cancel' do
|
|
|
|
expect(monitor).to receive(:process_job_cancel).with('my-jid')
|
|
|
|
|
|
|
|
subject
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'and message is not valid json' do
|
|
|
|
let(:payload) { '{"action"}' }
|
|
|
|
|
|
|
|
it 'skips processing' do
|
|
|
|
expect(monitor).not_to receive(:process_job_cancel)
|
|
|
|
|
|
|
|
subject
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2019-08-21 05:32:45 -04:00
|
|
|
describe '#stop' do
|
|
|
|
let!(:monitor_thread) { monitor.start }
|
|
|
|
|
|
|
|
it 'does stop the thread' do
|
|
|
|
expect(monitor_thread).to be_alive
|
|
|
|
|
|
|
|
expect { monitor.stop }.not_to raise_error
|
|
|
|
|
|
|
|
expect(monitor_thread).not_to be_alive
|
|
|
|
expect { monitor_thread.value }.to raise_error(Interrupt)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2019-08-20 11:25:04 -04:00
|
|
|
describe '#process_job_cancel' do
|
|
|
|
subject { monitor.send(:process_job_cancel, jid) }
|
|
|
|
|
|
|
|
context 'when jid is missing' do
|
|
|
|
let(:jid) { nil }
|
|
|
|
|
|
|
|
it 'does not run thread' do
|
|
|
|
expect(subject).to be_nil
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when jid is provided' do
|
|
|
|
let(:jid) { 'my-jid' }
|
|
|
|
|
|
|
|
context 'when jid is not found' do
|
|
|
|
it 'does not log cancellation message' do
|
|
|
|
expect(Sidekiq.logger).not_to receive(:warn)
|
2019-08-20 15:09:04 -04:00
|
|
|
expect(subject).to be_nil
|
2019-08-20 11:25:04 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when jid is found' do
|
|
|
|
let(:thread) { Thread.new { sleep 1000 } }
|
|
|
|
|
|
|
|
before do
|
2019-09-18 14:06:14 -04:00
|
|
|
monitor.jobs[jid] = { worker_class: 'worker_class', thread: thread, started_at: Time.now.to_i }
|
2019-08-20 11:25:04 -04:00
|
|
|
end
|
|
|
|
|
2019-08-21 05:32:45 -04:00
|
|
|
after do
|
|
|
|
thread.kill
|
|
|
|
rescue
|
|
|
|
end
|
|
|
|
|
2019-08-20 11:25:04 -04:00
|
|
|
it 'does log cancellation message' do
|
|
|
|
expect(Sidekiq.logger).to receive(:warn)
|
|
|
|
.with(
|
2019-08-21 06:03:42 -04:00
|
|
|
class: described_class.to_s,
|
2019-08-20 11:25:04 -04:00
|
|
|
action: 'cancel',
|
|
|
|
message: 'Canceling thread with CancelledError',
|
|
|
|
jid: 'my-jid',
|
|
|
|
thread_id: thread.object_id)
|
|
|
|
|
|
|
|
expect(subject).to be_a(Thread)
|
|
|
|
|
|
|
|
subject.join
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does cancel the thread' do
|
|
|
|
expect(subject).to be_a(Thread)
|
|
|
|
|
|
|
|
subject.join
|
|
|
|
|
2019-08-21 05:32:45 -04:00
|
|
|
# we wait for the thread to be cancelled
|
|
|
|
# by `process_job_cancel`
|
|
|
|
expect { thread.join(5) }.to raise_error(described_class::CancelledError)
|
2019-08-20 11:25:04 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '.cancel_job' do
|
|
|
|
subject { described_class.cancel_job('my-jid') }
|
|
|
|
|
|
|
|
it 'sets a redis key' do
|
|
|
|
expect_any_instance_of(::Redis).to receive(:setex)
|
|
|
|
.with('sidekiq:cancel:my-jid', anything, 1)
|
|
|
|
|
|
|
|
subject
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'notifies all workers' do
|
|
|
|
payload = '{"action":"cancel","jid":"my-jid"}'
|
|
|
|
|
|
|
|
expect_any_instance_of(::Redis).to receive(:publish)
|
|
|
|
.with('sidekiq:cancel:notifications', payload)
|
|
|
|
|
|
|
|
subject
|
|
|
|
end
|
|
|
|
end
|
2019-09-18 14:06:14 -04:00
|
|
|
|
|
|
|
describe '#notification_channel_enabled?' do
|
|
|
|
subject { monitor.send(:notification_channel_enabled?) }
|
|
|
|
|
|
|
|
it 'return nil when SIDEKIQ_MONITOR_WORKER is not set' do
|
|
|
|
expect(subject).to be nil
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'return nil when SIDEKIQ_MONITOR_WORKER set to 0' do
|
|
|
|
allow(ENV).to receive(:fetch).with('SIDEKIQ_MONITOR_WORKER', 0).and_return("0")
|
|
|
|
|
|
|
|
expect(subject).to be nil
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'return 1 when SIDEKIQ_MONITOR_WORKER set to 1' do
|
|
|
|
allow(ENV).to receive(:fetch).with('SIDEKIQ_MONITOR_WORKER', 0).and_return("1")
|
|
|
|
|
|
|
|
expect(subject).to be 1
|
|
|
|
end
|
|
|
|
end
|
2019-08-20 11:25:04 -04:00
|
|
|
end
|