2016-02-12 15:05:17 +00:00
|
|
|
require 'spec_helper'
|
|
|
|
|
2017-07-10 14:24:02 +00:00
|
|
|
describe PagesDomain do
|
2018-02-06 13:25:46 +00:00
|
|
|
using RSpec::Parameterized::TableSyntax
|
|
|
|
|
|
|
|
subject(:pages_domain) { described_class.new }
|
|
|
|
|
2016-02-12 15:05:17 +00:00
|
|
|
describe 'associations' do
|
|
|
|
it { is_expected.to belong_to(:project) }
|
|
|
|
end
|
2016-12-20 11:24:44 +00:00
|
|
|
|
2017-03-24 23:04:03 +00:00
|
|
|
describe 'validate domain' do
|
2017-05-19 14:07:38 +00:00
|
|
|
subject(:pages_domain) { build(:pages_domain, domain: domain) }
|
2016-02-12 15:05:17 +00:00
|
|
|
|
|
|
|
context 'is unique' do
|
|
|
|
let(:domain) { 'my.domain.com' }
|
|
|
|
|
2017-07-24 12:33:14 +00:00
|
|
|
it { is_expected.to validate_uniqueness_of(:domain).case_insensitive }
|
2016-02-12 15:05:17 +00:00
|
|
|
end
|
|
|
|
|
2017-05-19 14:07:38 +00:00
|
|
|
{
|
|
|
|
'my.domain.com' => true,
|
|
|
|
'123.456.789' => true,
|
|
|
|
'0x12345.com' => true,
|
|
|
|
'0123123' => true,
|
|
|
|
'_foo.com' => false,
|
|
|
|
'reserved.com' => false,
|
|
|
|
'a.reserved.com' => false,
|
|
|
|
nil => false
|
|
|
|
}.each do |value, validity|
|
|
|
|
context "domain #{value.inspect} validity" do
|
|
|
|
before do
|
|
|
|
allow(Settings.pages).to receive(:host).and_return('reserved.com')
|
|
|
|
end
|
|
|
|
|
|
|
|
let(:domain) { value }
|
|
|
|
|
|
|
|
it { expect(pages_domain.valid?).to eq(validity) }
|
|
|
|
end
|
2016-02-12 15:05:17 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'validate certificate' do
|
|
|
|
subject { domain }
|
|
|
|
|
|
|
|
context 'when only certificate is specified' do
|
|
|
|
let(:domain) { build(:pages_domain, :with_certificate) }
|
|
|
|
|
2016-05-30 08:11:46 +00:00
|
|
|
it { is_expected.not_to be_valid }
|
2016-02-12 15:05:17 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
context 'when only key is specified' do
|
|
|
|
let(:domain) { build(:pages_domain, :with_key) }
|
|
|
|
|
2016-05-30 08:11:46 +00:00
|
|
|
it { is_expected.not_to be_valid }
|
2016-02-12 15:05:17 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
context 'with matching key' do
|
|
|
|
let(:domain) { build(:pages_domain, :with_certificate, :with_key) }
|
|
|
|
|
|
|
|
it { is_expected.to be_valid }
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'for not matching key' do
|
2016-02-16 13:39:58 +00:00
|
|
|
let(:domain) { build(:pages_domain, :with_missing_chain, :with_key) }
|
2016-02-12 15:05:17 +00:00
|
|
|
|
2016-05-30 08:11:46 +00:00
|
|
|
it { is_expected.not_to be_valid }
|
2016-02-12 15:05:17 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2018-02-06 13:25:46 +00:00
|
|
|
describe 'validations' do
|
|
|
|
it { is_expected.to validate_presence_of(:verification_code) }
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#verification_code' do
|
|
|
|
subject { pages_domain.verification_code }
|
|
|
|
|
|
|
|
it 'is set automatically with 128 bits of SecureRandom data' do
|
|
|
|
expect(SecureRandom).to receive(:hex).with(16) { 'verification code' }
|
|
|
|
|
|
|
|
is_expected.to eq('verification code')
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#keyed_verification_code' do
|
|
|
|
subject { pages_domain.keyed_verification_code }
|
|
|
|
|
|
|
|
it { is_expected.to eq("gitlab-pages-verification-code=#{pages_domain.verification_code}") }
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#verification_domain' do
|
|
|
|
subject { pages_domain.verification_domain }
|
|
|
|
|
|
|
|
it { is_expected.to be_nil }
|
|
|
|
|
|
|
|
it 'is a well-known subdomain if the domain is present' do
|
|
|
|
pages_domain.domain = 'example.com'
|
|
|
|
|
|
|
|
is_expected.to eq('_gitlab-pages-verification-code.example.com')
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2017-03-24 23:04:03 +00:00
|
|
|
describe '#url' do
|
2016-02-12 15:05:17 +00:00
|
|
|
subject { domain.url }
|
|
|
|
|
|
|
|
context 'without the certificate' do
|
2018-01-08 01:27:19 +00:00
|
|
|
let(:domain) { build(:pages_domain, certificate: '') }
|
2016-02-12 15:05:17 +00:00
|
|
|
|
2018-02-06 13:25:46 +00:00
|
|
|
it { is_expected.to eq("http://#{domain.domain}") }
|
2016-02-12 15:05:17 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
context 'with a certificate' do
|
|
|
|
let(:domain) { build(:pages_domain, :with_certificate) }
|
|
|
|
|
2018-02-06 13:25:46 +00:00
|
|
|
it { is_expected.to eq("https://#{domain.domain}") }
|
2016-02-12 15:05:17 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2017-03-24 23:04:03 +00:00
|
|
|
describe '#has_matching_key?' do
|
2016-02-12 15:05:17 +00:00
|
|
|
subject { domain.has_matching_key? }
|
|
|
|
|
|
|
|
context 'for matching key' do
|
|
|
|
let(:domain) { build(:pages_domain, :with_certificate, :with_key) }
|
|
|
|
|
|
|
|
it { is_expected.to be_truthy }
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'for invalid key' do
|
2016-02-16 13:39:58 +00:00
|
|
|
let(:domain) { build(:pages_domain, :with_missing_chain, :with_key) }
|
2016-02-12 15:05:17 +00:00
|
|
|
|
|
|
|
it { is_expected.to be_falsey }
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2017-03-24 23:04:03 +00:00
|
|
|
describe '#has_intermediates?' do
|
2016-02-12 15:05:17 +00:00
|
|
|
subject { domain.has_intermediates? }
|
|
|
|
|
|
|
|
context 'for self signed' do
|
|
|
|
let(:domain) { build(:pages_domain, :with_certificate) }
|
|
|
|
|
|
|
|
it { is_expected.to be_truthy }
|
|
|
|
end
|
|
|
|
|
2016-02-16 13:39:58 +00:00
|
|
|
context 'for missing certificate chain' do
|
|
|
|
let(:domain) { build(:pages_domain, :with_missing_chain) }
|
2016-02-12 15:05:17 +00:00
|
|
|
|
|
|
|
it { is_expected.to be_falsey }
|
|
|
|
end
|
2016-02-16 13:39:58 +00:00
|
|
|
|
|
|
|
context 'for trusted certificate chain' do
|
2016-02-17 09:05:26 +00:00
|
|
|
# We only validate that we can to rebuild the trust chain, for certificates
|
|
|
|
# We assume that 'AddTrustExternalCARoot' needed to validate the chain is in trusted store.
|
|
|
|
# It will be if ca-certificates is installed on Debian/Ubuntu/Alpine
|
|
|
|
|
2016-02-16 13:39:58 +00:00
|
|
|
let(:domain) { build(:pages_domain, :with_trusted_chain) }
|
|
|
|
|
|
|
|
it { is_expected.to be_truthy }
|
|
|
|
end
|
2016-02-12 15:05:17 +00:00
|
|
|
end
|
|
|
|
|
2017-03-24 23:04:03 +00:00
|
|
|
describe '#expired?' do
|
2016-02-12 15:05:17 +00:00
|
|
|
subject { domain.expired? }
|
|
|
|
|
|
|
|
context 'for valid' do
|
|
|
|
let(:domain) { build(:pages_domain, :with_certificate) }
|
|
|
|
|
|
|
|
it { is_expected.to be_falsey }
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'for expired' do
|
|
|
|
let(:domain) { build(:pages_domain, :with_expired_certificate) }
|
|
|
|
|
|
|
|
it { is_expected.to be_truthy }
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2017-03-24 23:04:03 +00:00
|
|
|
describe '#subject' do
|
2016-02-12 15:05:17 +00:00
|
|
|
let(:domain) { build(:pages_domain, :with_certificate) }
|
|
|
|
|
|
|
|
subject { domain.subject }
|
|
|
|
|
|
|
|
it { is_expected.to eq('/CN=test-certificate') }
|
|
|
|
end
|
|
|
|
|
2017-03-24 23:04:03 +00:00
|
|
|
describe '#certificate_text' do
|
2016-02-12 15:05:17 +00:00
|
|
|
let(:domain) { build(:pages_domain, :with_certificate) }
|
|
|
|
|
|
|
|
subject { domain.certificate_text }
|
|
|
|
|
|
|
|
# We test only existence of output, since the output is long
|
2016-05-30 08:11:46 +00:00
|
|
|
it { is_expected.not_to be_empty }
|
2016-02-12 15:05:17 +00:00
|
|
|
end
|
2018-02-06 13:25:46 +00:00
|
|
|
|
|
|
|
describe '#update_daemon' do
|
|
|
|
it 'runs when the domain is created' do
|
|
|
|
domain = build(:pages_domain)
|
|
|
|
|
|
|
|
expect(domain).to receive(:update_daemon)
|
|
|
|
|
|
|
|
domain.save!
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'runs when the domain is destroyed' do
|
|
|
|
domain = create(:pages_domain)
|
|
|
|
|
|
|
|
expect(domain).to receive(:update_daemon)
|
|
|
|
|
|
|
|
domain.destroy!
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'delegates to Projects::UpdatePagesConfigurationService' do
|
|
|
|
service = instance_double('Projects::UpdatePagesConfigurationService')
|
|
|
|
expect(Projects::UpdatePagesConfigurationService).to receive(:new) { service }
|
|
|
|
expect(service).to receive(:execute)
|
|
|
|
|
|
|
|
create(:pages_domain)
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'configuration updates when attributes change' do
|
|
|
|
set(:project1) { create(:project) }
|
|
|
|
set(:project2) { create(:project) }
|
|
|
|
set(:domain) { create(:pages_domain) }
|
|
|
|
|
|
|
|
where(:attribute, :old_value, :new_value, :update_expected) do
|
|
|
|
now = Time.now
|
|
|
|
future = now + 1.day
|
|
|
|
|
|
|
|
:project | nil | :project1 | true
|
|
|
|
:project | :project1 | :project1 | false
|
|
|
|
:project | :project1 | :project2 | true
|
|
|
|
:project | :project1 | nil | true
|
|
|
|
|
|
|
|
# domain can't be set to nil
|
|
|
|
:domain | 'a.com' | 'a.com' | false
|
|
|
|
:domain | 'a.com' | 'b.com' | true
|
|
|
|
|
|
|
|
# verification_code can't be set to nil
|
|
|
|
:verification_code | 'foo' | 'foo' | false
|
|
|
|
:verification_code | 'foo' | 'bar' | false
|
|
|
|
|
|
|
|
:verified_at | nil | now | false
|
|
|
|
:verified_at | now | now | false
|
|
|
|
:verified_at | now | future | false
|
|
|
|
:verified_at | now | nil | false
|
|
|
|
|
|
|
|
:enabled_until | nil | now | true
|
|
|
|
:enabled_until | now | now | false
|
|
|
|
:enabled_until | now | future | false
|
|
|
|
:enabled_until | now | nil | true
|
|
|
|
end
|
|
|
|
|
|
|
|
with_them do
|
|
|
|
it 'runs if a relevant attribute has changed' do
|
|
|
|
a = old_value.is_a?(Symbol) ? send(old_value) : old_value
|
|
|
|
b = new_value.is_a?(Symbol) ? send(new_value) : new_value
|
|
|
|
|
|
|
|
domain.update!(attribute => a)
|
|
|
|
|
|
|
|
if update_expected
|
|
|
|
expect(domain).to receive(:update_daemon)
|
|
|
|
else
|
|
|
|
expect(domain).not_to receive(:update_daemon)
|
|
|
|
end
|
|
|
|
|
|
|
|
domain.update!(attribute => b)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'TLS configuration' do
|
|
|
|
set(:domain_with_tls) { create(:pages_domain, :with_key, :with_certificate) }
|
|
|
|
|
|
|
|
let(:cert1) { domain_with_tls.certificate }
|
|
|
|
let(:cert2) { cert1 + ' ' }
|
|
|
|
let(:key1) { domain_with_tls.key }
|
|
|
|
let(:key2) { key1 + ' ' }
|
|
|
|
|
|
|
|
it 'updates when added' do
|
|
|
|
expect(domain).to receive(:update_daemon)
|
|
|
|
|
|
|
|
domain.update!(key: key1, certificate: cert1)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'updates when changed' do
|
|
|
|
expect(domain_with_tls).to receive(:update_daemon)
|
|
|
|
|
|
|
|
domain_with_tls.update!(key: key2, certificate: cert2)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'updates when removed' do
|
|
|
|
expect(domain_with_tls).to receive(:update_daemon)
|
|
|
|
|
|
|
|
domain_with_tls.update!(key: nil, certificate: nil)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2016-02-12 15:05:17 +00:00
|
|
|
end
|