2013-03-12 06:37:53 -04:00
|
|
|
require 'spec_helper'
|
|
|
|
|
2015-12-09 05:55:49 -05:00
|
|
|
describe Projects::TransferService, services: true do
|
2014-05-28 12:04:18 -04:00
|
|
|
let(:user) { create(:user) }
|
|
|
|
let(:group) { create(:group) }
|
2017-03-27 17:14:01 -04:00
|
|
|
let(:project) { create(:project, :repository, namespace: user.namespace) }
|
2013-03-12 06:37:53 -04:00
|
|
|
|
2014-05-28 12:04:18 -04:00
|
|
|
context 'namespace -> namespace' do
|
2013-03-12 06:37:53 -04:00
|
|
|
before do
|
2017-06-21 09:48:12 -04:00
|
|
|
allow_any_instance_of(Gitlab::UploadsTransfer)
|
|
|
|
.to receive(:move_project).and_return(true)
|
|
|
|
allow_any_instance_of(Gitlab::PagesTransfer)
|
|
|
|
.to receive(:move_project).and_return(true)
|
2014-05-28 12:04:18 -04:00
|
|
|
group.add_owner(user)
|
2015-07-02 10:47:15 -04:00
|
|
|
@result = transfer_project(project, user, group)
|
2013-03-12 06:37:53 -04:00
|
|
|
end
|
|
|
|
|
2015-02-12 13:17:35 -05:00
|
|
|
it { expect(@result).to be_truthy }
|
|
|
|
it { expect(project.namespace).to eq(group) }
|
2013-03-12 06:37:53 -04:00
|
|
|
end
|
|
|
|
|
2017-06-02 09:44:59 -04:00
|
|
|
context 'when transfer succeeds' do
|
|
|
|
before do
|
|
|
|
group.add_owner(user)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'sends notifications' do
|
|
|
|
expect_any_instance_of(NotificationService).to receive(:project_was_moved)
|
|
|
|
|
|
|
|
transfer_project(project, user, group)
|
|
|
|
end
|
|
|
|
|
2017-06-29 18:11:33 -04:00
|
|
|
it 'expires full_path cache' do
|
|
|
|
expect(project).to receive(:expires_full_path_cache)
|
|
|
|
|
|
|
|
transfer_project(project, user, group)
|
|
|
|
end
|
|
|
|
|
2017-06-02 09:44:59 -04:00
|
|
|
it 'executes system hooks' do
|
|
|
|
expect_any_instance_of(Projects::TransferService).to receive(:execute_system_hooks)
|
|
|
|
|
|
|
|
transfer_project(project, user, group)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when transfer fails' do
|
|
|
|
let!(:original_path) { project_path(project) }
|
|
|
|
|
|
|
|
def attempt_project_transfer
|
|
|
|
expect do
|
|
|
|
transfer_project(project, user, group)
|
|
|
|
end.to raise_error(ActiveRecord::ActiveRecordError)
|
|
|
|
end
|
|
|
|
|
|
|
|
before do
|
|
|
|
group.add_owner(user)
|
|
|
|
|
|
|
|
expect_any_instance_of(Labels::TransferService).to receive(:execute).and_raise(ActiveRecord::StatementInvalid, "PG ERROR")
|
|
|
|
end
|
|
|
|
|
|
|
|
def project_path(project)
|
|
|
|
File.join(project.repository_storage_path, "#{project.path_with_namespace}.git")
|
|
|
|
end
|
|
|
|
|
|
|
|
def current_path
|
|
|
|
project_path(project)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'rolls back repo location' do
|
|
|
|
attempt_project_transfer
|
|
|
|
|
|
|
|
expect(Dir.exist?(original_path)).to be_truthy
|
|
|
|
expect(original_path).to eq current_path
|
|
|
|
end
|
|
|
|
|
|
|
|
it "doesn't send move notifications" do
|
|
|
|
expect_any_instance_of(NotificationService).not_to receive(:project_was_moved)
|
|
|
|
|
|
|
|
attempt_project_transfer
|
|
|
|
end
|
|
|
|
|
|
|
|
it "doesn't run system hooks" do
|
|
|
|
expect_any_instance_of(Projects::TransferService).not_to receive(:execute_system_hooks)
|
|
|
|
|
|
|
|
attempt_project_transfer
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2013-03-12 06:37:53 -04:00
|
|
|
context 'namespace -> no namespace' do
|
2014-05-28 12:04:18 -04:00
|
|
|
before do
|
2015-07-02 10:47:15 -04:00
|
|
|
@result = transfer_project(project, user, nil)
|
2014-05-28 12:04:18 -04:00
|
|
|
end
|
2013-03-12 06:37:53 -04:00
|
|
|
|
2015-06-13 18:24:51 -04:00
|
|
|
it { expect(@result).to eq false }
|
2015-02-12 13:17:35 -05:00
|
|
|
it { expect(project.namespace).to eq(user.namespace) }
|
2017-05-18 12:22:02 -04:00
|
|
|
it { expect(project.errors.messages[:new_namespace].first).to eq 'Please select a new namespace for your project.' }
|
2013-03-12 06:37:53 -04:00
|
|
|
end
|
|
|
|
|
2016-05-16 19:03:55 -04:00
|
|
|
context 'disallow transfering of project with tags' do
|
2017-03-23 10:54:59 -04:00
|
|
|
let(:container_repository) { create(:container_repository) }
|
2016-12-15 22:24:05 -05:00
|
|
|
|
2016-05-16 19:03:55 -04:00
|
|
|
before do
|
|
|
|
stub_container_registry_config(enabled: true)
|
2017-04-03 09:52:24 -04:00
|
|
|
stub_container_registry_tags(repository: :any, tags: ['tag'])
|
2017-03-24 07:41:42 -04:00
|
|
|
project.container_repositories << container_repository
|
2016-05-16 19:03:55 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
subject { transfer_project(project, user, group) }
|
|
|
|
|
|
|
|
it { is_expected.to be_falsey }
|
|
|
|
end
|
|
|
|
|
2014-05-28 12:04:18 -04:00
|
|
|
context 'namespace -> not allowed namespace' do
|
|
|
|
before do
|
2015-07-02 10:47:15 -04:00
|
|
|
@result = transfer_project(project, user, group)
|
2014-05-28 12:04:18 -04:00
|
|
|
end
|
|
|
|
|
2015-06-13 18:24:51 -04:00
|
|
|
it { expect(@result).to eq false }
|
2015-02-12 13:17:35 -05:00
|
|
|
it { expect(project.namespace).to eq(user.namespace) }
|
2013-03-12 06:37:53 -04:00
|
|
|
end
|
2014-10-04 05:44:20 -04:00
|
|
|
|
2015-07-02 10:47:15 -04:00
|
|
|
def transfer_project(project, user, new_namespace)
|
|
|
|
Projects::TransferService.new(project, user).execute(new_namespace)
|
2014-10-04 05:44:20 -04:00
|
|
|
end
|
2016-04-13 14:28:10 -04:00
|
|
|
|
|
|
|
context 'visibility level' do
|
|
|
|
let(:internal_group) { create(:group, :internal) }
|
|
|
|
|
2017-06-14 14:18:56 -04:00
|
|
|
before do
|
|
|
|
internal_group.add_owner(user)
|
|
|
|
end
|
2016-04-13 14:28:10 -04:00
|
|
|
|
|
|
|
context 'when namespace visibility level < project visibility level' do
|
2017-03-27 17:14:01 -04:00
|
|
|
let(:public_project) { create(:project, :public, :repository, namespace: user.namespace) }
|
2016-04-13 14:28:10 -04:00
|
|
|
|
2017-06-14 14:18:56 -04:00
|
|
|
before do
|
|
|
|
transfer_project(public_project, user, internal_group)
|
|
|
|
end
|
2016-04-13 14:28:10 -04:00
|
|
|
|
|
|
|
it { expect(public_project.visibility_level).to eq(internal_group.visibility_level) }
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when namespace visibility level > project visibility level' do
|
2017-03-27 17:14:01 -04:00
|
|
|
let(:private_project) { create(:project, :private, :repository, namespace: user.namespace) }
|
2016-04-13 14:28:10 -04:00
|
|
|
|
2017-06-14 14:18:56 -04:00
|
|
|
before do
|
|
|
|
transfer_project(private_project, user, internal_group)
|
|
|
|
end
|
2016-04-13 14:28:10 -04:00
|
|
|
|
|
|
|
it { expect(private_project.visibility_level).to eq(Gitlab::VisibilityLevel::PRIVATE) }
|
|
|
|
end
|
|
|
|
end
|
2016-09-26 16:10:54 -04:00
|
|
|
|
|
|
|
context 'missing group labels applied to issues or merge requests' do
|
|
|
|
it 'delegates tranfer to Labels::TransferService' do
|
|
|
|
group.add_owner(user)
|
|
|
|
|
|
|
|
expect_any_instance_of(Labels::TransferService).to receive(:execute).once.and_call_original
|
|
|
|
|
|
|
|
transfer_project(project, user, group)
|
|
|
|
end
|
|
|
|
end
|
2017-02-07 08:55:42 -05:00
|
|
|
|
|
|
|
describe 'refreshing project authorizations' do
|
|
|
|
let(:group) { create(:group) }
|
|
|
|
let(:owner) { project.namespace.owner }
|
|
|
|
let(:group_member) { create(:user) }
|
|
|
|
|
|
|
|
before do
|
|
|
|
group.add_user(owner, GroupMember::MASTER)
|
|
|
|
group.add_user(group_member, GroupMember::DEVELOPER)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'refreshes the permissions of the old and new namespace' do
|
|
|
|
transfer_project(project, owner, group)
|
|
|
|
|
|
|
|
expect(group_member.authorized_projects).to include(project)
|
|
|
|
expect(owner.authorized_projects).to include(project)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'only schedules a single job for every user' do
|
2017-06-21 09:48:12 -04:00
|
|
|
expect(UserProjectAccessChangedService).to receive(:new)
|
|
|
|
.with([owner.id, group_member.id])
|
|
|
|
.and_call_original
|
2017-02-07 08:55:42 -05:00
|
|
|
|
|
|
|
transfer_project(project, owner, group)
|
|
|
|
end
|
|
|
|
end
|
2013-03-12 06:37:53 -04:00
|
|
|
end
|