2012-04-08 21:28:58 +00:00
|
|
|
require 'spec_helper'
|
|
|
|
|
2017-07-10 14:24:02 +00:00
|
|
|
describe Milestone do
|
2012-04-08 22:01:42 +00:00
|
|
|
describe "Validation" do
|
2015-05-21 21:49:06 +00:00
|
|
|
before do
|
|
|
|
allow(subject).to receive(:set_iid).and_return(false)
|
|
|
|
end
|
|
|
|
|
2016-11-15 17:48:30 +00:00
|
|
|
describe 'start_date' do
|
|
|
|
it 'adds an error when start_date is greated then due_date' do
|
|
|
|
milestone = build(:milestone, start_date: Date.tomorrow, due_date: Date.yesterday)
|
|
|
|
|
|
|
|
expect(milestone).not_to be_valid
|
2017-11-18 18:22:11 +00:00
|
|
|
expect(milestone.errors[:due_date]).to include("must be greater than start date")
|
2016-11-15 17:48:30 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe "Associations" do
|
|
|
|
it { is_expected.to belong_to(:project) }
|
|
|
|
it { is_expected.to have_many(:issues) }
|
2012-04-08 22:01:42 +00:00
|
|
|
end
|
|
|
|
|
2017-08-02 19:55:11 +00:00
|
|
|
let(:project) { create(:project, :public) }
|
2016-12-12 08:43:56 +00:00
|
|
|
let(:milestone) { create(:milestone, project: project) }
|
|
|
|
let(:issue) { create(:issue, project: project) }
|
2016-03-17 20:59:30 +00:00
|
|
|
let(:user) { create(:user) }
|
2012-04-08 22:01:42 +00:00
|
|
|
|
2016-05-04 21:21:57 +00:00
|
|
|
describe "#title" do
|
2016-09-26 23:47:34 +00:00
|
|
|
let(:milestone) { create(:milestone, title: "<b>foo & bar -> 2.2</b>") }
|
2016-05-04 21:21:57 +00:00
|
|
|
|
|
|
|
it "sanitizes title" do
|
2016-09-26 23:47:34 +00:00
|
|
|
expect(milestone.title).to eq("foo & bar -> 2.2")
|
2016-05-04 21:21:57 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2017-07-07 15:08:49 +00:00
|
|
|
describe "unique milestone title" do
|
|
|
|
context "per project" do
|
|
|
|
it "does not accept the same title in a project twice" do
|
2017-07-25 17:09:00 +00:00
|
|
|
new_milestone = described_class.new(project: milestone.project, title: milestone.title)
|
2017-07-07 15:08:49 +00:00
|
|
|
expect(new_milestone).not_to be_valid
|
|
|
|
end
|
|
|
|
|
|
|
|
it "accepts the same title in another project" do
|
2017-08-02 19:55:11 +00:00
|
|
|
project = create(:project)
|
2017-07-25 17:09:00 +00:00
|
|
|
new_milestone = described_class.new(project: project, title: milestone.title)
|
2017-07-07 15:08:49 +00:00
|
|
|
|
|
|
|
expect(new_milestone).to be_valid
|
|
|
|
end
|
2016-02-02 09:44:30 +00:00
|
|
|
end
|
|
|
|
|
2017-07-07 15:08:49 +00:00
|
|
|
context "per group" do
|
|
|
|
let(:group) { create(:group) }
|
|
|
|
let(:milestone) { create(:milestone, group: group) }
|
|
|
|
|
|
|
|
before do
|
|
|
|
project.update(group: group)
|
|
|
|
end
|
|
|
|
|
|
|
|
it "does not accept the same title in a group twice" do
|
2017-07-25 17:09:00 +00:00
|
|
|
new_milestone = described_class.new(group: group, title: milestone.title)
|
2017-07-07 15:08:49 +00:00
|
|
|
|
|
|
|
expect(new_milestone).not_to be_valid
|
|
|
|
end
|
2016-02-02 09:44:30 +00:00
|
|
|
|
2017-07-07 15:08:49 +00:00
|
|
|
it "does not accept the same title of a child project milestone" do
|
|
|
|
create(:milestone, project: group.projects.first)
|
|
|
|
|
2017-07-25 17:09:00 +00:00
|
|
|
new_milestone = described_class.new(group: group, title: milestone.title)
|
2017-07-07 15:08:49 +00:00
|
|
|
|
|
|
|
expect(new_milestone).not_to be_valid
|
|
|
|
end
|
2016-02-02 09:44:30 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2012-08-25 17:54:38 +00:00
|
|
|
describe "#percent_complete" do
|
2016-08-01 15:00:44 +00:00
|
|
|
it "does not count open issues" do
|
2012-04-08 22:01:42 +00:00
|
|
|
milestone.issues << issue
|
2016-03-17 20:59:30 +00:00
|
|
|
expect(milestone.percent_complete(user)).to eq(0)
|
2012-04-08 22:01:42 +00:00
|
|
|
end
|
|
|
|
|
2016-08-01 15:00:44 +00:00
|
|
|
it "counts closed issues" do
|
2013-02-18 09:10:09 +00:00
|
|
|
issue.close
|
2012-08-25 17:54:38 +00:00
|
|
|
milestone.issues << issue
|
2016-03-17 20:59:30 +00:00
|
|
|
expect(milestone.percent_complete(user)).to eq(100)
|
2012-08-25 17:54:38 +00:00
|
|
|
end
|
2012-04-08 22:01:42 +00:00
|
|
|
|
2016-08-01 15:00:44 +00:00
|
|
|
it "recovers from dividing by zero" do
|
2016-03-17 20:59:30 +00:00
|
|
|
expect(milestone.percent_complete(user)).to eq(0)
|
2012-04-08 22:01:42 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2016-07-11 22:12:31 +00:00
|
|
|
describe '#expired?' do
|
2013-01-03 17:11:14 +00:00
|
|
|
context "expired" do
|
|
|
|
before do
|
2015-05-21 21:49:06 +00:00
|
|
|
allow(milestone).to receive(:due_date).and_return(Date.today.prev_year)
|
2013-01-03 17:11:14 +00:00
|
|
|
end
|
|
|
|
|
2015-02-12 18:17:35 +00:00
|
|
|
it { expect(milestone.expired?).to be_truthy }
|
2013-01-03 17:11:14 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
context "not expired" do
|
|
|
|
before do
|
2015-05-21 21:49:06 +00:00
|
|
|
allow(milestone).to receive(:due_date).and_return(Date.today.next_year)
|
2013-01-03 17:11:14 +00:00
|
|
|
end
|
|
|
|
|
2015-02-12 18:17:35 +00:00
|
|
|
it { expect(milestone.expired?).to be_falsey }
|
2013-01-03 17:11:14 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2016-11-15 17:48:30 +00:00
|
|
|
describe '#upcoming?' do
|
|
|
|
it 'returns true' do
|
|
|
|
milestone = build(:milestone, start_date: Time.now + 1.month)
|
|
|
|
expect(milestone.upcoming?).to be_truthy
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns false' do
|
|
|
|
milestone = build(:milestone, start_date: Date.today.prev_year)
|
|
|
|
expect(milestone.upcoming?).to be_falsey
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2016-07-11 22:12:31 +00:00
|
|
|
describe '#percent_complete' do
|
2013-01-03 17:11:14 +00:00
|
|
|
before do
|
2015-05-21 21:49:06 +00:00
|
|
|
allow(milestone).to receive_messages(
|
2013-01-03 17:11:14 +00:00
|
|
|
closed_items_count: 3,
|
|
|
|
total_items_count: 4
|
|
|
|
)
|
|
|
|
end
|
|
|
|
|
2016-03-17 20:59:30 +00:00
|
|
|
it { expect(milestone.percent_complete(user)).to eq(75) }
|
2013-01-03 17:11:14 +00:00
|
|
|
end
|
|
|
|
|
2016-07-11 22:12:31 +00:00
|
|
|
describe '#can_be_closed?' do
|
2015-02-12 18:17:35 +00:00
|
|
|
it { expect(milestone.can_be_closed?).to be_truthy }
|
2013-01-03 17:11:14 +00:00
|
|
|
end
|
2013-02-18 09:38:29 +00:00
|
|
|
|
2016-07-11 22:12:31 +00:00
|
|
|
describe '#total_items_count' do
|
2013-02-18 13:52:39 +00:00
|
|
|
before do
|
2016-12-12 08:43:56 +00:00
|
|
|
create :closed_issue, milestone: milestone, project: project
|
2015-10-03 06:48:54 +00:00
|
|
|
create :merge_request, milestone: milestone
|
2013-02-18 13:52:39 +00:00
|
|
|
end
|
2013-02-18 09:38:29 +00:00
|
|
|
|
2016-08-01 15:00:44 +00:00
|
|
|
it 'returns total count of issues and merge requests assigned to milestone' do
|
2016-03-17 20:59:30 +00:00
|
|
|
expect(milestone.total_items_count(user)).to eq 2
|
2013-02-18 09:38:29 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2016-07-11 22:12:31 +00:00
|
|
|
describe '#can_be_closed?' do
|
2013-02-18 13:52:39 +00:00
|
|
|
before do
|
2013-02-18 09:38:29 +00:00
|
|
|
milestone = create :milestone
|
2013-02-18 13:52:39 +00:00
|
|
|
create :closed_issue, milestone: milestone
|
|
|
|
|
2015-10-03 06:48:54 +00:00
|
|
|
create :issue
|
2013-02-18 13:52:39 +00:00
|
|
|
end
|
2013-02-18 09:38:29 +00:00
|
|
|
|
2016-08-01 15:00:44 +00:00
|
|
|
it 'returns true if milestone active and all nested issues closed' do
|
2015-02-12 18:17:35 +00:00
|
|
|
expect(milestone.can_be_closed?).to be_truthy
|
2013-02-18 09:38:29 +00:00
|
|
|
end
|
|
|
|
|
2016-08-01 15:00:44 +00:00
|
|
|
it 'returns false if milestone active and not all nested issues closed' do
|
2013-02-18 13:52:39 +00:00
|
|
|
issue.milestone = milestone
|
2013-03-20 21:46:30 +00:00
|
|
|
issue.save
|
2013-02-18 09:38:29 +00:00
|
|
|
|
2015-02-12 18:17:35 +00:00
|
|
|
expect(milestone.can_be_closed?).to be_falsey
|
2013-02-18 09:38:29 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2016-03-01 16:05:26 +00:00
|
|
|
describe '.search' do
|
|
|
|
let(:milestone) { create(:milestone, title: 'foo', description: 'bar') }
|
|
|
|
|
|
|
|
it 'returns milestones with a matching title' do
|
|
|
|
expect(described_class.search(milestone.title)).to eq([milestone])
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns milestones with a partially matching title' do
|
|
|
|
expect(described_class.search(milestone.title[0..2])).to eq([milestone])
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns milestones with a matching title regardless of the casing' do
|
|
|
|
expect(described_class.search(milestone.title.upcase)).to eq([milestone])
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns milestones with a matching description' do
|
|
|
|
expect(described_class.search(milestone.description)).to eq([milestone])
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns milestones with a partially matching description' do
|
2017-06-21 13:48:12 +00:00
|
|
|
expect(described_class.search(milestone.description[0..2]))
|
|
|
|
.to eq([milestone])
|
2016-03-01 16:05:26 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns milestones with a matching description regardless of the casing' do
|
2017-06-21 13:48:12 +00:00
|
|
|
expect(described_class.search(milestone.description.upcase))
|
|
|
|
.to eq([milestone])
|
2016-03-01 16:05:26 +00:00
|
|
|
end
|
|
|
|
end
|
2016-05-11 16:38:34 +00:00
|
|
|
|
|
|
|
describe '.upcoming_ids_by_projects' do
|
2017-08-02 19:55:11 +00:00
|
|
|
let(:project_1) { create(:project) }
|
|
|
|
let(:project_2) { create(:project) }
|
|
|
|
let(:project_3) { create(:project) }
|
2016-05-11 16:38:34 +00:00
|
|
|
let(:projects) { [project_1, project_2, project_3] }
|
|
|
|
|
|
|
|
let!(:past_milestone_project_1) { create(:milestone, project: project_1, due_date: Time.now - 1.day) }
|
|
|
|
let!(:current_milestone_project_1) { create(:milestone, project: project_1, due_date: Time.now + 1.day) }
|
|
|
|
let!(:future_milestone_project_1) { create(:milestone, project: project_1, due_date: Time.now + 2.days) }
|
|
|
|
|
|
|
|
let!(:past_milestone_project_2) { create(:milestone, project: project_2, due_date: Time.now - 1.day) }
|
|
|
|
let!(:closed_milestone_project_2) { create(:milestone, :closed, project: project_2, due_date: Time.now + 1.day) }
|
|
|
|
let!(:current_milestone_project_2) { create(:milestone, project: project_2, due_date: Time.now + 2.days) }
|
|
|
|
|
|
|
|
let!(:past_milestone_project_3) { create(:milestone, project: project_3, due_date: Time.now - 1.day) }
|
|
|
|
|
2016-05-16 09:23:21 +00:00
|
|
|
# The call to `#try` is because this returns a relation with a Postgres DB,
|
|
|
|
# and an array of IDs with a MySQL DB.
|
2017-07-25 17:09:00 +00:00
|
|
|
let(:milestone_ids) { described_class.upcoming_ids_by_projects(projects).map { |id| id.try(:id) || id } }
|
2016-05-11 16:38:34 +00:00
|
|
|
|
|
|
|
it 'returns the next upcoming open milestone ID for each project' do
|
|
|
|
expect(milestone_ids).to contain_exactly(current_milestone_project_1.id, current_milestone_project_2.id)
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when the projects have no open upcoming milestones' do
|
|
|
|
let(:projects) { [project_3] }
|
|
|
|
|
|
|
|
it 'returns no results' do
|
|
|
|
expect(milestone_ids).to be_empty
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2016-11-02 23:49:13 +00:00
|
|
|
|
|
|
|
describe '#to_reference' do
|
2017-08-03 11:50:06 +00:00
|
|
|
let(:group) { build_stubbed(:group) }
|
|
|
|
let(:project) { build_stubbed(:project, name: 'sample-project') }
|
|
|
|
let(:another_project) { build_stubbed(:project, name: 'another-project', namespace: project.namespace) }
|
|
|
|
|
|
|
|
context 'for a project milestone' do
|
|
|
|
let(:milestone) { build_stubbed(:milestone, iid: 1, project: project, name: 'milestone') }
|
|
|
|
|
|
|
|
it 'returns a String reference to the object' do
|
2017-09-20 09:55:54 +00:00
|
|
|
expect(milestone.to_reference).to eq '%"milestone"'
|
2017-08-03 11:50:06 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns a reference by name when the format is set to :name' do
|
|
|
|
expect(milestone.to_reference(format: :name)).to eq '%"milestone"'
|
|
|
|
end
|
2016-11-02 23:49:13 +00:00
|
|
|
|
2017-08-03 11:50:06 +00:00
|
|
|
it 'supports a cross-project reference' do
|
2017-09-20 09:55:54 +00:00
|
|
|
expect(milestone.to_reference(another_project)).to eq 'sample-project%"milestone"'
|
2017-08-03 11:50:06 +00:00
|
|
|
end
|
2016-11-02 23:49:13 +00:00
|
|
|
end
|
|
|
|
|
2017-08-03 11:50:06 +00:00
|
|
|
context 'for a group milestone' do
|
|
|
|
let(:milestone) { build_stubbed(:milestone, iid: 1, group: group, name: 'milestone') }
|
|
|
|
|
2017-09-20 09:55:54 +00:00
|
|
|
it 'returns a group milestone reference with a default format' do
|
|
|
|
expect(milestone.to_reference).to eq '%"milestone"'
|
2017-08-03 11:50:06 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns a reference by name when the format is set to :name' do
|
|
|
|
expect(milestone.to_reference(format: :name)).to eq '%"milestone"'
|
|
|
|
end
|
|
|
|
|
2017-09-20 09:55:54 +00:00
|
|
|
it 'does supports cross-project references within a group' do
|
2017-08-03 11:50:06 +00:00
|
|
|
expect(milestone.to_reference(another_project, format: :name)).to eq '%"milestone"'
|
|
|
|
end
|
2017-09-20 09:55:54 +00:00
|
|
|
|
|
|
|
it 'raises an error when using iid format' do
|
|
|
|
expect { milestone.to_reference(format: :iid) }
|
|
|
|
.to raise_error(ArgumentError, 'Cannot refer to a group milestone by an internal id!')
|
|
|
|
end
|
2016-11-02 23:49:13 +00:00
|
|
|
end
|
|
|
|
end
|
2017-05-29 09:20:41 +00:00
|
|
|
|
|
|
|
describe '#participants' do
|
2017-08-02 19:55:11 +00:00
|
|
|
let(:project) { build(:project, name: 'sample-project') }
|
2017-05-29 09:20:41 +00:00
|
|
|
let(:milestone) { build(:milestone, iid: 1, project: project) }
|
|
|
|
|
|
|
|
it 'returns participants without duplicates' do
|
|
|
|
user = create :user
|
|
|
|
create :issue, project: project, milestone: milestone, assignees: [user]
|
|
|
|
create :issue, project: project, milestone: milestone, assignees: [user]
|
|
|
|
|
|
|
|
expect(milestone.participants).to eq [user]
|
|
|
|
end
|
|
|
|
end
|
2012-04-08 21:28:58 +00:00
|
|
|
end
|