2017-02-06 13:38:17 -05:00
|
|
|
require 'spec_helper'
|
|
|
|
require 'mime/types'
|
|
|
|
|
2017-04-21 16:32:02 -04:00
|
|
|
describe API::V3::Branches do
|
2017-09-19 10:11:23 -04:00
|
|
|
set(:user) { create(:user) }
|
|
|
|
set(:user2) { create(:user) }
|
|
|
|
set(:project) { create(:project, :repository, creator: user) }
|
|
|
|
set(:master) { create(:project_member, :master, user: user, project: project) }
|
|
|
|
set(:guest) { create(:project_member, :guest, user: user2, project: project) }
|
2017-02-20 14:32:44 -05:00
|
|
|
let!(:branch_name) { 'feature' }
|
2017-03-16 20:15:05 -04:00
|
|
|
let!(:branch_sha) { '0b4bc9a49b562e85de7cc9e834518ea6828729b9' }
|
2017-02-20 14:32:44 -05:00
|
|
|
let!(:branch_with_dot) { CreateBranchService.new(project, user).execute("with.1.2.3", "master") }
|
2017-02-06 13:38:17 -05:00
|
|
|
|
|
|
|
describe "GET /projects/:id/repository/branches" do
|
|
|
|
it "returns an array of project branches" do
|
|
|
|
project.repository.expire_all_method_caches
|
|
|
|
|
|
|
|
get v3_api("/projects/#{project.id}/repository/branches", user), per_page: 100
|
|
|
|
|
2017-10-19 14:28:19 -04:00
|
|
|
expect(response).to have_gitlab_http_status(200)
|
2017-02-06 13:38:17 -05:00
|
|
|
expect(json_response).to be_an Array
|
|
|
|
branch_names = json_response.map { |x| x['name'] }
|
|
|
|
expect(branch_names).to match_array(project.repository.branch_names)
|
|
|
|
end
|
|
|
|
end
|
2017-02-22 12:37:13 -05:00
|
|
|
|
2017-02-20 14:32:44 -05:00
|
|
|
describe "DELETE /projects/:id/repository/branches/:branch" do
|
|
|
|
before do
|
|
|
|
allow_any_instance_of(Repository).to receive(:rm_branch).and_return(true)
|
|
|
|
end
|
|
|
|
|
|
|
|
it "removes branch" do
|
|
|
|
delete v3_api("/projects/#{project.id}/repository/branches/#{branch_name}", user)
|
|
|
|
|
2017-10-19 14:28:19 -04:00
|
|
|
expect(response).to have_gitlab_http_status(200)
|
2017-02-20 14:32:44 -05:00
|
|
|
expect(json_response['branch_name']).to eq(branch_name)
|
|
|
|
end
|
|
|
|
|
|
|
|
it "removes a branch with dots in the branch name" do
|
|
|
|
delete v3_api("/projects/#{project.id}/repository/branches/with.1.2.3", user)
|
|
|
|
|
2017-10-19 14:28:19 -04:00
|
|
|
expect(response).to have_gitlab_http_status(200)
|
2017-02-20 14:32:44 -05:00
|
|
|
expect(json_response['branch_name']).to eq("with.1.2.3")
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns 404 if branch not exists' do
|
|
|
|
delete v3_api("/projects/#{project.id}/repository/branches/foobar", user)
|
2017-10-19 14:28:19 -04:00
|
|
|
expect(response).to have_gitlab_http_status(404)
|
2017-02-20 14:32:44 -05:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2017-02-22 12:37:13 -05:00
|
|
|
describe "DELETE /projects/:id/repository/merged_branches" do
|
|
|
|
before do
|
|
|
|
allow_any_instance_of(Repository).to receive(:rm_branch).and_return(true)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns 200' do
|
|
|
|
delete v3_api("/projects/#{project.id}/repository/merged_branches", user)
|
|
|
|
|
2017-10-19 14:28:19 -04:00
|
|
|
expect(response).to have_gitlab_http_status(200)
|
2017-02-22 12:37:13 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns a 403 error if guest' do
|
2017-02-20 14:32:44 -05:00
|
|
|
delete v3_api("/projects/#{project.id}/repository/merged_branches", user2)
|
2017-02-22 12:37:13 -05:00
|
|
|
|
2017-10-19 14:28:19 -04:00
|
|
|
expect(response).to have_gitlab_http_status(403)
|
2017-02-22 12:37:13 -05:00
|
|
|
end
|
|
|
|
end
|
2017-03-16 20:15:05 -04:00
|
|
|
|
|
|
|
describe "POST /projects/:id/repository/branches" do
|
|
|
|
it "creates a new branch" do
|
|
|
|
post v3_api("/projects/#{project.id}/repository/branches", user),
|
|
|
|
branch_name: 'feature1',
|
|
|
|
ref: branch_sha
|
|
|
|
|
2017-10-19 14:28:19 -04:00
|
|
|
expect(response).to have_gitlab_http_status(201)
|
2017-03-16 20:15:05 -04:00
|
|
|
|
|
|
|
expect(json_response['name']).to eq('feature1')
|
|
|
|
expect(json_response['commit']['id']).to eq(branch_sha)
|
|
|
|
end
|
|
|
|
|
|
|
|
it "denies for user without push access" do
|
|
|
|
post v3_api("/projects/#{project.id}/repository/branches", user2),
|
|
|
|
branch_name: branch_name,
|
|
|
|
ref: branch_sha
|
2017-10-19 14:28:19 -04:00
|
|
|
expect(response).to have_gitlab_http_status(403)
|
2017-03-16 20:15:05 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns 400 if branch name is invalid' do
|
|
|
|
post v3_api("/projects/#{project.id}/repository/branches", user),
|
|
|
|
branch_name: 'new design',
|
|
|
|
ref: branch_sha
|
2017-10-19 14:28:19 -04:00
|
|
|
expect(response).to have_gitlab_http_status(400)
|
2017-03-16 20:15:05 -04:00
|
|
|
expect(json_response['message']).to eq('Branch name is invalid')
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns 400 if branch already exists' do
|
|
|
|
post v3_api("/projects/#{project.id}/repository/branches", user),
|
|
|
|
branch_name: 'new_design1',
|
|
|
|
ref: branch_sha
|
2017-10-19 14:28:19 -04:00
|
|
|
expect(response).to have_gitlab_http_status(201)
|
2017-03-16 20:15:05 -04:00
|
|
|
|
|
|
|
post v3_api("/projects/#{project.id}/repository/branches", user),
|
|
|
|
branch_name: 'new_design1',
|
|
|
|
ref: branch_sha
|
|
|
|
|
2017-10-19 14:28:19 -04:00
|
|
|
expect(response).to have_gitlab_http_status(400)
|
2017-03-16 20:15:05 -04:00
|
|
|
expect(json_response['message']).to eq('Branch already exists')
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns 400 if ref name is invalid' do
|
|
|
|
post v3_api("/projects/#{project.id}/repository/branches", user),
|
|
|
|
branch_name: 'new_design3',
|
|
|
|
ref: 'foo'
|
|
|
|
|
2017-10-19 14:28:19 -04:00
|
|
|
expect(response).to have_gitlab_http_status(400)
|
2017-03-16 20:15:05 -04:00
|
|
|
expect(json_response['message']).to eq('Invalid reference name')
|
|
|
|
end
|
|
|
|
end
|
2017-02-06 13:38:17 -05:00
|
|
|
end
|