2019-03-30 03:23:56 -04:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2017-08-24 10:34:36 -04:00
|
|
|
require 'spec_helper'
|
|
|
|
|
2020-06-24 14:09:03 -04:00
|
|
|
RSpec.describe InstanceConfiguration do
|
2017-08-24 10:34:36 -04:00
|
|
|
context 'without cache' do
|
|
|
|
describe '#settings' do
|
|
|
|
describe '#ssh_algorithms_hashes' do
|
2018-10-03 10:08:56 -04:00
|
|
|
let(:md5) { '5a:65:6c:4d:d4:4c:6d:e6:59:25:b8:cf:ba:34:e7:64' }
|
|
|
|
let(:sha256) { 'SHA256:2KJDT7xf2i68mBgJ3TVsjISntg4droLbXYLfQj0VvSY' }
|
2017-08-24 10:34:36 -04:00
|
|
|
|
|
|
|
it 'does not return anything if file does not exist' do
|
2020-11-19 16:09:07 -05:00
|
|
|
stub_pub_file(pub_file(exist: false))
|
2017-08-24 10:34:36 -04:00
|
|
|
|
|
|
|
expect(subject.settings[:ssh_algorithms_hashes]).to be_empty
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not return anything if file is empty' do
|
2020-11-19 16:09:07 -05:00
|
|
|
stub_pub_file(pub_file)
|
2017-08-24 10:34:36 -04:00
|
|
|
|
2020-11-19 16:09:07 -05:00
|
|
|
stub_file_read(pub_file, content: '')
|
2017-08-24 10:34:36 -04:00
|
|
|
|
|
|
|
expect(subject.settings[:ssh_algorithms_hashes]).to be_empty
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns the md5 and sha256 if file valid and exists' do
|
2020-11-19 16:09:07 -05:00
|
|
|
stub_pub_file(pub_file)
|
2017-08-24 10:34:36 -04:00
|
|
|
|
|
|
|
result = subject.settings[:ssh_algorithms_hashes].select { |o| o[:md5] == md5 && o[:sha256] == sha256 }
|
|
|
|
|
|
|
|
expect(result.size).to eq(InstanceConfiguration::SSH_ALGORITHMS.size)
|
|
|
|
end
|
|
|
|
|
2021-09-22 23:09:49 -04:00
|
|
|
it 'includes all algorithms' do
|
|
|
|
stub_pub_file(pub_file)
|
|
|
|
|
|
|
|
result = subject.settings[:ssh_algorithms_hashes]
|
|
|
|
|
|
|
|
expect(result.map { |a| a[:name] }).to match_array(%w(DSA ECDSA ED25519 RSA))
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not include disabled algorithm' do
|
|
|
|
Gitlab::CurrentSettings.current_application_settings.update!(dsa_key_restriction: ApplicationSetting::FORBIDDEN_KEY_VALUE)
|
|
|
|
stub_pub_file(pub_file)
|
|
|
|
|
|
|
|
result = subject.settings[:ssh_algorithms_hashes]
|
|
|
|
|
|
|
|
expect(result.map { |a| a[:name] }).to match_array(%w(ECDSA ED25519 RSA))
|
|
|
|
end
|
|
|
|
|
2020-11-19 16:09:07 -05:00
|
|
|
def pub_file(exist: true)
|
2019-03-31 19:07:50 -04:00
|
|
|
path = exist ? 'spec/fixtures/ssh_host_example_key.pub' : 'spec/fixtures/ssh_host_example_key.pub.random'
|
|
|
|
|
2020-11-19 16:09:07 -05:00
|
|
|
Rails.root.join(path)
|
|
|
|
end
|
|
|
|
|
|
|
|
def stub_pub_file(path)
|
|
|
|
allow(subject).to receive(:ssh_algorithm_file).and_return(path)
|
2017-08-24 10:34:36 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#host' do
|
|
|
|
it 'returns current instance host' do
|
|
|
|
allow(Settings.gitlab).to receive(:host).and_return('exampledomain')
|
|
|
|
|
|
|
|
expect(subject.settings[:host]).to eq(Settings.gitlab.host)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#gitlab_pages' do
|
|
|
|
let(:gitlab_pages) { subject.settings[:gitlab_pages] }
|
2019-12-18 19:08:01 -05:00
|
|
|
|
2017-08-24 10:34:36 -04:00
|
|
|
it 'returns Settings.pages' do
|
|
|
|
gitlab_pages.delete(:ip_address)
|
|
|
|
|
|
|
|
expect(gitlab_pages).to eq(Settings.pages.symbolize_keys)
|
|
|
|
end
|
|
|
|
|
2018-09-21 08:05:37 -04:00
|
|
|
it 'returns the GitLab\'s pages host ip address' do
|
2017-08-24 10:34:36 -04:00
|
|
|
expect(gitlab_pages.keys).to include(:ip_address)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns the ip address as nil if the domain is invalid' do
|
|
|
|
allow(Settings.pages).to receive(:host).and_return('exampledomain')
|
|
|
|
|
|
|
|
expect(gitlab_pages[:ip_address]).to eq nil
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns the ip address of the domain' do
|
|
|
|
allow(Settings.pages).to receive(:host).and_return('localhost')
|
|
|
|
|
|
|
|
expect(gitlab_pages[:ip_address]).to eq('127.0.0.1').or eq('::1')
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2021-08-23 02:09:01 -04:00
|
|
|
describe '#size_limits' do
|
|
|
|
before do
|
|
|
|
Gitlab::CurrentSettings.current_application_settings.update!(
|
|
|
|
max_attachment_size: 10,
|
|
|
|
receive_max_input_size: 20,
|
|
|
|
max_import_size: 30,
|
|
|
|
diff_max_patch_bytes: 409600,
|
|
|
|
max_artifacts_size: 50,
|
|
|
|
max_pages_size: 60,
|
|
|
|
snippet_size_limit: 70
|
|
|
|
)
|
|
|
|
end
|
2019-12-18 19:08:01 -05:00
|
|
|
|
2021-08-23 02:09:01 -04:00
|
|
|
it 'returns size limits from application settings' do
|
|
|
|
size_limits = subject.settings[:size_limits]
|
2017-08-24 10:34:36 -04:00
|
|
|
|
2021-08-23 02:09:01 -04:00
|
|
|
expect(size_limits[:max_attachment_size]).to eq(10.megabytes)
|
|
|
|
expect(size_limits[:receive_max_input_size]).to eq(20.megabytes)
|
|
|
|
expect(size_limits[:max_import_size]).to eq(30.megabytes)
|
|
|
|
expect(size_limits[:diff_max_patch_bytes]).to eq(400.kilobytes)
|
|
|
|
expect(size_limits[:max_artifacts_size]).to eq(50.megabytes)
|
|
|
|
expect(size_limits[:max_pages_size]).to eq(60.megabytes)
|
|
|
|
expect(size_limits[:snippet_size_limit]).to eq(70.bytes)
|
2017-08-24 10:34:36 -04:00
|
|
|
end
|
|
|
|
|
2021-08-23 02:09:01 -04:00
|
|
|
it 'returns nil if receive_max_input_size not set' do
|
|
|
|
Gitlab::CurrentSettings.current_application_settings.update!(receive_max_input_size: nil)
|
|
|
|
|
|
|
|
size_limits = subject.settings[:size_limits]
|
|
|
|
|
|
|
|
expect(size_limits[:receive_max_input_size]).to be_nil
|
2017-08-24 10:34:36 -04:00
|
|
|
end
|
2019-03-29 19:50:02 -04:00
|
|
|
|
2021-08-23 02:09:01 -04:00
|
|
|
it 'returns nil if set to 0 (unlimited)' do
|
|
|
|
Gitlab::CurrentSettings.current_application_settings.update!(max_import_size: 0, max_pages_size: 0)
|
|
|
|
|
|
|
|
size_limits = subject.settings[:size_limits]
|
2019-03-29 19:50:02 -04:00
|
|
|
|
2021-08-23 02:09:01 -04:00
|
|
|
expect(size_limits[:max_import_size]).to be_nil
|
|
|
|
expect(size_limits[:max_pages_size]).to be_nil
|
2019-03-29 19:50:02 -04:00
|
|
|
end
|
2017-08-24 10:34:36 -04:00
|
|
|
end
|
2021-07-30 02:08:52 -04:00
|
|
|
|
2021-08-16 08:09:17 -04:00
|
|
|
describe '#package_file_size_limits' do
|
|
|
|
let_it_be(:plan1) { create(:plan, name: 'plan1', title: 'Plan 1') }
|
|
|
|
let_it_be(:plan2) { create(:plan, name: 'plan2', title: 'Plan 2') }
|
|
|
|
|
|
|
|
before do
|
|
|
|
create(:plan_limits,
|
|
|
|
plan: plan1,
|
|
|
|
conan_max_file_size: 1001,
|
|
|
|
maven_max_file_size: 1002,
|
|
|
|
npm_max_file_size: 1003,
|
|
|
|
nuget_max_file_size: 1004,
|
|
|
|
pypi_max_file_size: 1005,
|
|
|
|
terraform_module_max_file_size: 1006,
|
|
|
|
generic_packages_max_file_size: 1007
|
|
|
|
)
|
|
|
|
create(:plan_limits,
|
|
|
|
plan: plan2,
|
|
|
|
conan_max_file_size: 1101,
|
|
|
|
maven_max_file_size: 1102,
|
|
|
|
npm_max_file_size: 1103,
|
|
|
|
nuget_max_file_size: 1104,
|
|
|
|
pypi_max_file_size: 1105,
|
|
|
|
terraform_module_max_file_size: 1106,
|
|
|
|
generic_packages_max_file_size: 1107
|
|
|
|
)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns package file size limits' do
|
|
|
|
file_size_limits = subject.settings[:package_file_size_limits]
|
|
|
|
|
|
|
|
expect(file_size_limits[:Plan1]).to eq({ conan: 1001, maven: 1002, npm: 1003, nuget: 1004, pypi: 1005, terraform_module: 1006, generic: 1007 })
|
|
|
|
expect(file_size_limits[:Plan2]).to eq({ conan: 1101, maven: 1102, npm: 1103, nuget: 1104, pypi: 1105, terraform_module: 1106, generic: 1107 })
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2021-07-30 02:08:52 -04:00
|
|
|
describe '#rate_limits' do
|
|
|
|
before do
|
|
|
|
Gitlab::CurrentSettings.current_application_settings.update!(
|
|
|
|
throttle_unauthenticated_enabled: false,
|
|
|
|
throttle_unauthenticated_requests_per_period: 1001,
|
|
|
|
throttle_unauthenticated_period_in_seconds: 1002,
|
|
|
|
throttle_authenticated_api_enabled: true,
|
|
|
|
throttle_authenticated_api_requests_per_period: 1003,
|
|
|
|
throttle_authenticated_api_period_in_seconds: 1004,
|
|
|
|
throttle_authenticated_web_enabled: true,
|
|
|
|
throttle_authenticated_web_requests_per_period: 1005,
|
|
|
|
throttle_authenticated_web_period_in_seconds: 1006,
|
|
|
|
throttle_protected_paths_enabled: true,
|
|
|
|
throttle_protected_paths_requests_per_period: 1007,
|
|
|
|
throttle_protected_paths_period_in_seconds: 1008,
|
|
|
|
throttle_unauthenticated_packages_api_enabled: false,
|
|
|
|
throttle_unauthenticated_packages_api_requests_per_period: 1009,
|
|
|
|
throttle_unauthenticated_packages_api_period_in_seconds: 1010,
|
|
|
|
throttle_authenticated_packages_api_enabled: true,
|
|
|
|
throttle_authenticated_packages_api_requests_per_period: 1011,
|
|
|
|
throttle_authenticated_packages_api_period_in_seconds: 1012,
|
2021-09-22 05:11:53 -04:00
|
|
|
throttle_authenticated_git_lfs_enabled: true,
|
|
|
|
throttle_authenticated_git_lfs_requests_per_period: 1022,
|
|
|
|
throttle_authenticated_git_lfs_period_in_seconds: 1023,
|
2021-07-30 02:08:52 -04:00
|
|
|
issues_create_limit: 1013,
|
|
|
|
notes_create_limit: 1014,
|
|
|
|
project_export_limit: 1015,
|
|
|
|
project_download_export_limit: 1016,
|
|
|
|
project_import_limit: 1017,
|
|
|
|
group_export_limit: 1018,
|
|
|
|
group_download_export_limit: 1019,
|
|
|
|
group_import_limit: 1020,
|
|
|
|
raw_blob_request_limit: 1021
|
|
|
|
)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns rate limits from application settings' do
|
|
|
|
rate_limits = subject.settings[:rate_limits]
|
|
|
|
|
|
|
|
expect(rate_limits[:unauthenticated]).to eq({ enabled: false, requests_per_period: 1001, period_in_seconds: 1002 })
|
|
|
|
expect(rate_limits[:authenticated_api]).to eq({ enabled: true, requests_per_period: 1003, period_in_seconds: 1004 })
|
|
|
|
expect(rate_limits[:authenticated_web]).to eq({ enabled: true, requests_per_period: 1005, period_in_seconds: 1006 })
|
|
|
|
expect(rate_limits[:protected_paths]).to eq({ enabled: true, requests_per_period: 1007, period_in_seconds: 1008 })
|
|
|
|
expect(rate_limits[:unauthenticated_packages_api]).to eq({ enabled: false, requests_per_period: 1009, period_in_seconds: 1010 })
|
|
|
|
expect(rate_limits[:authenticated_packages_api]).to eq({ enabled: true, requests_per_period: 1011, period_in_seconds: 1012 })
|
2021-09-22 05:11:53 -04:00
|
|
|
expect(rate_limits[:authenticated_git_lfs_api]).to eq({ enabled: true, requests_per_period: 1022, period_in_seconds: 1023 })
|
2021-07-30 02:08:52 -04:00
|
|
|
expect(rate_limits[:issue_creation]).to eq({ enabled: true, requests_per_period: 1013, period_in_seconds: 60 })
|
|
|
|
expect(rate_limits[:note_creation]).to eq({ enabled: true, requests_per_period: 1014, period_in_seconds: 60 })
|
|
|
|
expect(rate_limits[:project_export]).to eq({ enabled: true, requests_per_period: 1015, period_in_seconds: 60 })
|
|
|
|
expect(rate_limits[:project_export_download]).to eq({ enabled: true, requests_per_period: 1016, period_in_seconds: 60 })
|
|
|
|
expect(rate_limits[:project_import]).to eq({ enabled: true, requests_per_period: 1017, period_in_seconds: 60 })
|
|
|
|
expect(rate_limits[:group_export]).to eq({ enabled: true, requests_per_period: 1018, period_in_seconds: 60 })
|
|
|
|
expect(rate_limits[:group_export_download]).to eq({ enabled: true, requests_per_period: 1019, period_in_seconds: 60 })
|
|
|
|
expect(rate_limits[:group_import]).to eq({ enabled: true, requests_per_period: 1020, period_in_seconds: 60 })
|
|
|
|
expect(rate_limits[:raw_blob]).to eq({ enabled: true, requests_per_period: 1021, period_in_seconds: 60 })
|
|
|
|
end
|
|
|
|
end
|
2017-08-24 10:34:36 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'with cache', :use_clean_rails_memory_store_caching do
|
|
|
|
it 'caches settings content' do
|
|
|
|
expect(Rails.cache.read(described_class::CACHE_KEY)).to be_nil
|
|
|
|
|
|
|
|
settings = subject.settings
|
|
|
|
|
|
|
|
expect(Rails.cache.read(described_class::CACHE_KEY)).to eq(settings)
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'cached settings' do
|
|
|
|
before do
|
|
|
|
subject.settings
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'expires after EXPIRATION_TIME' do
|
2020-05-22 05:08:09 -04:00
|
|
|
allow(Time).to receive(:now).and_return(Time.current + described_class::EXPIRATION_TIME)
|
2017-08-24 10:34:36 -04:00
|
|
|
Rails.cache.cleanup
|
|
|
|
|
|
|
|
expect(Rails.cache.read(described_class::CACHE_KEY)).to eq(nil)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|