gitlab-org--gitlab-foss/spec/requests/api/variables_spec.rb

196 lines
6.3 KiB
Ruby
Raw Normal View History

require 'spec_helper'
describe API::Variables do
let(:user) { create(:user) }
let(:user2) { create(:user) }
let!(:project) { create(:project, creator_id: user.id) }
let!(:master) { create(:project_member, :master, user: user, project: project) }
let!(:developer) { create(:project_member, :developer, user: user2, project: project) }
let!(:variable) { create(:ci_variable, project: project) }
describe 'GET /projects/:id/variables' do
context 'authorized user with proper permissions' do
it 'returns project variables' do
get api("/projects/#{project.id}/variables", user)
2016-06-27 14:10:42 -04:00
expect(response).to have_http_status(200)
expect(json_response).to be_a(Array)
end
end
context 'authorized user with invalid permissions' do
it 'does not return project variables' do
get api("/projects/#{project.id}/variables", user2)
2016-06-27 14:10:42 -04:00
expect(response).to have_http_status(403)
end
end
context 'unauthorized user' do
it 'does not return project variables' do
get api("/projects/#{project.id}/variables")
2016-06-27 14:10:42 -04:00
expect(response).to have_http_status(401)
end
end
end
describe 'GET /projects/:id/variables/:key' do
context 'authorized user with proper permissions' do
it 'returns project variable details' do
2015-12-31 10:25:49 -05:00
get api("/projects/#{project.id}/variables/#{variable.key}", user)
2016-06-27 14:10:42 -04:00
expect(response).to have_http_status(200)
2015-12-31 10:25:49 -05:00
expect(json_response['value']).to eq(variable.value)
2017-05-25 07:49:46 -04:00
expect(json_response['protected']).to eq(variable.protected?)
end
it 'responds with 404 Not Found if requesting non-existing variable' do
get api("/projects/#{project.id}/variables/non_existing_variable", user)
2016-06-27 14:10:42 -04:00
expect(response).to have_http_status(404)
end
end
context 'authorized user with invalid permissions' do
it 'does not return project variable details' do
get api("/projects/#{project.id}/variables/#{variable.key}", user2)
2016-06-27 14:10:42 -04:00
expect(response).to have_http_status(403)
end
end
context 'unauthorized user' do
it 'does not return project variable details' do
get api("/projects/#{project.id}/variables/#{variable.key}")
2015-12-31 10:25:49 -05:00
2016-06-27 14:10:42 -04:00
expect(response).to have_http_status(401)
2015-12-31 10:25:49 -05:00
end
end
end
2015-12-31 16:30:07 -05:00
describe 'POST /projects/:id/variables' do
context 'authorized user with proper permissions' do
it 'creates variable' do
2015-12-31 16:30:07 -05:00
expect do
2017-05-25 07:49:46 -04:00
post api("/projects/#{project.id}/variables", user), key: 'TEST_VARIABLE_2', value: 'VALUE_2', protected: true
end.to change {project.variables.count}.by(1)
2015-12-31 16:30:07 -05:00
2016-06-27 14:10:42 -04:00
expect(response).to have_http_status(201)
2015-12-31 16:30:07 -05:00
expect(json_response['key']).to eq('TEST_VARIABLE_2')
expect(json_response['value']).to eq('VALUE_2')
expect(json_response['protected']).to be_truthy
2015-12-31 16:30:07 -05:00
end
it 'creates variable with optional attributes' do
expect do
post api("/projects/#{project.id}/variables", user), key: 'TEST_VARIABLE_2', value: 'VALUE_2'
end.to change {project.variables.count}.by(1)
expect(response).to have_http_status(201)
expect(json_response['key']).to eq('TEST_VARIABLE_2')
expect(json_response['value']).to eq('VALUE_2')
expect(json_response['protected']).to be_falsey
end
it 'does not allow to duplicate variable key' do
2015-12-31 16:30:07 -05:00
expect do
2016-01-13 13:57:23 -05:00
post api("/projects/#{project.id}/variables", user), key: variable.key, value: 'VALUE_2'
end.to change {project.variables.count}.by(0)
2015-12-31 16:30:07 -05:00
2016-06-27 14:10:42 -04:00
expect(response).to have_http_status(400)
2015-12-31 16:30:07 -05:00
end
end
context 'authorized user with invalid permissions' do
it 'does not create variable' do
2015-12-31 16:30:07 -05:00
post api("/projects/#{project.id}/variables", user2)
2016-06-27 14:10:42 -04:00
expect(response).to have_http_status(403)
2015-12-31 16:30:07 -05:00
end
end
context 'unauthorized user' do
it 'does not create variable' do
2015-12-31 16:30:07 -05:00
post api("/projects/#{project.id}/variables")
2016-06-27 14:10:42 -04:00
expect(response).to have_http_status(401)
2015-12-31 16:30:07 -05:00
end
end
end
describe 'PUT /projects/:id/variables/:key' do
2015-12-31 10:25:49 -05:00
context 'authorized user with proper permissions' do
it 'updates variable data' do
2015-12-31 10:25:49 -05:00
initial_variable = project.variables.first
value_before = initial_variable.value
2017-05-25 07:49:46 -04:00
put api("/projects/#{project.id}/variables/#{variable.key}", user), value: 'VALUE_1_UP', protected: true
2015-12-31 10:25:49 -05:00
updated_variable = project.variables.first
2016-06-27 14:10:42 -04:00
expect(response).to have_http_status(200)
2015-12-31 10:25:49 -05:00
expect(value_before).to eq(variable.value)
expect(updated_variable.value).to eq('VALUE_1_UP')
2017-05-25 07:49:46 -04:00
expect(updated_variable).to be_protected
2015-12-31 10:25:49 -05:00
end
it 'responds with 404 Not Found if requesting non-existing variable' do
put api("/projects/#{project.id}/variables/non_existing_variable", user)
2016-06-27 14:10:42 -04:00
expect(response).to have_http_status(404)
end
2015-12-31 10:25:49 -05:00
end
context 'authorized user with invalid permissions' do
it 'does not update variable' do
put api("/projects/#{project.id}/variables/#{variable.key}", user2)
2015-12-31 10:25:49 -05:00
2016-06-27 14:10:42 -04:00
expect(response).to have_http_status(403)
2015-12-31 10:25:49 -05:00
end
end
context 'unauthorized user' do
it 'does not update variable' do
put api("/projects/#{project.id}/variables/#{variable.key}")
2016-06-27 14:10:42 -04:00
expect(response).to have_http_status(401)
end
end
end
2015-12-31 10:56:03 -05:00
describe 'DELETE /projects/:id/variables/:key' do
2015-12-31 10:56:03 -05:00
context 'authorized user with proper permissions' do
it 'deletes variable' do
2015-12-31 10:56:03 -05:00
expect do
delete api("/projects/#{project.id}/variables/#{variable.key}", user)
2017-02-20 13:18:12 -05:00
expect(response).to have_http_status(204)
end.to change {project.variables.count}.by(-1)
2015-12-31 10:56:03 -05:00
end
it 'responds with 404 Not Found if requesting non-existing variable' do
delete api("/projects/#{project.id}/variables/non_existing_variable", user)
2016-06-27 14:10:42 -04:00
expect(response).to have_http_status(404)
end
2015-12-31 10:56:03 -05:00
end
context 'authorized user with invalid permissions' do
it 'does not delete variable' do
delete api("/projects/#{project.id}/variables/#{variable.key}", user2)
2015-12-31 10:56:03 -05:00
2016-06-27 14:10:42 -04:00
expect(response).to have_http_status(403)
2015-12-31 10:56:03 -05:00
end
end
context 'unauthorized user' do
it 'does not delete variable' do
delete api("/projects/#{project.id}/variables/#{variable.key}")
2015-12-31 10:56:03 -05:00
2016-06-27 14:10:42 -04:00
expect(response).to have_http_status(401)
2015-12-31 10:56:03 -05:00
end
end
end
end