kotovalexarian-likes-gitlab
/
gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity
gitlab-org--gitlab-foss/.gitlab/merge_request_templates/Security Release.md

36 lines
1.5 KiB
Markdown
Raw Normal View History

Create security release MR template Improve existing issue templates for security releases
2019-01-28 11:21:42 +00:00
<!--
# README first!
Add latest changes from gitlab-org/gitlab@master
2019-12-18 18:08:04 +00:00
This MR should be created on `gitlab.com/gitlab-org/security/gitlab`.
Create security release MR template Improve existing issue templates for security releases
2019-01-28 11:21:42 +00:00
Address docs review feedback
2019-01-29 10:57:21 +00:00
See [the general developer security release guidelines](https://gitlab.com/gitlab-org/release/docs/blob/master/general/security/developer.md).
Create security release MR template Improve existing issue templates for security releases
2019-01-28 11:21:42 +00:00
-->
Add latest changes from gitlab-org/gitlab@master
2019-12-18 18:08:04 +00:00
Create security release MR template Improve existing issue templates for security releases
2019-01-28 11:21:42 +00:00
## Related issues
<!-- Mention the issue(s) this MR is related to -->
Author is Developer in sec. release MR template
2019-02-05 13:57:44 +00:00
## Developer checklist
Create security release MR template Improve existing issue templates for security releases
2019-01-28 11:21:42 +00:00
Add latest changes from gitlab-org/gitlab@master
2019-12-18 18:08:04 +00:00
- [ ] Link this MR in the `links` section of the related issue on [GitLab Security].
- [ ] Merge request targets `master`, or `X-Y-stable` for backports.
- [ ] Milestone is set for the version this merge request applies to.
- [ ] Title of this merge request is the same as for all backports.
Create security release MR template Improve existing issue templates for security releases
2019-01-28 11:21:42 +00:00
- [ ] A [CHANGELOG entry](https://docs.gitlab.com/ee/development/changelog.html) is added without a `merge_request` value, with `type` set to `security`
Add latest changes from gitlab-org/gitlab@master
2019-12-18 18:08:04 +00:00
- [ ] Assign to a reviewer and maintainer, per our [Code Review process].
- [ ] If this merge request targets `master`, ensure it's approved according to our [Approval Guidelines].
- [ ] Merge request _must not_ close the corresponding security issue, _unless_ it targets `master`.
**Note:** Reviewer/maintainer should not be a Release Manager
Create security release MR template Improve existing issue templates for security releases
2019-01-28 11:21:42 +00:00
Author is Developer in sec. release MR template
2019-02-05 13:57:44 +00:00
## Reviewer checklist
Create security release MR template Improve existing issue templates for security releases
2019-01-28 11:21:42 +00:00
- [ ] Correct milestone is applied and the title is matching across all backports
- [ ] Assigned to `@gitlab-release-tools-bot` with passing CI pipelines
Remove requirement to target security branches This removes the requirement and any mention of targeting security branches when working on security releases. The release process documentation changes for these CE changes can be found in merge request https://gitlab.com/gitlab-org/release/docs/merge_requests/97. The proposal to remove security branches was approved in https://gitlab.com/gitlab-org/release/framework/issues/165#note_138139016.
2019-02-06 13:14:55 +00:00
/label ~security
Add latest changes from gitlab-org/gitlab@master
2019-12-18 18:08:04 +00:00
[GitLab Security]: https://gitlab.com/gitlab-org/security/gitlab
[approval guidelines]: https://docs.gitlab.com/ee/development/code_review.html#approval-guidelines
[Code Review process]: https://docs.gitlab.com/ee/development/code_review.html