2015-08-26 01:42:46 +00:00
|
|
|
# == Schema Information
|
|
|
|
#
|
|
|
|
# Table name: commits
|
|
|
|
#
|
|
|
|
# id :integer not null, primary key
|
|
|
|
# project_id :integer
|
|
|
|
# ref :string(255)
|
|
|
|
# sha :string(255)
|
|
|
|
# before_sha :string(255)
|
|
|
|
# push_data :text
|
|
|
|
# created_at :datetime
|
|
|
|
# updated_at :datetime
|
|
|
|
# tag :boolean default(FALSE)
|
|
|
|
# yaml_errors :text
|
|
|
|
# committed_at :datetime
|
|
|
|
#
|
|
|
|
|
|
|
|
require 'spec_helper'
|
|
|
|
|
2015-09-09 12:17:16 +00:00
|
|
|
describe Ci::Commit do
|
2015-09-28 11:35:26 +00:00
|
|
|
let(:project) { FactoryGirl.create :ci_project }
|
|
|
|
let(:gl_project) { FactoryGirl.create :empty_project, gitlab_ci_project: project }
|
|
|
|
let(:commit) { FactoryGirl.create :ci_commit, gl_project: gl_project }
|
2015-08-26 01:42:46 +00:00
|
|
|
|
2015-09-28 11:35:26 +00:00
|
|
|
it { is_expected.to belong_to(:gl_project) }
|
2015-09-10 13:52:52 +00:00
|
|
|
it { is_expected.to have_many(:builds) }
|
|
|
|
it { is_expected.to validate_presence_of :sha }
|
2015-08-26 01:42:46 +00:00
|
|
|
|
2015-09-10 13:52:52 +00:00
|
|
|
it { is_expected.to respond_to :git_author_name }
|
|
|
|
it { is_expected.to respond_to :git_author_email }
|
|
|
|
it { is_expected.to respond_to :short_sha }
|
2015-08-26 01:42:46 +00:00
|
|
|
|
|
|
|
describe :last_build do
|
|
|
|
subject { commit.last_build }
|
|
|
|
before do
|
2015-09-09 12:17:16 +00:00
|
|
|
@first = FactoryGirl.create :ci_build, commit: commit, created_at: Date.yesterday
|
|
|
|
@second = FactoryGirl.create :ci_build, commit: commit
|
2015-08-26 01:42:46 +00:00
|
|
|
end
|
|
|
|
|
2015-09-10 13:52:52 +00:00
|
|
|
it { is_expected.to be_a(Ci::Build) }
|
|
|
|
it('returns with the most recently created build') { is_expected.to eq(@second) }
|
2015-08-26 01:42:46 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
describe :retry do
|
|
|
|
before do
|
2015-09-09 12:17:16 +00:00
|
|
|
@first = FactoryGirl.create :ci_build, commit: commit, created_at: Date.yesterday
|
|
|
|
@second = FactoryGirl.create :ci_build, commit: commit
|
2015-08-26 01:42:46 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
it "creates new build" do
|
|
|
|
expect(commit.builds.count(:all)).to eq 2
|
|
|
|
commit.retry
|
|
|
|
expect(commit.builds.count(:all)).to eq 3
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe :valid_commit_sha do
|
|
|
|
context 'commit.sha can not start with 00000000' do
|
|
|
|
before do
|
|
|
|
commit.sha = '0' * 40
|
|
|
|
commit.valid_commit_sha
|
|
|
|
end
|
|
|
|
|
2015-09-10 13:52:52 +00:00
|
|
|
it('commit errors should not be empty') { expect(commit.errors).not_to be_empty }
|
2015-08-26 01:42:46 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe :short_sha do
|
|
|
|
subject { commit.short_sha }
|
|
|
|
|
2015-09-10 13:52:52 +00:00
|
|
|
it 'has 8 items' do
|
|
|
|
expect(subject.size).to eq(8)
|
|
|
|
end
|
|
|
|
it { expect(commit.sha).to start_with(subject) }
|
2015-08-26 01:42:46 +00:00
|
|
|
end
|
|
|
|
|
2015-10-05 13:59:31 +00:00
|
|
|
describe :stage do
|
|
|
|
subject { commit.stage }
|
|
|
|
|
|
|
|
before do
|
|
|
|
@second = FactoryGirl.create :ci_build, commit: commit, name: 'deploy', stage: 'deploy', stage_idx: 1, status: :pending
|
|
|
|
@first = FactoryGirl.create :ci_build, commit: commit, name: 'test', stage: 'test', stage_idx: 0, status: :pending
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns first running stage' do
|
|
|
|
is_expected.to eq('test')
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'first build succeeded' do
|
|
|
|
before do
|
|
|
|
@first.update_attributes(status: :success)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns last running stage' do
|
|
|
|
is_expected.to eq('deploy')
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'all builds succeeded' do
|
|
|
|
before do
|
|
|
|
@first.update_attributes(status: :success)
|
|
|
|
@second.update_attributes(status: :success)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns nil' do
|
|
|
|
is_expected.to be_nil
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2015-08-26 01:42:46 +00:00
|
|
|
describe :create_next_builds do
|
2015-10-05 10:02:26 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
describe :create_builds do
|
2015-10-05 11:12:00 +00:00
|
|
|
let(:commit) { FactoryGirl.create :ci_commit, gl_project: gl_project }
|
2015-10-05 10:02:26 +00:00
|
|
|
|
|
|
|
def create_builds(trigger_request = nil)
|
|
|
|
commit.create_builds('master', false, nil, trigger_request)
|
2015-08-26 01:42:46 +00:00
|
|
|
end
|
|
|
|
|
2015-10-05 10:02:26 +00:00
|
|
|
def create_next_builds(trigger_request = nil)
|
|
|
|
commit.create_next_builds('master', false, nil, trigger_request)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'creates builds' do
|
|
|
|
expect(create_builds).to be_truthy
|
2015-08-26 01:42:46 +00:00
|
|
|
commit.builds.reload
|
2015-09-10 13:52:52 +00:00
|
|
|
expect(commit.builds.size).to eq(2)
|
2015-08-26 01:42:46 +00:00
|
|
|
|
2015-10-05 10:02:26 +00:00
|
|
|
expect(create_next_builds).to be_truthy
|
2015-08-26 01:42:46 +00:00
|
|
|
commit.builds.reload
|
2015-09-10 13:52:52 +00:00
|
|
|
expect(commit.builds.size).to eq(4)
|
2015-08-26 01:42:46 +00:00
|
|
|
|
2015-10-05 10:02:26 +00:00
|
|
|
expect(create_next_builds).to be_truthy
|
2015-08-26 01:42:46 +00:00
|
|
|
commit.builds.reload
|
2015-09-10 13:52:52 +00:00
|
|
|
expect(commit.builds.size).to eq(5)
|
2015-08-26 01:42:46 +00:00
|
|
|
|
2015-10-05 10:02:26 +00:00
|
|
|
expect(create_next_builds).to be_falsey
|
2015-08-26 01:42:46 +00:00
|
|
|
end
|
|
|
|
|
2015-10-05 10:02:26 +00:00
|
|
|
context 'for different ref' do
|
|
|
|
def create_develop_builds
|
|
|
|
commit.create_builds('develop', false, nil, nil)
|
|
|
|
end
|
2015-08-26 01:42:46 +00:00
|
|
|
|
2015-10-05 10:02:26 +00:00
|
|
|
it 'creates builds' do
|
|
|
|
expect(create_builds).to be_truthy
|
|
|
|
commit.builds.reload
|
|
|
|
expect(commit.builds.size).to eq(2)
|
|
|
|
|
|
|
|
expect(create_develop_builds).to be_truthy
|
|
|
|
commit.builds.reload
|
|
|
|
expect(commit.builds.size).to eq(4)
|
|
|
|
expect(commit.refs.size).to eq(2)
|
|
|
|
expect(commit.builds.pluck(:name).uniq.size).to eq(2)
|
|
|
|
end
|
2015-08-26 01:42:46 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
context 'for build triggers' do
|
2015-09-09 12:17:16 +00:00
|
|
|
let(:trigger) { FactoryGirl.create :ci_trigger, project: project }
|
|
|
|
let(:trigger_request) { FactoryGirl.create :ci_trigger_request, commit: commit, trigger: trigger }
|
2015-08-26 01:42:46 +00:00
|
|
|
|
|
|
|
it 'creates builds' do
|
2015-10-05 10:02:26 +00:00
|
|
|
expect(create_builds(trigger_request)).to be_truthy
|
2015-08-26 01:42:46 +00:00
|
|
|
commit.builds.reload
|
2015-09-10 13:52:52 +00:00
|
|
|
expect(commit.builds.size).to eq(2)
|
2015-08-26 01:42:46 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
it 'rebuilds commit' do
|
2015-10-05 10:02:26 +00:00
|
|
|
expect(create_builds).to be_truthy
|
2015-08-26 01:42:46 +00:00
|
|
|
commit.builds.reload
|
2015-09-10 13:52:52 +00:00
|
|
|
expect(commit.builds.size).to eq(2)
|
2015-08-26 01:42:46 +00:00
|
|
|
|
2015-10-05 10:02:26 +00:00
|
|
|
expect(create_builds(trigger_request)).to be_truthy
|
2015-08-26 01:42:46 +00:00
|
|
|
commit.builds.reload
|
2015-09-10 13:52:52 +00:00
|
|
|
expect(commit.builds.size).to eq(4)
|
2015-08-26 01:42:46 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
it 'creates next builds' do
|
2015-10-05 10:02:26 +00:00
|
|
|
expect(create_builds(trigger_request)).to be_truthy
|
2015-08-26 01:42:46 +00:00
|
|
|
commit.builds.reload
|
2015-09-10 13:52:52 +00:00
|
|
|
expect(commit.builds.size).to eq(2)
|
2015-08-26 01:42:46 +00:00
|
|
|
|
2015-10-05 10:02:26 +00:00
|
|
|
expect(create_next_builds(trigger_request)).to be_truthy
|
2015-08-26 01:42:46 +00:00
|
|
|
commit.builds.reload
|
2015-09-10 13:52:52 +00:00
|
|
|
expect(commit.builds.size).to eq(4)
|
2015-08-26 01:42:46 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
context 'for [ci skip]' do
|
|
|
|
before do
|
2015-10-05 10:02:26 +00:00
|
|
|
allow(commit).to receive(:git_commit_message) { 'message [ci skip]' }
|
2015-08-26 01:42:46 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
it 'rebuilds commit' do
|
2015-09-10 13:52:52 +00:00
|
|
|
expect(commit.status).to eq('skipped')
|
2015-10-05 10:02:26 +00:00
|
|
|
expect(create_builds(trigger_request)).to be_truthy
|
2015-08-26 01:42:46 +00:00
|
|
|
commit.builds.reload
|
2015-09-10 13:52:52 +00:00
|
|
|
expect(commit.builds.size).to eq(2)
|
|
|
|
expect(commit.status).to eq('pending')
|
2015-08-26 01:42:46 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe "#finished_at" do
|
2015-09-28 11:14:34 +00:00
|
|
|
let(:commit) { FactoryGirl.create :ci_commit }
|
2015-08-26 01:42:46 +00:00
|
|
|
|
|
|
|
it "returns finished_at of latest build" do
|
2015-09-09 12:17:16 +00:00
|
|
|
build = FactoryGirl.create :ci_build, commit: commit, finished_at: Time.now - 60
|
2015-10-03 06:48:54 +00:00
|
|
|
FactoryGirl.create :ci_build, commit: commit, finished_at: Time.now - 120
|
2015-08-26 01:42:46 +00:00
|
|
|
|
2015-09-10 13:52:52 +00:00
|
|
|
expect(commit.finished_at.to_i).to eq(build.finished_at.to_i)
|
2015-08-26 01:42:46 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
it "returns nil if there is no finished build" do
|
2015-10-03 06:48:54 +00:00
|
|
|
FactoryGirl.create :ci_not_started_build, commit: commit
|
2015-08-26 01:42:46 +00:00
|
|
|
|
2015-09-10 13:52:52 +00:00
|
|
|
expect(commit.finished_at).to be_nil
|
2015-08-26 01:42:46 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe "coverage" do
|
2015-09-09 12:17:16 +00:00
|
|
|
let(:project) { FactoryGirl.create :ci_project, coverage_regex: "/.*/" }
|
2015-09-28 11:14:34 +00:00
|
|
|
let(:gl_project) { FactoryGirl.create :empty_project, gitlab_ci_project: project }
|
|
|
|
let(:commit) { FactoryGirl.create :ci_commit, gl_project: gl_project }
|
2015-08-26 01:42:46 +00:00
|
|
|
|
|
|
|
it "calculates average when there are two builds with coverage" do
|
2015-09-09 12:17:16 +00:00
|
|
|
FactoryGirl.create :ci_build, name: "rspec", coverage: 30, commit: commit
|
|
|
|
FactoryGirl.create :ci_build, name: "rubocop", coverage: 40, commit: commit
|
2015-09-10 13:52:52 +00:00
|
|
|
expect(commit.coverage).to eq("35.00")
|
2015-08-26 01:42:46 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
it "calculates average when there are two builds with coverage and one with nil" do
|
2015-09-09 12:17:16 +00:00
|
|
|
FactoryGirl.create :ci_build, name: "rspec", coverage: 30, commit: commit
|
|
|
|
FactoryGirl.create :ci_build, name: "rubocop", coverage: 40, commit: commit
|
|
|
|
FactoryGirl.create :ci_build, commit: commit
|
2015-09-10 13:52:52 +00:00
|
|
|
expect(commit.coverage).to eq("35.00")
|
2015-08-26 01:42:46 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
it "calculates average when there are two builds with coverage and one is retried" do
|
2015-09-09 12:17:16 +00:00
|
|
|
FactoryGirl.create :ci_build, name: "rspec", coverage: 30, commit: commit
|
|
|
|
FactoryGirl.create :ci_build, name: "rubocop", coverage: 30, commit: commit
|
|
|
|
FactoryGirl.create :ci_build, name: "rubocop", coverage: 40, commit: commit
|
2015-09-10 13:52:52 +00:00
|
|
|
expect(commit.coverage).to eq("35.00")
|
2015-08-26 01:42:46 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
it "calculates average when there is one build without coverage" do
|
2015-09-09 12:17:16 +00:00
|
|
|
FactoryGirl.create :ci_build, commit: commit
|
2015-09-10 13:52:52 +00:00
|
|
|
expect(commit.coverage).to be_nil
|
2015-08-26 01:42:46 +00:00
|
|
|
end
|
|
|
|
end
|
2015-10-05 12:15:15 +00:00
|
|
|
|
|
|
|
describe :should_create_next_builds? do
|
|
|
|
before do
|
|
|
|
@build1 = FactoryGirl.create :ci_build, commit: commit, name: 'build1', ref: 'master', tag: false, status: :success
|
|
|
|
@build2 = FactoryGirl.create :ci_build, commit: commit, name: 'build1', ref: 'develop', tag: false, status: :failed
|
|
|
|
@build3 = FactoryGirl.create :ci_build, commit: commit, name: 'build1', ref: 'master', tag: true, status: :failed
|
|
|
|
@build4 = FactoryGirl.create :ci_build, commit: commit, name: 'build4', ref: 'master', tag: false, status: :success
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'for success' do
|
|
|
|
it 'to create if all succeeded' do
|
|
|
|
expect(commit.should_create_next_builds?(@build4)).to be_truthy
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'for failed' do
|
|
|
|
before do
|
|
|
|
@build4.update_attributes(status: :failed)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'to not create' do
|
|
|
|
expect(commit.should_create_next_builds?(@build4)).to be_falsey
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'and ignore failures for current' do
|
|
|
|
before do
|
|
|
|
@build4.update_attributes(allow_failure: true)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'to create' do
|
|
|
|
expect(commit.should_create_next_builds?(@build4)).to be_truthy
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'for running' do
|
|
|
|
before do
|
|
|
|
@build4.update_attributes(status: :running)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'to not create' do
|
|
|
|
expect(commit.should_create_next_builds?(@build4)).to be_falsey
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'for retried' do
|
|
|
|
before do
|
|
|
|
@build5 = FactoryGirl.create :ci_build, commit: commit, name: 'build4', ref: 'master', tag: false, status: :failed
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'to not create' do
|
|
|
|
expect(commit.should_create_next_builds?(@build4)).to be_falsey
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2015-08-26 01:42:46 +00:00
|
|
|
end
|