2018-12-05 19:51:30 -05:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
|
|
|
require 'spec_helper'
|
|
|
|
|
|
|
|
describe Issues::ImportCsvService do
|
|
|
|
let(:project) { create(:project) }
|
|
|
|
let(:user) { create(:user) }
|
|
|
|
|
|
|
|
subject do
|
|
|
|
uploader = FileUploader.new(project)
|
|
|
|
uploader.store!(file)
|
|
|
|
|
2019-01-03 00:17:07 -05:00
|
|
|
described_class.new(user, project, uploader).execute
|
2018-12-05 19:51:30 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
describe '#execute' do
|
|
|
|
context 'invalid file' do
|
|
|
|
let(:file) { fixture_file_upload('spec/fixtures/banana_sample.gif') }
|
|
|
|
|
|
|
|
it 'returns invalid file error' do
|
2019-12-16 07:07:43 -05:00
|
|
|
expect_next_instance_of(Notify) do |instance|
|
|
|
|
expect(instance).to receive(:import_issues_csv_email)
|
|
|
|
end
|
2018-12-05 19:51:30 -05:00
|
|
|
|
|
|
|
expect(subject[:success]).to eq(0)
|
2018-12-31 03:39:43 -05:00
|
|
|
expect(subject[:parse_error]).to eq(true)
|
2018-12-05 19:51:30 -05:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2020-03-02 07:07:57 -05:00
|
|
|
context 'with a file generated by Gitlab CSV export' do
|
|
|
|
let(:file) { fixture_file_upload('spec/fixtures/csv_gitlab_export.csv') }
|
|
|
|
|
|
|
|
it 'imports the CSV without errors' do
|
|
|
|
expect_next_instance_of(Notify) do |instance|
|
|
|
|
expect(instance).to receive(:import_issues_csv_email)
|
|
|
|
end
|
|
|
|
|
|
|
|
expect(subject[:success]).to eq(4)
|
|
|
|
expect(subject[:error_lines]).to eq([])
|
|
|
|
expect(subject[:parse_error]).to eq(false)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'correctly sets the issue attributes' do
|
|
|
|
expect { subject }.to change { project.issues.count }.by 4
|
|
|
|
|
|
|
|
expect(project.issues.reload.last).to have_attributes(
|
|
|
|
title: 'Test Title',
|
|
|
|
description: 'Test Description'
|
|
|
|
)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2018-12-05 19:51:30 -05:00
|
|
|
context 'comma delimited file' do
|
|
|
|
let(:file) { fixture_file_upload('spec/fixtures/csv_comma.csv') }
|
|
|
|
|
|
|
|
it 'imports CSV without errors' do
|
2019-12-16 07:07:43 -05:00
|
|
|
expect_next_instance_of(Notify) do |instance|
|
|
|
|
expect(instance).to receive(:import_issues_csv_email)
|
|
|
|
end
|
2018-12-05 19:51:30 -05:00
|
|
|
|
|
|
|
expect(subject[:success]).to eq(3)
|
2018-12-31 03:39:43 -05:00
|
|
|
expect(subject[:error_lines]).to eq([])
|
|
|
|
expect(subject[:parse_error]).to eq(false)
|
2018-12-05 19:51:30 -05:00
|
|
|
end
|
2020-03-02 07:07:57 -05:00
|
|
|
|
|
|
|
it 'correctly sets the issue attributes' do
|
|
|
|
expect { subject }.to change { project.issues.count }.by 3
|
|
|
|
|
|
|
|
expect(project.issues.reload.last).to have_attributes(
|
|
|
|
title: 'Title with quote"',
|
|
|
|
description: 'Description'
|
|
|
|
)
|
|
|
|
end
|
2018-12-05 19:51:30 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
context 'tab delimited file with error row' do
|
|
|
|
let(:file) { fixture_file_upload('spec/fixtures/csv_tab.csv') }
|
|
|
|
|
|
|
|
it 'imports CSV with some error rows' do
|
2019-12-16 07:07:43 -05:00
|
|
|
expect_next_instance_of(Notify) do |instance|
|
|
|
|
expect(instance).to receive(:import_issues_csv_email)
|
|
|
|
end
|
2018-12-05 19:51:30 -05:00
|
|
|
|
|
|
|
expect(subject[:success]).to eq(2)
|
2018-12-31 03:39:43 -05:00
|
|
|
expect(subject[:error_lines]).to eq([3])
|
|
|
|
expect(subject[:parse_error]).to eq(false)
|
2018-12-05 19:51:30 -05:00
|
|
|
end
|
2020-03-02 07:07:57 -05:00
|
|
|
|
|
|
|
it 'correctly sets the issue attributes' do
|
|
|
|
expect { subject }.to change { project.issues.count }.by 2
|
|
|
|
|
|
|
|
expect(project.issues.reload.last).to have_attributes(
|
|
|
|
title: 'Hello',
|
|
|
|
description: 'World'
|
|
|
|
)
|
|
|
|
end
|
2018-12-05 19:51:30 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
context 'semicolon delimited file with CRLF' do
|
|
|
|
let(:file) { fixture_file_upload('spec/fixtures/csv_semicolon.csv') }
|
|
|
|
|
|
|
|
it 'imports CSV with a blank row' do
|
2019-12-16 07:07:43 -05:00
|
|
|
expect_next_instance_of(Notify) do |instance|
|
|
|
|
expect(instance).to receive(:import_issues_csv_email)
|
|
|
|
end
|
2018-12-05 19:51:30 -05:00
|
|
|
|
|
|
|
expect(subject[:success]).to eq(3)
|
2018-12-31 03:39:43 -05:00
|
|
|
expect(subject[:error_lines]).to eq([4])
|
|
|
|
expect(subject[:parse_error]).to eq(false)
|
2018-12-05 19:51:30 -05:00
|
|
|
end
|
2020-03-02 07:07:57 -05:00
|
|
|
|
|
|
|
it 'correctly sets the issue attributes' do
|
|
|
|
expect { subject }.to change { project.issues.count }.by 3
|
|
|
|
|
|
|
|
expect(project.issues.reload.last).to have_attributes(
|
|
|
|
title: 'Hello',
|
|
|
|
description: 'World'
|
|
|
|
)
|
|
|
|
end
|
2018-12-05 19:51:30 -05:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|