2018-05-21 12:41:21 -04:00
# rubocop:disable Style/SignalException
if gitlab . mr_body . size < 5
2018-07-10 06:10:54 -04:00
fail " Please provide a proper merge request description. "
2018-05-21 12:41:21 -04:00
end
if gitlab . mr_labels . empty?
fail " Please add labels to this merge request. "
end
unless gitlab . mr_json [ " assignee " ]
warn " This merge request does not have any assignee yet. Setting an assignee clarifies who needs to take action on the merge request at any given time. "
end
has_milestone = ! gitlab . mr_json [ " milestone " ] . nil?
unless has_milestone
warn " This merge request does not refer to an existing milestone. " , sticky : false
end
has_pick_into_stable_label = gitlab . mr_labels . find { | label | label . start_with? ( 'Pick into' ) }
if gitlab . branch_for_base != " master " && ! has_pick_into_stable_label
2018-09-04 04:57:22 -04:00
warn " Most of the time, merge requests should target `master`. Otherwise, please set the relevant `Pick into X.Y` label. "
2018-05-21 12:41:21 -04:00
end
2018-11-06 09:20:33 -05:00
if gitlab . mr_json [ 'title' ] . length > 72
warn 'The title of this merge request is longer than 72 characters and ' \
'would violate our commit message rules when using the Squash on Merge ' \
'feature. Please consider adjusting the title, or rebase the ' \
" commits manually and don't use Squash on Merge. "
end