2019-03-30 07:23:56 +00:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2018-03-21 01:58:43 +00:00
|
|
|
require 'spec_helper'
|
|
|
|
|
2020-06-24 18:09:03 +00:00
|
|
|
RSpec.describe Ci::BuildMetadata do
|
2020-02-12 15:09:37 +00:00
|
|
|
let_it_be(:user) { create(:user) }
|
|
|
|
let_it_be(:group) { create(:group) }
|
|
|
|
let_it_be(:project) { create(:project, :repository, group: group, build_timeout: 2000) }
|
2018-03-21 01:58:43 +00:00
|
|
|
|
2020-02-12 15:09:37 +00:00
|
|
|
let_it_be(:pipeline) do
|
2018-03-21 01:58:43 +00:00
|
|
|
create(:ci_pipeline, project: project,
|
|
|
|
sha: project.commit.id,
|
|
|
|
ref: project.default_branch,
|
|
|
|
status: 'success')
|
|
|
|
end
|
|
|
|
|
|
|
|
let(:build) { create(:ci_build, pipeline: pipeline) }
|
2018-09-02 14:35:15 +00:00
|
|
|
let(:metadata) { build.metadata }
|
2018-03-21 01:58:43 +00:00
|
|
|
|
2018-12-04 10:24:21 +00:00
|
|
|
it_behaves_like 'having unique enum values'
|
|
|
|
|
2018-03-26 15:47:46 +00:00
|
|
|
describe '#update_timeout_state' do
|
2018-09-02 14:35:15 +00:00
|
|
|
subject { metadata }
|
2018-03-21 01:58:43 +00:00
|
|
|
|
2019-09-16 18:06:05 +00:00
|
|
|
shared_examples 'sets timeout' do |source, timeout|
|
|
|
|
it 'sets project_timeout_source' do
|
|
|
|
expect { subject.update_timeout_state }.to change { subject.reload.timeout_source }.to(source)
|
2018-03-21 01:58:43 +00:00
|
|
|
end
|
|
|
|
|
2019-09-16 18:06:05 +00:00
|
|
|
it 'sets project timeout' do
|
|
|
|
expect { subject.update_timeout_state }.to change { subject.reload.timeout }.to(timeout)
|
2018-03-21 01:58:43 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2019-09-16 18:06:05 +00:00
|
|
|
context 'when project timeout is set' do
|
|
|
|
context 'when runner is assigned to the job' do
|
|
|
|
before do
|
|
|
|
build.update!(runner: runner)
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when runner timeout is not set' do
|
|
|
|
let(:runner) { create(:ci_runner, maximum_timeout: nil) }
|
|
|
|
|
|
|
|
it_behaves_like 'sets timeout', 'project_timeout_source', 2000
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when runner timeout is lower than project timeout' do
|
|
|
|
let(:runner) { create(:ci_runner, maximum_timeout: 1900) }
|
|
|
|
|
|
|
|
it_behaves_like 'sets timeout', 'runner_timeout_source', 1900
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when runner timeout is higher than project timeout' do
|
|
|
|
let(:runner) { create(:ci_runner, maximum_timeout: 2100) }
|
|
|
|
|
|
|
|
it_behaves_like 'sets timeout', 'project_timeout_source', 2000
|
|
|
|
end
|
2018-03-21 01:58:43 +00:00
|
|
|
end
|
|
|
|
|
2019-09-16 18:06:05 +00:00
|
|
|
context 'when job timeout is set' do
|
|
|
|
context 'when job timeout is higher than project timeout' do
|
|
|
|
let(:build) { create(:ci_build, pipeline: pipeline, options: { job_timeout: 3000 }) }
|
2018-03-21 01:58:43 +00:00
|
|
|
|
2019-09-16 18:06:05 +00:00
|
|
|
it_behaves_like 'sets timeout', 'job_timeout_source', 3000
|
2018-03-21 01:58:43 +00:00
|
|
|
end
|
|
|
|
|
2019-09-16 18:06:05 +00:00
|
|
|
context 'when job timeout is lower than project timeout' do
|
|
|
|
let(:build) { create(:ci_build, pipeline: pipeline, options: { job_timeout: 1000 }) }
|
|
|
|
|
|
|
|
it_behaves_like 'sets timeout', 'job_timeout_source', 1000
|
2018-03-21 01:58:43 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2019-09-16 18:06:05 +00:00
|
|
|
context 'when both runner and job timeouts are set' do
|
|
|
|
before do
|
2020-09-07 15:09:04 +00:00
|
|
|
build.update!(runner: runner)
|
2019-09-16 18:06:05 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
context 'when job timeout is higher than runner timeout' do
|
|
|
|
let(:build) { create(:ci_build, pipeline: pipeline, options: { job_timeout: 3000 }) }
|
|
|
|
let(:runner) { create(:ci_runner, maximum_timeout: 2100) }
|
2018-03-21 01:58:43 +00:00
|
|
|
|
2019-09-16 18:06:05 +00:00
|
|
|
it_behaves_like 'sets timeout', 'runner_timeout_source', 2100
|
2018-03-21 01:58:43 +00:00
|
|
|
end
|
|
|
|
|
2019-09-16 18:06:05 +00:00
|
|
|
context 'when job timeout is lower than runner timeout' do
|
|
|
|
let(:build) { create(:ci_build, pipeline: pipeline, options: { job_timeout: 1900 }) }
|
|
|
|
let(:runner) { create(:ci_runner, maximum_timeout: 2100) }
|
|
|
|
|
|
|
|
it_behaves_like 'sets timeout', 'job_timeout_source', 1900
|
2018-03-21 01:58:43 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2020-06-22 12:08:47 +00:00
|
|
|
|
|
|
|
describe 'validations' do
|
|
|
|
context 'when attributes are valid' do
|
|
|
|
it 'returns no errors' do
|
|
|
|
metadata.secrets = {
|
|
|
|
DATABASE_PASSWORD: {
|
|
|
|
vault: {
|
|
|
|
engine: { name: 'kv-v2', path: 'kv-v2' },
|
|
|
|
path: 'production/db',
|
|
|
|
field: 'password'
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
expect(metadata).to be_valid
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when data is invalid' do
|
|
|
|
it 'returns errors' do
|
|
|
|
metadata.secrets = { DATABASE_PASSWORD: { vault: {} } }
|
|
|
|
|
|
|
|
aggregate_failures do
|
|
|
|
expect(metadata).to be_invalid
|
|
|
|
expect(metadata.errors.full_messages).to eq(["Secrets must be a valid json schema"])
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2018-03-21 01:58:43 +00:00
|
|
|
end
|