gitlab-org--gitlab-foss/app/workers/concerns/mail_scheduler_queue.rb

# frozen_string_literal: true

module MailSchedulerQueue
  extend ActiveSupport::Concern

  included do
    queue_namespace :mail_scheduler
  end

  def notification_service
    @notification_service ||= NotificationService.new
  end
end
Enable frozen string for app/workers/*/.rb Partially addresses #47424. 2018-06-27 03:31:41 -04:00			`# frozen_string_literal: true`

Send emails for issues due tomorrow Also, refactor the mail sending slightly: instead of one worker sending all emails, create a worker per project with issues due, which will send all emails for that project. 2018-03-30 09:05:20 -04:00			`module MailSchedulerQueue`
			`extend ActiveSupport::Concern`

			`included do`
			`queue_namespace :mail_scheduler`
			`end`
Move NotificationService calls to Sidekiq The NotificationService has to do quite a lot of work to calculate the recipients for an email. Where possible, we should try to avoid doing this in an HTTP request, because the mail are sent by Sidekiq anyway, so there's no need to schedule those emails immediately. This commit creates a generic Sidekiq worker that uses Global ID to serialise and deserialise its arguments, then forwards them to the NotificationService. The NotificationService gains an `#async` method, so you can replace: notification_service.new_issue(issue, current_user) With: notification_service.async.new_issue(issue, current_user) And have everything else work as normal, except that calculating the recipients will be done by Sidekiq, which will then schedule further Sidekiq jobs to send each email. 2018-04-20 13:37:38 -04:00
			`def notification_service`
			`@notification_service \|\|= NotificationService.new`
			`end`
Send emails for issues due tomorrow Also, refactor the mail sending slightly: instead of one worker sending all emails, create a worker per project with issues due, which will send all emails for that project. 2018-03-30 09:05:20 -04:00			`end`