2020-01-17 10:08:37 -05:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
|
|
|
require 'spec_helper'
|
|
|
|
|
|
|
|
describe Ci::Processable do
|
2020-02-12 10:09:37 -05:00
|
|
|
let_it_be(:project) { create(:project) }
|
|
|
|
let_it_be(:pipeline) { create(:ci_pipeline, project: project) }
|
2020-01-17 10:08:37 -05:00
|
|
|
|
|
|
|
describe '#aggregated_needs_names' do
|
|
|
|
let(:with_aggregated_needs) { pipeline.processables.select_with_aggregated_needs(project) }
|
|
|
|
|
|
|
|
context 'with created status' do
|
|
|
|
let!(:processable) { create(:ci_build, :created, project: project, pipeline: pipeline) }
|
|
|
|
|
|
|
|
context 'with needs' do
|
|
|
|
before do
|
|
|
|
create(:ci_build_need, build: processable, name: 'test1')
|
|
|
|
create(:ci_build_need, build: processable, name: 'test2')
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns all processables' do
|
|
|
|
expect(with_aggregated_needs).to contain_exactly(processable)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns all needs' do
|
|
|
|
expect(with_aggregated_needs.first.aggregated_needs_names).to contain_exactly('test1', 'test2')
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'with ci_dag_support disabled' do
|
|
|
|
before do
|
|
|
|
stub_feature_flags(ci_dag_support: false)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns all processables' do
|
|
|
|
expect(with_aggregated_needs).to contain_exactly(processable)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns empty needs' do
|
|
|
|
expect(with_aggregated_needs.first.aggregated_needs_names).to be_nil
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'without needs' do
|
|
|
|
it 'returns all processables' do
|
|
|
|
expect(with_aggregated_needs).to contain_exactly(processable)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns empty needs' do
|
|
|
|
expect(with_aggregated_needs.first.aggregated_needs_names).to be_nil
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2020-02-12 01:09:05 -05:00
|
|
|
|
|
|
|
describe 'validate presence of scheduling_type' do
|
|
|
|
context 'on create' do
|
|
|
|
let(:processable) do
|
|
|
|
build(
|
|
|
|
:ci_build, :created, project: project, pipeline: pipeline,
|
|
|
|
importing: importing, scheduling_type: nil
|
|
|
|
)
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when importing' do
|
|
|
|
let(:importing) { true }
|
|
|
|
|
|
|
|
context 'when validate_scheduling_type_of_processables is true' do
|
|
|
|
before do
|
|
|
|
stub_feature_flags(validate_scheduling_type_of_processables: true)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not validate' do
|
|
|
|
expect(processable).to be_valid
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when validate_scheduling_type_of_processables is false' do
|
|
|
|
before do
|
|
|
|
stub_feature_flags(validate_scheduling_type_of_processables: false)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not validate' do
|
|
|
|
expect(processable).to be_valid
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when not importing' do
|
|
|
|
let(:importing) { false }
|
|
|
|
|
|
|
|
context 'when validate_scheduling_type_of_processables is true' do
|
|
|
|
before do
|
|
|
|
stub_feature_flags(validate_scheduling_type_of_processables: true)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'validates' do
|
|
|
|
expect(processable).not_to be_valid
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when validate_scheduling_type_of_processables is false' do
|
|
|
|
before do
|
|
|
|
stub_feature_flags(validate_scheduling_type_of_processables: false)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not validate' do
|
|
|
|
expect(processable).to be_valid
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'on update' do
|
|
|
|
let(:processable) { create(:ci_build, :created, project: project, pipeline: pipeline) }
|
|
|
|
|
|
|
|
it 'does not validate' do
|
|
|
|
processable.scheduling_type = nil
|
|
|
|
expect(processable).to be_valid
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2020-02-14 07:09:03 -05:00
|
|
|
|
|
|
|
describe '.populate_scheduling_type!' do
|
|
|
|
let!(:build_without_needs) { create(:ci_build, project: project, pipeline: pipeline) }
|
|
|
|
let!(:build_with_needs) { create(:ci_build, project: project, pipeline: pipeline) }
|
|
|
|
let!(:needs_relation) { create(:ci_build_need, build: build_with_needs) }
|
|
|
|
let!(:another_build) { create(:ci_build, project: project) }
|
|
|
|
|
|
|
|
before do
|
|
|
|
Ci::Processable.update_all(scheduling_type: nil)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'populates scheduling_type of processables' do
|
|
|
|
expect do
|
|
|
|
pipeline.processables.populate_scheduling_type!
|
|
|
|
end.to change(pipeline.processables.where(scheduling_type: nil), :count).from(2).to(0)
|
|
|
|
|
|
|
|
expect(build_without_needs.reload.scheduling_type).to eq('stage')
|
|
|
|
expect(build_with_needs.reload.scheduling_type).to eq('dag')
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not affect processables from other pipelines' do
|
|
|
|
pipeline.processables.populate_scheduling_type!
|
|
|
|
expect(another_build.reload.scheduling_type).to be_nil
|
|
|
|
end
|
|
|
|
end
|
2020-01-17 10:08:37 -05:00
|
|
|
end
|