2020-09-29 11:10:08 -04:00
|
|
|
# frozen_string_literal: true
|
2021-02-08 01:09:18 -05:00
|
|
|
# rubocop:disable Style/SignalException
|
2020-09-29 11:10:08 -04:00
|
|
|
|
2021-01-11 16:10:36 -05:00
|
|
|
CHANGED_FILES_MESSAGE = <<~MSG
|
2021-01-12 19:10:50 -05:00
|
|
|
For the following files, a review from the [Data team and Product Intelligence team](https://gitlab.com/groups/gitlab-org/growth/product-intelligence/engineers/-/group_members?with_inherited_permissions=exclude) is recommended
|
2021-02-10 10:11:19 -05:00
|
|
|
Please check the ~"product intelligence" [guide](https://docs.gitlab.com/ee/development/usage_ping.html) and reach out to %<engineers_group>s group for a review.
|
2020-09-29 11:10:08 -04:00
|
|
|
|
|
|
|
|
|
|
|
%<changed_files>s
|
|
|
|
|
|
|
|
MSG
|
|
|
|
|
|
|
|
UPDATE_METRICS_DEFINITIONS_MESSAGE = <<~MSG
|
2020-11-02 16:09:10 -05:00
|
|
|
When adding, changing, or updating metrics, please update the [Event dictionary Usage Ping table](https://about.gitlab.com/handbook/product/product-analytics-guide#event-dictionary).
|
2020-09-29 11:10:08 -04:00
|
|
|
|
|
|
|
MSG
|
|
|
|
|
2021-01-12 19:10:50 -05:00
|
|
|
ENGINEERS_GROUP = '@gitlab-org/growth/product-intelligence/engineers'
|
2020-09-29 11:10:08 -04:00
|
|
|
|
2021-02-08 01:09:18 -05:00
|
|
|
UPDATE_DICTIONARY_MESSAGE = <<~MSG
|
|
|
|
When updating metrics definitions, please update [Metrics Dictionary](https://docs.gitlab.com/ee/development/usage_ping/dictionary.html)
|
|
|
|
|
|
|
|
```shell
|
|
|
|
bundle exec rake gitlab:usage_data:generate_metrics_dictionary
|
|
|
|
```
|
|
|
|
MSG
|
|
|
|
|
|
|
|
all_changed_files = helper.all_changed_files
|
|
|
|
|
2020-09-29 11:10:08 -04:00
|
|
|
tracking_files = [
|
|
|
|
'lib/gitlab/tracking.rb',
|
|
|
|
'spec/lib/gitlab/tracking_spec.rb',
|
|
|
|
'app/helpers/tracking_helper.rb',
|
|
|
|
'spec/helpers/tracking_helper_spec.rb',
|
|
|
|
'app/assets/javascripts/tracking.js',
|
2021-01-20 07:11:06 -05:00
|
|
|
'spec/frontend/tracking_spec.js',
|
|
|
|
'generator_templates/usage_metric_definition/metric_definition.yml',
|
|
|
|
'lib/generators/rails/usage_metric_definition_generator.rb',
|
2021-02-08 01:09:18 -05:00
|
|
|
'spec/lib/generators/usage_metric_definition_generator_spec.rb',
|
|
|
|
'config/metrics/schema.json'
|
2020-09-29 11:10:08 -04:00
|
|
|
]
|
|
|
|
|
2021-02-08 01:09:18 -05:00
|
|
|
tracking_changed_files = all_changed_files & tracking_files
|
|
|
|
usage_data_changed_files = all_changed_files.grep(%r{(usage_data)})
|
|
|
|
metrics_changed_files = all_changed_files.grep(%r{((ee/)?config/metrics/.*\.yml)})
|
2021-02-09 07:09:48 -05:00
|
|
|
dictionary_changed_file = all_changed_files.grep(%r{(doc/development/usage_ping/dictionary.md)})
|
2020-09-29 11:10:08 -04:00
|
|
|
|
2021-02-08 01:09:18 -05:00
|
|
|
usage_changed_files = usage_data_changed_files + tracking_changed_files + metrics_changed_files + dictionary_changed_file
|
2020-09-29 11:10:08 -04:00
|
|
|
|
2021-02-08 01:09:18 -05:00
|
|
|
if usage_changed_files.any?
|
2020-09-29 11:10:08 -04:00
|
|
|
|
|
|
|
mention = if helper.draft_mr?
|
2021-01-11 16:10:36 -05:00
|
|
|
"`#{ENGINEERS_GROUP}`"
|
2020-09-29 11:10:08 -04:00
|
|
|
else
|
2021-01-11 16:10:36 -05:00
|
|
|
ENGINEERS_GROUP
|
2020-09-29 11:10:08 -04:00
|
|
|
end
|
|
|
|
|
2021-02-08 01:09:18 -05:00
|
|
|
warn format(CHANGED_FILES_MESSAGE, changed_files: helper.markdown_list(usage_changed_files), engineers_group: mention)
|
|
|
|
warn format(UPDATE_METRICS_DEFINITIONS_MESSAGE) if usage_data_changed_files.any?
|
|
|
|
|
|
|
|
fail format(UPDATE_DICTIONARY_MESSAGE) if metrics_changed_files.any? && dictionary_changed_file.empty?
|
2020-09-29 11:10:08 -04:00
|
|
|
|
2021-01-11 16:10:36 -05:00
|
|
|
labels = ['product intelligence']
|
|
|
|
labels << 'product intelligence::review pending' unless helper.mr_has_labels?('product intelligence::approved')
|
2020-09-29 11:10:08 -04:00
|
|
|
|
2021-01-11 16:10:36 -05:00
|
|
|
markdown(helper.prepare_labels_for_mr(labels))
|
2020-09-29 11:10:08 -04:00
|
|
|
end
|