2018-11-09 13:39:43 -05:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2018-07-18 07:12:57 -04:00
|
|
|
# Gitlab::Git::Commit is a wrapper around Gitaly::GitCommit
|
2017-01-04 13:43:06 -05:00
|
|
|
module Gitlab
|
|
|
|
module Git
|
|
|
|
class Commit
|
2017-06-01 17:21:14 -04:00
|
|
|
include Gitlab::EncodingHelper
|
2019-02-21 16:07:26 -05:00
|
|
|
prepend Gitlab::Git::RuggedImpl::Commit
|
2018-10-30 09:37:40 -04:00
|
|
|
extend Gitlab::Git::WrapsGitalyErrors
|
2020-06-10 08:08:58 -04:00
|
|
|
include Gitlab::Utils::StrongMemoize
|
2017-01-04 13:43:06 -05:00
|
|
|
|
2017-06-20 11:20:02 -04:00
|
|
|
attr_accessor :raw_commit, :head
|
2017-01-04 13:43:06 -05:00
|
|
|
|
2018-03-20 15:20:12 -04:00
|
|
|
MAX_COMMIT_MESSAGE_DISPLAY_SIZE = 10.megabytes
|
2017-11-22 09:48:09 -05:00
|
|
|
MIN_SHA_LENGTH = 7
|
2017-01-04 13:43:06 -05:00
|
|
|
SERIALIZE_KEYS = [
|
|
|
|
:id, :message, :parent_ids,
|
|
|
|
:authored_date, :author_name, :author_email,
|
|
|
|
:committed_date, :committer_name, :committer_email
|
|
|
|
].freeze
|
|
|
|
|
2020-01-15 22:08:47 -05:00
|
|
|
attr_accessor(*SERIALIZE_KEYS)
|
2017-01-04 13:43:06 -05:00
|
|
|
|
|
|
|
def ==(other)
|
|
|
|
return false unless other.is_a?(Gitlab::Git::Commit)
|
|
|
|
|
2017-05-09 14:41:21 -04:00
|
|
|
id && id == other.id
|
2017-01-04 13:43:06 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
class << self
|
|
|
|
# Get commits collection
|
|
|
|
#
|
|
|
|
# Ex.
|
|
|
|
# Commit.where(
|
|
|
|
# repo: repo,
|
|
|
|
# ref: 'master',
|
|
|
|
# path: 'app/models',
|
|
|
|
# limit: 10,
|
|
|
|
# offset: 5,
|
|
|
|
# )
|
|
|
|
#
|
|
|
|
def where(options)
|
|
|
|
repo = options.delete(:repo)
|
|
|
|
raise 'Gitlab::Git::Repository is required' unless repo.respond_to?(:log)
|
|
|
|
|
2017-07-13 08:54:21 -04:00
|
|
|
repo.log(options)
|
2017-01-04 13:43:06 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
# Get single commit
|
|
|
|
#
|
|
|
|
# Ex.
|
|
|
|
# Commit.find(repo, '29eda46b')
|
|
|
|
#
|
|
|
|
# Commit.find(repo, 'master')
|
|
|
|
#
|
2017-07-12 10:31:36 -04:00
|
|
|
# Gitaly migration: https://gitlab.com/gitlab-org/gitaly/issues/321
|
2017-01-04 13:43:06 -05:00
|
|
|
def find(repo, commit_id = "HEAD")
|
2017-07-25 17:33:06 -04:00
|
|
|
# Already a commit?
|
2017-03-17 15:36:46 -04:00
|
|
|
return commit_id if commit_id.is_a?(Gitlab::Git::Commit)
|
2017-07-25 17:33:06 -04:00
|
|
|
|
2018-06-01 05:37:03 -04:00
|
|
|
# This saves us an RPC round trip.
|
2020-05-15 08:08:28 -04:00
|
|
|
return unless valid?(commit_id)
|
2018-05-16 04:20:14 -04:00
|
|
|
|
2019-02-21 16:07:26 -05:00
|
|
|
commit = find_commit(repo, commit_id)
|
2017-01-04 13:43:06 -05:00
|
|
|
|
2017-07-25 17:33:06 -04:00
|
|
|
decorate(repo, commit) if commit
|
2018-07-18 07:12:57 -04:00
|
|
|
rescue Gitlab::Git::CommandError, Gitlab::Git::Repository::NoRepository, ArgumentError
|
2017-01-04 13:43:06 -05:00
|
|
|
nil
|
|
|
|
end
|
|
|
|
|
2019-02-21 16:07:26 -05:00
|
|
|
def find_commit(repo, commit_id)
|
|
|
|
wrapped_gitaly_errors do
|
|
|
|
repo.gitaly_commit_client.find_commit(commit_id)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2017-01-04 13:43:06 -05:00
|
|
|
# Get last commit for HEAD
|
|
|
|
#
|
|
|
|
# Ex.
|
|
|
|
# Commit.last(repo)
|
|
|
|
#
|
|
|
|
def last(repo)
|
|
|
|
find(repo)
|
|
|
|
end
|
|
|
|
|
|
|
|
# Get last commit for specified path and ref
|
|
|
|
#
|
|
|
|
# Ex.
|
|
|
|
# Commit.last_for_path(repo, '29eda46b', 'app/models')
|
|
|
|
#
|
|
|
|
# Commit.last_for_path(repo, 'master', 'Gemfile')
|
|
|
|
#
|
|
|
|
def last_for_path(repo, ref, path = nil)
|
2020-03-31 08:08:09 -04:00
|
|
|
# rubocop: disable Rails/FindBy
|
|
|
|
# This is not where..first from ActiveRecord
|
2017-01-04 13:43:06 -05:00
|
|
|
where(
|
|
|
|
repo: repo,
|
|
|
|
ref: ref,
|
|
|
|
path: path,
|
|
|
|
limit: 1
|
|
|
|
).first
|
2020-03-31 08:08:09 -04:00
|
|
|
# rubocop: enable Rails/FindBy
|
2017-01-04 13:43:06 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
# Get commits between two revspecs
|
|
|
|
# See also #repository.commits_between
|
|
|
|
#
|
|
|
|
# Ex.
|
|
|
|
# Commit.between(repo, '29eda46b', 'master')
|
|
|
|
#
|
|
|
|
def between(repo, base, head)
|
2018-10-30 09:37:40 -04:00
|
|
|
wrapped_gitaly_errors do
|
2018-06-28 03:36:57 -04:00
|
|
|
repo.gitaly_commit_client.between(base, head)
|
2017-06-23 17:52:51 -04:00
|
|
|
end
|
2017-01-04 13:43:06 -05:00
|
|
|
end
|
|
|
|
|
2017-06-27 06:17:14 -04:00
|
|
|
# Returns commits collection
|
|
|
|
#
|
|
|
|
# Ex.
|
|
|
|
# Commit.find_all(
|
|
|
|
# repo,
|
|
|
|
# ref: 'master',
|
|
|
|
# max_count: 10,
|
|
|
|
# skip: 5,
|
|
|
|
# order: :date
|
|
|
|
# )
|
|
|
|
#
|
|
|
|
# +options+ is a Hash of optional arguments to git
|
|
|
|
# :ref is the ref from which to begin (SHA1 or name)
|
|
|
|
# :max_count is the maximum number of commits to fetch
|
|
|
|
# :skip is the number of commits to skip
|
|
|
|
# :order is the commits order and allowed value is :none (default), :date,
|
|
|
|
# :topo, or any combination of them (in an array). Commit ordering types
|
2020-02-13 16:08:59 -05:00
|
|
|
# are documented here: https://git-scm.com/docs/git-log#_commit_ordering
|
2017-01-04 13:43:06 -05:00
|
|
|
def find_all(repo, options = {})
|
2018-10-30 09:37:40 -04:00
|
|
|
wrapped_gitaly_errors do
|
2018-06-28 07:41:59 -04:00
|
|
|
Gitlab::GitalyClient::CommitService.new(repo).find_all_commits(options)
|
2017-06-27 06:17:14 -04:00
|
|
|
end
|
2017-07-18 04:06:49 -04:00
|
|
|
end
|
|
|
|
|
2017-07-25 16:48:17 -04:00
|
|
|
def decorate(repository, commit, ref = nil)
|
|
|
|
Gitlab::Git::Commit.new(repository, commit, ref)
|
2017-01-04 13:43:06 -05:00
|
|
|
end
|
|
|
|
|
2017-08-15 07:22:55 -04:00
|
|
|
def shas_with_signatures(repository, shas)
|
2018-06-27 08:29:03 -04:00
|
|
|
Gitlab::GitalyClient::CommitService.new(repository).filter_shas_with_signatures(shas)
|
2017-08-15 07:22:55 -04:00
|
|
|
end
|
2017-12-05 08:15:30 -05:00
|
|
|
|
|
|
|
# Only to be used when the object ids will not necessarily have a
|
|
|
|
# relation to each other. The last 10 commits for a branch for example,
|
|
|
|
# should go through .where
|
|
|
|
def batch_by_oid(repo, oids)
|
2018-10-30 09:37:40 -04:00
|
|
|
wrapped_gitaly_errors do
|
2018-07-06 08:44:54 -04:00
|
|
|
repo.gitaly_commit_client.list_commits_by_oid(oids)
|
2017-12-05 08:15:30 -05:00
|
|
|
end
|
|
|
|
end
|
2018-01-18 09:10:17 -05:00
|
|
|
|
2018-02-28 11:56:00 -05:00
|
|
|
def extract_signature_lazily(repository, commit_id)
|
2018-11-23 06:26:17 -05:00
|
|
|
BatchLoader.for(commit_id).batch(key: repository) do |commit_ids, loader, args|
|
|
|
|
batch_signature_extraction(args[:key], commit_ids).each do |commit_id, signature_data|
|
|
|
|
loader.call(commit_id, signature_data)
|
2018-02-28 11:56:00 -05:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
def batch_signature_extraction(repository, commit_ids)
|
|
|
|
repository.gitaly_commit_client.get_commit_signatures(commit_ids)
|
|
|
|
end
|
|
|
|
|
2018-03-20 15:20:12 -04:00
|
|
|
def get_message(repository, commit_id)
|
2018-11-23 06:26:17 -05:00
|
|
|
BatchLoader.for(commit_id).batch(key: repository) do |commit_ids, loader, args|
|
|
|
|
get_messages(args[:key], commit_ids).each do |commit_id, message|
|
|
|
|
loader.call(commit_id, message)
|
2018-03-20 15:20:12 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
def get_messages(repository, commit_ids)
|
2018-06-27 07:46:51 -04:00
|
|
|
repository.gitaly_commit_client.get_commit_messages(commit_ids)
|
2018-03-20 15:20:12 -04:00
|
|
|
end
|
2017-01-04 13:43:06 -05:00
|
|
|
end
|
|
|
|
|
2019-03-19 15:24:23 -04:00
|
|
|
def initialize(repository, raw_commit, head = nil, lazy_load_parents: false)
|
2017-01-04 13:43:06 -05:00
|
|
|
raise "Nil as raw commit passed" unless raw_commit
|
|
|
|
|
2018-03-20 15:20:12 -04:00
|
|
|
@repository = repository
|
|
|
|
@head = head
|
2019-03-19 15:24:23 -04:00
|
|
|
@lazy_load_parents = lazy_load_parents
|
2018-03-20 15:20:12 -04:00
|
|
|
|
2019-02-21 16:07:26 -05:00
|
|
|
init_commit(raw_commit)
|
|
|
|
end
|
|
|
|
|
|
|
|
def init_commit(raw_commit)
|
2017-07-18 04:06:49 -04:00
|
|
|
case raw_commit
|
|
|
|
when Hash
|
2017-01-04 13:43:06 -05:00
|
|
|
init_from_hash(raw_commit)
|
2017-07-25 16:48:17 -04:00
|
|
|
when Gitaly::GitCommit
|
2017-06-23 17:33:16 -04:00
|
|
|
init_from_gitaly(raw_commit)
|
2017-01-04 13:43:06 -05:00
|
|
|
else
|
|
|
|
raise "Invalid raw commit type: #{raw_commit.class}"
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
def sha
|
|
|
|
id
|
|
|
|
end
|
|
|
|
|
|
|
|
def short_id(length = 10)
|
|
|
|
id.to_s[0..length]
|
|
|
|
end
|
|
|
|
|
|
|
|
def safe_message
|
|
|
|
@safe_message ||= message
|
|
|
|
end
|
|
|
|
|
|
|
|
def created_at
|
|
|
|
committed_date
|
|
|
|
end
|
|
|
|
|
|
|
|
# Was this commit committed by a different person than the original author?
|
|
|
|
def different_committer?
|
|
|
|
author_name != committer_name || author_email != committer_email
|
|
|
|
end
|
|
|
|
|
2019-03-19 15:24:23 -04:00
|
|
|
def parent_ids
|
|
|
|
return @parent_ids unless @lazy_load_parents
|
|
|
|
|
|
|
|
@parent_ids ||= @repository.commit(id).parent_ids
|
|
|
|
end
|
|
|
|
|
2017-01-04 13:43:06 -05:00
|
|
|
def parent_id
|
|
|
|
parent_ids.first
|
|
|
|
end
|
|
|
|
|
2020-06-10 08:08:58 -04:00
|
|
|
def committed_date
|
|
|
|
strong_memoize(:committed_date) do
|
|
|
|
init_date_from_gitaly(raw_commit.committer) if raw_commit
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
def authored_date
|
|
|
|
strong_memoize(:authored_date) do
|
|
|
|
init_date_from_gitaly(raw_commit.author) if raw_commit
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2017-01-04 13:43:06 -05:00
|
|
|
# Returns a diff object for the changes from this commit's first parent.
|
|
|
|
# If there is no parent, then the diff is between this commit and an
|
2017-07-25 17:26:52 -04:00
|
|
|
# empty repo. See Repository#diff for keys allowed in the +options+
|
2017-01-04 13:43:06 -05:00
|
|
|
# hash.
|
|
|
|
def diff_from_parent(options = {})
|
2018-06-22 05:49:46 -04:00
|
|
|
@repository.gitaly_commit_client.diff_from_parent(self, options)
|
2017-07-25 17:26:52 -04:00
|
|
|
end
|
|
|
|
|
2017-05-09 06:27:17 -04:00
|
|
|
def deltas
|
2017-07-25 17:26:52 -04:00
|
|
|
@deltas ||= begin
|
2018-07-06 08:44:54 -04:00
|
|
|
deltas = @repository.gitaly_commit_client.commit_deltas(self)
|
2017-07-25 17:26:52 -04:00
|
|
|
deltas.map { |delta| Gitlab::Git::Diff.new(delta) }
|
|
|
|
end
|
2017-05-09 06:27:17 -04:00
|
|
|
end
|
|
|
|
|
2017-01-04 13:43:06 -05:00
|
|
|
def has_zero_stats?
|
|
|
|
stats.total.zero?
|
|
|
|
rescue
|
|
|
|
true
|
|
|
|
end
|
|
|
|
|
|
|
|
def no_commit_message
|
2020-01-16 07:08:32 -05:00
|
|
|
"No commit message"
|
2017-01-04 13:43:06 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
def to_hash
|
|
|
|
serialize_keys.map.with_object({}) do |key, hash|
|
2017-08-03 22:20:34 -04:00
|
|
|
hash[key] = send(key) # rubocop:disable GitlabSecurity/PublicSend
|
2017-01-04 13:43:06 -05:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
def date
|
|
|
|
committed_date
|
|
|
|
end
|
|
|
|
|
|
|
|
def diffs(options = {})
|
2017-01-04 14:54:47 -05:00
|
|
|
Gitlab::Git::DiffCollection.new(diff_from_parent(options), options)
|
2017-01-04 13:43:06 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
def parents
|
2017-07-25 16:48:17 -04:00
|
|
|
parent_ids.map { |oid| self.class.find(@repository, oid) }.compact
|
2017-01-04 13:43:06 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
def stats
|
2017-09-06 06:55:16 -04:00
|
|
|
Gitlab::Git::CommitStats.new(@repository, self)
|
2017-01-04 13:43:06 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
# Get ref names collection
|
|
|
|
#
|
|
|
|
# Ex.
|
|
|
|
# commit.ref_names(repo)
|
|
|
|
#
|
|
|
|
def ref_names(repo)
|
|
|
|
refs(repo).map do |ref|
|
2018-01-31 05:03:13 -05:00
|
|
|
ref.sub(%r{^refs/(heads|remotes|tags)/}, "")
|
2017-01-04 13:43:06 -05:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
def message
|
|
|
|
encode! @message
|
|
|
|
end
|
|
|
|
|
|
|
|
def author_name
|
|
|
|
encode! @author_name
|
|
|
|
end
|
|
|
|
|
|
|
|
def author_email
|
|
|
|
encode! @author_email
|
|
|
|
end
|
|
|
|
|
|
|
|
def committer_name
|
|
|
|
encode! @committer_name
|
|
|
|
end
|
|
|
|
|
|
|
|
def committer_email
|
|
|
|
encode! @committer_email
|
|
|
|
end
|
|
|
|
|
2017-09-19 13:09:10 -04:00
|
|
|
def merge_commit?
|
|
|
|
parent_ids.size > 1
|
|
|
|
end
|
|
|
|
|
2019-03-14 00:20:40 -04:00
|
|
|
def gitaly_commit?
|
|
|
|
raw_commit.is_a?(Gitaly::GitCommit)
|
|
|
|
end
|
|
|
|
|
2018-01-15 04:39:06 -05:00
|
|
|
def tree_entry(path)
|
2018-04-17 10:30:16 -04:00
|
|
|
return unless path.present?
|
|
|
|
|
2019-03-07 16:53:22 -05:00
|
|
|
commit_tree_entry(path)
|
|
|
|
end
|
|
|
|
|
|
|
|
def commit_tree_entry(path)
|
2018-06-26 08:12:08 -04:00
|
|
|
# We're only interested in metadata, so limit actual data to 1 byte
|
|
|
|
# since Gitaly doesn't support "send no data" option.
|
|
|
|
entry = @repository.gitaly_commit_client.tree_entry(id, path, 1)
|
|
|
|
return unless entry
|
|
|
|
|
2019-03-07 16:53:22 -05:00
|
|
|
# To be compatible with the rugged format
|
2018-06-26 08:12:08 -04:00
|
|
|
entry = entry.to_h
|
|
|
|
entry.delete(:data)
|
|
|
|
entry[:name] = File.basename(path)
|
|
|
|
entry[:type] = entry[:type].downcase
|
|
|
|
|
|
|
|
entry
|
2018-01-15 04:39:06 -05:00
|
|
|
end
|
|
|
|
|
2017-11-21 08:47:52 -05:00
|
|
|
def to_gitaly_commit
|
2019-03-14 00:20:40 -04:00
|
|
|
return raw_commit if gitaly_commit?
|
2017-11-21 08:47:52 -05:00
|
|
|
|
|
|
|
message_split = raw_commit.message.split("\n", 2)
|
|
|
|
Gitaly::GitCommit.new(
|
|
|
|
id: raw_commit.oid,
|
|
|
|
subject: message_split[0] ? message_split[0].chomp.b : "",
|
|
|
|
body: raw_commit.message.b,
|
|
|
|
parent_ids: raw_commit.parent_ids,
|
2018-10-01 23:21:46 -04:00
|
|
|
author: gitaly_commit_author_from_raw(raw_commit.author),
|
|
|
|
committer: gitaly_commit_author_from_raw(raw_commit.committer)
|
2017-11-21 08:47:52 -05:00
|
|
|
)
|
|
|
|
end
|
|
|
|
|
2017-01-04 13:43:06 -05:00
|
|
|
private
|
|
|
|
|
|
|
|
def init_from_hash(hash)
|
|
|
|
raw_commit = hash.symbolize_keys
|
|
|
|
|
|
|
|
serialize_keys.each do |key|
|
2017-08-03 22:20:34 -04:00
|
|
|
send("#{key}=", raw_commit[key]) # rubocop:disable GitlabSecurity/PublicSend
|
2017-01-04 13:43:06 -05:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2017-06-23 17:33:16 -04:00
|
|
|
def init_from_gitaly(commit)
|
|
|
|
@raw_commit = commit
|
|
|
|
@id = commit.id
|
|
|
|
# TODO: Once gitaly "takes over" Rugged consider separating the
|
|
|
|
# subject from the message to make it clearer when there's one
|
|
|
|
# available but not the other.
|
2018-03-20 15:20:12 -04:00
|
|
|
@message = message_from_gitaly_body
|
2017-06-23 17:33:16 -04:00
|
|
|
@author_name = commit.author.name.dup
|
|
|
|
@author_email = commit.author.email.dup
|
2019-12-03 13:06:49 -05:00
|
|
|
|
2017-06-23 17:33:16 -04:00
|
|
|
@committer_name = commit.committer.name.dup
|
|
|
|
@committer_email = commit.committer.email.dup
|
2018-02-19 06:21:23 -05:00
|
|
|
@parent_ids = Array(commit.parent_ids)
|
2017-06-23 17:33:16 -04:00
|
|
|
end
|
|
|
|
|
2019-12-03 13:06:49 -05:00
|
|
|
# Gitaly provides a UNIX timestamp in author.date.seconds, and a timezone
|
|
|
|
# offset in author.timezone. If the latter isn't present, assume UTC.
|
|
|
|
def init_date_from_gitaly(author)
|
|
|
|
if author.timezone.present?
|
|
|
|
Time.strptime("#{author.date.seconds} #{author.timezone}", '%s %z')
|
|
|
|
else
|
|
|
|
Time.at(author.date.seconds).utc
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2017-01-04 13:43:06 -05:00
|
|
|
def serialize_keys
|
|
|
|
SERIALIZE_KEYS
|
|
|
|
end
|
2017-11-21 08:47:52 -05:00
|
|
|
|
2018-10-01 23:21:46 -04:00
|
|
|
def gitaly_commit_author_from_raw(author_or_committer)
|
2017-11-21 08:47:52 -05:00
|
|
|
Gitaly::CommitAuthor.new(
|
|
|
|
name: author_or_committer[:name].b,
|
|
|
|
email: author_or_committer[:email].b,
|
|
|
|
date: Google::Protobuf::Timestamp.new(seconds: author_or_committer[:time].to_i)
|
|
|
|
)
|
|
|
|
end
|
2018-01-31 05:03:13 -05:00
|
|
|
|
|
|
|
# Get a collection of Gitlab::Git::Ref objects for this commit.
|
|
|
|
#
|
|
|
|
# Ex.
|
|
|
|
# commit.ref(repo)
|
|
|
|
#
|
|
|
|
def refs(repo)
|
|
|
|
repo.refs_hash[id]
|
|
|
|
end
|
2018-03-20 15:20:12 -04:00
|
|
|
|
|
|
|
def message_from_gitaly_body
|
|
|
|
return @raw_commit.subject.dup if @raw_commit.body_size.zero?
|
|
|
|
return @raw_commit.body.dup if full_body_fetched_from_gitaly?
|
|
|
|
|
|
|
|
if @raw_commit.body_size > MAX_COMMIT_MESSAGE_DISPLAY_SIZE
|
|
|
|
"#{@raw_commit.subject}\n\n--commit message is too big".strip
|
|
|
|
else
|
|
|
|
fetch_body_from_gitaly
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
def full_body_fetched_from_gitaly?
|
|
|
|
@raw_commit.body.bytesize == @raw_commit.body_size
|
|
|
|
end
|
|
|
|
|
|
|
|
def fetch_body_from_gitaly
|
|
|
|
self.class.get_message(@repository, id)
|
|
|
|
end
|
2020-05-15 08:08:28 -04:00
|
|
|
|
|
|
|
def self.valid?(commit_id)
|
|
|
|
commit_id.is_a?(String) && !(
|
|
|
|
commit_id.start_with?('-') ||
|
|
|
|
commit_id.include?(':') ||
|
|
|
|
commit_id.include?("\x00") ||
|
|
|
|
commit_id.match?(/\s/)
|
|
|
|
)
|
|
|
|
end
|
2017-01-04 13:43:06 -05:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2019-02-21 16:07:26 -05:00
|
|
|
|
|
|
|
Gitlab::Git::Commit.singleton_class.prepend Gitlab::Git::RuggedImpl::Commit::ClassMethods
|