gitlab-org--gitlab-foss/db/migrate/20170508153950_add_not_null...

class AddNotNullContraintsToCiVariables < ActiveRecord::Migration[4.2]
  DOWNTIME = false

  def up
    change_column(:ci_variables, :key, :string, null: false)
    change_column(:ci_variables, :project_id, :integer, null: false)
  end

  def down
    # no op
  end
end
Add version 4.2 to all existing migrations DB schema generated by a migration may look different in rails 4 and 5 (because rails 5 may use different default values). For this reason it's important to explicitly set for which rails version a migration was written for. See https://stackoverflow.com/questions/35929869/activerecordmigration-deprecation-warning-asks-for-rails-version-but-im-no/35930912#35930912 2018-11-13 07:27:31 +00:00			`class AddNotNullContraintsToCiVariables < ActiveRecord::Migration[4.2]`
Prevent NULL values on ci_variables columns To be more specific; key, and project_id. If either of these is NULL its wrong, because: 1. storing a key value pair without key is just plain wrong 2. all variables should belong to a project Non of these cases existed on the staging database. 2017-05-08 17:15:43 +00:00			`DOWNTIME = false`

			`def up`
			`change_column(:ci_variables, :key, :string, null: false)`
			`change_column(:ci_variables, :project_id, :integer, null: false)`
			`end`

			`def down`
			`# no op`
			`end`
			`end`