gitlab-org--gitlab-foss/db/migrate/20170725145659_add_binary_t...

class AddBinaryToMergeRequestDiffFiles < ActiveRecord::Migration[4.2]
  include Gitlab::Database::MigrationHelpers

  DOWNTIME = false

  def change
    add_column :merge_request_diff_files, :binary, :boolean
  end
end
Add version 4.2 to all existing migrations DB schema generated by a migration may look different in rails 4 and 5 (because rails 5 may use different default values). For this reason it's important to explicitly set for which rails version a migration was written for. See https://stackoverflow.com/questions/35929869/activerecordmigration-deprecation-warning-asks-for-rails-version-but-im-no/35930912#35930912 2018-11-13 07:27:31 +00:00			`class AddBinaryToMergeRequestDiffFiles < ActiveRecord::Migration[4.2]`
Fix saving diffs that are not valid UTF-8 Previously, we used Psych, which would: 1. Check if a string was encoded as binary, and not ASCII-compatible. 2. Add the !binary tag in that case. 3. Convert to base64. We need to do the same thing, using a new column in place of the tag. 2017-07-25 16:57:02 +00:00			`include Gitlab::Database::MigrationHelpers`

			`DOWNTIME = false`

			`def change`
			`add_column :merge_request_diff_files, :binary, :boolean`
			`end`
			`end`